Changes by R. David Murray :
--
nosy: +dmalcolm
___
Python tracker
<http://bugs.python.org/issue10013>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Does the "fix" for issue 10006 affect this? (I imagine that question is why
Antoine made Benjamin nosy on this issue).
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.
Changes by R. David Murray :
--
nosy: +asksol, jnoller
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue10015>
___
___
Python-bugs-lis
R. David Murray added the comment:
You are right that this needs to be tested on other platforms. In order to so
test it (and in any case!), the patch will need unit tests. It also needs doc
updates.
In general patch itself looks good to me, modulo the concern you raise about
truncate
R. David Murray added the comment:
Fix committed to py3k in r85179, 3.1 in r85170, and 2.7 in r85181. I modified
the unit tests, deleting the ones that were redundant because they were just
two different python spellings of the same input string, and adding a comment
about the third test
R. David Murray added the comment:
Version 4 of patch, now including doc updates.
The patch set is now complete.
--
Added file: http://bugs.python.org/file19110/email_parse_bytes4.diff
___
Python tracker
<http://bugs.python.org/issue4
R. David Murray added the comment:
Rietveld issue, with a small doc addition compared to pach4:
http://codereview.appspot.com/2362041
--
___
Python tracker
<http://bugs.python.org/issue4
R. David Murray added the comment:
Upload svn patch, so that Martin's new rietveld support will (hopefully) create
an automatic review link.
--
Added file: http://bugs.python.org/file19113/email_parse_bytes5.diff
___
Python tracker
Changes by R. David Murray :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue10017>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Since no test case has been provided I am closing this issue.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue1
R. David Murray added the comment:
I don't believe either the example that other mailers reject or the one that
they accept are in fact RFC compliant. Encoded words are not supposed to occur
in (structured) MIME headers. The behavior observed is a consequence of all
headers, wh
R. David Murray added the comment:
Here is a patch.
--
keywords: +patch
stage: unit test needed -> patch review
Added file: http://bugs.python.org/file19114/add_header.patch
___
Python tracker
<http://bugs.python.org/issue1
R. David Murray added the comment:
Here is a patch that makes the output consistently (bytes, string) pairs. This
is definitely a potential backward compatibility issue, but in general code
which compensates for the old behavior should work fine with the new behavior,
since it was always
Changes by R. David Murray :
--
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issue6302>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Yes, that was a late night post and as I was falling asleep I realized that I
was wrong.
Certainly decode_header_as_string is a function most people using the email
package will want and will re-implement in one form or another, so I think it
is a good
R. David Murray added the comment:
The compatibility argument is a fair point, and yes we could default to utf8
and no language. So that is probably a better solution than raising the error.
--
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
Alexander closed issue 7789 in favor of this one, which is fine, but I want to
respond to Eric's rejection there of including info about datetime in the
'format mini language' section of the docs. His point was that only the
builtin types
Changes by R. David Murray :
--
nosy: +rhettinger
___
Python tracker
<http://bugs.python.org/issue10025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: -BreamoreBoy
resolution: out of date ->
___
Python tracker
<http://bugs.python.org/issue1104021>
___
___
Python-bugs-lis
R. David Murray added the comment:
The example works fine for me (server returns mailbox does not exist) in both
2.7 and py3k trunk, so I'm closing this as out of date.
--
nosy: +r.david.murray -BreamoreBoy
resolution: -> out of date
stage: patch review -> committed/reje
R. David Murray added the comment:
Note that of the versions still getting doc updates, only 2.7 still supports
the old style relative imports.
--
nosy: +r.david.murray
type: -> behavior
versions: -Python 2.6, Python 3.3
___
Python tracker
&l
R. David Murray added the comment:
It would be nice to retain the pure python version as a fallback for non
CPython implementations, that will require tweaking the tests to make sure both
are tested.
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
Yes. Benjamin merged this to py3k in r82292. If someone wants to explain to
me how to cherry pick the changeset into 3.1 I'd be happy to do it, otherwise I
think I'm done with this one :)
--
stage: commit review -> committed/rejected
R. David Murray added the comment:
If you do want to pursue this further note that "[your] own crappy code" is a
better reproducer to post than something that depends on a third party module.
--
nosy: +r.david.murray
___
Python trac
R. David Murray added the comment:
It is what is normally done *now* when there is both a C and a python
implementation (see, for example, test_datetime.py and test_io.py for two
different approaches to that). Not all tests have been updated to this
practice.
Thanks for working on this
Changes by R. David Murray :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue10045>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I'm changing the versions to just 2.7 (though I'm not sure this can be
considered a bug fix), since StringIO is reimplemented as part of io in 3.x.
--
nosy: +r.david.murray
versions: -Python 2.6, Python 3.1, Python 3.2,
R. David Murray added the comment:
It is possible this behavior changed after the docs were written. I'm adding a
couple of people to nosy who might have some insight into that possibility. It
could be either a change in finalization procedures or a change in signal
handling semanti
R. David Murray added the comment:
Indeed, newspipe appears to be a pure python package, so this looks like it is
probably a bug in python somewhere.
You might want to report it to newspipe too, though. They are likely to be
able to figure out how to reduce the problem to a minimum cause
R. David Murray added the comment:
Can you reproduce this using python2.7? Python 2.6 is in security fix only
mode now.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Here is an updated patch incorporating the reitveld feedback and feedback from
python-dev about the API. Now we have BytesParser instead of Parser with a
parsebytes method, and a message_from_binary_file helper. Generator also now
converts bodies with an
R. David Murray added the comment:
Generator converts 8bit bodies into 7bit bodies by applying an appropriate 7bit
CTE. The reason it does this is that the output of Generator will often be
passed to some other Python library function (most often smtplib) that can only
handle ASCII unicode
R. David Murray added the comment:
Even if smtplib accepted bytes (it currently does not), *Generator* is still
producing unicode, and should produce valid unicode and still insofar as
possible preserve the meaning of the original message. This means unicode acts
as if it is an SMTP server
R. David Murray added the comment:
I can only fix one package at a time :)
And in case it isn't clear, the "Generator produces ASCII-only unicode", which
is in many ways a rather strange API, is one of the chief motivati
R. David Murray added the comment:
Here is the final pre-alpha patch. This one includes the BytesFeedParser class
and a test.
Unless there are objections I'd like to commit this. Believing the code needs
a more thorough review would be a valid objection :)
--
Added file:
R. David Murray added the comment:
After RM approval on irc, committed in r85322, with some additional doc fixes
but no code changes relative to the last patch posted here.
I'm leaving this open because I still want to try to improve the handling of
non-ascii bytes in headers when dec
R. David Murray added the comment:
No, that would be a bug, thanks.
Also thanks for reminding me about this issue.
--
___
Python tracker
<http://bugs.python.org/issue1553
R. David Murray added the comment:
I like 'allframes', so I changed to that. The updated patch also adds the
allframes parameter to format_exception.
In going over the tests I realized that I'm not sure the output for the case of
chain=True is correct. Opinions? If it is no
R. David Murray added the comment:
Pascal: my question exactly. The question is whether the code is accurately
reflecting the state of the python stack at exception time (which it seems like
it ought to), in which case I don't understand how Python handles the chained
exception,
R. David Murray added the comment:
After giving this some thought, I'm sure that the observed results are not what
we want, so I've changed the test to be the result that we want. I haven't
been able to figure out what is causing it, and am starting to wonder if it
represent
R. David Murray added the comment:
vinay: duh. I'm using a debug build and my test is slicing off the refount
line. I think there's a helping in test.support for that...
--
___
Python tracker
<http://bugs.python.org
R. David Murray added the comment:
There isn't much that Python can do if there is a sufficiently broken C-based
module in sys.path. All you report about the problematic module is that it is
'bad' or 'corrupt'. Can you give more information about what makes
R. David Murray added the comment:
Does it also need a deprecation cycle?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10063>
___
___
R. David Murray added the comment:
If it's been reviewed on python-dev and the consensus was to turn it into an
error in 3.2, then I'm fine with it. But I'll bet we'll get at least a few bug
reports :)
--
___
P
R. David Murray added the comment:
What I am saying is that if an extension module (one that provides non-python
code in a load module) is corrupt, then it can totally screw up Python's
internal bookkeeping, and there is nothing Python can do to protect itself
against that.
If the &qu
R. David Murray added the comment:
Kai: could you write a unit test for this?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Unless Nick has further feedback I think you've done all you need to, thanks.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
Changes by R. David Murray :
--
nosy: +benjamin.peterson
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue10069>
___
___
Python-bugs-lis
R. David Murray added the comment:
In Python we often don't type check, we just let errors happen. It is true
that it would make the problem clearer to do a type check and issue a specific
error message, but I don't know if it is worth it. (The error would already
have been c
R. David Murray added the comment:
I am indeed going to close this. The patch isn't complete, since there's the
line ending issue Antoine pointed out, which implies that there are also some
missing tests.
I doubt that linecache performance is something that affects very many pe
Changes by R. David Murray :
--
nosy: +georg.brandl -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue6322>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
I doubt it. As Senthil says, file invoking ftp it is a bug. I'm just betting
that *someone* is going to complain when it stops working in their particular
situation.
--
___
Python tracker
R. David Murray added the comment:
Éric: WellI suppose that depends on how you look at it.
The RFC says that 'file:' does not specify a network protocol, and so "it's
utility in network protocols between hosts is limited". So, technically an
implementation tha
R. David Murray added the comment:
Éric, if you are saying, "the user asked for it, it *should* fail", then that
is indeed one of the arguments put forward in issue 9992 where this was
discussed. But I think the emerging consensus is that it is better to just
avoid the problem
R. David Murray added the comment:
I think the error message should be changed from 'allowed' to 'supported',
though.
--
___
Python tracker
<http://bug
R. David Murray added the comment:
Because hardcoding a particular condition into a context manager is less
flexible? (I'm +0 on this thing myself, by the way.)
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Yes, and I can't think of any other way to approach it.
--
___
Python tracker
<http://bugs.python.org/issue7425>
___
___
R. David Murray added the comment:
If I'm reading this thread correctly, this bug should be closed and a new one
opened about SSL socket close. Antoine, does that sound correct?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.py
R. David Murray added the comment:
This is a duplicate of #9291.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> mimetypes initialization fails on Windows because of non-Latin
characters
Changes by R. David Murray :
--
nosy: +vldmit
___
Python tracker
<http://bugs.python.org/issue9291>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
assignee: -> r.david.murray
nosy: +r.david.murray
stage: -> commit review
type: -> behavior
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Committed to py3k in r85554, 2.7 in r85556. Sébastien, from what you say it
sounds like this does not apply to 3.1, so I blocked it there. If this is
incorrect let me know and I'll backport it.
--
resolution: -> fixed
stage: commi
R. David Murray added the comment:
No, that would be incorrect syntax (if you omit the optional argument you
should also omit the comma that precedes it).
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
Changes by R. David Murray :
--
type: -> behavior
versions: -3rd party, Python 2.5, Python 2.6, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
I yhink you need to add an svnignore property to that directory for __pycache__.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue9
R. David Murray added the comment:
The attribute and test aren't in 3.1 (or 2.7), so this issue only applies to
3.x trunk.
--
___
Python tracker
<http://bugs.python.org/i
New submission from R. David Murray :
Quoting PoltoS from issue 8293:
If I do sock.close() (sock is instance of ssl.SSLSocket), the connection is not
closed: I see it as Established in netstat and nothing is sent over network:
tcpdump show nothing going thru the network
R. David Murray added the comment:
I opened issue 10127 for the ssl.SSLSocket().close() problem.
--
resolution: works for me -> out of date
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by R. David Murray :
--
nosy: +asksol
___
Python tracker
<http://bugs.python.org/issue10128>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
For reference, the py3k rev was r70091.
--
nosy: +r.david.murray
resolution: -> accepted
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by R. David Murray :
--
nosy: +lemburg
___
Python tracker
<http://bugs.python.org/issue10090>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Thank you, Martin.
--
___
Python tracker
<http://bugs.python.org/issue8845>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
title: mkpkg.py is lacked. -> mkpkg.py is missing
___
Python tracker
<http://bugs.python.org/issue10132>
___
___
Python-bugs-lis
R. David Murray added the comment:
Committed Neil's patch (after adding docs) in r85671. Thanks.
--
nosy: +r.david.murray
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python
R. David Murray added the comment:
I reviewed the doc and tightened up the wording (which was already mostly
correct) in r85672. Also fixed one typo and changed it to consistently use
'byte string' (rather than 'bytestring' which was used
R. David Murray added the comment:
Victor, can you paste or attach the error for email? My MSDN subscription has
expired so I can't set up to test it myself (I've submitted the renewal, but
who knows how long it will take to process :)
--
nosy: +r.da
R. David Murray added the comment:
Committed to py3k in r85675, 3.1 in r85676, and 2.7 in r85677.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Committed to py3k in r85678. If I'm reading this string correctly, I believe
this can (and should be) be backported. Am I correct?
--
nosy: +r.david.murray
resolution: -> fixed
stage: -> committ
R. David Murray added the comment:
Yes, Georg mentioned the directive because it exists :)
See the turtle docs for some examples, I think. I seem to remember using it
when I made those doctests pass on 2.7 (warning: it writes weird stuff on your
screen
R. David Murray added the comment:
The interesting question is, why aren't the buildbots seeing this failure? I
can reproduce it in my Windows VM using 3.2a3, and will work on a fix (to the
tests, the code under test is doing the "correct" thing, though that thing is
som
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue10134>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
Drat, there's a real bug here, too. The bytes parsing machinery doesn't
correctly translate crlf on input.
--
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Here is a patch that adds a test of the underlying problem and fixes it. I
don't like this patch because it tries to detect the line ending style of the
input stream and changes behavior based on that, but because email wants to use
'\n' a
R. David Murray added the comment:
Revised patch that seems to fix all the windows failures.
Still not sure why they were not showing up on the buildbots. Victor was
working from an svn checkout and I from the binary installer, so it's not just
a difference in the svn eol han
Changes by R. David Murray :
Removed file: http://bugs.python.org/file19273/windows_email_fix.patch
___
Python tracker
<http://bugs.python.org/issue10134>
___
___
Pytho
R. David Murray added the comment:
Clarification of my earlier comment on the patch: I think the behavior
*originally* tested for by the changed test is arguably incorrect, given
email's internal use of '\n' line endings. So I think the patch improves
things, but it is a pot
R. David Murray added the comment:
Having looked more carefully at the email4 (python2) code, I think I'm wrong.
The test I changed appears to codify the behavior expected when parsing a crlf
file in binary mode. This means that email4 code being ported to email5 may
depend on
Changes by R. David Murray :
--
assignee: d...@python ->
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue10145>
___
___
Python-bugs-lis
R. David Murray added the comment:
Woops, I didn't meant to unassign docs.
--
assignee: -> d...@python
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org
Changes by R. David Murray :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue6460>
___
___
Python-bugs-list
Changes by R. David Murray :
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7096>
___
___
Python-bugs-
Changes by R. David Murray :
--
dependencies: +email.Generators does not separates headers with "\r\n"
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Malcolm: a Content-Transfer-Encoding of 8bit may only contain \r and \n
characters as part of the line ending sequence. 8bit is *not* binary; to use a
CTE of binary the SMTP server must support BINARYMIME, which I don't think is
all that common yet
R. David Murray added the comment:
I agree with Terry.
--
nosy: +r.david.murray
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
For other reviewers, I'm reposting just his python program as a text file.
Maciek: I myself don't know enough about expat to comment, but is it possible
you have an issue similar to issue 10026?
--
nosy: +r.david.murray
Added
R. David Murray added the comment:
It would be nice if we could expand this fix to include FreeBSD, which as I
understand it has the same problem.
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by R. David Murray :
--
assignee: -> d...@python
components: +Documentation -XML
nosy: +d...@python
stage: -> needs patch
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6
___
Python track
Changes by R. David Murray :
--
nosy: +asksol
___
Python tracker
<http://bugs.python.org/issue10158>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
The bug tracker is not an appropriate place to get help on using Python.
Please ask your question on a forum where you are more likely to get help, such
as python-list.
--
nosy: +r.david.murray
___
Python
R. David Murray added the comment:
Updated patch that adds a missing test for BytesGenerator.flatten and fixes the
bugs in it. Also added versionchanged tags to the docs for the linesep
argument.
I think this is ready to go in.
--
stage: patch review -> commit review
Added f
701 - 800 of 10554 matches
Mail list logo