[issue8565] Always run regrtest.py with -bb

2010-04-29 Thread R. David Murray
R. David Murray added the comment: There are currently (at least) two places where regrtest is invoked by the buildbots, one for unix and one for windows. The flags used are not always in sync, but probably should be. I think it is probably better to not hack regrtest for this, since that

[issue8084] pep-0370 on osx duplicates existing functionality

2010-04-29 Thread R. David Murray
R. David Murray added the comment: Since you want it before the next beta, I'm promoting it to release blocker. Benjamin can reduce it if needed when we get down to the wire. -- nosy: +r.david.murray priority: high -> release blocker __

[issue8570] 2to3 crashes with "AttributeError: 'int' object has no attribute 'startswith'"

2010-04-29 Thread R. David Murray
Changes by R. David Murray : -- nosy: +benjamin.peterson type: crash -> behavior versions: +Python 2.7, Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/iss

[issue8572] httplib getheader() throws error instead of default

2010-04-29 Thread R. David Murray
R. David Murray added the comment: For backward compatibility this would have to be something more like: if not isinstance(default, list): if isinstance(default, string): default = [default] else: default = list(default) return ', &

[issue4025] C99 comments in Python 2.6 break build on AIX 6.1

2010-04-29 Thread R. David Murray
R. David Murray added the comment: Sure. It can always be reopened if the OP comes back and says it isn't fixed. I'm closing it out of date because there are no references to checkins that fixed it. -- nosy: +r.david.murray resolution: -> out of date stage: -> co

[issue2016] Crash when modifying the **kwargs passed to a function.

2010-04-29 Thread R. David Murray
R. David Murray added the comment: It was merged to py3k in r73623, 3.1 in r73625, but not, as far as I can see, to 2.6. -- nosy: +r.david.murray stage: patch review -> commit review versions: -Python 2.5, Python 2.7, Python 3.0, Python

[issue6883] OptionParser.allow_interspersed_args is undocumented

2010-04-29 Thread R. David Murray
R. David Murray added the comment: Since he hasn't proposed a patch, we close it :) Skip can always reopen it if he wants. -- nosy: +r.david.murray status: open -> closed ___ Python tracker <http://bugs.python.or

[issue2211] Cookie.Morsel interface needs update

2010-04-29 Thread R. David Murray
R. David Murray added the comment: This looks like it would be a worthwhile cleanup, and the issue contains useful info to that end, so I'm marking it languishing rather than closing it, in the hopes that someone will pick it up some day. I also think this could be a nice bug day tas

[issue8572] httplib getheader() throws error instead of default

2010-04-29 Thread R. David Murray
R. David Murray added the comment: No, because my code is a backward compatibility hack. Currently if someone is passing a default successfully they must be doing it by passing in a list or tuple consisting of one or more strings. So your code would result in something like

[issue8573] Buggy _strerror in asyncore

2010-04-29 Thread R. David Murray
Changes by R. David Murray : -- nosy: +giampaolo.rodola, josiahcarlson type: crash -> behavior ___ Python tracker <http://bugs.python.org/issue8573> ___ ___ Py

[issue8572] httplib getheader() throws error instead of default

2010-04-29 Thread R. David Murray
R. David Murray added the comment: @senthil: I'm not quite sure what your sentence referencing couchdb is getting at, but the headers that are being queried are in an email.Message object, and contain only string values unless some code is misusing the API and setting new non-string v

[issue8572] httplib getheader() throws error instead of default

2010-04-29 Thread R. David Murray
R. David Murray added the comment: I seem to have been missing some context here. I now understand that this is a regression relative to Python 2.x. It seems to me that the translation from rfc822.Message to email.Message was done incorrectly. In the 2.x code getheader returns only the

[issue8557] subprocess PATH semantics and portability

2010-04-30 Thread R. David Murray
R. David Murray added the comment: Well, it seems I was mistaken when I thought I knew how this worked :) Checking the os.exec documentation linked from the subprocess page, I see that when an environment is supplied PATH is indeed checked in it. The documentation for CreateProcess, however

[issue8580] Problem urllib2.URLError

2010-04-30 Thread R. David Murray
R. David Murray added the comment: The bug tracker is for bugs in Python itself, and isn't a good place to look for help on getting an application program to work. You should try the python email list/newsgroup. (You can find links to the newsgroup and other resources under the '

[issue8582] urllib.urlretrieve fails with ValueError: Invalid format string

2010-04-30 Thread R. David Murray
R. David Murray added the comment: The fact that our docs don't mention it is a clue that it is platform dependent :) Theoretically it shouldn't be, since it is in Posix: http://www.opengroup.org/onlinepubs/009695399/functions/strftime.html but practically speaking it is, sin

[issue8582] urllib.urlretrieve fails with ValueError: Invalid format string

2010-04-30 Thread R. David Murray
Changes by R. David Murray : -- stage: -> unit test needed type: crash -> behavior versions: +Python 2.6, Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/

[issue8576] test_support.find_unused_port can cause socket conflicts on Windows

2010-05-01 Thread R. David Murray
R. David Murray added the comment: Could you special case the test_socket test by checking for the error that Windows sometimes throws and retrying (in a loop for say a second)? Not ideal, but probably better than adding a sleep or throwing away the test :) -- nosy: +r.david.murray

[issue8586] test_imp.py test failures on Py3K Mac OS X

2010-05-01 Thread R. David Murray
Changes by R. David Murray : -- assignee: barry -> nosy: +ezio.melotti, flox ___ Python tracker <http://bugs.python.org/issue8586> ___ ___ Python-bugs-list mai

[issue8589] test_warnings.CEnvironmentVariableTests.test_nonascii fails under an ascii terminal

2010-05-01 Thread R. David Murray
R. David Murray added the comment: Victor has proposed a patch for the traceback problem for regrtest, I think. I haven't looked at it, but I wonder if there is something that can instead be done to make unittest work in cases like this when run in an ascii terminal. See issue

[issue8586] test_imp.py test failures on Py3K Mac OS X

2010-05-01 Thread R. David Murray
Changes by R. David Murray : -- assignee: -> barry ___ Python tracker <http://bugs.python.org/issue8586> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8557] subprocess PATH semantics and portability

2010-05-01 Thread R. David Murray
R. David Murray added the comment: I didn't run the script. I have now, but I'm not clear from its output what each test is actually doing, and don't really have the time to figure it out from the code right now. I think it is probably more efficient to just ask you what you

[issue7192] webbrowser.get("firefox") does not work on Mac with installed Firefox

2010-05-02 Thread R. David Murray
R. David Murray added the comment: issue 8238 notes the problem with autoraise and new on windows. I believe when I looked at that issue that I confirmed that the syntax webbrowser uses on Linux to support those options works on windows with the current firefox, even though I couldn't

[issue8599] _execvpe behaves inconsistently when PATH includes a filename

2010-05-02 Thread R. David Murray
R. David Murray added the comment: The python functions are thin wrappers around the system calls, and are reporting the result of calling the corresponding system call. The fact that the shell chooses to catch both errors and report a single one would be equivalent to, say, the cmd module

[issue8598] test/support: don't use localhost as IPv6 host name

2010-05-02 Thread R. David Murray
R. David Murray added the comment: All of my Gentoo systems except one have localhost on the ::1 line. The one that doesn't hasn't been updated in several years. That one has the same entry for ::1 as your Ubuntu. The FreeBSD 6.3 box I have access to has localhost on the ::1 lin

[issue8601] bz2.BZ2File should support "with" protocol per PEP 343

2010-05-03 Thread R. David Murray
R. David Murray added the comment: Indeed, and it was considered a feature request and thus is not appropriate for backport. If you wish to see that decision changed I think you will need to appeal to python-dev. -- nosy: +r.david.murray resolution: -> out of date stage: ne

[issue5565] Strange behavior when I logout() with IMAP4_SSL

2010-05-03 Thread R. David Murray
R. David Murray added the comment: FWIW on my cisco firewalls the logs contain a lot of 'deny, no connection' messages for RST packets, probably coming from similar scenarios. -- nosy: +r.david.murray resolution: -> invalid stage: -> committed/rejected status

[issue8557] subprocess PATH semantics and portability

2010-05-03 Thread R. David Murray
R. David Murray added the comment: Sorry for my Windows ignorance, but if CreateProcess ignores the PATH, how does updating the PATH fix the problem? -- ___ Python tracker <http://bugs.python.org/issue8

[issue8607] OSX: duplicate -arch flags in CFLAGS breaks sysconfig

2010-05-03 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of issue 8366. -- nosy: +r.david.murray resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> OS X universal builds fail on 2.7b1 and py3k with "Don't know m

[issue8557] subprocess PATH semantics and portability

2010-05-03 Thread R. David Murray
R. David Murray added the comment: Well, it wouldn't be the first time the microsoft docs were wrong. There are two questions here: (1) is this behavior consistent across all microsoft platforms we support? (2) is this *change* in behavior of Popen acceptable? For (1) we need a unit

[issue3620] test_smtplib is flaky

2010-05-03 Thread R. David Murray
R. David Murray added the comment: If it would provide clearer error message in cases of failure, it sounds like a reasonable thing to add whether or not the failure in this issue is still happening. -- nosy: +r.david.murray ___ Python tracker

[issue8557] subprocess PATH semantics and portability

2010-05-04 Thread R. David Murray
R. David Murray added the comment: Fair enough. Thank you for your detective work, and hopefully someone will be interested enough to pick this up again later. -- status: open -> languishing ___ Python tracker <http://bugs.python.org/iss

[issue8608] fix_import prefixes "." to already relative imports

2010-05-04 Thread R. David Murray
R. David Murray added the comment: Thanks, but this is a duplicate of issue 8553, which has already been fixed. -- nosy: +r.david.murray resolution: -> duplicate stage: -> committed/rejected status: open -> closed superseder: -> 2to3 breaks rela

[issue5753] CVE-2008-5983 python: untrusted python modules search path

2010-05-04 Thread R. David Murray
R. David Murray added the comment: FWIW I agree with Antoine. -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue5753> ___ ___ Python-bug

[issue7472] email.encoders.encode_7or8bit(): typo "iso-2202". "iso-2022" is correct.

2010-05-04 Thread R. David Murray
R. David Murray added the comment: Comments on patch: We prefer patches to be generated from the top level directory of the checkout, so that it can be applied by doing 'patch -p0 <http://bugs.python.org/i

[issue8617] Non-existent variables documented

2010-05-04 Thread R. David Murray
R. David Murray added the comment: These are references to environment variables. The markup marks them as such, but this does not translate into HTML in a visible way. Without a text description it is also left to guesswork as to how they function. The 2.7 docs are even more confusing

[issue8619] Doc bug for urllib.request._urlopener in Python 3.1+

2010-05-05 Thread R. David Murray
R. David Murray added the comment: Why do we have a public API that begins with an '_'? -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.

[issue3244] multipart/form-data encoding

2010-05-05 Thread R. David Murray
Changes by R. David Murray : -- assignee: -> r.david.murray versions: +Python 3.2 -Python 2.7 ___ Python tracker <http://bugs.python.org/issue3244> ___ ___ Py

[issue740495] API enhancement: poplib.MailReader()

2010-05-05 Thread R. David Murray
Changes by R. David Murray : -- assignee: -> r.david.murray nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue740495> ___ ___ Python-

[issue8628] Incorrect numbers.Complex.imag documentation

2010-05-05 Thread R. David Murray
Changes by R. David Murray : -- nosy: +mark.dickinson ___ Python tracker <http://bugs.python.org/issue8628> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8572] httplib getheader() throws error instead of default

2010-05-05 Thread R. David Murray
R. David Murray added the comment: Given what we've learned, I think that Walter's first patch is the best fix. No one should be relying on the current actual behavior of the default argument, and the fix makes it work as documented. As for backporting to 2.7, I don't think

[issue7472] email.encoders.encode_7or8bit(): typo "iso-2202". "iso-2022" is correct.

2010-05-05 Thread R. David Murray
R. David Murray added the comment: Committed to trunk in r80800. However, when I ported it to py3k, it turns out the test fails there, but passes if the original fix from this issue has been applied. More investigation is needed, but clearly something changed in the payload encoding logic

[issue8619] Doc bug for urllib.request._urlopener in Python 3.1+

2010-05-05 Thread R. David Murray
R. David Murray added the comment: Mainly I'm saying that I don't think a public API should have a name starting with an '_'. Sets a bad precedent :) Looking at the functionality more closely, though, it does make me nervous that we are recommending changing the global

[issue8630] Keepends param in codec readline(s)

2010-05-05 Thread R. David Murray
Changes by R. David Murray : -- nosy: +lemburg ___ Python tracker <http://bugs.python.org/issue8630> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7583] Improve explanation of tab expansion in doctests

2010-05-05 Thread R. David Murray
R. David Murray added the comment: I tried your suggestion, but it seemed to me that it made the first paragraph of that section be all about tabs, and get even farther away from its original focus, which was introducing the example. I've attached a patch that instead moves the e

[issue7472] email.encoders.encode_7or8bit(): typo "iso-2202". "iso-2022" is correct.

2010-05-05 Thread R. David Murray
R. David Murray added the comment: It turns out that email5 (py3k), because it is using unicode for the payload, doesn't do the encoding to the output character set until later in the process. Specifically, charset.body_encode no longer does the input-to-output charset conversion. T

[issue8654] Improve ABI compatibility between UCS2 and UCS4 builds

2010-05-07 Thread R. David Murray
R. David Murray added the comment: Adding MvL because he wrote the ABI PEP, and MAL because he cares about the Unicode interface. -- nosy: +lemburg, loewis, r.david.murray ___ Python tracker <http://bugs.python.org/issue8

[issue7584] datetime.rfcformat() for Date and Time on the Internet

2010-05-09 Thread R. David Murray
R. David Murray added the comment: I think Daniel's suggestion of having an option to control this is the best way to handle the different use cases. And I think the default should be -00:00, as he suggested. Removing 2.7 and 3.1 since 3.2 is the only branch open to new features at

[issue8256] TypeError: bad argument type for built-in operation

2010-05-10 Thread R. David Murray
R. David Murray added the comment: Victor, you've been dealing with Python's default encoding lately, care to render an opinion on the correct fix for this bug? @Filip: the patch will need a unit test, which will also help with assessing the validity of the fix. -- no

[issue4256] optparse/argparse: provide a simple way to get a programmatically useful list of options

2010-05-10 Thread R. David Murray
R. David Murray added the comment: zsh's completion system is completely programmable. I looks like it would be pretty easy to add generic 'python script' support widgets(*) using this hidden option, and probably other neat tricks as well. Something that would make it even

[issue8425] a -= b should be fast if a is a small set and b is a large set

2010-05-10 Thread R. David Murray
R. David Murray added the comment: The answer is almost certainly "no". -- nosy: +r.david.murray ___ Python tracker <http://bugs.python.org/issue8425> ___ __

[issue4768] email.generator.Generator object bytes/str crash - b64encode() bug?

2010-05-10 Thread R. David Murray
Changes by R. David Murray : -- priority: high -> critical ___ Python tracker <http://bugs.python.org/issue4768> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8666] Allow ConfigParser.get*() to take a default value

2010-05-10 Thread R. David Murray
R. David Murray added the comment: Rather than a raise_on_bad option, it seems to me it would be better to code a try/except clause in cases where you want the default even if there is an error converting the data in the file. I would expect such cases to be rare, except for cases where you

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-11 Thread R. David Murray
R. David Murray added the comment: There is a reason, and that is that it may break existing code in the field relying on the current behavior. This is (unfortunately) true regardless of whether the function is public or private, though the fact that it is ostensibly private is likely to

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-11 Thread R. David Murray
R. David Murray added the comment: Hmm. I didn't read your comment carefully enough before I replied. I think you are saying that the bug fix is confined to the routine in question and doesn't change even its API, in which case the nature of the function doesn't come in to

[issue8686] "This isn't defined beyond that" phrase is not friendly to non-native English speakers.

2010-05-11 Thread R. David Murray
R. David Murray added the comment: Unfortunately that wouldn't be correct English, as far as I know. How about "This isn't defined other than that..." I think that reads a bit more clearly than "beyond that" even to a native speaker, even though be

[issue8686] "This isn't defined beyond that" phrase is not friendly to non-native English speakers.

2010-05-11 Thread R. David Murray
Changes by R. David Murray : -- versions: +Python 3.1 -Python 3.3 ___ Python tracker <http://bugs.python.org/issue8686> ___ ___ Python-bugs-list mailing list Unsub

[issue8684] improvements to sched.py

2010-05-11 Thread R. David Murray
Changes by R. David Murray : -- dependencies: +sched.py module doesn't have a test suite superseder: sched.py module doesn't have a test suite -> ___ Python tracker <http://bugs.pyth

[issue3704] cookielib doesn't handle URLs with / in parameters

2010-05-11 Thread R. David Murray
R. David Murray added the comment: I don't expect anything; I had written that it looked OK to me but apparently I accidentally deleted that text before posting. But I'm not someone who has ever programmed using cookielib so I wouldn't expect my opinion to coun

[issue2620] Multiple buffer overflows in unicode processing

2010-05-12 Thread R. David Murray
Changes by R. David Murray : -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue2620> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8700] strip() is removing an extra character if the strip pattern contains "-"

2010-05-12 Thread R. David Murray
R. David Murray added the comment: The argument to strip is a set of characters to remove, not a substring. -- nosy: +r.david.murray resolution: -> invalid stage: -> committed/rejected status: open -> closed ___ Python track

[issue8702] difflib: unified_diff produces wrong patches (again)

2010-05-13 Thread R. David Murray
Changes by R. David Murray : -- keywords: +easy type: -> behavior versions: -Python 3.3 ___ Python tracker <http://bugs.python.org/issue8702> ___ ___ Python-

[issue4898] {context, unified}_diff add spurious trailing whitespace if fromfiledate/tofiledate are emptyk

2010-05-13 Thread R. David Murray
Changes by R. David Murray : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed superseder: -> difflib should separate filename from timestamp with tab ___ Python tracker <http://bugs.pytho

[issue8705] shutil.rmtree with empty filepath

2010-05-13 Thread R. David Murray
Changes by R. David Murray : -- nosy: +tarek ___ Python tracker <http://bugs.python.org/issue8705> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8424] Test assumptions for test_itimer_virtual and test_itimer_prof

2010-05-14 Thread R. David Murray
R. David Murray added the comment: The patches look good, so yes, please apply them. As for closing the issue...if the failures are no longer happening on the buildbots, then yes :) -- ___ Python tracker <http://bugs.python.org/issue8

[issue4523] logging module __init__ uses has_key

2008-12-04 Thread R. David Murray
New submission from R. David Murray <[EMAIL PROTECTED]>: I ran my ap with -3 and got the following: /usr/lib/python2.6/logging/__init__.py:849: DeprecationWarning: dict.has_key() not supported in 3.x; use the in operator -- components: Library (Lib) messages: 76883 nosy: bit

[issue43493] EmailMessage mis-folding headers of a certain length

2021-03-18 Thread R. David Murray
R. David Murray added the comment: Parsing and newlines have nothing to do with this bug, actually. I don't think your foldfix post-processing is going to do what you want in the general case. The source of the bug here is in the folding algorithm in _header_value_parser. It has chec

[issue43922] Double dots in quopri transported emails

2021-04-23 Thread R. David Murray
R. David Murray added the comment: Since python is doing the right thing here, I don't see a particularly good reason to put a hack into the stdlib to fix the failure of third party software to adhere to standards. (On the output side. We do follow Postel's rule on input and t

[issue43922] Double dots in quopri transported emails

2021-04-23 Thread R. David Murray
R. David Murray added the comment: As far as I know the only resources are the context manager docs and the source code. The stdlib content manager can serve as a model. I have to admit that it was long enough ago that I wrote that code that I'd have to re-read the docs and code myse

[issue42892] AttributeError in email.message.get_body()

2021-05-19 Thread R. David Murray
R. David Murray added the comment: Yes, that's the real question. That's what needs to be fixed, otherwise we'll just keep finding new bugs. For example, try calling iter_parts() on that message. It isn't pretty :) -- __

[issue42892] AttributeError in email.message.get_body()

2021-05-19 Thread R. David Murray
R. David Murray added the comment: Actually, I'm wrong. The body of a part can be a string, and that's what's going to happen with a malformed body of something claiming to be a multipart. The problem is that there is code that doesn't guard against this possibility.

[issue44560] Unrecognized charset "eucgb2312_cn" in email header for many MUA

2021-07-06 Thread R. David Murray
R. David Murray added the comment: I can't tell tell for sure if this behavior is intentional or not from a quick glance at the code (though like you I wouldn't think it would be). That's part of the legacy api, at this point. The new api will just use utf8: from email

[issue39100] email.policy.SMTP throws AttributeError on invalid header

2021-07-06 Thread R. David Murray
R. David Murray added the comment: How are you encountering this error? The following program runs without exception for me on master: from email import message_from_binary_file from email.policy import SMTP msg = message_from_binary_file(open('mail.eml', 'rb'), po

[issue43493] EmailMessage mis-folding headers of a certain length

2021-07-06 Thread R. David Murray
R. David Murray added the comment: Ah, yes, the problem is more subtle than I thought. The design here is that we should be starting with the largest lexical unit, seeing if that fits on the current line, or a line by itself, and if so, using that, and if not, move down to the next smaller

[issue43124] [security] smtplib multiple CRLF injection

2021-07-13 Thread R. David Murray
R. David Murray added the comment: This bug report starts with "a malicious user with direct access to `smtplib.SMTP(..., local_hostname, ..)", which is a senseless supposition. Anyone with "access to" the SMTP object could just as well be talking directly to th

[issue43124] [security] smtplib multiple CRLF injection

2021-07-13 Thread R. David Murray
R. David Murray added the comment: s/header injection/command injection/ -- ___ Python tracker <https://bugs.python.org/issue43124> ___ ___ Python-bugs-list m

[issue44637] Quoting issue on header Reply-To

2021-07-14 Thread R. David Murray
R. David Murray added the comment: There is definitely a problem here, though I see a different problem when I run it (AttributeError: 'Group' object has no attribute 'local_part', presumably because of the ':' not getting escaped correctly). I believe it appli

[issue44637] Quoting issue on header Reply-To

2021-07-15 Thread R. David Murray
R. David Murray added the comment: Forget what I said about my different error, I made a mistake running the test script. Interesting. If it is related to the length of the name, then the problem is most likely in the folding algorithm, specifically in what happens when the "display

[issue44637] Quoting issue on header Reply-To

2021-07-15 Thread R. David Murray
R. David Murray added the comment: Yes, compat32 uses a different parser and folder (the legacy ones), that have a lot of small bugs relative to the RFCs (which is why I rewrote it). -- ___ Python tracker <https://bugs.python.org/issue44

[issue43124] [security] smtplib multiple CRLF injection

2021-07-19 Thread R. David Murray
R. David Murray added the comment: My apologies, I did not think about the possibility of an English issue. I was reacting to the "security report speak", which I find often makes a security issue sound worse than it is :) Thank you for reporting this problem, and I do think we

[issue44660] email.feedparser: support RFC 6532 section 3.5

2021-07-23 Thread R. David Murray
R. David Murray added the comment: Having looked at the cited part of the RFC (but not tried to analyze it in detail), I think you are correct. I've also glanced at your PR, and I think your approach is correct in broad outline, but I haven't looked at the details. For full mess

[issue44694] Message from BytesParser cannot be flattened immediately

2021-07-23 Thread R. David Murray
R. David Murray added the comment: I suspect maxheaderlen=0 works because it causes the original lines to be re-emitted without any folding or other processing. Without that, lines longer than the default max_line_length get refolded. Can you provide an example of an input message that

[issue44685] Email package issue with Outlook msg files

2021-07-23 Thread R. David Murray
R. David Murray added the comment: That file appears to be a binary file? By itself it isn't enough to reproduce the problem. Can you provide a complete script as well as the email message you are parsing that demonstrates the problem? By "looks like any other eml file", ar

[issue28973] [doc] The fact that multiprocess.Queue uses serialization should be documented.

2021-08-07 Thread R. David Murray
R. David Murray added the comment: Mentioning ids would be pretty much redundant with mentioning pickle. If it is pickled its id is going to change. I think Davin was suggesting that while the use of serialization is documented, it is not documented *consistently*. Everywhere

[issue45551] EmailMessage utf-8 folding error

2021-10-22 Thread R. David Murray
R. David Murray added the comment: I'm pretty sure this is a duplicate report and that we worked on a fix, but I don't know if it got committed because I can't find the issue... (To be clear, the problem here is the lack of whitespace at the start of the folded par

[issue45299] SMTP.send_message() does from mangling when it should not

2021-11-23 Thread R. David Murray
R. David Murray added the comment: In this case the docs are correct and the code has a bug. The intent was that if the message passed in to BytesGenerator has a policy, that policy should be followed. If it is not being followed, that's a bug in BytesGenerator. The tricky part of c

[issue45299] SMTP.send_message() does from mangling when it should not

2021-11-24 Thread R. David Murray
R. David Murray added the comment: Your backward compatibility argument is persuasive. As you say, that means the BytesGenerate docs would need to be updated to note that that parameter is the exception to the rule for backward compatibility reasons. (If it is the only exception I have to

[issue45932] EmailMessage incorrectly splits name and address header

2021-11-30 Thread R. David Murray
R. David Murray added the comment: This is a duplicate of #44637. -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44637] Quoting issue on header Reply-To and other address headers

2021-11-30 Thread R. David Murray
Change by R. David Murray : -- nosy: +thehesiod title: Quoting issue on header Reply-To -> Quoting issue on header Reply-To and other address headers ___ Python tracker <https://bugs.python.org/issu

[issue46011] Python 3.10 email returns invalid Date: header unchanged.

2021-12-09 Thread R. David Murray
R. David Murray added the comment: Yeah, I think there may be a general issue with getting header defects reflected somehow in message.defects, but that's a separate issue :) -- ___ Python tracker <https://bugs.python.org/is

[issue38698] While parsing email message id: UnboundLocalError

2019-11-24 Thread R. David Murray
R. David Murray added the comment: More tests are always good :) The "correct" solution here (as far as I remember, its has been a while since I've had time to even looked at the _header_value_parser code) would be to add a new 'invalid-msg-id' token, and

[issue38672] mimetypes.init() fails if no access to one of known files

2019-11-24 Thread R. David Murray
R. David Murray added the comment: I haven't looked at this in detail, but here are my general thoughts: I think it would be reasonable to expect that the module would function even if the file permissions are screwed up, similar to how unix commands that try to read .netrc will (t

[issue38698] While parsing email message id: UnboundLocalError

2019-11-24 Thread R. David Murray
R. David Murray added the comment: Actually, the success path there should also check that value is empty, and if it is not register a defect for that as well. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38625] SpooledTemporaryFile does not seek correctly after being rolled over

2019-11-24 Thread R. David Murray
R. David Murray added the comment: The docs currently say "The returned object is a file-like object whose _file attribute is either an io.BytesIO or io.StringIO object (depending on whether binary or text mode was specified) or a true file object, depending on whether rollover() has

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-13 Thread R. David Murray
R. David Murray added the comment: Thanks for the report. Can you provide an example that reproduces the problem? Per the RFC, lines may be broken before whitespace in certain places in certain headers, but that does not make the whitespace go away. Only the crlf sequence is removed

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-13 Thread R. David Murray
R. David Murray added the comment: That header is *completely* non-RFC compliant. If gmail generated that header there is something very wrong in google-land :( The RFC compliant formatting for that header looks like this: Content-Disposition: attachment; filename*=utf-8''Schulb

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-14 Thread R. David Murray
R. David Murray added the comment: Yes, google should fix their bug. However, the python email package tries very hard to interpret even RFC-non-compliant emails when there is a way to do so. As I said, the package already tries to interpret headers such as google is generating, it's

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-14 Thread R. David Murray
R. David Murray added the comment: And you are right that this is a very common bug in email programs. So common that I suspect the RFC folks will eventually have to accept it as a de-facto standard. So we do need to support it in the python email library

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-15 Thread R. David Murray
R. David Murray added the comment: The example you want to look at is get_unstructured. That shows both lookback and modification of the parse tree to handle the whitespace between encoded words. -- ___ Python tracker <https://bugs.python.

[issue39040] Wrong attachement filename when mail mime header was too long

2019-12-16 Thread R. David Murray
R. David Murray added the comment: In general your solution looks good, just a few naming comments and an additional test request. -- ___ Python tracker <https://bugs.python.org/issue39

[issue39071] email.parser.BytesParser - parse and parsebytes work not equivalent

2019-12-17 Thread R. David Murray
R. David Murray added the comment: The problem is that you are starting with different inputs. unicode strings and bytes are different things, and so parsing them can produce different results. The fact of that matter is that email messages are defined to be bytes, so parsing a unicode

<    18   19   20   21   22   23   24   25   26   27   >