Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue3244>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
Somehow I missed this in my pre-beta feature request review :(
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue1162
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue9864>
___
___
Python-bugs-list mailing list
Unsub
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue1043706>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
The skip was added and the service is back and has been for a while, so I'm
closing this, but see also issue 6027.
--
resolution: -> out of date
stage: patch review -> committed/rejected
status: ope
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue740495>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue634412>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 2.7
___
Python tracker
<http://bugs.python.org/issue795081>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue1025395>
___
___
Python-bugs-list mailin
Changes by R. David Murray :
--
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue8769>
___
___
Python-bugs-list mailing list
Unsub
Changes by R. David Murray :
--
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue9967>
___
___
Python-bugs-list mailing list
Unsub
Changes by R. David Murray :
--
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue9298>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
If the RFC says they are safe it seems like we should include them in the safe
list.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Committed to 2.7 in r87515. On second thought there's no reason to forward
port the test because Python3 doesn't have the equivalent type-promotion issues.
--
nosy: -BreamoreBoy
resolution: -> fixed
stage: patch review -> committed
R. David Murray added the comment:
Committed (redid, actually) 2nd patch in r87516. I may or may not backport it.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.6, Python 2.7, P
R. David Murray added the comment:
But clearly intentional, and now enshrined in released code.
--
nosy: +mark.dickinson, r.david.murray
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python track
R. David Murray added the comment:
LazyImporter isn't used in Python3. Without someone motivated to propose a
patch this isn't going to be changed, so I'm closing the issue.
--
resolution: -> wont fix
stage: -> committed/rejected
s
R. David Murray added the comment:
>>> struct.pack('2s', 'ha')
b'ha'
>>> struct.pack('2s', 'hé')
b'h\xc3'
>>> struct.pack('3s', 'h
R. David Murray added the comment:
Parser is a legacy API, and message_from_string (which uses it) is just a
convenience function. If performance is an issue for your application, call
feedparser directly and optimize the feeding to suit your application.
--
resolution: -> wont
R. David Murray added the comment:
As far as I can tell it is simply wrong per-RFC to put a charset parameter on a
mulitpart content-type. So I think this should, indeed, raise an error on the
Multipart subtype.
If someone sets any charset, the CTE is set wrong. So code that sets charset
R. David Murray added the comment:
Since set_charset should not be valid on a multipart, I don't see a reason to
have a separate issue for the post-attach case.
Also, although I haven't searched the RFCs, I don't think we can assume that
set_chaset is valid only on text pa
Changes by R. David Murray :
--
keywords: +easy
nosy: +michael.foord
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
See also issue 6533.
--
___
Python tracker
<http://bugs.python.org/issue6027>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
Committed to py3k in r87550. Since the only application that would trip up
would be one not using SimpleCookie to read SimpleCookie generated cookies
*and* that doesn't implement unescaping (in which case it wasn't really
handling SimpleCookie co
R. David Murray added the comment:
In this case I think it is safe enough, since it only results in the ;,= not
getting encoded. If an application were doing anything with the encoded chars,
it would probably be decoding them, and now that step will simply become a
noop. Of course
New submission from R. David Murray :
Working on issue 10686, I've discovered that the logic for charset conversion
in email.header.Header.append is bogus. It happens to work for most charsets
because for most charsets the input codec and the output codec are the same.
For shift_ji
Changes by R. David Murray :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue10790>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Updated patch that also fixes the docs.
--
Added file: http://bugs.python.org/file20189/header_append.patch
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Since GZipFile inherits from BufferedIOBase, and TextIOWrapper is supposed to
be designed to wrap a BufferedIOBase object, I would say yes it ought to work.
On the other hand there may also be a doc error there, since it may be that
TextIOWrapper actually
R. David Murray added the comment:
Oops. It only has that inheritance in 3.2.
--
versions: -Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Heh, and 2.7. Fixing versions yet again.
--
versions: +Python 2.7
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
bz2 is a pure C module, so that's a very different situation.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Right, but in the bz2 case I think it is a feature request rather than a
bugfix. In any case it should be a separate issue.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
One way to "fix" this would be to have make test run the tests with -j1 and
pass in the -S and -s flags, and then have regrtest special case test_site and
remove those flags for the run of that single test.
An interesting facet of this proposal
R. David Murray added the comment:
Here is a proof of concept patch if anyone wants to play with it.Note that
a higher value could be used for the j option; multiple threads help even on
uniprocessor systems since a bunch of the tests spend time waiting around.
The patch removes the &#x
R. David Murray added the comment:
Applied in r87590. I threw in an extra test for a multi-leapyear-range. Since
there was no reason not to, I backported it to 3.1 in r87591 and 2.7 in r87592.
In the latter two commits I also backported the issue 9342 patch.
Thanks for the patch, John
R. David Murray added the comment:
Backported it to 3.1 in r87591 and 2.7 in r87592 along with the patch for issue
9361.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue9
R. David Murray added the comment:
I finally got around to researching this issue in the tracker.
Issue 10298 is a close relative to this issue. The fix from that issue make
the test that Xuanji added here pass. That issue contains no testsit would
be ideal to have tests that test the
R. David Murray added the comment:
FWIW, having just looked at related code in zipfile recently, this patch looks
correct to me.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Thank you very much for working on this! I'll try to take a look at the patch
soon. A couple quick comments based on your posting: first, the email module
now has a BytesFeedparser that will accept a byte stream, which I hope might
simplify your
R. David Murray added the comment:
Dev: I have no idea how what you just posted relates to the subject of this
issue. Could you clarify please?
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Etienne: since this is about solving a 3.x specific problem, it will not get
backported. Issue 1573931 looks unrelated to me at a quick glance. FYI, you
will find that you *do* have detach in 2.7 if you open a file using the io
subsystem (import io). Of
R. David Murray added the comment:
Yes, that is my suggestion. Keep in mind that I haven't looked at the patch or
run any tests yet :)
If windows-specific hacks are needed to get the binary stream in 3.x, then IMO
that's a bug in IO. As far as I know at the moment there
R. David Murray added the comment:
Yeah, making a generic way to put specific tests into a subprocess run sounds
like a better solution.
But...
The xml error in test___all__ is due to the fact that test___all__ imports
site. So even with the above we'd need to special case si
R. David Murray added the comment:
Ah, I hadn't looked closely enough at site.py to realize that the init work was
being done by a 'main()' call. Given that, just moving the main call out
should be relatively unlikely to break any custom site.py. Worse case would
pre
R. David Murray added the comment:
The hanging test still hangs for me with _VERBOSE set to True on py3k trunk.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
Agreed that the original issue is invalid. So either the title should be
changed so it can be used to address Martin's question, or it should be closed.
--
nosy: +r.david.murray
___
Python tracker
R. David Murray added the comment:
Have you tried 3.2b2?
--
nosy: +haypo, r.david.murray
type: -> behavior
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
Committed to py3k in r87750 and 3.1 in r87751.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
A day late, but I've looked at the patch.
Now, I'm not all that knowledgeable about CGI, so other people will probably
want to chime in here
First, I'm uploading a new version of the patch as an svn diff (can be applied
to a checkout u
R. David Murray added the comment:
Here is a modified version of the unittest file from unittest.zip that can be
run against Pierre's code (it feeds FieldStorage a text stream with a buffer).
Running the tests require the data files from the zip.
They do not pass, in a very differen
R. David Murray added the comment:
Yeah, the documentation for the email stuff is in the dev docs. There's a
short summary in the changes section of the email intro with links to the
classes and methods that are affected. But basically you call BinaryFeedParser
and feed it a binary
R. David Murray added the comment:
Another alternative might be to return "None" ("refuse the temptation to
guess"). But, given the long standing nature of the current guessing, having
it return the specific version string may indeed make sense.
--
Changes by R. David Murray :
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue10835>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Well, the digits are there if they are there in the name when that's actually
what is in argv[0], so as long as that's the name the binary is actually
installed under I don't think it will break anything. I presume the same
applies to th
R. David Murray added the comment:
The behaviour you observe is by design, and documented. The email package
needs to be able to handle RFC-invalid input, which includes messages with
multiple instances of fields that are supposed to be singletons. It also needs
to keep track of the order
R. David Murray added the comment:
Haypo: I believe that the consensus we've come to is that you shouldn't have
to. FieldStorage should take a binary stream. So should cgi.parse. If
defaulting to sys.stdin, then if stdin is text, they should turn it in to a
binary stream ri
R. David Murray added the comment:
Ah, you are right. That makes the backward compatibility issue a lot worse :(
--
___
Python tracker
<http://bugs.python.org/issue4
R. David Murray added the comment:
Note that based on my experience with the conversion of compileall to
argparse,it is important to have good tests. Of course, regrtest itself has no
tests...
--
nosy: +r.david.murray
___
Python tracker
<h
R. David Murray added the comment:
I agree that not guessing would be better. But as long as we *are* guessing,
it seems to me that /usr/bin/python2.7 would be less wrong than
/usr/bin/python, for almost all modern unix systems.
--
___
Python
R. David Murray added the comment:
Here is a patch. Three of the tests currently fail due to what appears to be a
bug in the Header formatting routines. I'll have to look in to that before
finishing this issue.
Note that doing str on a message with binary headers can produce ove
Changes by R. David Murray :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue10686>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I have a little bit of concern whether or not 'unknown-8bit' is the correct
charset to use. It seems to be the one in the RFCs, but I have a feeling it
may not be what is used "in the wild" in headers, so I am looking for opinions.
-
R. David Murray added the comment:
Well, unknown-8bit is registered as a charset with IANA. It is registered
specifically for use in message bodies, but as a registered charset it "should"
be acceptable in headers as well. There is no similar registration for just
'unknown&
R. David Murray added the comment:
Well, since unknown-8bit is a registered charset, it should be RFC-valid in an
encoded word. Whether or not any other mailer out there is going to be able to
handle it is a different question.
--
___
Python
R. David Murray added the comment:
There's no need for any deeper investigation. The answer is "nobody wrote the
patch". If someone writes a good patch, it will go in.
--
nosy: +r.david.murray
___
Python tracker
<http
R. David Murray added the comment:
No it doesn't. It has an arbitrary message string. That's the same as all
other exceptions that don't have special attributes.
--
nosy: +r.david.murray
status: open -> closed
___
Pyt
R. David Murray added the comment:
+1
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10858>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
Committed a revised version of the patch, including doc updates, in r87840.
While I haven't documented the way to alter what encoding name is used for the
unknown bytes, I did make it possible to do so (set charset.UNKNOWN8BIT to the
desired s
R. David Murray added the comment:
I agree that when dealing with prexisting folding it is better to preserve it.
The case I was talking about is, say, prepending re to a subject and refolding
it. It is the transformation step where I think turning fws into a single
space makes sense. But
R. David Murray added the comment:
Antoine didn't want to backport that patch. Does the fix applied in issue
678250 address this?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
I ran into a redirection loop when cookies were blocked from google, who should
know better. And then they had the gall to blacklist my ip for an attempted
DOS attack. So a feature request may not be out of order; but I for one would
not be motivated
R. David Murray added the comment:
Receiving no negative votes :), I've committed this to py3k in r87873, 3.1 in
r87874, and 2.7 in r87875.
Barry, Martin, do you think this should be backported as a security fix? I'm
thinking it should be.
--
nosy: +loewis
resolution:
R. David Murray added the comment:
The email package does have a 'parser headers only' mode, but it doesn't do
what you want, since it reads the remainder of the file and sets it as the
payload of the single, un-nested Message object it returns.
Adding a flag to tell it
Changes by R. David Murray :
--
versions: -Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue10879>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
I don't have time to review the patch or even respond in detail to the comments
right now, but I do want to respond about BytesFeedParser. It is true that
there is currently no interface to get the raw-bytes version of the header back
out of the Me
R. David Murray added the comment:
Well, imagine a web form that has a 'subject' text entry field, and the
application does Message['Subject'] = subject_from_form as it builds a Message
to hand off to smtp.sendmail. If the application didn't sanitize the subjec
R. David Murray added the comment:
Ah, I should clarify. A sensible web application should be dealing with any
multiline input it allows by turning it into a newline-less single line before
using it as a subject, so the probability that there are exploitable
applications out there is, I
R. David Murray added the comment:
Testing regrtest is distinctly non-trivial, since options have interactions
(some of the somewhat unobvious). Ideally we'd refactor the code so that we
could point it at a test test-directory so we could write some automated tests
for it :) But if yo
R. David Murray added the comment:
Note that it is also possible that after doing a review of the functionality,
there might be consensus to drop one or more options, which would be a good
thing overall, IMO.
--
___
Python tracker
<h
R. David Murray added the comment:
Yes, the immanence of RC1 makes it really doubtful that this can be fixed in
3.2. Whether or not it can be fixed in 3.2.1 will depend on the nature of the
fix. If it changes behavior such that currently working uses of FieldStorage
(that don't deal
R. David Murray added the comment:
I've been intending to take a look at this issue at some point, but am not sure
when I'd get to it.
I took a quick look. It does seems to me that it is true that for data-validity
purposes the message files need to be opened in binary and fed to
R. David Murray added the comment:
It getting in to 3.2 would be a release manager call, so I've set it to release
blocker so Georg can make the call. My opinion is that while I would *really*
like to see this fixed in 3.2, the changes really should have a thorough
*design* review as
R. David Murray added the comment:
Victor: we normally leave the patch file that was committed attached to the
issue for future reference.
The _plus_tests file was just the original patch plus the existing cgi tests
adjusted to pass in bytes instead of strings to cgi, if I recall correctly
Changes by R. David Murray :
--
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
Adrian's suggestions don't look to me like they fiddle with the API, but rather
make the behavior match the documented API. The existing behavior is, IMO, a
very surprising corner case, especially to a less experienced Python
programmer. I do
Changes by R. David Murray :
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> relative import broken
___
Python tracker
<http://bugs.python
R. David Murray added the comment:
08 is an invalid octal literal. See
http://docs.python.org/reference/lexical_analysis.html#integer-and-long-integer-literals
--
nosy: +r.david.murray
resolution: -> invalid
stage: -> committed/rejected
status: open -&g
R. David Murray added the comment:
The reason that it is surprising is that the API is designed to allow an
arbitrary function to be called, with whatever arguments and keyword arguments
that function takes. The user of the API is not necessarily going to remember
that the first argument to
R. David Murray added the comment:
Yes, it's about the concurrent.futures 'submit' method:
http://docs.python.org/dev/py3k/library/concurrent.futures.html#executor-objects
I've updated the title to reflect this. There are other places in the stdlib
affected by this
R. David Murray added the comment:
Duplicate of issue 6306.
--
nosy: +r.david.murray
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> filecmp.cmp can not compare two files from different OS with
the
R. David Murray added the comment:
Name mangling applies only to attributes of classes, and so does not enter in
to this issue.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Adrian: you are correct of course, I was misremembering and did not check the
docs. I prefer the other solution, though.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
telnetlib closes the socket, which in turn calls the OS level socket close
function. What happens after that is up to the OS tcp/ip stack, and is not
under Python's control. So if there is a bug here it isn't in Python.
--
nosy:
R. David Murray added the comment:
If I understand correctly, what Alexander means by "only work in the C locale"
is that both strptime and strftime are locale dependent, and so if the locale
is something other than C it may fail to parse the month name and may generate
a non-stan
R. David Murray added the comment:
Eric, could you point out the part of the specification that requires exactly a
string and makes a string subclass invalid? I did a quick scan and couldn't
find it, and unfortunately don't have the time to re-read the whole spec right
now.
-
R. David Murray added the comment:
As you say, "on some systems". The variation is documented, and the documented
codes are documented as being just those required by the C standard.
--
nosy: +r.david.murray
resolution: -> invalid
stage: -> committed/rejected
status
R. David Murray added the comment:
OK. So he is saying that when the spec says "an object of type str" he means
'type(x) is str' as opposed to 'isinstance(x, str)'. I would naively have
expected the latter, as other people clearly do as well. I didn't par
R. David Murray added the comment:
All right, I'll open it back up for that suggestion (I've changed the title
accordingly) and let the docs folks decide. The most useful link would be one
to the relevant Windows documentation, since that's the hardest one to find.
Altho
R. David Murray added the comment:
This is indeed a doc problem, although there was some discussion of working
toward a method rename. See issue 8047 (but be prepared to read a novel to
understand why tostring returns bytes...) The doc for 3.2 is slightly clearer,
but both 3.1 and 3.2
1601 - 1700 of 10554 matches
Mail list logo
