R. David Murray added the comment:
I've committed this (with the whitespace fix) in r86577. I've made myself a
note to backport it when the maint branches unfreeze.
--
assignee: nnorwitz ->
nosy: +r.david.murray
resolution: -> fixed
stage: patch review -> commit
Changes by R. David Murray :
--
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue1574217>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
keywords: -patch
stage: unit test needed -> patch review
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/iss
R. David Murray added the comment:
On the other hand, the test case in test_compileall says "test some aspects of
compileall's CLI". Since the patch completely changes the logic of CLI
parsing, having tests that cover as much as practical of the CLI would greatly
increase
R. David Murray added the comment:
Note that Benjamin's commit only addresses the posix side. Amaury, do you want
to fix the windows side?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
It looks good, but as mentioned on IRC it would be nice to have a unit test
that confirmed that the headers were being correctly buffered.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.
Changes by R. David Murray :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue9721>
___
___
Python-bugs-list mai
Changes by R. David Murray :
--
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue9721>
___
___
Python-bugs-list mailing list
Unsub
R. David Murray added the comment:
Issue 1508475 has a patch, though it still needs updated.
--
resolution: -> duplicate
stage: unit test needed -> committed/rejected
status: open -> closed
superseder: -> transparent gzip compressio
Changes by R. David Murray :
--
assignee: eric.araujo -> r.david.murray
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org/i
R. David Murray added the comment:
Patch committed with minor formatting changes and one fixed test (test_force)
in r86611. Thanks, Michele!
--
resolution: -> accepted
stage: commit review -> committed/rejected
status: open -> closed
_
R. David Murray added the comment:
Thanks for the patch and test. They look good.
A doc update is also needed, since the docs are currently written in such a way
that buffering the header lines makes the documentation no longer true.
Also, send_response_only writes directly to the output
Changes by R. David Murray :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue3709>
___
___
Python-bugs-list mailing list
Unsubscri
R. David Murray added the comment:
TempdirManager is new, which is why I forgot about it. It works with the
buildbots because it is a context manager, so if things go badly the cleanup
code is still going to run and delete the cruft. Since the distutils tests are
unlikely to hang (which is
R. David Murray added the comment:
For the record, I don't find the behavior of __iter__ on a binary file at all
confusing. It's the same behavior I see if I open the file in, say, vi. So it
is in fact the behavior I expect, and I would be surprised if it didn't work.
Whethe
R. David Murray added the comment:
Senthil, I didn't clearly express my concern about send_response_only. It
doesn't look to me like, with buffering in place, that it *should* write
directly, it looks to me like it should write to the buffer. Consider
specifically the
R. David Murray added the comment:
This is fixed by r86642. The remaining failing tests were pointing to bugs in
the implementation of the linesep argument to generator.flatten. I had to add
an additional test to catch all the related bugs, though.
The tests now run the inversion tests
R. David Murray added the comment:
In investigating issue 10466 I find that getlocale on windows returns the value
that windows accepts for me. For example on my US windows system, getlocale
returns ('English_United States', '1252'), and that appears to work when passe
R. David Murray added the comment:
See also issue 1699853.
The problem here is that resetlocale calls getdefaultlocale, and
getdefaultlocale returns something that setlocale cannot consume on Windows.
For example, on my US windows system, getlocale returns ('English_United
States&#x
R. David Murray added the comment:
It is unfunny that your program fails on Windows.
Yes it is the same bug, since calendar calls getdefaultlocale.
Issue 1080864 makes very interesting reading in this context. Clearly Martin
is right, yet the OP seems to find the current behavior of
New submission from R. David Murray :
See issue 10466 for background, but in short LocaleHTMLCalendar uses
getdefaultlocale if no locale is specified, and on windows this results in a
locale that setlocale will not accept. The fix is presumably to use
setlocale(LC_DATE, '')
Changes by R. David Murray :
--
nosy: +skoczian
___
Python tracker
<http://bugs.python.org/issue10498>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I've opened issue 10498 for the calendar bug.
--
___
Python tracker
<http://bugs.python.org/issue10466>
___
___
Pytho
R. David Murray added the comment:
Agreed on the closing. The pre-diff processing function would be a great
addition. For the record, I am currently satisfying my use case by doing this:
self.assertEqual(bstr1.split(b'\n'), bstr2.split(b'\n'))
which produces
R. David Murray added the comment:
I had a report from a user on IRC during the bug weekend that they could not
reproduce the failure on windows. So it may be dependent on the windows
version. That doesn't answer your question of why it hasn't come up before,
though, since my
R. David Murray added the comment:
These are wrappers around the posix functions. As such the unix man pages are
a better authority than the Python docs :) Still, we could certainly improve
the docs.
The getlogin error is probably a miscopy from the man page: the man page on my
system
R. David Murray added the comment:
This is working as designed. Whether or not the design is correct has been
debated in the past. If you want to re-debate it the appropriate place is
probably python-ideas.
--
nosy: +bethard, r.david.murray
resolution: -> invalid
status: o
R. David Murray added the comment:
This is a duplicate if issue 9291.
--
nosy: +r.david.murray
stage: -> committed/rejected
status: open -> closed
superseder: -> mimetypes initialization fails on Windows because of non-Latin
characters in
Changes by R. David Murray :
--
nosy: +aclover
___
Python tracker
<http://bugs.python.org/issue9291>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Please don't change the type, this issue is about the feature request of adding
this regex engine to the stdlib.
I'm sure Matthew will get back to you about your question.
--
type: behavior -> fe
R. David Murray added the comment:
For the email package I would be in favor of moving the tests to Lib/test.
I've always found it a bit inconvenient that they are in Lib/email. After
hearing of Michael's intent with unittest, and given the evolution of email5
into email5.1,
R. David Murray added the comment:
Yes, a cheeseshop package is definitely part of the plan, I didn't mean to
imply otherwise. It won't be hard to automate the packaging, and indeed I'll
wind up doing that anyway even if the tests stay inside Lib/email.
I will say that th
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue1079>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
Note that none of your examples are valid encoded words, so given that email
currently does strict parsing, the fact that it is not attempting to decode
those words is technically correct.
However, I agree that it would be better for it to do a "
R. David Murray added the comment:
Kovid: so essentially what you are saying is that the windows platform is
broken with respect to MIME types and with respect to its security model. Why
am I not surprised? :)
You would have the same problem if software installation altered the
/etc
R. David Murray added the comment:
I would expect that it would not be people new to mimetypes that would have the
issues, but people like you for whom the behavior on Windows has changed. And
this is indeed a concern.
The people involved in making the windows mimetypes enhancement are nosy
R. David Murray added the comment:
Boštjan, please see issue 10466 for further information about your question on
fr_FR vs French. Windows, as usual, does not follow the standards.
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
I think Boštjan is correct that that sentence is not parallel to the others.
If I understand correctly, at that point the installation is complete, and it
is the final 'exit or back' dialog. So I think the title should be "Complet
R. David Murray added the comment:
Committed to py3k in r86925, 3.1 in r86926, and 2.7 in r86927.
Thanks for the patch, Xuanji.
--
nosy: +r.david.murray
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -&g
Changes by R. David Murray :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue10603>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Much work has been done on non-ASCII paths in 3.2. Can you test this with the
3.2 alpha and let us know the results?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Are you sure testA1 is correct? It seems to me that in that case the sniffer
can indeed not determine the delimiter, but I don't really understand the
guessing algorithm. The existing behavior on unquoted strings is...interesting
:)
Also if yo
Changes by R. David Murray :
--
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Committed to py3k in r86936 with minor fixups.
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
R. David Murray added the comment:
I've taken another look at this, and the email module is pretty consistent
about just passing through data if it can't interpret it according to
standards. I think it would lead to a cluttered API if we add support for
being strict and rais
R. David Murray added the comment:
Do you have in implementation in mind? I'm not clear how this would work.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Closing this in favor of 1486713, which has a patch and covers additional
issues.
--
nosy: -BreamoreBoy
resolution: -> duplicate
stage: unit test needed -> committed/rejected
status: open -> closed
superseder: -> HTMLParser : A a
R. David Murray added the comment:
I have committed a version of this patch, without the warnings, using the
keyword 'strict=True' as the default, and with a couple added heuristics from
other similar issues, in r86952.
kxroberto, if you want to supply your full name, I'll
R. David Murray added the comment:
The new strict=False mode from #1486713 handles this case.
--
nosy: +r.david.murray
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
superseder: -> HTMLParser : A auto-tolerant
R. David Murray added the comment:
Included this in the 'strict=False' mode in the issue 1486713 patch.
--
nosy: +r.david.murray -BreamoreBoy
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
superseder: -> HTMLParser : A
Changes by R. David Murray :
--
title: HTMLParser fix to accept mailformed tag attributes -> HTMLParser fix to
accept malformed tag attributes
___
Python tracker
<http://bugs.python.org/issue1
R. David Murray added the comment:
Ah, I did not realize that getstatusoutput was implemented using os.popen. I
thought it already used Popen. Now, in python3, os.popen is in turn
implemented using subprocess.Popen, so removing that level of indirection seems
sensible.
The question that
R. David Murray added the comment:
A note for the curious: I changed the keyword name from 'tolerant' to 'strict'
because the stdlib has other examples of 'strict' as a keyword, but the word
'tolerant' appears nowhere in the documentation and certainly
R. David Murray added the comment:
I've decided that writing (some) errors to stdout instead of stderr is really a
bug, not a feature request, and have backported this fix to 3.1 in r87053 and
to 2.7 in r87055.
The one possible reason not to do this is that it is conceivable that it
R. David Murray added the comment:
Eric, I'm assuming you just forgot to close this. On the other hand, if you
wanted a +1 from another dev, you've got it :) Besides the considerations you
mentioned, changing this would be a significant backward incompatibility, and
is theref
R. David Murray added the comment:
So, Martin, are you then arguing that this should in fact be considered a bug
in ZipFile? The documentation for the constructor says "Open a ZIP file, where
file can be either a path to a file (a string) or a file-like object." Reading
th
R. David Murray added the comment:
I would expect this code to report an error of some sort, not pass as an
expected failure. The expected failure should be in the test case *only*, not
in the setup or teardown methods. That is, I don't think this is a bug, I
think it is a feature
R. David Murray added the comment:
I'm working on it.
--
___
Python tracker
<http://bugs.python.org/issue10453>
___
___
Python-bugs-list mailing list
Unsubsc
R. David Murray added the comment:
Here's the test. The fix isn't as simple as making it nargs='*', though.
--
Added file: http://bugs.python.org/file19960/compileall_multidir_test.diff
___
Python tracker
<http://bug
R. David Murray added the comment:
Here is a fix. This is not finished, though, because I see that I did not do
an adequate review of the original patch. There are still bugs in the -d and
-i handling that need both tests and fixes.
--
Added file: http://bugs.python.org/file19961
R. David Murray added the comment:
I suspect this is a duplicate of issue 9614, or rather a subset of that issue.
--
nosy: +alexandre.vassalotti, amaury.forgeotdarc, janglin, pitrou, r.david.murray
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
I just tried using script_helper in a new test, so I have a couple of comments.
I don't see stdout and stderr being conflated, it looks to me like they are
returned separately, at least by the assert methods.
The assert methods return results, whi
Changes by R. David Murray :
--
nosy: +michael.foord
___
Python tracker
<http://bugs.python.org/issue9517>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Wow, I didn't realize that's how logging worked. My understanding was a module
should just get a logger and log messages, and if the application didn't do any
setup beforehand, the first logging call would cause messages to be written to
st
R. David Murray added the comment:
I have to say that it would never have occurred to me to assert a pre or post
condition and an expected failure where I expected the pre or post condition to
fail, but if you've got a real use case and it would make the code simpler, I
suppose I ha
R. David Murray added the comment:
OK, fine on the convention, but I'd still like a more memorable name for
assert_python_failure. I've been working on this issue off and on today, and
I've had to look up that name at least four times. I can remember
assert_python_ok, but I
Changes by R. David Murray :
--
stage: -> committed/rejected
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue10643>
___
___
Pyth
R. David Murray added the comment:
If the problem is in site.py it doesn't sound like a distutils bug at all. I
remember Victor doing something that changed the error handling/reporting when
importing site.py, so I'm adding him as nosy. I thought that was only in 3.x,
though.
R. David Murray added the comment:
I believe that in the absence of other documentation the ABC is considered
authoritative.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue9
R. David Murray added the comment:
I'm not sure what bug you are reporting here. Are you saying that values using
a , are automatically getting generated by tkinter and then rejected when fed
back in? If so, I suspect this is a tk problem, not tkinter problem, but
someone would ha
R. David Murray added the comment:
On gentoo linux with tcl/tk 8.5.8, if I use the following command line:
>LC_NUMERIC=fr_FR ../release31-maint/python ListboxScrollbarLocaleIssue.py
(which runs 3.1.3+) I can move the slider without any problem. I confirmed
that locale.format_string(
R. David Murray added the comment:
Well, it sounds like you are on Windows, which is a platform I'm not all that
familiar with. I think we bundle TK for the windows installer, but I'm not
100% sure. I think to use a different version you have to recompile Python,
which on Window
R. David Murray added the comment:
As you observe, the attribute is not read only, it simply isn't referred to
when special method lookup is done. This is specified as part of the language
design for new style classes, but has only been made consistently true in
recent versions.
On o
R. David Murray added the comment:
Here is a patch that causes _assert_python to remove the refcount lines from
stderr.
--
keywords: +patch
Added file: http://bugs.python.org/file19975/script_helper_del_refcount.patch
___
Python tracker
<h
R. David Murray added the comment:
Hmm. Having posted that it occurs to me that it could be useful to have the
_remove_refcount function in test.support as remove_refcount instead.
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by R. David Murray :
--
nosy: +belopolsky
___
Python tracker
<http://bugs.python.org/issue10654>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +belopolsky
___
Python tracker
<http://bugs.python.org/issue10653>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I'm still working on this, making sure the remaining options that aren't
currently tested have tests and work.
--
assignee: eric.araujo -> r.david.murray
___
Python tracker
<http://bugs.pytho
R. David Murray added the comment:
Oh, good, I'll use that then. I could have sworn I looked for that
functionality a couple weeks ago and couldn't find it.
--
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
The format support is written specifically so that it is extensible. You can
write your own string subclass that extends the formatting mini-language with
whatever features you find useful. There are too many variations on what might
be useful with
R. David Murray added the comment:
OK, here is what I hope is a comprehensive set of CLI tests, and fixes for the
bugs revealed thereby. Except for the new test added by Georg after the
original patch here was committed, all of the tests either pass using the old
compileall module or fail
R. David Murray added the comment:
for what it is worth, I am +1 on having completion and history file work by
default. The sqlite3 command line does this, for example. I think it is what
unix user expect nowadays, and I think it is reasonable.
Looking at my home directory, it would appear
R. David Murray added the comment:
This class was added by the fix for issue 1486663 in r53509. Adding Georg as
nosy since he committed it, but it seems like it would be worth fixing it in
case someone else uses the class in an additional test in the future.
--
nosy: +georg.brandl
Changes by R. David Murray :
--
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue10668>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
My guess is "it shouldn't", and "yes", but I've added the multiprocessing
maintainers as nosy and they can answer definitively.
--
nosy: +asksol, jnoller, r.david.murray
___
Python tr
Changes by R. David Murray :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue10674>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
I think this is the kind of thing where you are *much* better off writing a
specialized assert method that exactly fits your use case. There are too many
variations on this theme, IMO, for it to make sense as an stdlib method.
--
nosy
R. David Murray added the comment:
Committed the patch_flush_mmap patch to 3.1 in r87163 and 2.7 in r87164.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue
R. David Murray added the comment:
What do you mean by "there is a test for this case in csv.py"? If I run
sniffer against "abcde\ndefgh\n" I get a delimiter of 'e'. If I run it against
'a\nb\n', I get the could not determine delimiter error.
Attach
R. David Murray added the comment:
Forgot to attach the patch.
--
Added file: http://bugs.python.org/file20006/csv_delimiter_tests.patch
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
Upon reflection I think the risk of breaking apparently working programs is
higher than the benefit to be obtained from backporting this.
--
___
Python tracker
<http://bugs.python.org/issue1574
Changes by R. David Murray :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Yeah, obviously wrong. I forgot to finish editing the comment.
I think a fallback of ',' makes more sense than ''. What would a delimiter of
nothing mean? I don't think the unquoted case can be changed for backward
compatibility
R. David Murray added the comment:
I like the suggestion of turning it into a warning, myself, but you are right
that at the least the error message should be improved.
--
resolution: invalid ->
stage: committed/rejected -> needs patch
status: closed -
R. David Murray added the comment:
mktime_tz is documented as turning the input into a *UTC* timestamp. That's
what your example shows it doing.
There is an open issue elsewhere in this tracker for providing a way to
round-trip RFC2822 timestamps.
--
nosy: +r.david.m
R. David Murray added the comment:
My guess is people don't read warnings when they are a common occurrence. A
working Python should not emit any warnings, and a properly working Python
program (post 2.6/3.1 (or whenever it was we decided to suppress deprecation
warnings by default)) s
Changes by R. David Murray :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue10682>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
nosy: +brian.curtin, tarek, tim.golden
___
Python tracker
<http://bugs.python.org/issue10684>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
The tests are failing on windows:
http://www.python.org/dev/buildbot/all/builders/x86%20XP-4%203.x/builds/3770/steps/test/logs/stdio
==
ERROR: test_mkdtemp_failure
R. David Murray added the comment:
There's also a typo in the issue number in your commit message (10888 instead
of 10188).
--
___
Python tracker
<http://bugs.python.org/is
1301 - 1400 of 10554 matches
Mail list logo
