Changes by R. David Murray :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Patch looks good to me.
--
assignee: -> r.david.murray
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issu
Changes by R. David Murray :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue1025395>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue8769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue9967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
versions: +Python 3.3 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue1823>
___
___
Python-bugs-list mailing list
Unsub
Changes by R. David Murray :
--
versions: +Python 3.2, Python 3.3 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue10574>
___
___
Python-bugs-list m
R. David Murray added the comment:
Assuming this is correct (I haven't tried looking for the reference yet), I'm
leaning toward it being enough of a behavior change that it should not be
backported.
--
versions: +Python 3.3 -Python 2.7, Python 3.1,
Changes by R. David Murray :
--
versions: +Python 3.2
___
Python tracker
<http://bugs.python.org/issue5803>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by R. David Murray :
--
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue11050>
___
___
Python-bugs-list m
R. David Murray added the comment:
Hmm. It seems to me that in this case the test *should* fail, since it
indicates a broken Python installation. How about instead catching the error
in the test and calling self.fail with the error and an additional message
about making sure configure has
R. David Murray added the comment:
MvL explained that there is a configure tests that makes the existence of this
routine optional. So the skip is appropriate, but the message should read
something like "the clear history tests cannot be run because the clear_history
method is not avai
R. David Murray added the comment:
Here is a patch that adds a footnote explaining the issue.
--
keywords: +patch
Added file: http://bugs.python.org/file21117/gen_not_quite_idem.patch
___
Python tracker
<http://bugs.python.org/issue1440
R. David Murray added the comment:
The tests for this function are...not sufficient. I don't think I'm
comfortable committing a patch without improving the tests. Ideally there
would also be a test that the locale does not affect the result, which would
need to be skipped if
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue11496>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
Thanks.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: crash -> behavior
versions: +Python 3.2
___
Python tracker
<http://bugs.python
R. David Murray added the comment:
Yes, if it is not actually an RFC non-compliance I'd rather not backport it,
but I'm not averse to changing it. I'm open to argument about backporting
though...if you know of spam filters that actually do count
R. David Murray added the comment:
How does assertRaisesRegex address the use case in issue 3583?
--
___
Python tracker
<http://bugs.python.org/issue10
R. David Murray added the comment:
It exists, but clearly it is broken. I'll look in to it.
--
assignee: -> r.david.murray
stage: -> needs patch
type: -> behavior
versions: +Python 3.1, Python 3.2, Python 3.3
___
Python
R. David Murray added the comment:
It looks to me like description is still missing from the docstring, at least
on python3 tip.
--
___
Python tracker
<http://bugs.python.org/issue8
Changes by R. David Murray :
--
stage: -> patch review
type: behavior -> feature request
___
Python tracker
<http://bugs.python.org/issue11511>
___
___
Pyth
R. David Murray added the comment:
I don't think we have any committers who run NetBDS. Can you attach your patch
here? I take it the other NetBSD checks are still required?
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.py
R. David Murray added the comment:
Here is a patch that adds tests for the methods I didn't previous have test
for. There may still be some headers that I'm not testing for the 'contains
binary' case, but this is certainly more comprehensive than we had before.
Please
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue11555>
___
___
Python-bugs-list mailing list
Un
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue11556>
___
___
Python-bugs-list mailing list
Un
Changes by R. David Murray :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
versions: +Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue11555>
___
___
Python-bugs-list m
Changes by R. David Murray :
--
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue11556>
___
___
Python-bugs-list mailin
R. David Murray added the comment:
Fixed, thanks.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
R. David Murray added the comment:
I've committed the patch as is. We'll address improving the semantics one way
or another as part of email6 development.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status
R. David Murray added the comment:
Raymond, it looks like you committed this fix separately to the 3.2 branch and
the default branch, instead of committing to 3.2 and then merging to default.
With svn, this wasn't a big deal, but with mercurial it will leave the 3.2
changeset unmerged
R. David Murray added the comment:
It turns out this is a bug in 3.1, not something introduced by email5.1 in 3.2.
The minimum reproducer is stringifying any message containing a header with no
body.
--
stage: -> needs patch
versions: +Python
Changes by R. David Murray :
Removed file: http://bugs.python.org/file21043/issue11298_py2.7.patch
___
Python tracker
<http://bugs.python.org/issue11298>
___
___
Pytho
R. David Murray added the comment:
Drat, I accidentally deleted the patch file. Reattaching.
--
nosy: +r.david.murray
Added file: http://bugs.python.org/file21234/issue11298_py2.7.patch
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
Steffen, these look like different kinds of errors than the one you reported in
this ticket. If they are, could you open a new issue? Either way, simple
reproducers would be the most helpful.
--
___
Python
R. David Murray added the comment:
This fix reveals a second bug. Without this fix, a non-existent file raises an
IOError with an appropriate error message, but with the chained exception.
After this fix, it raises an error that says 'not a gzip file', which while
technically t
R. David Murray added the comment:
Note that the code in question was changed to the form with the bugs in 3.2, so
this fix does not need to be backported to 3.1. The test could be, though.
--
components: +Library (Lib) -Interpreter Core
title: Infinite recursion around raising an
Changes by R. David Murray :
--
type: crash -> behavior
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue11548>
___
___
Python-
Changes by R. David Murray :
--
nosy: +vinay.sajip
___
Python tracker
<http://bugs.python.org/issue11557>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
+1 for providing a way to autogenerate the message.
--
___
Python tracker
<http://bugs.python.org/issue1559549>
___
___
Pytho
R. David Murray added the comment:
I talked with Barry, who could find no relevant discussions in his email logs.
We decided that _bencode was misguided in the first place (this is reinforced
by the bug I fixed a year ago where email was stripping the final newline off a
body *after
R. David Murray added the comment:
We commented out a few of the tests because they took too long to run due to
the large default loop count. timeit would have to be further modified to
support testing the default, which probably isn't worth it.
--
resolution: -> accept
R. David Murray added the comment:
OK, now this bit works like it did in Python2.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by R. David Murray :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue11578>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by R. David Murray :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue4114>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
Steffen, what you are doing in 11243-test is not something that the current
email package supports. String input to message_as_string must be ASCII only
in email 5.1/python3.2. Likewise for decode_header. To get unicode in to a
header, you have to pass
R. David Murray added the comment:
I'm closing this issue. If you have a specific test case that is still
failing, please open a new issue. And thanks for testing this fix.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: ope
R. David Murray added the comment:
I'm rejecting this. There is more than one bug here, but it starts with the
fact that ('xxx', None) is treated the same as ('xxx', 'us-ascii'). In the
first case it would be nice if a space was used to separate two of th
R. David Murray added the comment:
Yes, I can well understand that feeling. I've only relatively recently taken
over maintaining the email package. I'm working my way through the old bug
queue, and I can only deal with them in the context in which I
R. David Murray added the comment:
I don't see a test case here, did you forget to attatch something?
Also, in this:
elf._msg[n] = email.header.make_header(email.header.decode_header(b))
unless 'b' is an ASCII-only string, it isn&
Changes by R. David Murray :
--
assignee: -> r.david.murray
stage: -> test needed
type: -> behavior
versions: +Python 3.2
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
If the message contains 8bit bytes in a header, then getitem is going to return
a Header object. decode_header does not operate on Header objects, as you have
observed. Thinking about it some more, having decode_header operate on a
Header and return its
R. David Murray added the comment:
I talked to Martin. He wants the 2.5 mercurial branch to get *exactly* that
set of changes that needs to be applied to the svn repository in order for him
to build the security release, no more no less. Note that 2.5 goes out of
security maintenance in
R. David Murray added the comment:
Yes, although there may be another answer on the compile bug.
--
resolution: -> wont fix
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://
R. David Murray added the comment:
I talked to Martin about this at the sprints. He wants the set of patches in
the 2.5 hg repo to be exactly those that he should apply to svn to build the
next release, no more no less. If someone wants to propose a patch that fixes
the hg compile but does
Changes by R. David Murray :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue11594>
___
___
Python-bugs-list mailing list
Unsubscribe:
R. David Murray added the comment:
>>> str(u"\u0411")
Traceback (most recent call last):
File "", line 1, in
UnicodeEncodeError: 'ascii' codec can't encode character u'\u0411' in position
0: ordinal not in range(128)
So, clearly
R. David Murray added the comment:
Well, python3 is probably pushing some people to try to add better unicode
support to their python2 versions. I think it is more a question of "is this
an easy fix?" or would it require extensive changes to support unicode
properly. If it is ea
R. David Murray added the comment:
Until unittest learns to do parameterized tests, it's nice to have each test be
separate so that you can easily see which test cases are failing. (A number of
the existing email tests have a lot of tests in each "unit" test, and this can
R. David Murray added the comment:
I understand what you are saying, and I thought about that, too; but
you could say the same thing about any bug fix that makes code work that didn't
work before, yet we don't. So I guess you are right that it should be
discussed on
Changes by R. David Murray :
--
Removed message: http://bugs.python.org/msg131361
___
Python tracker
<http://bugs.python.org/issue11579>
___
___
Python-bugs-list m
R. David Murray added the comment:
I understand what you are saying, and I thought about that, too; but you could
say the same thing about any bug fix that makes code work that didn't work
before, yet we don't. So I guess you are right that it should be discussed on
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue9874>
___
___
Python-bugs-list mailing list
Un
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue11605>
___
___
Python-bugs-list mailing list
Un
Changes by R. David Murray :
--
assignee: -> r.david.murray
stage: -> patch review
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
I can reproduce this just using message_from_binary_file and BytesGenerator on
your input file, so thanks for attaching the email. I have a test in the test
suite that is *supposed* to test this, but clearly there is a case here that is
not being tested
R. David Murray added the comment:
Fixed now. Thanks, and sorry for the delay, and the confusion.
--
resolution: accepted -> fixed
stage: needs patch -> committed/rejected
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
Gah, I messed up the push. Now I have to backport the doc fix :(
--
___
Python tracker
<http://bugs.python.org/issue7
Changes by R. David Murray :
--
assignee: skip.montanaro -> r.david.murray
status: closed -> open
___
Python tracker
<http://bugs.python.org/issue7198>
___
__
R. David Murray added the comment:
OK, now it's really done (I hope!).
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7198>
___
R. David Murray added the comment:
Thanks, Michael! I tweaked the patch slightly: deleted that
test-writing-helper check you had marked with the XXX, and renamed the helper
test methods to _test_XXX. I also didn't wind up applying it to 2.7 because hg
doesn't support merge ma
Changes by R. David Murray :
--
assignee: -> r.david.murray
stage: -> patch review
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Thanks again, Michael.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Michael, in general your approach looks sound and is much easier to read and
comprehend than the original code (which, as the comments say, was never
refined from the original quick and dirty hack). However, rather than
dynamically defining sub-functions
New submission from R. David Murray :
Example:
http://www.python.org/dev/buildbot/all/builders/x86%20FreeBSD%207.2%203.x/builds/1609/steps/test/logs/stdio
==
FAIL: test_source (test.test_collections.TestNamedTuple
R. David Murray added the comment:
I needed an airplane-trip-sized problem to work on on the way back from PyCon
and the sprints, so I tried my hand at "fixing" this. The attached patch is
really just a proof of concept. Because it is so invasive of the email package
machinery I
Changes by R. David Murray :
--
versions: -Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue975330>
___
___
Python-bugs-list m
R. David Murray added the comment:
Yes there is a delay. The cron job that creates the link runs every two
minutes. Not sure why the delay seems to be longer than that, though.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.
R. David Murray added the comment:
I turns out that issue 5803 has a patch that also fixes this bug, and the
algorithm used there is even more efficient than the one you've developed here.
However, it is also not compatible with the email5 version of quoprimime. It
could be adapted,
Changes by R. David Murray :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Thanks. Shortened patch by using the fact that os.path.join returns the second
component if it is absolute, as discussed on IRC.
--
nosy: +r.david.murray
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> cl
R. David Murray added the comment:
Made the same change to the usage of os.path.join.
--
nosy: +r.david.murray
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
type: -> feature request
___
Py
Changes by R. David Murray :
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Antoine wrote:
> Do you want to keep track of the specificities of each version of the *BSDs?
Currently regrtest does, but they are currently all set to the same list of
tests. Perhaps a FreeBSD generic that implies all versions, and then if we
ever hav
R. David Murray added the comment:
Thinking about this some more, I now think it is incorrect that an 8bit header
causes getitem to return a Header object. I think instead it should be
returning the stringified version of the header, including the unknown-8bit
encoding. That way
R. David Murray added the comment:
It is reasonably likely that the attached patch will fix this. It also removes
3 seconds of fixed overhead from the test.
--
keywords: +patch
nosy: +r.david.murray
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.3
Added f
R. David Murray added the comment:
I documented that? Where?
It is true that the fact that all headers will be objects when using the email6
API was one reason I did it this way, but in hindsight I don't think it was the
right choice. However, I/we may now be stuck with it, in which
R. David Murray added the comment:
Heh.
OK, so I think we're stuck with it, then. It does mean I don't have to handle
certain other edge cases, and can punt more convenient handling of them into
email6. I'll make the patch for decode_heade
R. David Murray added the comment:
OK, here is the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file21392/decode_Header.patch
___
Python tracker
<http://bugs.python.org/issue11
R. David Murray added the comment:
Theoretically there should be no way to get bytes into that code path. I'm
sure there's a way if you try hard enough (I haven't tried directly assigning a
byte string as a header value, for example), but they would be broken uses of
the AP
R. David Murray added the comment:
That could be, certainly. The code is depending on the mtime having a
resolution of at least one second. Try making the constant 61 instead of 60.
If that doesn't work, try putting the mtime back a lot farther and see if that
makes it work If it p
R. David Murray added the comment:
Hmm. You are right, I wasn't thinking clearly, and I copied that mtime setting
call from another test. Now I have no idea why 61 would work, unless the clock
between your virthost and your smb server is off by a m
R. David Murray added the comment:
Could you print out the mtime values that are being set, and the value of
self._mbox._last_read? Or, rather, print out the result of calls to
os.path.getmtime on the two directories after the mtime is changed
R. David Murray added the comment:
Hmm. 411-61=350. Three seconds difference looks a little odd. But doesn't
explain 60 vs 61 making the difference in the test.
Can you change it back to 60 (or even less) and see what the values look like
when the test fails?
It is interesting
R. David Murray added the comment:
All right, so how about I set the add factor to, say, 5, so that if things are
mostly in sync it will succeed, and otherwise just ignore your failures :)
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by R. David Murray :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
R. David Murray added the comment:
Antoine agreed in IRC that this was an acceptable closure.
--
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/
R. David Murray added the comment:
Are you sure? (see issue 10471). I don't see how -b could do anything in
python2, since bytes and string are the same there (and, indeed, from command
line experimentation it doesn't seem to).
--
nosy: +r.da
R. David Murray added the comment:
rdmurray@hey:~/python/p27>cat temp.py
x = bytes('abc')
print x
print str(x)
rdmurray@hey:~/python/p27>./python -bb temp.py
abc
abc
--
___
Python tracker
<http://bugs.py
1001 - 1100 of 10554 matches
Mail list logo
