Jason R. Coombs added the comment:
I just confirmed, and `normalize_path` has been moved to the _legacy module for
importlib_resources, so I'd expect that change to land in CPython soon too.
--
___
Python tracker
<https://bugs.py
New submission from Jason R. Coombs :
importlib_resources 5.4 did some refactoring to ensure that the preferred
traversable API was tested
(https://github.com/python/importlib_resources/pull/239). Let's incorporate
those changes for importlib.resources.
--
messages: 408872
Change by Jason R. Coombs :
--
components: +Library (Lib)
versions: +Python 3.11
___
Python tracker
<https://bugs.python.org/issue46125>
___
___
Python-bug
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue46125>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
I filed issue46125 to track that issue separately.
--
___
Python tracker
<https://bugs.python.org/issue46124>
___
___
Pytho
New submission from Jason R. Coombs :
In https://github.com/python/importlib_metadata/issues/302, I learned that the
way unittest reports failures in tests is incentivizing the replacement of
docstrings with comments in order not to make resolution of the relevant
failing test more difficult
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28409
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30189
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28410
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30190
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 9b52920173735ac609664c6a3a3021d24a95a092 by Jason R. Coombs in
branch 'main':
bpo-46125: Refactor tests to test traversable API directly. Includes changes
from importlib_resources 5.4.0. (GH-30189)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
Absolutely. I was thinking to do just that.
--
___
Python tracker
<https://bugs.python.org/issue46126>
___
___
Python-bug
Jason R. Coombs added the comment:
I created this diff:
```diff
diff --git a/Lib/test/test_importlib/test_metadata_api.py
b/Lib/test/test_importlib/test_metadata_api.py
index e16773a7e8..92aacd5ad5 100644
--- a/Lib/test/test_importlib/test_metadata_api.py
+++ b/Lib/test/test_importlib
Jason R. Coombs added the comment:
My guess is the tests were run with something like this:
```
./python.exe -E -We -m test -v test_importlib | grep '... ERROR'
Entry points should only be exposed for the first package ... ERROR
test test_importlib failed
```
In that case, the l
Jason R. Coombs added the comment:
Looks like the code, I believe here's where the reporting happens:
https://github.com/python/cpython/blob/9b52920173735ac609664c6a3a3021d24a95a092/Lib/unittest/runner.py#L48-L51
I see a "description" property there that may already prov
Jason R. Coombs added the comment:
It looks like that 'descriptions' attribute is passed through from
TextTestRunner, which sets it to True by default
(https://github.com/python/cpython/blob/9b52920173735ac609664c6a3a3021d24a95a092/Lib/unittest/runner.py#L163).
It seems that beha
Jason R. Coombs added the comment:
After some investigation (and tracing calls through a dozen or more layers), I
found that Python's own regression tests can disable this behavior thus:
```
diff --git a/Lib/test/support/testresult.py b/Lib/test/support/testresult.py
index 2cd13
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28415
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30194
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
assignee: jaraco -> p-ganssle
___
Python tracker
<https://bugs.python.org/issue46124>
___
___
Python-bugs-list mailing list
Un
Jason R. Coombs added the comment:
The reason I wanted to consider issue46118 first was because I wanted to
explore whether the ABCs from `importlib_resources.abc` should be _documented_
as `importlib.resources.abc` or `importlib.abc` (as they are now).
After filing the issue and exploring
Jason R. Coombs added the comment:
> a ToC at the top of the main page which identifies the submodules (and
> provides a brief summary for each) would be extra helpful.
I've added this in the latest commit (1adefaf552).
--
___
Pyt
Jason R. Coombs added the comment:
As I'm exploring this issue, I notice that currently, the docs refer to
:class:`importlib.resources.abc.Traversable` (even though that doesn't
currently exist)
(https://github.com/python/cpython/blame/main/Doc/library/importli
Jason R. Coombs added the comment:
I recently noticed that some docs already refer to `importlib.resources.abc`
even though it doesn't currently exist
(https://github.com/python/cpython/blame/main/Doc/library/importlib.rst#L948).
That finding leads me to adjust my expectation that pe
Jason R. Coombs added the comment:
I realize, I can limit the scope of this issue to address 'resources' alone,
leaving ABCs where they are except for resource-related ones, allowing us to
defer a larger refactoring to a separate issue/effort.
--
title: Separate resourc
Jason R. Coombs added the comment:
> Does `joinpath` have less validation?
Yes. Previously, resources.* would perform some validation on the path to
ensure that it didn't contain path separators (to avoid users attempting to get
resources in subdirectories or perhaps manipulating
Jason R. Coombs added the comment:
Normalize_path from legacy implementation:
https://github.com/python/importlib_resources/blob/3beb2fd5831e65f7b45033e1ec276c4a6b4ca973/importlib_resources/_legacy.py#L30-L40
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
New changeset e712a5b277866a71c195f38c1b5d87d9126dba3e by Jason R. Coombs in
branch 'main':
bpo-46118: Move importlib.resources to its own package. (#30176)
https://github.com/python/cpython/commit/e712a5b277866a71c195f38c1b5d87
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 99945c6b5cf280bd90075cffae942af44941abcc by Jason R. Coombs in
branch 'main':
bpo-46109: Separate out files relating to importlib.resources (GH-30160)
https://github.com/python/cpython/commit/99945c6b5cf280bd90075cffae942a
Jason R. Coombs added the comment:
Installed buildbots are failing (like this one:
https://buildbot.python.org/all/#/builders/350/builds/1164). I'm going to see
if it's a simple fix like updating the makefile or if a rollback is called for.
--
status: clos
Change by Jason R. Coombs :
--
pull_requests: +28525
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/30311
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Looks like I encountered the same foot gun when originally introducing the
importlib.metadata package (issue34632).
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
And the underlying cause is reported in issue37043.
--
___
Python tracker
<https://bugs.python.org/issue46118>
___
___
Pytho
Jason R. Coombs added the comment:
I encountered this issue again today in issue46118.
I started looking into creating the patchcheck, but I realize it may be a
little tricky to detect the introduction of a new folder, because `git diff`
doesn't actually report new folders, and my in
Jason R. Coombs added the comment:
New changeset 35628e4cde71e54afe12aea50c74069afe2c3389 by Jason R. Coombs in
branch 'main':
bpo-46118: Make sure importlib.resources is included. (GH-30311)
https://github.com/python/cpython/commit/35628e4cde71e54afe12aea50c7406
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46118>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
> > I presume I don't need to explain why docstrings are nice and preferable
> > over comments.
> Actually, can you?
I searched around and didn't find any good treatise or thorough overview of
reasons _why_ docstrings should be
Jason R. Coombs added the comment:
I'd recommend not to block on issue24132. It's not obvious to me that
subclassing would be valuable. It depends on how it's implemented, but in my
experience, zipfile.Path doesn't and cannot implement the full interface of
p
Jason R. Coombs added the comment:
Perhaps it is a mistake. The `__slots__` were added as a (possible premature)
optimization in [this
conversation](https://github.com/python/importlib_metadata/pull/278/files#r565475347).
It's not obvious to me what the danger is in defining __slots__
Jason R. Coombs added the comment:
Today I learned something. Thanks Arie. Yes, I agree that's a mistake. Perhaps
the test suite should also have a test to capture the missed expectation (that
__dict__ should not be present or setting attributes on EntryPoints instances
should
Jason R. Coombs added the comment:
I don't have a good answer, but given the title of this issue (which is
specifically scoped to site install schemes), I'm tempted to say we should deal
with prefixes in a separate, perhaps broader issue, and there address the
reported issue (tha
New submission from Jason R. Coombs :
I'd like to be able to do something pretty fundamental: lazily load lines from
a file in a single expression.
Best I can tell, that's not possible in the language without triggering
warnings.
One can use 'open' but that trigge
Jason R. Coombs added the comment:
Hi Eric. I did mention that option in my report, but that option requires
loading the whole file into memory. I'd like something equivalent to the
iterator that `open()` provides, which yields lines lazily.
Serihy, thanks for the feedback. I do indee
Jason R. Coombs added the comment:
Nice reference. Indeed, the
[rationale](https://www.python.org/dev/peps/pep-0533/#id15) of that pep gives a
similar example and the
[background](https://www.python.org/dev/peps/pep-0533/#id3) describes the
problem with the solution I've drafted abov
R. David Murray added the comment:
Note also that datetime.now() gives you a naive datetime. From an API
consistency standpoint I think it makes sense that datetime.utcnow() gives a
naive datetime. It would actually be confusing (IMO) for it to return an aware
datetime. I can see why you
R. David Murray added the comment:
Note that the parser does attempt to accept obsolete syntax (registering
defects for it), so if there is a bug in the implementation of the obsolete
syntax handling it should be fixed. And yes, there have been other bugs with
whitespace handling in the
R. David Murray added the comment:
The general idea is that the string version of the header should contain all of
the original information, but the parsed elements (the things returned by
special header attributes) will contain the valid data, if any. So if the
string version of the
Jason R. Coombs added the comment:
Closing, presumed fixed. Please re-open if not.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue46425>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
I've merged the fix for regrtest and I'll explore Terry's concerns and see what
I can devise for those concerns as well.
--
___
Python tracker
<https://bugs.pyt
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue46126>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
pull_requests: +28984
pull_request: https://github.com/python/cpython/pull/30799
___
Python tracker
<https://bugs.python.org/issue46
New submission from Jason R. Coombs :
Originally reported to the Python Security Response Team, the
EntryPoint.pattern demonstrates a potential
[ReDoS](https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_).
The issue has been patched and fix released with
Jason R. Coombs added the comment:
Because I want this security issue to be back-portable to older Pythons, I'll
first apply importlib_metadata 4.10.0 and then apply the change from 4.10.1
separately.
--
___
Python tracker
&
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +28987
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30802
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +28988
pull_request: https://github.com/python/cpython/pull/30802
___
Python tracker
<https://bugs.python.org/issue46
Change by Jason R. Coombs :
--
pull_requests: +28990
pull_request: https://github.com/python/cpython/pull/30803
___
Python tracker
<https://bugs.python.org/issue46
Change by Jason R. Coombs :
--
pull_requests: +28989
pull_request: https://github.com/python/cpython/pull/30803
___
Python tracker
<https://bugs.python.org/issue46
Change by Jason R. Coombs :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue41682>
___
___
Python-bugs-list mai
Jason R. Coombs added the comment:
New changeset d888ff5381594641126065e78dc9210dae4436a4 by Jason R. Coombs in
branch 'main':
bpo-46425: Partially revert "bpo-46425: fix direct invocation of
`test_importlib` (GH-30682)" (GH-30799)
https://github.com/p
Jason R. Coombs added the comment:
New changeset 443dec6c9a104386ee90165d32fb28d0c5d29043 by Jason R. Coombs in
branch 'main':
bpo-46474: Apply changes from importlib_metadata 4.10.0 (GH-30802)
https://github.com/python/cpython/commit/443dec6c9a104386ee90165d32fb28
Jason R. Coombs added the comment:
New changeset 51c3e28c8a163e58dc753765e3cc51d5a717e70d by Jason R. Coombs in
branch 'main':
bpo-46474: Avoid REDoS in EntryPoint.pattern (sync with importlib_metadata
4.10.1) (GH-30803)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
pull_requests: +29014
pull_request: https://github.com/python/cpython/pull/30827
___
Python tracker
<https://bugs.python.org/issue46
Change by Jason R. Coombs :
--
pull_requests: +29015
pull_request: https://github.com/python/cpython/pull/30828
___
Python tracker
<https://bugs.python.org/issue46
Change by Jason R. Coombs :
--
pull_requests: +29016
pull_request: https://github.com/python/cpython/pull/30829
___
Python tracker
<https://bugs.python.org/issue46
Jason R. Coombs added the comment:
New changeset a7a4ca4f06c8c31d7f403113702ad2e80bfc326b by Jason R. Coombs in
branch '3.10':
[3.10] bpo-46474: Avoid REDoS in EntryPoint.pattern (sync with
importlib_metadata 4.10.1) (GH-30803) (GH-30827)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 1514d1252f96e6a83eb65c439522a6b5443f6a1a by Jason R. Coombs in
branch '3.9':
[3.9] bpo-46474: Avoid REDoS in EntryPoint.pattern (sync with
importlib_metadata 4.10.1) (GH-30803). (GH-30828)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
R. David Murray added the comment:
Yeah, I think we need a complete example here.
Note that in the general case there is no such thing as an RFC-valid email in
unicode (which is what python strings are), though with utf8=True and an email
involving only text you might get away with it. I
Jason R. Coombs added the comment:
Thanks Nikita for the report. I agree, it's inelegant that this property leaks.
Because this code is synced with importlib_metadata, I'm not sure it's worth
the effort of changing it here. Your change here implies a cherry-pick to the
backpo
New submission from Jason R. Coombs :
Attempting to define a lazy-loaded property for a module, I found [this
guidance](https://stackoverflow.com/a/52018676/70170) referencing [module
attribute
access](https://docs.python.org/3/reference/datamodel.html#customizing-module-attribute-access
Jason R. Coombs added the comment:
The tempora library implements a [portable
strftime](https://tempora.readthedocs.io/en/latest/index.html#tempora.strftime).
--
___
Python tracker
<https://bugs.python.org/issue13
Jason R. Coombs added the comment:
I'm pretty sure both EntryPoints and DeprecatedList were introduced in Python
3.10, so 3.9 and 3.8 aren't relevant.
--
versions: -Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.o
R. David Murray added the comment:
The policy is named 'default' because it was intended to become the default two
feature releases after the new email code became non-provisional (first:
deprecate not specifying an explicit policy, next release make default the
default policy an
R. David Murray added the comment:
That is the first step, yes. In addition to that we need to have the various
explain_to methods delete the special attributes that aren't valid for the new
Message subtype.
--
___
Python tracker
R. David Murray added the comment:
I wonder if it has something to do with range returning a special type? range
and len are very different things under the hood.
--
nosy: +r.david.murray
___
Python tracker
<http://bugs.python.org/issue12
R. David Murray added the comment:
Unfortunately I don't think there is any way except going through each subclass
to see what special attributes it creates.
--
___
Python tracker
<http://bugs.python.org/is
R. David Murray added the comment:
Ezio, I don't see any indication in this ticket that this bug was actually
*fixed* in 3.x. Unicode doesn't cause immediate errors in 3.x, but it isn't
recognized as wordchars, etc. Am I mi
R. David Murray added the comment:
Why? The bug hasn't been fixed yet.
--
assignee: -> r.david.murray
stage: -> patch review
status: closed -> open
versions: +Python 3.2
___
Python tracker
<http://bugs.pyth
R. David Murray added the comment:
I may have, but I'd prefer to check before closing the issue. (I'm deep in
another project right now, but I'll review all these open bugs this fall some
time).
--
status: closed -> open
___
Pyt
R. David Murray added the comment:
It is python.exe on OS/X, which I've always found most odd. The reason is that
the OS/X filesystem is case insensitive by default, and there is a directory
named 'Python'.
--
nosy: +r.david.murray
___
R. David Murray added the comment:
I'm flat out right now on other projects. But if no one else gets around to
doing a final review and commit I should be able to get to it by the end of
October. If I don't, please ping me by posting
Changes by R. David Murray :
--
assignee: docs@python
components: Documentation
nosy: docs@python, r.david.murray
priority: normal
severity: normal
status: open
title: RLock support the context manager protocol but this is not documented
___
Python
Jason R. Coombs added the comment:
I now seem to be unable to reproduce the issue. I do keep my .pypirc in a
revision control system, so I have reasonable confidence that my .pypirc
contained the content that I'm attaching now (passwords scrubbed of course).
One possible factor is th
Jason R. Coombs added the comment:
Sure enough. I just confirmed that with Python 3.2.0, if .pypirc is symlinked,
distutils behaves as if the .pypirc isn't present at all, but if that same
.pypirc is copied, it behaves as expected. If one deletes the .pypirc
altogether, it produces the
R. David Murray added the comment:
Note that a C accelerator for Decimal is in the works.
--
nosy: +mark.dickinson, r.david.murray
___
Python tracker
<http://bugs.python.org/issue13
R. David Murray added the comment:
It seems to me that saying "floating point" and "mathematically correct" in the
same breath is...optimistic :) But that's why I added Mark to nosy, he knows
far more about this stuff than I do.
As far as I know the accelerator is
R. David Murray added the comment:
+1. decode_idna is likely to be useful to the email package.
--
___
Python tracker
<http://bugs.python.org/issue3232>
___
___
Changes by R. David Murray :
--
stage: -> needs patch
versions: -Python 2.6, Python 3.1, Python 3.4
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
It seems clear enough to me that when a process terminates ("the entire Python
program exits") then all of its threads must terminate. That's part of the
definition of threads, to my understanding.
I think the confusion arises from the
Changes by R. David Murray :
--
assignee: -> r.david.murray
___
Python tracker
<http://bugs.python.org/issue13080>
___
___
Python-bugs-list mailing list
Un
R. David Murray added the comment:
This looks correct to me, and it tested out fine on the test suite (and the
provided test failed without the provided fix), so I committed it.
I have a small concern that the change in output might be a bit radical for a
bug fix release, but it does seem to
R. David Murray added the comment:
Heh, you happened to post your patch at a time when I wanted something to do as
a break from something I didn't want to do...and I *thought* I understood the
problem, after reading the various links. But clearly I didn't. We don't have
R. David Murray added the comment:
Sorry. It is intended behavior. The lambda 'each' is bound to the local
'each', and by the time the lambda's execute, the value of 'each' is 'baz'.
I'm going to turn this into a doc bug, because while
Changes by R. David Murray :
--
title: setattr misbehaves when used with lambdas inside for loop -> Need
Programming FAQ entry for the behavior of closures
___
Python tracker
<http://bugs.python.org/issu
R. David Murray added the comment:
Hmm. But what I did was look up the RLock section of the manual to answer the
question "does this support the context manager protocol", and the answer
appeared to be no. In a reference manual I would expect all the important
features of an ob
Jason R. Coombs added the comment:
Thanks Garen for the detailed analysis and writeup. The short answer to your
question is "supported by the Python runtime". Allow me to provide a bit of
history.
Symlink awareness under Windows was added to Python in Python 3.2, so the
behavior
R. David Murray added the comment:
I wonder if it is a bug in Windows? Have you tried similar experiments with
regular files? tempfile is really just about *where* the files are located
(and what happens when they are closed), not about their fundamental nature as
OS file objects. (I
R. David Murray added the comment:
Well, your patch is a little *too* simple: it doesn't change the function
prototype to match :)
This is a cosmetic issue rather than a bug, but it would still be nice to fix
it. Or maybe a documentation issue in the sense that Python code is (us
New submission from Jason R. Coombs :
The urllib2 docs indicate that HTTPError is a subclass of URLError and that
URLError has an attribute of 'reason', but HTTPError does not have this
attribute. The docs should be updated to reflect this deviance.
It appears the Python 3.2 docs
R. David Murray added the comment:
"This issue" is currently a collection point for specific "allow this in lax
mode" issues. Do you have one or more specific cases in point that you'd like
to talk about? (Note that the 'garbage after end of fil
101 - 200 of 12187 matches
Mail list logo
