Petr Viktorin added the comment:
Closing per discussion in https://github.com/python/cpython/pull/13357
--
resolution: -> not a bug
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 33e71e01e95506cf8d93fd68251fc56352bc7b39 by Petr Viktorin (Marcel
Plch) in branch 'master':
bpo-31862: Port binascii to PEP 489 multiphase initialization (GH-4108)
https://github.com/python/cpython/commit/33e71e01e95506cf8d93fd68251fc5
Petr Viktorin added the comment:
New changeset d092caf096fa48baadfc0900792206bb5aa0192d by Petr Viktorin (Jeroen
Demeyer) in branch '3.7':
bpo-36907: fix refcount bug in _PyStack_UnpackDict() (GH-13381) (GH-13493)
https://github.com/python/cpyt
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Petr Viktorin :
If the PyObject_MALLOC() call failed in PyType_FromSpecWithBases(),
PyObject_Free() would be called on a static string in type_dealloc().
Fixed by Zackery Spytz in pull request 10304. I'm opening the issue
retroactively.
--
messages: 343194
Change by Petr Viktorin :
--
pull_requests: +13412
___
Python tracker
<https://bugs.python.org/issue37012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Petr Viktorin :
--
pull_requests: +13411
___
Python tracker
<https://bugs.python.org/issue37012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
New changeset f1e17e9f97d9a4e97a5d99574775ee343a3a74fb by Petr Viktorin in
branch 'master':
bpo-34626: Document creating heap types from the C-API (GH-9154)
https://github.com/python/cpython/commit/f1e17e9f97d9a4e97a5d99574775ee
Petr Viktorin added the comment:
It looks like this caused bpo-37072: PyAST_FromNodeObject doesn't ignore flags
any more, and when PyNode_Compile passes NULL flags, it crashes.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.py
Petr Viktorin added the comment:
Looks like this is caused by:
https://github.com/python/cpython/pull/12086/files#diff-4d35cf8992b795c5e97e9c8b6167cb34R787
PyAST_FromNodeObject doesn't ignore flags any more, so when PyNode_Compile
passes NULL flags, it crashes.
(This is unfamiliar cod
Petr Viktorin added the comment:
New changeset eb65e2443ac21739baf6d373abc7b4638b9d6927 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36922: implement PEP-590 Py_TPFLAGS_METHOD_DESCRIPTOR (GH-13338)
https://github.com/python/cpython/commit/eb65e2443ac21739baf6d373abc7b4
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Petr Viktorin :
New changeset aacc77fbd77640a8f03638216fa09372cc21673d by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: implement PEP 590 (GH-13185)
https://github.com/python/cpython/commit/aacc77fbd77640a8f03638216fa093
Change by Petr Viktorin :
--
pull_requests: +13555
pull_request: https://github.com/python/cpython/pull/13665
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset fecb75c1bb46c818e6579ba422cfa5d0d9d104d1 by Petr Viktorin in
branch 'master':
bpo-36974: Fix GDB integration (GH-13665)
https://github.com/python/cpython/commit/fecb75c1bb46c818e6579ba422cfa5
New submission from Petr Viktorin :
test_gdb.StackNavigationTests.test_pycfunction checks that the GDB integration
can pick up calls to C-API functions. Currently it includes the comment:
> Tested function must not be defined with METH_NOARGS or METH_O,
> otherwise call_function() d
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +13557
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13668
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
No, just https://github.com/python/cpython/pull/13665 is addressing the
failures. And it seems that it's successful -- only the slowest of the failed
ones (AMD64 Ubuntu Shared 3.x) is still red.
bpo-37090 extends the test so it can catch more bugs i
Petr Viktorin added the comment:
All stable buildbots are back to green.
--
___
Python tracker
<https://bugs.python.org/issue36974>
___
___
Python-bugs-list m
Petr Viktorin added the comment:
New changeset 735e8afa9ee942367b5d0807633a2b9f662cbdbf by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: inherit the vectorcall protocol (GH-13498)
https://github.com/python/cpython/commit/735e8afa9ee942367b5d0807633a2b
Petr Viktorin added the comment:
New changeset c145f3bfbe80d498d40848450d4d33c14e2cf782 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: remove _PyObject_HasFastCall (GH-13460)
https://github.com/python/cpython/commit/c145f3bfbe80d498d40848450d4d33
Petr Viktorin added the comment:
New changeset 249b7d59d8038f9017fc95dc28a3ce3494aaf832 by Petr Viktorin
(Zackery Spytz) in branch 'master':
bpo-20602: Do not clear sys.flags and sys.float_info during shutdown (GH-8096)
https://github.com/python/cpyt
Petr Viktorin added the comment:
New changeset 37788bc23f6f1ed0362b9b3b248daf296c024849 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: rename _FastCallKeywords -> _Vectorcall (GH-13653)
https://github.com/python/cpython/commit/37788bc23f6f1ed0362b9b3b248
Petr Viktorin added the comment:
I found an issue in PEP 590:
When inheriting a heap subclass from a vectorcall class that sets
.tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit
_Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it.
Possible
Change by Petr Viktorin :
--
pull_requests: +13584
pull_request: https://github.com/python/cpython/pull/13699
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset fb9423fd0a85f06affb8c3a8f25dd598a649aa42 by Petr Viktorin in
branch 'master':
bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types (GH-13699)
https://github.com/python/cpython/commit/fb9423fd0a85f06affb8c3a8f25dd5
Petr Viktorin added the comment:
I will fix the compiler warning along with another one that I just introduced.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue36
Change by Petr Viktorin :
--
pull_requests: +13640
pull_request: https://github.com/python/cpython/pull/13758
___
Python tracker
<https://bugs.python.org/issue36
Change by Petr Viktorin :
--
pull_requests: +13639
pull_request: https://github.com/python/cpython/pull/13758
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in
branch 'master':
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings
(GH-13758)
https://github.com/python/cpython/commit/e584cbff1ea78e700cf9
Petr Viktorin added the comment:
New changeset e584cbff1ea78e700cf9943d50467e3b58301ccc by Petr Viktorin in
branch 'master':
bpo-36027 bpo-36974: Fix "incompatible pointer type" compiler warnings
(GH-13758)
https://github.com/python/cpython/commit/e584cbff1ea78e700cf9
Petr Viktorin added the comment:
New changeset 7f4ae1b2cc60cb69938e7c88793b9e9a2dd36d93 by Petr Viktorin in
branch 'master':
bpo-37012: Clean up special cases in PyType_FromSpecWithBases slot assignments
(GH-13496)
https://github.com/python/cpyt
Petr Viktorin added the comment:
New changeset 9e3e06e582accec82eb29cf665c3b4c7d84d2eb0 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: document PEP 590 (GH-13450)
https://github.com/python/cpython/commit/9e3e06e582accec82eb29cf665c3b4
Petr Viktorin added the comment:
New changeset be718c33f06b3496faa61142df24fb071fd5d1f1 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: add some assertions for PEP 590 (GH-13682)
https://github.com/python/cpython/commit/be718c33f06b3496faa61142df24fb
Change by Petr Viktorin :
--
pull_requests: +13646
pull_request: https://github.com/python/cpython/pull/13761
___
Python tracker
<https://bugs.python.org/issue36
Petr Viktorin added the comment:
New changeset 1e375c6269e9de4f3d05d4aa6d6d74e00f522d63 by Petr Viktorin in
branch 'master':
bpo-36027: Really fix "incompatible pointer type" compiler warning (GH-13761)
https://github.com/python/cpython/commit/1e375c6269e9de4f3d05
Change by Petr Viktorin :
--
pull_requests: +13649
pull_request: https://github.com/python/cpython/pull/13761
___
Python tracker
<https://bugs.python.org/issue33
Petr Viktorin added the comment:
New changeset 13136e83a637a9f1cfbada7e93097005296659b4 by Petr Viktorin
(Matthias Bussonnier) in branch 'master':
bpo-36896: Clarify that some types constructors are unstable (GH-13271)
https://github.com/python/cpyt
New submission from Petr Viktorin :
Hello,
I haven't investigated this fully yet, and won't be able to find time today.
I'm forwarding the report here in case someone familiar with the code wants to
take a look.
On Fedora, "clang" fails to build with Python 3.8,
Petr Viktorin added the comment:
Possible regression caused by this change: https://bugs.python.org/issue37140
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue35
Petr Viktorin added the comment:
The issue is with building clang using Python 3.8; not building Python 3.8
using clang :)
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Petr Viktorin :
When compiled with GCC's -Werror=declaration-after-statement ("intermingled
declarations" in PEP7), cpython/abstract.h (included from ) errors on
vectorcall helper functions added in 3.8.0 Beta 1.
It's well within our rights to ignor
Change by Petr Viktorin :
--
keywords: +patch
pull_requests: +13761
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/13887
___
Python tracker
<https://bugs.python.org/issu
Petr Viktorin added the comment:
> pygobject3, python-dbus, xen
Correction:
- The Fedora packages failed to build; this might or might not be due to the
projects themseves
- pygobject3 actually only warns on this
Anyway, we can usually take care of open-source stuff. Only take it a
Petr Viktorin added the comment:
New changeset 3f345c39255dc3823dd989d4e3c93b12d18c44e0 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-37151: simplify classmethoddescr_call (GH-13340)
https://github.com/python/cpython/commit/3f345c39255dc3823dd989d4e3c93b
Petr Viktorin added the comment:
Please don't forget that it is possible to use venv without PyPI.
With my Fedora hat on: as a distro, we don't trust PyPI as a package delivery
infrastructure. Lots of users do, and we allow the users to easily but
explicitly opt in to trusting it
Petr Viktorin added the comment:
I agree with Steve that renaming tp_print to tp_vectorcall_offset is well
within our rights.
For reference, the rationale for the replacing is the first section of:
https://mail.python.org/pipermail/python-dev/2018-June/153927.html
I hope Cython
Petr Viktorin added the comment:
> scientific projects that depend on it may lag longer as rebuilds and releases
> will need to happen on PyPI, conda, and conda-forge.
Keep in mind that binary artifacts (wheels, Conda/distro packages) should not
be affected. They need to be re-bui
Petr Viktorin added the comment:
New changeset a8b27e623d75377aabe50df27e97cab4e81a174a by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858)
https://github.com/python/cpython/commit/a8b27e623d75377aabe50df27e97ca
Petr Viktorin added the comment:
1. If sdist consumers will need to regenerate an sdist?
They would need to compile from the source, e.g. clone from Git and make an
sdist (or install) from that.
2. How many sdist consumers will likely be impacted?
I don't know. Depends on how fast p
Petr Viktorin added the comment:
New changeset 26fe6c35374fa32577b230b856a92a3b094e08ed by Petr Viktorin (Miss
Islington (bot)) in branch '3.8':
bpo-36974: inherit tp_vectorcall_offset unconditionally (GH-13858) (GH-14342)
https://github.com/python/cpyt
Petr Viktorin added the comment:
New changeset d917cfe4051d45b2b755c726c096ecfcc4869ceb by Petr Viktorin (Jeroen
Demeyer) in branch '3.8':
[3.8] bpo-37250: put back tp_print for backwards compatibility (GH-14193)
https://github.com/python/cpyt
Petr Viktorin added the comment:
New changeset 4a2edc34a405150d0b23ecfdcb401e7cf59f4650 by Petr Viktorin (Pablo
Galindo) in branch 'master':
bpo-37221: Add PyCode_NewWithPosOnlyArgs to be used internally and set
PyCode_New as a compatibility wrapper (GH-13959)
https://github.
Petr Viktorin added the comment:
> https://github.com/cython/cython/pull/3009 was merged.
(to master, so far)
> Is it part of Cython 0.29.11 released yesterday?
It should be, see: https://cython.readthedocs.io/en/latest/src/changes.ht
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 0d722f3cd602e5f5492f9c65c8af57ea9d3743b6 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-36974: separate vectorcall functions for each calling convention (GH-13781)
https://github.com/python/cpyt
Petr Viktorin added the comment:
Buildbots are green, closing.
Thank you for the implementation!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset 7b57c03a7cb63ccfb2b8dfa82a1bf169268d80ba by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-37151: remove _PyMethodDef_RawFastCall* functions (GH-14603)
https://github.com/python/cpython/commit/7b57c03a7cb63ccfb2b8dfa82a1bf1
Petr Viktorin added the comment:
Thank you, Jeroen and INADA-san!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Petr Viktorin added the comment:
New changeset b1e4d1b6032d4c82b549233fa08a2c7cfe7e818b by Petr Viktorin (Miss
Islington (bot)) in branch '3.8':
bpo-26967: fix flag grouping with allow_abbrev=False (GH-14316) (GH-14759)
https://github.com/python/cpyt
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Changes by Petr Viktorin :
--
nosy: +encukou
___
Python tracker
<http://bugs.python.org/issue26415>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
The test is already skipped if the user is root. It verifies that process 1
can't be touched by non-root users.
The problem is an assumption that process with PID 1 belongs to root. That
assumption isn't true in containers: PID 1 is whatever the con
Petr Viktorin added the comment:
Do we have a use case for this?
I'd rather avoid making it easy to do the wrong thing, unless it's needed.
--
___
Python tracker
<http://bugs.python.o
Petr Viktorin added the comment:
Again, what is the use case? That's a real question, I'm not saying it to
dismiss your ideas or points of view. It would be very much easier to think
about a concrete use case, rather than making a general system for the sake of
how easy it is impl
Petr Viktorin added the comment:
Alright, that makes sense. Thanks for the feedback!
Please give us some time for an updated proposal/implementation. I'm going on
vacation, so expect about a week.
--
___
Python tracker
<http://bugs.py
Petr Viktorin added the comment:
Ah, XML is such an overengineered format!
I usually live with the standard HTML entities – but it turns out
you can define your own!
Here's a reproducer which shows how to do that.
--
nosy: +petr.viktorin
Added file: https://bugs.pytho
Change by Petr Viktorin :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Petr Stupka :
OS: CentOS Linux release 7.6.1810 (Core)
==
FAIL: test_imap4_host_default_value (test.test_imaplib.TestImaplib)
--
Traceback
Petr Viktorin added the comment:
New changeset 4e80f5cbeaee87a26e49bc9623c92a10e28dbbd9 by Petr Viktorin (Paul
Ganssle) in branch 'master':
bpo-35186: Remove "built with" comment in setup.py upload (GH-10414)
https://github.com/python/cpython/commit/4e80f5cbeaee87a26e49
Petr Viktorin added the comment:
Hi (and sorry for the delay -- it's a busy time of year).
Unfortunately, there's no good documentation yet. Python's standard library
itself is not free of global state, and I don't think we want to start
documenting
Change by Petr Viktorin :
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/issue10915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
I would very much like to see this fixed.
Yes, it can make some extension types immortal, but I believe those types were
relying on buggy behavior, and need to be fixed to prevent memory leaks.
I think this is a big enough change to be mentioned in What’s New
Petr Viktorin added the comment:
I'll allocate time this week for the review.
--
___
Python tracker
<https://bugs.python.org/issue35810>
___
___
Pytho
Petr Viktorin added the comment:
Changing all types to heap types is definitely a gigantic task. First let's
make heap types more usable and bug-free, and then it will be easier :)
(I do have an agenda here: improving heap types usable is also yak-shaving* for
making modules play nice
Changes by Petr MOTEJLEK :
--
pull_requests: +391
___
Python tracker
<http://bugs.python.org/issue29615>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Petr MOTEJLEK :
--
pull_requests: +392
___
Python tracker
<http://bugs.python.org/issue29615>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Petr Zemek:
multiprocessing.Pool.__exit__() calls terminate() instead of close(). Why?
Wouldn't it be better (and more expected from a user's point of view) if it
called close()?
Reasons:
- Calling close() would wait until all tasks are completed before shutting
Changes by Petr Viktorin :
--
nosy: +encukou, ncoghlan
___
Python tracker
<http://bugs.python.org/issue30403>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
It's part of a larger effort to bring the capabilities of extension modules up
to par with Python ones. For example, it's one less surprise you'd get when you
Cythonize a module. And it's not only for stdlib modules – it's for any
ex
Petr Viktorin added the comment:
Adding Stefan from the Cython project.
Stefan, is this something you'd want to use?
(It does require PEP 489 multi-phase initialization, so I assume it would need
extra #ifdefs in Cythonized code for Python 3.5+ or 3.7+)
--
nosy: +s
Petr Viktorin added the comment:
This is now waiting to be added to the PEPs repo:
https://github.com/python/peps/pull/266
--
___
Python tracker
<http://bugs.python.org/issue30
Petr Viktorin added the comment:
PyModule_GetState() gives you *per-module* state, not per-interpreter state.
Module objects are shared across subinterpreters, unless you use multi-phase
initialization.
> PyModule_GetState() requires having the module object that corresponds
> to the
Petr Viktorin added the comment:
Joannah, yes, that looks like a good place. Eric Snow might have more info; he
wrote that module.
As for testing Py_FatalError, there's an assert_python_failure function in
test.support.script_h
Petr Viktorin added the comment:
New changeset 364f0b0f19cc3f0d5e63f571ec9163cf41c62958 by Petr Viktorin (Eddie
Elizondo) in branch 'master':
bpo-35810: Incref heap-allocated types in PyObject_Init (GH-11661)
https://github.com/python/cpython/commit/364f0b0f19cc3f0d5e63f571ec9163
Petr Viktorin added the comment:
I just reviewed, and I plan to merge it if I don't see any pushback from the
others.
Sorry for the extreme delay.
--
nosy: +petr.viktorin
___
Python tracker
<https://bugs.python.org/is
Petr Viktorin added the comment:
New changeset fcef60f59d04c63b3540b4c4886226098c1bacd1 by Petr Viktorin (Jeroen
Demeyer) in branch 'master':
bpo-33261: guard access to __code__ attribute in inspect (GH-6448)
https://github.com/python/cpython/commit/fcef60f59d04c63b3540b4c4886226
Change by Petr Viktorin :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33261>
___
___
Pyth
Petr Viktorin added the comment:
Indeed, this is a good idea.
--
___
Python tracker
<https://bugs.python.org/issue36616>
___
___
Python-bugs-list mailin
Petr Viktorin added the comment:
Correct usage of multi-phase init might now get users stuck when they start
needing per-module state. See PEP 573 "Module State Access from C Extension
Methods" for the (hopefully) last thing that prevents me from generally
recommending multi-
Petr Viktorin added the comment:
This is a duplicate of https://bugs.python.org/issue31474
which was fixed in https://github.com/python/cpython/pull/3581
It should be included in the next Python 2.7.x release.
--
nosy: +encukou
___
Python tracker
Petr Viktorin added the comment:
Well, PEP 489 basically punts this to module authors: generally, C globals are
bad, but if you do have global state, please manage it, keeping in mind that
multiple module objects can be created from the extension.
That's required to make everything work
Change by Petr Viktorin :
--
nosy: +Dormouse759, encukou
___
Python tracker
<https://bugs.python.org/issue26979>
___
___
Python-bugs-list mailing list
Unsub
Change by Petr Viktorin :
--
nosy: +Dormouse759
___
Python tracker
<https://bugs.python.org/issue15727>
___
___
Python-bugs-list mailing list
Unsubscribe:
Petr Viktorin added the comment:
An option would be to use a colon to separate the module(s) from the
attribute(s). The "inspect" module CLI does this, for example:
https://docs.python.org/3/library/inspect.html#command-line-interface
$ python3 -m inspect urllib.parse:SplitRes
601 - 700 of 950 matches
Mail list logo