Paul Moore added the comment:
PJE's patch looks OK. I agree with Nick that the chain of &&s in
PyImport_GetImporter should be expanded into a chain of ifs. As it
stands, the code is needlessly obfuscated.
_
Tracker <[EMAIL P
New submission from Paul Moore:
The latest MSI daily snapshot installer for Python 2.6 (19 Nov) does not
include the .pem files for the SSL tests from the Lib\test directory.
--
components: Installation
messages: 57666
nosy: pmoore
severity: normal
status: open
title: MSI installer does
Paul Moore added the comment:
The following looks like it may be OK. I have no way of testing it,
unfortunately, as I don't currently have a working build environment,
and I've no idea how to build the MSI even if I did...
Added file: http://bugs.python.org/file8782
New submission from Paul Moore:
When running the test suite on Windows, test_socket_ssl hangs.
After a bit of investigation, it appears that the test is hanging at
line 184 (if self.s.stdout.readline() != "ERROR\n":) in
OpenSSLServer._external.
The problem is that the test assumes i
New submission from Paul Moore :
When uninstalling a package installed using a bdist_wininst installer, the
uninstall reports "XXX files and directories could not be removed". The problem
appears to be the __pycache__ directories introduced in Python 3.2, which are
not remove
Paul Moore added the comment:
Not really (tbh, not at all). If I get some spare time, I can have a
look at producing a patch, but I have little time available for coding
at the moment (and I'm switching constantly between 3 PCs, so never
have a working development environment when I nee
Paul Moore added the comment:
On 9 October 2011 04:21, Éric Araujo wrote:
>
> Éric Araujo added the comment:
>
> I don’t have a Windows VM set up yet, but I can try to write a patch in the
> coming weeks and ask you to test it. Deal?
N
Changes by Paul Moore :
--
nosy: +pmoore
___
Python tracker
<http://bugs.python.org/issue12779>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Paul Moore :
I am trying to create a pysetup package that contains a precompiled binary
extension, which can be installed without compiling, by using the resource file
feature of setup.cfg. This may be incorrect usage of pysetup, but at a minimum,
a proper error message
New submission from Paul Moore :
In a directory with 2 files, setup.cfg and a single C file containing source
for an extension module. The same happens with a pure-python module. This is on
Windows.
PS D:\Data\python-sample> D:\Data\cpython\PCbuild\python.exe -m packaging.run
run --l
New submission from Paul Moore :
On Windows, packaging seems to create RECORD files with an additional CR at the
end of the line. (So the line end is CR CR LF). This does not seem to be
consistent, but it is likely to be because a file is being opened in text mode
rather than binary.
I am
Paul Moore added the comment:
No it didn't - I had not built the _msi module when I built Python for some
reason. I have built _msi now, and everything works. Sorry for the false alarm.
Arguably, the command shouldn't fail, it should simply omit the bdist_msi
command from the listi
New submission from Paul Moore :
With a simple setup.cfg defining a distribution containing a single Python
module, if you misspell the "modules" keyword (say, as "module") then pysetup
does nothing without reporting the error.
This silent failure is very hard to debug, an
Paul Moore added the comment:
Unfortunately, no. I have been unable to get this in a reproducible form - but
I have seen it a few times now. I will keep trying to reproduce.
The worst thing is that packaging fails to recognise the data in RECORD and
won't uninstall the package. It wou
New submission from Paul Moore :
The title explains. Here is an example:
PS D:\Data\python-sample\python> pysetup install
Installing from source directory: 'D:\\Data\\python-sample\\python'
running install_dist
running build
running build_py
running install_lib
byte-compiling D:
New submission from Paul Moore :
PS D:\Data\python-sample\python> pysetup run bdist_wininst
running bdist_wininst
running build
running build_py
Invalid command install
Traceback (most recent call last):
File "D:\Data\cpython\lib\packaging\command\__init__.py", line 57, in
get_
Paul Moore added the comment:
Windows 7, 32 bit.
--
___
Python tracker
<http://bugs.python.org/issue13175>
___
___
Python-bugs-list mailing list
Unsubscribe:
Paul Moore added the comment:
I suppose so, yes. But it feels symptomatic of a general lack of clean
error handling, which I think should be fixed :-(
--
___
Python tracker
<http://bugs.python.org/issue13
Paul Moore added the comment:
I found the problem - it's in packaging.util.write_record_file. The
file passed to csv.writer should be opened with newline=''.
--
___
Python tracker
<http://bugs.pyt
Paul Moore added the comment:
Here's a patch. It includes a test, but I don't expect the test will catch the
issue except on Windows...
--
keywords: +patch
Added file: http://bugs.python.org/file23416/recordfix.patch
___
Python trac
New submission from Paul Moore :
The attached patch is a first version of a bdist_simple binary distribution
format for packaging. There is a bdist_simple command to build the
distribution, and pysetup install has been updated to handle bdist_simple
format distributions (only as local files
Changes by Paul Moore :
Removed file: http://bugs.python.org/file23417/bdist_simple.patch
___
Python tracker
<http://bugs.python.org/issue13189>
___
___
Python-bugs-list m
Paul Moore added the comment:
New patch including some basic tests.
--
Added file: http://bugs.python.org/file23422/bdist_simple.patch
___
Python tracker
<http://bugs.python.org/issue13
Paul Moore added the comment:
On 17 October 2011 14:15, Éric Araujo wrote:
>> The file passed to csv.writer should be opened with newline=''.
> How will we port this to 2.x?
No idea :-( The 2.7 documentation says use the 'b' flag, but that
probably doesn'
Paul Moore added the comment:
> That’s odd. Are the pyc files in RECORD?
Yes, but not in __pycache__ where they should be.
PS D:\Data\python-sample\python> type
D:\Data\cpython\Lib\site-packages\hello-0.1.dist-info\RECORD
D:\Data\cpython\Lib\site-packages\he
Paul Moore added the comment:
> Would you be satisfied with a more helpful traceback that would point you
> immediately to missing msi? Do you prefer that bdist_msi
> catch an ImportError for _msi and print a short error message instead of a
> traceback in all its glory?
I'
Paul Moore added the comment:
I'm not getting the second error on my home PC. As the failing buildbot is
mine, I'll have a look on there to see if I can reproduce when I get the chance.
--
___
Python tracker
<http://bugs.python.o
Paul Moore added the comment:
First one - the problem is in packaging.manifest._translate_pattern, which uses
os.path.join on regex parts. That won't work on Windows where os.sep is a
backslash, as the backslash is a RE metacharacter.
Actually, the file list seems to only use '/&
Paul Moore added the comment:
Yes, working correctly now
--
___
Python tracker
<http://bugs.python.org/issue13181>
___
___
Python-bugs-list mailing list
Unsub
Paul Moore added the comment:
I see what you're saying - and looking through sysconfig.cfg, I can see how
things are expected to be laid out (and how I'd configure it if I didn't like
it :-))
But as far as I can see, there's no way in packaging to describe a module that
Changes by Paul Moore :
--
nosy: +pmoore
___
Python tracker
<http://bugs.python.org/issue10181>
___
___
Python-bugs-list mailing list
Unsubscribe:
Paul Moore added the comment:
One important point - in the "new world" where data files living
alongside code is unsupported, the bdist_msi and bdist_wininst
installers need to be updated to install data files as needed. This
may work already (I'll do some tests to see how well
Changes by Paul Moore :
--
nosy: +pmoore
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Paul Moore added the comment:
A simple rebuild and test run of that test in debug mode didn't fail...
I'll run the full test suite as a check, but that could take some time - that
buildslave isn't the fastest in the world...
--
___
Changes by Paul Moore :
--
nosy: +pmoore
___
Python tracker
<http://bugs.python.org/issue12678>
___
___
Python-bugs-list mailing list
Unsubscribe:
Paul Moore added the comment:
Certainly the 2.7 branch on my buildbot is now OK (3.x is failing for
other reasons :-()
--
status: pending -> open
___
Python tracker
<http://bugs.python.org/iss
Paul Moore added the comment:
Seems to be correctly skipping the test now - failures are because of
other issues (a load more hg builds means that the buildslave is
getting a bit tight on space...)
This change looks fine. Thanks!
--
status: pending -> o
Paul Moore added the comment:
This bug appears to be Unix-only. On Windows:
>>> from subprocess import *
>>> p1 = Popen(['cat'], stdin=PIPE, stdout=PIPE)
>>> p2 = Popen(['grep', 'a'], stdin=p1.stdout, stdout=PIPE)
>>> p1.stdin.w
Paul Moore added the comment:
Patch looks good to me. Can this be applied? As a temporary workaround I have
set my buildbot to run interactively. Once the fix is applied, I will switch
back to running as a service.
--
keywords: +buildbot
Changes by Paul Moore :
--
nosy: +gpolo
___
Python tracker
<http://bugs.python.org/issue9931>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Paul Moore added the comment:
> Perhaps somewhat orthogonal to the patch, but in terms of the original hang
> issue, does your service definition have the "interact with desktop" option
> checked? That ought to permit any normal UI processing to take place as if
&g
New submission from Paul Moore <[EMAIL PROTECTED]>:
The latest version of Mingw binutils, 2.18.50.20080109, uses a 4-part
version number which distutils does not like (StrictVersion only allows
for 3 parts).
The attached patch fixes this, simply by using LooseVersion (the version
numb
New submission from Paul Moore :
test_support.find_unused_port attempts to find an unused port to use. The
approach is fragile (as noted in the docstring) in certain cases. In
particular, it appears that Windows takes a short time to free the socket after
it is closed, meaning that when the
Changes by Paul Moore :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue8576>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Paul Moore added the comment:
OK. I've attached a patch which removes the use of get_unused_port for
test_smtplib and test_multiprocessing. It doesn't use bind_port as both cases
test classes that create their own port internally, rather I've used port 0 and
then introspected
Paul Moore added the comment:
Here's a patch for test_logging. It needed a minor tweak to logging.config -
but I can't see anywhere that this affects the documentation, so I didn't do a
doc patch. I hope that's OK.
I'll have a look at test_socket but that looks a
Paul Moore added the comment:
Might work - but the only ones that were actually failing for me were
test_multiprocessing and test_smtplib. So I'm not quite sure where/when the
error would be raised on the remaining 2 (socket & httplib). But I'll keep it
in mind.
To be honest,
Paul Moore added the comment:
One of the tests in test_socket is checking that an attempt to connect to a
port with no server running gives socket.error. For that, we need a port that's
guaranteed to have no server present.
I think that one of the tests in test_httplib check
Paul Moore added the comment:
Thanks for the suggestions, I'll see if I can implement something based on them.
--
___
Python tracker
<http://bugs.python.org/i
Paul Moore added the comment:
I believe that mailbox.py is expected to work with files opened in
binary mode. A long time ago I opened a bug on th email package
(http://bugs.python.org/issue586899) which turned out to be because
mailbox.py required binary mode files. The conclusion was that it
New submission from Paul Moore <[EMAIL PROTECTED]>:
This patch adds a new get_data function to the pkgutil module, allowing
access to data stored in the package directory. It wraps the PEP 302
loader "get_data" function, so that it works with such loaders (for
example, zipimp
Paul Moore <[EMAIL PROTECTED]> added the comment:
I'm not sure I understand. It uses pkgutil.get_loader, which returns a
wrapper for filesystem modules. You pointed me to it. It seems to work,
that's what test_getdata_filesys is testing in test_pkgutil.py.
Can you supply a tes
Paul Moore <[EMAIL PROTECTED]> added the comment:
Is that true? loader.load_module(pkg) should return sys.modules[pkg]
without reloading if it already exists. See PEP 302 "Specification part
1: The Importer Protocol":
The load_module() method has a few responsibilities tha
Changes by Paul Moore <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file9792/pkgutil.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2439>
__
Paul Moore <[EMAIL PROTECTED]> added the comment:
Nick, thanks I now see the issue. I'll work up a test to check for this
(and then correct it :-)).
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Paul Moore <[EMAIL PROTECTED]> added the comment:
But that's not a valid loader.
I'm still struggling here. I see what you're trying to get at, but I
can't see how I can write a valid loader that does this.
To test the problem you're suggesting (that the code ca
Paul Moore <[EMAIL PROTECTED]> added the comment:
It has to be a valid loader, as I see no reason to support loaders that
aren't valid. In any case, I did try incrementing a counter and it
doesn't demonstrate the problem. If you try the currently attached
patch, you should see
Paul Moore <[EMAIL PROTECTED]> added the comment:
Thanks for the update. Something's seriously screwy here. I am getting
no failures, so you can probably see why I was confused. Can you tell me
what platform, etc (anything that might be relevant) and I'll try to see
Paul Moore <[EMAIL PROTECTED]> added the comment:
By the way, for comparison, I'm running the test (under Windows) using
rt -q -v test_pkgutil from the PCBuild directory. I can't see how
test_getdata_filesys can fail, as long as you're running it from the
correct
Paul Moore <[EMAIL PROTECTED]> added the comment:
Ah, no. I see your command line. I get the same failure as you in that
case. I can see why test_getdata_filesys fails in that case, I'll fix
that. I'm confused as to why test_alreadyloaded fails there but not via
rt.bat, but ne
Paul Moore <[EMAIL PROTECTED]> added the comment:
OK, I found it. There were 2 problems, the double-loading one, and a
problem with adding my importer to sys.meta_path - if the test failed, I
wasn't removing it (so it was there for the next test, and interfering
with it).
Here'
Changes by Paul Moore <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file9799/pkgutil.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2439>
__
Paul Moore <[EMAIL PROTECTED]> added the comment:
Thanks,
Paul.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2439>
__
___
Python-bugs-list mailing list
New submission from Paul Moore :
This patch takes the existing "simplegeneric" decorator, currently an
internal implementation detail of the pkgutil module, and exposes it as
a feature of the functools module.
Documentation and tests have been added, and the pkgutil code has been
upda
Paul Moore added the comment:
Well spotted! I missed that when I checked. I will add tests and
documentation.
I agree that generic is better. I only left it as it was because the
original intent was simply to move the existing code - but that's not a
particularly good reason for keep
Paul Moore added the comment:
Here's an updated patch.
Added file: http://bugs.python.org/file12936/generic.patch
___
Python tracker
<http://bugs.python.org/i
Paul Moore added the comment:
Fair comment. As Ryan said, it's a bit of a bikeshed issue. I prefer
"generic", on the basis that I'd prefer to keep the simple name for the
simple use - something as complex as the RuleDispatch version could use
the name "dispatch"
Paul Moore added the comment:
Agreed about the compatibility. It's there from pkgutil, where to be
honest, it's even less necessary, as simplegeneric was for internal use
only, there. I'm certainly not aware of any backward compatibility
requirements for functools.
Assuming nobo
Paul Moore added the comment:
Agreed (in principle). However, in practice the subtleties of override
order must be documented (and a method of implementation must be
established!!!) Consider:
>>> class A:
... pass
...
>>> class C:
... __metaclass__ = abc.ABCMe
Paul Moore added the comment:
Very good point. Registering for the standard ABCs seems like an
important use case. Unfortunately, it seems to me that ABCs simply don't
provide that capability - is there a way, for a given class, of listing
all the ABCs it's registered under? Even if
Paul Moore added the comment:
Here's an updated patch. I've reverted to the name "simplegeneric" and
documented the limitation around ABCs (I've tried to give an explanation
why it's there, as well as a hint on now to work around the limitation -
let me know if
Paul Moore added the comment:
In principle I don't have a problem with the automatic generation of an
EXE (I assume it generates a shell script with no extension on Unix?)
but it should be done in such a way that the EXE is version-independent.
This is necessary to ensure that pure-p
Paul Moore added the comment:
> as well as potentially being able to be a script or .pyz launcher with a
> simple rename.
Would it be possible to also make the launcher work when prepended to a
zipfile? That's a really useful use-case (make a zipapp automatically runnable,
Paul Moore added the comment:
This is Windows (shell) behaviour. To avoid this, you need to add the .py
extension to the PATHEXT environment variable.
--
___
Python tracker
<https://bugs.python.org/issue47
Paul Moore added the comment:
I added the label for you.
--
___
Python tracker
<https://bugs.python.org/issue25172>
___
___
Python-bugs-list mailing list
Unsub
Paul Moore added the comment:
To clarify, I think adding the label needs core dev (or maybe triager) rights
on github, so I don't think it's something you can do yourself.
--
___
Python tracker
<https://bugs.python.o
Paul Moore added the comment:
This is normal behaviour of the Windows console command line editing. Python
simply inherits the standard console behaviour.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Pytho
New submission from Paul Moore :
The venv module with Python 3.4 on Windows doesn't install pip - even though
the --without-pip flag is not specified. This appears to be a regression since
pip is installed when using 3.7:
>C:\Utils\PythonVersions\Python-3.7.3\python.exe -m venv ve-
Paul Moore added the comment:
This appears to be somehow caused by running Python 3.7.4 from an active
virtualenv (which I'd forgotten I had active when I did the test).
Regardless, I'd have expected that the command would either correctly create a
venv containing pip, or fail to
Paul Moore added the comment:
Further update - this appears to also happen on Ubuntu (at least the version
available through the Windows Linux subsystem), so it's not a Windows-specific
issue.
--
assignee: steve.dower ->
___
Python
Paul Moore added the comment:
Sigh. Never mind, this appears to be because virtualenv uses its own hacked
copy of site.py which is missing a lot of the venv support code.
I'll report this over on virtualenv.
--
resolution: -> third party
stage: -> resolved
status: ope
Paul Moore added the comment:
Can you give an example of a script that fails? If you try to print (or
otherwise use the standard IO streams) pythonw will fail, because there are no
stdio streams for a GUI executable - and the traceback, which goes to stderr by
default, will be lost.
This
New submission from Paul Moore :
I am trying to write a meta path finder that "redirects" module loads to a
different part of the filesystem. There's not much information in the importlib
documentation, but PEP 451 says "find_spec() must return a spec with "loader&
Paul Moore added the comment:
OK, cool. That might be worth explaining somewhere in the docs (although I
don't really know where, as I'm not sure where namespace packages are
documented, either :-))
I'm not at all sure what would happen if we have meta path find
Paul Moore added the comment:
> if they return a spec they can, if they don't then they can't
What I've never really got clear in my mind is how dotted names get handled.
But that's probably just a matter of needing to experiment a bit (I don't think
it's
Paul Moore added the comment:
There's a lot of technical discussion of implementation details here, but not
much about use cases. IMO, what's more important is whether NamedTemporaryFile
is *useful* to people, and what they want to use it *for*. Working out how to
implement i
Paul Moore added the comment:
Sorry - I'm maybe making an unwarranted assumption. If simply removing "delete
on close" behaviour in the CM case is acceptable, then I'm 100% in favour of
that.
I'd assumed that it was somehow unacceptable, but you're right,
Paul Moore added the comment:
New changeset 196983563d05e32d2dcf217e955a919f9e0c25e1 by Stéphane Bidoul in
branch 'master':
bpo-43930: Update bundled pip to 21.1 and setuptools to 56.0.0 (GH-25576)
https://github.com/python/cpython/commit/196983563d05e32d2dcf217e955a91
Paul Moore added the comment:
New changeset d962b00fcffa9070acdca850753f254828caa1d7 by Stéphane Bidoul in
branch '3.9':
[3.9] bpo-43930: Update bundled pip to 21.1 and setuptools to 56.0.0 (GH-25578)
https://github.com/python/cpython/commit/d962b00fcffa9070acdca850753f25
Paul Moore added the comment:
New changeset fc82f3f8fb36f88a4e7238a463812c2916bd4db0 by Stéphane Bidoul in
branch '3.8':
[3.8] bpo-43930: Update bundled pip to 21.1 and setuptools to 56.0.0 (GH-25576)
(GH-25579)
https://github.com/python/cpyt
Paul Moore added the comment:
New changeset d92513390a1a0da781bb08c284136f4d7abea36d by Tzu-ping Chung in
branch 'master':
bpo-43312: Functions returning default and preferred sysconfig schemes
(GH-24644)
https://github.com/python/cpython/commit/d92513390a1a0da781bb08c284136f
New submission from Paul Moore :
The importlib.metadata documentation states that the PackagePath class is "a
pathlib.Path derived object". This isn't true - it's a PurePath subclass, and
in particular it does not have a resolve() method. In fact, it has an
undocu
Change by Paul Moore :
--
keywords: +patch
pull_requests: +24358
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25669
___
Python tracker
<https://bugs.python.org/issu
Paul Moore added the comment:
To be explicit, I'm +1 on breaking backward compatibility in the minor form
described by Ethan: if NamedTemporaryFile is used as a context manager, the
file is closed *on context manager exit* and *not* when the file is closed.
Breaking compatibility is al
Paul Moore added the comment:
I'd suggest also posting it on the Packaging discourse, to get feedback from
other distro maintainers.
--
___
Python tracker
<https://bugs.python.org/is
Paul Moore added the comment:
Looking at the various comments, I think we have 5 votes for deleting on CM
exit when used as a CM, and no change in behaviour otherwise (me, Zachary,
Ethan, Jason and Steve). Steve also wants O_TEMPORARY to be removed, which
doesn't seem controversial
Paul Moore added the comment:
Eryk, thank you for clarifying. I apologise - I got bogged down somewhere in
the middle of the discussion on reimplementing bits of the CRT (your posts are
so information-dense that my usual habit of skimming breaks down - that's not a
complaint, t
Paul Moore added the comment:
New changeset bf99b7151663905fd5e71efe45184dc8fffc3236 by Stéphane Bidoul in
branch 'master':
bpo-43993: Update vendored pip to 21.1.1 (GH-25761)
https://github.com/python/cpython/commit/bf99b7151663905fd5e71efe45184dc8fffc3236
--
nosy: +
Paul Moore added the comment:
New changeset af1e06c62f3958082c4b409e771f291d12479b3d by Stéphane Bidoul in
branch '3.9':
[3.9] bpo-43993: Update vendored pip to 21.1.1 (GH-25761). (GH-25782)
https://github.com/python/cpython/commit/af1e06c62f3958082c4b409e771f29
Paul Moore added the comment:
New changeset 6034c4aa58fe7257d39b53c77944393700c66396 by Stéphane Bidoul in
branch '3.8':
[3.8] bpo-43993: Update vendored pip to 21.1.1 (GH-25761). (GH-25783)
https://github.com/python/cpython/commit/6034c4aa58fe7257d39b53c7794439
1 - 100 of 677 matches
Mail list logo