[issue6173] Minor typo in socket.py

2009-06-01 Thread Pablo Torres Navarrete
New submission from Pablo Torres Navarrete : Index: socket.py === --- socket.py (revision 73134) +++ socket.py (working copy) @@ -16,7 +16,7 @@ gethostbyname() -- map a hostname to its IP number gethostbyaddr() -- map an IP

[issue6173] Minor typo in socket.py

2009-06-01 Thread Pablo Torres Navarrete
Changes by Pablo Torres Navarrete : -- versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue6173> ___ ___ Python-bugs-list mailing list Unsub

[issue1184112] Missing trailing newline with comment raises SyntaxError

2009-06-07 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Confirmed on versions 2.6.2, 3.0.1 and 3.1rc1. On the three of them, I tried this: >>> import parser >>> test = 'def foo():\n\tpass\n\n# comment' >>> parser.suite(test) Traceback (most recent call last): F

[issue1184112] Missing trailing newline with comment raises SyntaxError

2009-06-07 Thread Pablo Torres Navarrete
Changes by Pablo Torres Navarrete : -- versions: +Python 3.1 ___ Python tracker <http://bugs.python.org/issue1184112> ___ ___ Python-bugs-list mailing list Unsub

[issue5313] multiprocessing.process using os.close(sys.stdin.fileno) instead of sys.stdin.close()

2009-06-10 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Wouldn't it be more pythonic to just try sys.stdin.fileno() and catch the AtributeError too? def _bootstrap(self): try: os.close(sys.stdin.fileno()) except Atribute

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Patch attached. While I was at it, I also removed stupid whitespace and generally made the module more PEP8-compliant. -- nosy: +ptn Added file: http://bugs.python.org/file14311/patch ___ Python tracker

[issue5801] spurious empty lines in wsgiref code

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: The patch for issue #5800 solves this. -- nosy: +ptn ___ Python tracker <http://bugs.python.org/issue5801> ___ ___ Pytho

[issue6064] Add "daemon" argument to threading.Thread constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: +1, but I can't apply the patch cleanly: $ patch -p0 < threading.diff patching file Doc/library/threading.rst Hunk #1 succeeded at 198 (offset -17 lines). Hunk #2 succeeded at 211 (offset -17 lines). Hunk #3 succeeded at 230 (offset -

[issue1685] linecache .updatecache fails on utf8 encoded files

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Cannot reproduce on Ubuntu 9.04 with py3k at revision 73267: $ ./python Python 3.1rc1+ (py3k:73267, Jun 7 2009, 14:45:03) [GCC 4.3.3] on linux2 Type "help", "copyright", "credits" or "license" for more inform

[issue6064] Add "daemon" argument to threading.Thread constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Nope. Our working copies seem to be different. I'm uploading mine, which I just update to revision 73468. Please diff yours against that and against HEAD too, just in case. Hunk 2 on threading.py fails because your attributes use two le

[issue6064] Add "daemon" argument to threading.Thread constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: > I'm diffing against the 2.7 branch, I guess your comes from the 3.2? *forehead meets desktop* Patch applies cleanly and all tests pass. I used it for a while and everything seemed OK. After someone else tests, I say we g

[issue6064] Add "daemon" argument to threading.Thread constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: +1 on making it a keyword-only argument. -- ___ Python tracker <http://bugs.python.org/issue6064> ___ ___ Python-bug

[issue5800] make wsgiref.headers.Headers accept empty constructor

2009-06-17 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Added a pointer from #5801 to here. -- ___ Python tracker <http://bugs.python.org/issue5800> ___ ___ Python-bugs-list m

[issue5801] spurious empty lines in wsgiref code

2009-06-19 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: I added the patch for #5800 -- Added file: http://bugs.python.org/file14321/patch ___ Python tracker <http://bugs.python.org/issue5

[issue6372] Make all switches keyword-only

2009-06-29 Thread Pablo Torres Navarrete
New submission from Pablo Torres Navarrete : I propose that all formal parameters that really act as options/switches be made keyword-only. Examples of switches are all flags, timeouts, 'verbose' bools, maximums and minimums, etc. This stresses the difference between needed i

[issue6372] Make all switches keyword-only

2009-06-29 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: OK, bad idea it is then. Thank you for your time. -- ___ Python tracker <http://bugs.python.org/issue6372> ___ ___

[issue5801] spurious empty lines in wsgiref code

2009-06-30 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: I cleaned the rest of the module by shortening lines that are too long, removing useless blocks of empty lines and adding whitespace around operators and after commas. Nothing in the programming logic was changed. -- Added file: http

[issue5801] spurious empty lines in wsgiref code

2009-06-30 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: The patch applies to rev 73702 of the py3k branch. -- ___ Python tracker <http://bugs.python.org/issue5801> ___ ___

[issue5801] spurious empty lines in wsgiref code

2009-06-30 Thread Pablo Torres Navarrete
Pablo Torres Navarrete added the comment: Oops, forgot to add the .diff extension so web browsers don't get confused. Their contents are the same though. -- keywords: +patch Added file: http://bugs.python.org/file14411/wsgiref-patch.diff ___ P