Pablo Galindo Salgado added the comment:
I am marking this as a release blocker, giving that this is probably going to
involve a big change.
--
priority: deferred blocker -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I'm elevating this as a release blocker since this is probably going to involve
a moderately big change and we don't want people relying on the new behaviour
when we don't intend to.
--
priority: deferred blocker -&g
New submission from Pablo Galindo Salgado :
Check out this build:
https://github.com/python/cpython/pull/25584/checks?check_run_id=2437718845
Here, test_ssl fails in the macos CI target:
1 test failed:
test_ssl
20 tests skipped:
test_devpoll test_epoll test_gdb test_idle test_ioctl
Pablo Galindo Salgado added the comment:
> Pablo, I've made a patch for most of these (I've left out Christian's
> modules). I've only added a couple of tests for now. Do you want all in one
> PR?
Yes, please. The second most important part here is also add
Pablo Galindo Salgado added the comment:
New changeset 284c52da092438522949d6f96d8c1f9ff37f9f00 by Dennis Sweeney in
branch 'master':
bpo-38530: Require 50% similarity in NameError and AttributeError suggestions
(GH-25584)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
If we could include column offsets from the AST nodes for every bytecode
instructions we could leverage these to offer much better tracebacks and a lot
more information to debuggers and similar tools. For instance, in an expression
such as:
z
Change by Pablo Galindo Salgado :
--
nosy: +nedbat, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue43950>
___
___
Python-bugs-list mailin
Pablo Galindo Salgado added the comment:
I'm going to prepare a PEP since the discussion regarding if the two integers
per bytecode are worth enough is going to be eternal.
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
Thanks, Larry for pinging me!
What compiler / gdb version are you using?
I tried to reproduce but I don't see any failure:
master on master [$] pyenv 3.9.1 took 9s
❯ ./python -m sysconfig | grep CFLAGS
BASECFLAGS = "-Wno-unu
Pablo Galindo Salgado added the comment:
Can you try to do this:
% make distclean
% export CFLAGS='-O0 -g3'
% ./configure
% make -j
% ./python -m test test_gdb -m test_wrapper_call -v
My guess is that the DWARF generated is not sufficient for whatever reason
(hence the -g3) in m
Pablo Galindo Salgado added the comment:
I will try to reproduce this in other systems this afternoon. I trust that this
fails, but we must know exactly what triggers this first.
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Yup, but I still think is worth the cost, giving that debugging improvements
are usually extremely popular among users.
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> Pablo, there seems to be some instability in the tests.
Apart from the typical test_asyncio random timeouts I don't see anything on the
buildbots or the CI. What are those failing test? Maybe I can try to reproduce
on
Change by Pablo Galindo Salgado :
--
nosy: -pablogsal
___
Python tracker
<https://bugs.python.org/issue43955>
___
___
Python-bugs-list mailing list
Unsubscribe:
Pablo Galindo Salgado added the comment:
As I mentioned here:
https://bugs.python.org/msg390213
the dump needs to be generated in a docker container using the same compiler
version that is used in the CI
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
You are using Fedora, which is not the same docker container and likely the
same compiler version that is used to check the dump
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> We don't have immutability tests for static types then why heap types?
Because all static types are immutable, and some have been converted to heap
types changing the contract, therefore is a regression and therefore we need
regression t
Pablo Galindo Salgado added the comment:
> Immutability of the type is mainly an implementation detail
I kindly disagree and based on the title of this issue I think more people have
a similar opinion.
--
___
Python tracker
<
Pablo Galindo Salgado added the comment:
In any case, that's my personal opinion of course.
What we should do is decide collectively if immutability is defined behaviour.
If we decide that it is, we need regression tests. If we define that as "nice
to have" but ultimately
New submission from Pablo Galindo Salgado :
See for example:
https://buildbot.python.org/all/#/builders/511/builds/10/steps/4/logs/stdio
test_idle leaked [684, 684, 684] references, sum=2052
test_idle leaked [282, 282, 282] memory blocks, sum=846
--
assignee: terry.reedy
components
Pablo Galindo Salgado added the comment:
Marking this as a release blocker
--
___
Python tracker
<https://bugs.python.org/issue43981>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
I will try to investigate today or tomorrow but notice that is very possible
that the leak is somewhere else in the interpreter and is just showing in the
IDLE tests.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
Thanks Mark for the quick fix!
Can someone confirm if the pytest issue is fixed?
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Unfortunately commit 2f2b69855d6524e15d12c15ddc0adce629e7de84 has broken the
buildbots:
==
FAIL: test_annotations_are_created_correctly (test.test_module.ModuleTests
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue43901>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
I think that test_annotations_are_created_correctly should use the
import_helper.import_fresh_module helper
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Oh, actually is workse because commenting out the test shows refleaks:
𓋹 ./python.exe -m test test_module -R :
0:00:00 load avg: 5.03 Run tests sequentially
0:00:00 load avg: 5.03 [1/1] test_module
beginning 9 repetitions
123456789
Pablo Galindo Salgado added the comment:
>> Why would it fail on Windows?
It fails on all refleak buildbots. To reproduce:
% ./configure --with-pydebug -C && make -j -s
% ./python.exe -m test test_module -R :
--
___
Python t
Change by Pablo Galindo Salgado :
--
pull_requests: +2
pull_request: https://github.com/python/cpython/pull/25754
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> Eek! I swear I did a refleak check and got a clean bill of health. Again,
> sorry about this!
No problem at all! I'm sure we can fix this on time :)
Opened https://github.com/python/cpython/pull/25754 for t
Pablo Galindo Salgado added the comment:
I made a fix for everything in https://github.com/python/cpython/pull/25754.
Could you review it?
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Taking into account the last time the builder built successully it must have
happened in some of these commits:
b38b2fa021 Document importlib.metadata.PackagePath.locate method (GH-25669)
4a85718212 bpo-43970: Optimize Path.cwd() in pathlib by not
Pablo Galindo Salgado added the comment:
New changeset e374a40afa09be728b01653a06c9febfad9c9c50 by Pablo Galindo in
branch 'master':
bpo-43901: Fix refleaks in test_module (GH-25754)
https://github.com/python/cpython/commit/e374a40afa09be728b01653a06c9fe
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
I checked and reverting commit 15d3861856 fixes the leaks.
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Unfortunately given how close are we to the beta release and per our buildbot
policy
(https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404)
I may need to revert commit 15d3861856 to avoid masking other issues
Pablo Galindo Salgado added the comment:
> So I'm still puzzled about why that test worked on POSIX and failed on Windows
I was able to reproduce it in my MacOS machine (maybe also it reproduced on
Linux). The problem is that when you run with -R, the test runs several times
and th
Change by Pablo Galindo Salgado :
--
pull_requests: +24448
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25758
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I am decreasing the priority of this to deferred blocker since
https://bugs.python.org/issue43916 is mostly fixed
--
priority: release blocker -> deferred blocker
___
Python tracker
<
Pablo Galindo Salgado added the comment:
New changeset 6689e45dfee75d756c540ff0946ebf0ae8847f43 by Pablo Galindo in
branch 'master':
bpo-43981: Fix reference leaks in test_squeezer (GH-25758)
https://github.com/python/cpython/commit/6689e45dfee75d756c540ff0946ebf
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Refleaks fixed by 6689e45dfee75d756c540ff0946ebf0ae8847f43
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
New changeset e467ec476f624323b8638cf100d1bfbf1d6a21c6 by Erlend Egeberg
Aasland in branch 'master':
bpo-43995: Fix reference leak in test_grammar (GH-25764)
https://github.com/python/cpython/commit/e467ec476f624323b8638cf100d1bf
Pablo Galindo Salgado added the comment:
Thanks for the quick fix Erlend!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
> Specific examples of current messages and proposed improvements would help
> focus discussion.
Yeah, I am proposing going from:
>>> x['aa']['bb']['cc']['dd'].sddfsdf.sdfsdf
T
Pablo Galindo Salgado added the comment:
Basically, to highlight in all exceptions the range in the displayed line where
the error ocurred. For instance:
>>> foo(a, b/z+2, c, 132432 /x, d /y)
^
Traceback (most recent call last):
File "
Pablo Galindo Salgado added the comment:
Hi Dennis, this is a fantastic investigation!
I think I really like GCC approach here. We may want to invest into porting
some of their ideas into our solution.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
> If one of the admins could make that post into a wiki post, it would be open
> for editing, making it easier to fill the holes in the lists.
Not sure what do you have in mind for the wiki, but the easiest is to open some
GitHub issue somewh
Pablo Galindo Salgado added the comment:
> * _ast.AST: use {Py_tp_new, PyType_GenericNew} and {Py_tp_init,
> ast_type_init} slots. What happens if tp_new is called without calling
> tp_init?
I think this is fine since ast_type_init doesn't initialize any C fields and
on
Pablo Galindo Salgado added the comment:
Something is wrong after commit 3bb09947ec4837de75532e21dd4bd25db0a1f1b7.
When building Python I am getting:
*** WARNING: renaming "_curses" since importing it failed:
/home/pablogsal/github/python/master/build/lib.linux-x86_64-3.
Pablo Galindo Salgado added the comment:
The problem is that the curses module is using a function that requires to be
built in the core:
#ifdef Py_BUILD_CORE
extern int _PyStructSequence_InitType(
PyTypeObject *type,
PyStructSequence_Desc *desc,
unsigned long tp_flags);
#endif
Change by Pablo Galindo Salgado :
--
pull_requests: +24461
pull_request: https://github.com/python/cpython/pull/25768
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
The build errors were in the CI, but because Python doesn't complain if it
cannot build a module, then we never catched this. I have opened
https://github.com/python/cpython/pull/25768 to fix it to unblock the release,
since the curses modu
Pablo Galindo Salgado added the comment:
> So would marking the 0 denominator when there is more than one candidate: "e
> = a/b + c/d".
No, it will mark the offset of the bytecode that was getting executed when the
exception was raised. Is just a way to mark what is raisin
Pablo Galindo Salgado added the comment:
New changeset 558df9010915c8fe94f4d7f842e7c5aabbb06b14 by Pablo Galindo in
branch 'master':
bpo-43916: Export the _PyStructSequence_InitType to fix build errors in the
curses module (GH-25768)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 1.0 -> 2.0
pull_requests: +24463
pull_request: https://github.com/python/cpython/pull/25770
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 9a42d5069a4c2a531076abfb198d2be26b57216c by Pablo Galindo in
branch 'master':
bpo-43957: Add a missins space to the new format enum warning (#25770)
https://github.com/python/cpython/commit/9a42d5069a4c2a531076abfb198d2b
Pablo Galindo Salgado added the comment:
> See https://meta.discourse.org/t/what-is-a-wiki-post/30801
Gotcha, will try to do that as soon as possible
--
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
test test_nntplib crashed -- Traceback (most recent call last):
File
"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/libregrtest/runtest.py",
line 282, in _runtest_inner
refleak = _runtest_inner2(ns,
Pablo Galindo Salgado added the comment:
> Should be fixed by a5669b3c627e64c9196d9bb58b733eb723d34e99
Does this mean that all the RHEL7 buildbots are not testing the SSL module?
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I have transformed
https://discuss.python.org/t/list-of-built-in-types-converted-to-heap-types/8403
into a wiki. Tell me if you need some alterations of something is missing.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
Ethan can we close this issue?
--
___
Python tracker
<https://bugs.python.org/issue43957>
___
___
Python-bugs-list m
Pablo Galindo Salgado added the comment:
If would be great if we can have these buildbots using a locally compiled
version of OpenSSL.
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Since commit
https://github.com/python/cpython/commit/5fb06edbbb769561e245d0fe13002bab50e2ae60
was merged there are multiple timeouts in several buildbots. Unfortunately if
this is not fixed by the time I need to do the beta release I may need to
Change by Pablo Galindo Salgado :
--
pull_requests: +24531
pull_request: https://github.com/python/cpython/pull/25848
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
I have created https://github.com/python/cpython/pull/25848 for the revert, in
case this is not fixed in the next hours or so.
Given the nature of PR 17975, this should have tested with the buildbots as the
release team asked in:
https
Pablo Galindo Salgado added the comment:
Specifically this part of both messages:
>> If your change involves some platform-specific behaviour or has a
>> non-trivial amount of C code, make sure you run the buildbots
>> in your Pull Request by using the "test-with-buil
Pablo Galindo Salgado added the comment:
Batuhan, can this issue be closed?
--
___
Python tracker
<https://bugs.python.org/issue42725>
___
___
Python-bugs-list m
Change by Pablo Galindo Salgado :
--
pull_requests: +24538
pull_request: https://github.com/python/cpython/pull/25854
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
New changeset c2931d31f8ba7cf10044de276018c713ffc73592 by Pablo Galindo in
branch 'master':
bpo-43916: Move the _PyStructSequence_InitType function to the internal API
(GH-25854)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +24539
pull_request: https://github.com/python/cpython/pull/25855
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
New changeset 39494285e15dc2d291ec13de5045b930eaf0a3db by Pablo Galindo in
branch 'master':
bpo-43754: Fix compiler warning in Python/compile.c (GH-25855)
https://github.com/python/cpython/commit/39494285e15dc2d291ec13de5045b9
Pablo Galindo Salgado added the comment:
New changeset 7719953b30430b351ba0f153c2b51b16cc68ee36 by Pablo Galindo in
branch 'master':
bpo-44011: Revert "New asyncio ssl implementation (GH-17975)" (GH-25848)
https://github.com/python/cpython/commit/7719953b30430b351ba0
Pablo Galindo Salgado added the comment:
Unfortunately I have reverted 5fb06edbbb769561e245d0fe13002bab50e2ae60 commit
to unblock the beta release :(
I know that nobody wants this but my responsibilities as a release manager is
to safeguard the stability of the release and we are too close
Pablo Galindo Salgado added the comment:
New changeset 80a2a4ed7d090fff2584302f07315d567109bca9 by Dennis Sweeney in
branch 'master':
bpo-38530: Refactor and improve AttributeError suggestions (GH-25776)
https://github.com/python/cpython/commit/80a2a4ed7d090fff2584302f07315d
Change by Pablo Galindo Salgado :
--
pull_requests: +24547
pull_request: https://github.com/python/cpython/pull/25866
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> Pablo, I checked an AttributeError instance and the missing phrase is not
> present
This cannot be included in the AttributeError because of performance reasons.
These errors will be thrown naturally all over the place without this meaning
Pablo Galindo Salgado added the comment:
I don't feel comfortable adding a public API to get the message either in the
traceback or the exception, at least for the time being.
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
> Is this error going to happen for everyone testing with 3.10b1?
3.10.0b1 includes both of these PRs so people testing the beta should not get
affected. That's why I marked this as release
Pablo Galindo Salgado added the comment:
> The pytest failure still happens with 3.10.0b1 and pytest 6.2.3.
What I am missing? 3.10.0b1 includes the fixes for this issue, no? Is it
because the fixes still require some changes in the source? If that's the case,
we should mention i
New submission from Pablo Galindo Salgado :
I have installed autoconf-archive and autoconf 2.69 and tried to regenerate the
configure script and it fails:
$ ls /share/aclocal/ax_* | wc -l
572
$ autoconf --version
autoconf (GNU Autoconf) 2.69
Copyright (C) 2012 Free Software Foundation, Inc
Pablo Galindo Salgado added the comment:
Reverting
https://github.com/python/cpython/commit/5d6e8c1c1a5f667cdce99cb3c563ac922198678d
works
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Also:
grep -r AX_C_FLOAT_WORDS_BIGENDIAN /share/aclocal/
ax_c_float_words_bigendian.m4:# AX_C_FLOAT_WORDS_BIGENDIAN([ACTION-IF-TRUE],
[ACTION-IF-FALSE], [ACTION-IF-UNKNOWN])
ax_c_float_words_bigendian.m4:AC_DEFUN([AX_C_FLOAT_WORDS_BIGENDIAN
Pablo Galindo Salgado added the comment:
Yep, I am also setting ACLOCAL_PATH to make sure it picks it up.
To be honest I think this has to be something about the weird setup in this
machine but I think more people may run into this so it may be worth to include
this in the News entry and
Pablo Galindo Salgado added the comment:
Those are intesting options, I will think about this. I am still afraid of
adding more APIs in this area as having arbitrary Python getting call in the
middle of handling the exceptions it can be quite tricky: think that we are
handling an exception
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue44043>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Given that this happens in hashlib, could this be related to the OpenSSL
version?
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
Thanks for the suggestion! Unfortunately I am not very convinced since we
already have the self imposed limitation for the maximum size of the string
(this is to limit the execution time and memory) so there is no point of
allowing bigger buffers
Pablo Galindo Salgado added the comment:
Christian, could you look into that patch?
--
___
Python tracker
<https://bugs.python.org/issue44043>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
> Should these references to "master" be changed to "main"?
We could, but won't change anything IIUC as the string that triggers the build
on main is the one placed in the files on the "main" branch. The importan
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 4.0 -> 5.0
pull_requests: +24647
pull_request: https://github.com/python/cpython/pull/25994
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 03acfc50ac0be8b49847b94dee93e21b1efa0e76 by Pablo Galindo in
branch '3.10':
bpo-32924: Fix the Show Source url in the documentation (GH-25994)
https://github.com/python/cpython/commit/03acfc50ac0be8b49847b94dee93e2
Change by Pablo Galindo Salgado :
--
pull_requests: +24649
pull_request: https://github.com/python/cpython/pull/25996
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
I created an issue on the release repo.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Seems to work like a charm:
❯ docker run -v`pwd`:/src tiran/cpython_autoconf
Rebuilding configure script
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force
autoreconf: configu
Pablo Galindo Salgado added the comment:
Unfortunately this commit has introduced some reference leaks, see:
https://buildbot.python.org/all/#/builders/684/builds/5
Could someone take a look?
--
nosy: +pablogsal
resolution: fixed ->
status: closed ->
Pablo Galindo Salgado added the comment:
This seems to have broken the address sanitizer buildbot:
https://buildbot.python.org/all/#/builders/582/builds/116/steps/5/logs/stdio
Example error:
==28597==ERROR: AddressSanitizer
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue40222>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
To reproduce with a modern gcc:
% export ASAN_OPTIONS=detect_leaks=0:allocator_may_return_null=1:handle_segv=0
% ./configure --with-address-sanitizer --without-pymalloc
% make -j -s
% ./python -m test test_statistics
801 - 900 of 4560 matches
Mail list logo