Pablo Galindo Salgado added the comment:
New changeset b86ed8e3bb41ede77eeab4a8bb4e2b91a8065283 by Pablo Galindo in
branch 'master':
bpo-43797: Improve syntax error for invalid comparisons (#25317)
https://github.com/python/cpython/commit/b86ed8e3bb41ede77eeab4a8bb4e2b
Pablo Galindo Salgado added the comment:
This is currently being proposed as part of
https://www.python.org/dev/peps/pep-0646.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
I am closing this as duplicate of https://www.python.org/dev/peps/pep-0646, but
feel free to reopen if you think there is some missing considerations.
--
resolution: -> duplicate
stage: -> resolved
status: open -&g
Pablo Galindo Salgado added the comment:
Ah, it was not clear from the issue that pytest was constructing nodes by hand.
It makes sense now. Thanks!
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Background on why I reactivated it:
I every single alpha release I had to fix actual documentation errors (no false
positives) like the one fixed here:
https://github.com/python/cpython/commit/20ac34772aa9805ccbf082e700f2b033291ff5d2
I don't
Change by Pablo Galindo Salgado :
--
pull_requests: +24107
pull_request: https://github.com/python/cpython/pull/25375
___
Python tracker
<https://bugs.python.org/issue43
New submission from Pablo Galindo Salgado :
Given that is quite common to forgot a comma in containers, function calls,
...etc and that the current error is:
>>> [a, b, c d]
File "", line 1
[a, b, c d]
^
SyntaxError: invalid syntax
We could improve
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +24109
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25377
___
Python tracker
<https://bugs.python.org/issu
New submission from Pablo Galindo Salgado :
Currently the error for invalid dict literals is generic:
>>> {1:2, 3:}
File "", line 1
{1:2, 3:}
^
SyntaxError: invalid syntax
>>> {1:2, 3}
File "", line 1
{1:2, 3}
^
SyntaxErr
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +24110
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25378
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I don't get any error executing the t33a.py script
--
___
Python tracker
<https://bugs.python.org/issue14811>
___
___
Pablo Galindo Salgado added the comment:
Seems that the regeneration script is not detecting correctly that needs
Python3.8+ for regenerating pegen. Check for instance:
https://buildbot.python.org/all/#/builders/596/builds/2/steps/2/logs/stdio
--
resolution: fixed ->
status: clo
Change by Pablo Galindo Salgado :
--
pull_requests: +24123
pull_request: https://github.com/python/cpython/pull/25390
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> no longer fails in Windows.
So that means we can close the issue, no?
--
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
New changeset 30ed93bfec5dfa7ee05982e2df8fd810f3f49305 by Pablo Galindo in
branch 'master':
bpo-43797: Handle correctly invalid assignments inside function calls and
generators (GH-25390)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
This is know behaviour unfortunately and cannot be changed because of backwards
compatibility.
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Ok, then we need to revert by latest 2 PRs and add a new label or something to
skip
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
We tried changing this IIRC and it broke code in the stdlib (now reformatted)
so it will break code in the wild. I am not sure the gains are worth it.
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
Precisely because examples like that changing this is a breaking change. Don't
get me wrong: I would love to change it, but I don't know if is worth the risk
--
___
Python tracker
<https://bu
Pablo Galindo Salgado added the comment:
One thing we could consider as Serhiy proposed on the mailing list is to emit a
Syntax Warning. The ambiguous cases are specially scary so I think that makes
sense
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
> To skip ABI tests? I proposed to ignore ABI changes if they can be ignored
> safely. But I don't know right now which changes can be ignored or not.
As the situation stands we need to choose on keeping my changes to ignore _Py
function
Pablo Galindo Salgado added the comment:
> $ objdump -T /lib64/libpython3.10.so.1.0|grep
> _Py_M__importlib_bootstrap_external
# empty output
This was happening on 3.8 Victor:
root@d9c5942e274b:/src# objdump -T libpython3.8.so | grep
_Py_M__importlib_bootstrap_external
0033
Pablo Galindo Salgado added the comment:
I am going to revert the 3.9 PR as 3.9+ is hiding symbols by default.
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
pull_requests: +24127
pull_request: https://github.com/python/cpython/pull/25394
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Ok, let's continue the discussion on https://bugs.python.org/issue38755
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
New changeset 37494b441aced0362d7edd2956ab3ea7801e60c8 by Pablo Galindo in
branch 'master':
bpo-38530: Offer suggestions on AttributeError (#16856)
https://github.com/python/cpython/commit/37494b441aced0362d7edd2956ab3e
Change by Pablo Galindo Salgado :
--
title: Offer suggestions on AttributeError -> Offer suggestions on
AttributeError and NameError
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +24129
pull_request: https://github.com/python/cpython/pull/25397
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 5bf8bf2267cd109970b2d946d43b2e9f71379ba2 by Pablo Galindo in
branch 'master':
bpo-38530: Offer suggestions on NameError (GH-25397)
https://github.com/python/cpython/commit/5bf8bf2267cd109970b2d946d43b2e
Change by Pablo Galindo Salgado :
--
pull_requests: +24141
pull_request: https://github.com/python/cpython/pull/25408
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset e07f4ab26aaf08f90ebd9e6004af14fd6ef39351 by Pablo Galindo in
branch 'master':
bpo-38530: Make sure that failing to generate suggestions on failure will not
propagate exceptions (GH-25408)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +24144
pull_request: https://github.com/python/cpython/pull/25412
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 3fc65b97d09fd29272fdf60d2e567bfb070da824 by Pablo Galindo in
branch 'master':
bpo-38530: Optimize the calculation of string sizes when offering suggestions
(GH-25412)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset da7435017430671f86075449ff7bde96fd7700a5 by Pablo Galindo in
branch 'master':
bpo-43823: Improve syntax errors for invalid dictionary literals (GH-25378)
https://github.com/python/cpython/commit/da7435017430671f86075449ff7bde
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset b280248be8e648feb82f3f3ed0050e50b238df7b by Pablo Galindo in
branch 'master':
bpo-43822: Improve syntax errors for missing commas (GH-25377)
https://github.com/python/cpython/commit/b280248be8e648feb82f3f3ed0050e
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +24160
pull_request: https://github.com/python/cpython/pull/25427
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
This is probably not worth the complexity, so I am closing it
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset b5b98bd8f8c72a9068cf149dbc162c8c95d30057 by Pablo Galindo in
branch 'master':
bpo-43823: Fix location of one of the errors for invalid dictionary literals
(GH-25427)
https://github.com/python/cpyt
New submission from Pablo Galindo Salgado :
The current indentation error is quite simplistic and it does not include the
context of the statement that was associated with the indented block and where
it was:
>>> def foo():
... if lel:
... x = 2
File ""
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +24162
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25431
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
I agree with all you said, but I am against forcing the release management team
to absorb the responsibility of fixing all the errors that the CI didn't catch,
real or not. Releasing is already a multi-hour process and having many docs
error
Pablo Galindo Salgado added the comment:
> Why did you catch them in the release process, and not in the regular Python
> development workflow?
Because our release tools run suspicious.py and it fails and then we need to
manually inspect every single failure and fix it as almost all
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
pull_requests: +24173
pull_request: https://github.com/python/cpython/pull/25443
___
Python tracker
<https://bugs.python.org/issue38
Change by Pablo Galindo Salgado :
--
pull_requests: +24174
pull_request: https://github.com/python/cpython/pull/25444
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 3b82cae774638ecf2baaee8fe2cac8fedafb2ca7 by Pablo Galindo in
branch 'master':
bpo-38530: Properly extend UnboundLocalError from NameError (GH-25444)
https://github.com/python/cpython/commit/3b82cae774638ecf2baaee8fe2cac8
Pablo Galindo Salgado added the comment:
New changeset 0ad81d4db2f409d72f469d0b74ab597be772a68e by Pablo Galindo in
branch 'master':
bpo-38530: Match exactly AttributeError and NameError when offering suggestions
(GH-25443)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
pull_requests: +24187
pull_request: https://github.com/python/cpython/pull/25460
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 3ab4bea5a3ac28820781cf62a768c65370c9054c by Pablo Galindo in
branch 'master':
bpo-38530: Include builtins in NameError suggestions (GH-25460)
https://github.com/python/cpython/commit/3ab4bea5a3ac28820781cf62a768c6
Change by Pablo Galindo Salgado :
--
pull_requests: +24188
pull_request: https://github.com/python/cpython/pull/25462
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 0b1c169c4a009e1094fe5df938d2367e63ebeea0 by Pablo Galindo in
branch 'master':
bpo-38530: Cover more error paths in error suggestion functions (GH-25462)
https://github.com/python/cpython/commit/0b1c169c4a009e1094fe5df938d236
Pablo Galindo Salgado added the comment:
It definitely shouldn't be related to any of these, all are unrelated code
paths.
--
___
Python tracker
<https://bugs.python.org/is
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 2.0 -> 3.0
pull_requests: +24199
pull_request: https://github.com/python/cpython/pull/25473
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +24200
pull_request: https://github.com/python/cpython/pull/25475
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
pull_requests: +24201
pull_request: https://github.com/python/cpython/pull/25473
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
New changeset 7a041162468b83f6cad667b78ed5c786286aed2b by Pablo Galindo in
branch 'master':
bpo-25460: Surround suggestions by quotes (GH-25473)
https://github.com/python/cpython/commit/7a041162468b83f6cad667b78ed5c7
Pablo Galindo Salgado added the comment:
Given that the AST is a public interface, I would advise to implement this
before beta freeze of 3.10 to avoid making this a breaking change in the future
for linters and the like
--
nosy: +pablogsal
Pablo Galindo Salgado added the comment:
Also, I would like some more extensive argument or why not having context
dependent nodes justifies the extra maintainance cost (I'm not against that of
course, and I am sympathetic, but I think this needs some more extensive
coverage or why w
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 13.0 -> 14.0
pull_requests: +24214
pull_request: https://github.com/python/cpython/pull/25490
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
resolution: fixed -> postponed
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue38605>
___
___
Pablo Galindo Salgado added the comment:
Ee, apparently this issue in the buildbot repo may be related:
https://github.com/buildbot/buildbot/issues/4078
Could you investigate if we can use this on our PSF server?
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
I'm going to try it our on the server but apparently there are some problems:
https://github.com/buildbot/buildbot/issues/5991
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
New changeset b0544ba77cf86074fb1adde00558c67ca75eeea1 by Pablo Galindo in
branch 'master':
bpo-38605: Revert making 'from __future__ import annotations' the default
(GH-25490)
https://github.com/p
Pablo Galindo Salgado added the comment:
New changeset 56c95dfe271b1242bdc8163d4677e311552c00cb by Pablo Galindo in
branch 'master':
bpo-43859: Improve the error message for IndentationError exceptions (GH-25431)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Can someone confirm if they still have this problem on the buildbot server?
--
___
Python tracker
<https://bugs.python.org/issue41
Pablo Galindo Salgado added the comment:
Commit a02cb474f9c097c83cd444a47e9fb5f99b4aaf45 fails to build in the refleak
buildbots:
https://buildbot.python.org/all/#/builders/75/builds/2/steps/5/logs/stdio
Example failure:
❯ ./python -m test test_enum -R :
0:00:00 load avg: 1.81 Run tests
Change by Pablo Galindo Salgado :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue38659>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Can someone take a look?
As per the buildbot policy
(https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404)
we may need to revert it if is not fixed in 24 because of the risk of masking
errors
Change by Pablo Galindo Salgado :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue43914>
___
___
Python-bugs-list mailing list
Unsub
New submission from Pablo Galindo Salgado :
To improve the user experience understanding what part of the error messages
associated to SyntaxErrors are wrong, we can highlight the whole error range
and not only place the caret at the first character. In this way:
>>> foo(x, z for z
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +24245
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25525
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +lys.nikolaou
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue43914>
___
___
Python-
Change by Pablo Galindo Salgado :
--
components: +Parser
___
Python tracker
<https://bugs.python.org/issue43914>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Thanks Ammar for the fix. Unfortunately there is still some failures related to
this on test_socker:
==
ERROR: test_msgflag_enum (test.test_socket.GeneralModuleTests
Pablo Galindo Salgado added the comment:
> I'm not really sure whether we should continue following this old tradition
> of int? end_* attributes for new sum types like pattern, considering that it
> was done for supporting the creation of old nodes 3.8< without any
New submission from Pablo Galindo Salgado :
I'm creating this issue and marking it as a deferred blocker to make sure we
don't forget to check this (adding tests) before the release.
Check this message from Serhiy regarding heap typed concerns:
https://bugs.python.org
Pablo Galindo Salgado added the comment:
Serhiy's comment for reference:
Static type with tp_new = NULL does not have public constructor, but heap type
inherits constructor from base class. As result, it allows to create instances
without proper initialization, that can lead to cras
New submission from Pablo Galindo Salgado :
https://buildbot.python.org/all/#/builders/405/builds/9
Extract from the logs:
The Buildbot has detected a new failure on builder AMD64 Windows8.1 Non-Debug
3.x while building python/cpython.
Full details are available at:
https
Pablo Galindo Salgado added the comment:
Gentle ping
--
___
Python tracker
<https://bugs.python.org/issue38659>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
Commenting out the enum tests reveals that test_socket has additional problems:
𓋹 ./python.exe -m test test_socket -R 3:3
0:00:00 load avg: 2.32 Run tests sequentially
0:00:00 load avg: 2.32 [1/1] test_socket
beginning 6 repetitions
123456
/Users
Pablo Galindo Salgado added the comment:
New changeset a77aac4fca9723b8fd52a832f3e9df13beb25113 by Pablo Galindo in
branch 'master':
bpo-43914: Highlight invalid ranges in SyntaxErrors (#25525)
https://github.com/python/cpython/commit/a77aac4fca9723b8fd52a832f3e9df
Change by Pablo Galindo Salgado :
--
pull_requests: +24279
pull_request: https://github.com/python/cpython/pull/25560
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
Unfortunately, I am being forced to revert commit
a02cb474f9c097c83cd444a47e9fb5f99b4aaf45 due to have it failing of all refleak
buildbots for more than two days.
--
___
Python tracker
<ht
Change by Pablo Galindo Salgado :
--
priority: normal -> deferred blocker
___
Python tracker
<https://bugs.python.org/issue43921>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Thanks a lot Ethan. I will wait then for the investigation.
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
> I just thought having a whole “expr-without-walrus-or-yield” subgrammar
> would be tedious.
Yeah I have experimented with something similar in the past and this becomes
out of hand super quickly and leafs to a lot of duplication.
Similarly,
Change by Pablo Galindo Salgado :
--
assignee: -> Mark.Shannon
___
Python tracker
<https://bugs.python.org/issue43933>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Marking as release blocker since is breaking pytest
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
Thanks for the bisection, Anthony
--
___
Python tracker
<https://bugs.python.org/issue43933>
___
___
Python-bugs-list m
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
Seems that the buildbots are going back to green so I will close the revert PR.
THanks a lot, Ethan for the fix and the investigation!
--
___
Python tracker
<https://bugs.python.org/issue38
Pablo Galindo Salgado added the comment:
I also opened https://bugs.python.org/issue43916 to track some points raised by
Serhiy
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
Serhiy, do you think this should be a release blocker for the beta?
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
> Is there any way we can fix this in Objects/typeobject.c, or do we actually
> have to patch every single type manually?
That would be probably a bad idea since typeobject.c is supposed to be generic.
We would be inverting the responsi
Pablo Galindo Salgado added the comment:
> it fails only very rarely.
Unfortunately, in https://github.com/python/cpython/pull/25584 it has failed 3
times in a row. That's why I decided to open the issue.
Let me re-run again.
--
__
701 - 800 of 4560 matches
Mail list logo
