[issue43572] "Too many open files" on macOS buildbot

Pablo Galindo Salgado added the comment: >> I don't see that error message - where are you seeing it? You need to search for it in the full log: stderr: --- Traceback (most recent call last): File "/Users/buildbot/buildarea/3.x.billenstein-macos/build/Lib/test/test_i

[issue43591] Parser aborts on incomplete/incorrect unicode literals in interactive mode

Change by Pablo Galindo Salgado : -- pull_requests: +23732 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24973 ___ Python tracker <https://bugs.python.org/issu

[issue43591] Parser aborts on incomplete/incorrect unicode literals in interactive mode

Pablo Galindo Salgado added the comment: Thanks for the report and the patch Erlend!. I have transformed it into a PR with attribution in PR 24973 -- ___ Python tracker <https://bugs.python.org/issue43

[issue43591] Parser aborts on incomplete/incorrect unicode literals in interactive mode

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43591] Parser aborts on incomplete/incorrect unicode literals in interactive mode

Pablo Galindo Salgado added the comment: New changeset 123ff266cda9ad279106f20dca06ba114f6a9b8a by Pablo Galindo in branch 'master': bpo-43591: Fix error location in interactive mode for errors at the end of the line (GH-24973) https://github.com/python/cpyt

[issue43555] Location of SyntaxError with new parser missing (after continuation character)

Pablo Galindo Salgado added the comment: New changeset 96eeff516204b7cc751103fa33dcc665e387846e by Pablo Galindo in branch 'master': bpo-43555: Report the column offset for invalid line continuation character (GH-24939) https://github.com/python/cpyt

[issue43555] Location of SyntaxError with new parser missing (after continuation character)

Pablo Galindo Salgado added the comment: New changeset 994a519915bff4901abaa7476e2b91682dea619a by Miss Islington (bot) in branch '3.9': bpo-43555: Report the column offset for invalid line continuation character (GH-24939) (#24975) https://github.com/python/cpyt

[issue43555] Location of SyntaxError with new parser missing (after continuation character)

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue31861] add aiter() and anext() functions

Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 12.0 -> 13.0 pull_requests: +23762 pull_request: https://github.com/python/cpython/pull/25004 ___ Python tracker <https://bugs.python.org/issu

[issue31861] add aiter() and anext() functions

Change by Pablo Galindo Salgado : -- pull_requests: +23763 pull_request: https://github.com/python/cpython/pull/25005 ___ Python tracker <https://bugs.python.org/issue31

[issue31861] add aiter() and anext() functions

Pablo Galindo Salgado added the comment: New changeset d9692027f41ee7600fe401c066617ebfc8bac930 by Pablo Galindo in branch 'master': bpo-31861: Complete the C-API docs for PyObject_GetAiter and PyAiter_Check (GH-25004) https://github.com/python/cpyt

[issue43452] Microoptimize PyType_Lookup for cache hits

Pablo Galindo Salgado added the comment: New changeset a054f6b2b1d9f75edfb5ec2247bbf60f07491977 by Pablo Galindo in branch 'master': bpo-43452: Document the PyType_Lookup optimizations in the What's New for 3.10 (GH-24949) https://github.com/python

[issue31861] add aiter() and anext() functions

Pablo Galindo Salgado added the comment: New changeset 919d42d477093154a30b55d9d79f023dbbe5614a by Pablo Galindo in branch 'master': bpo-31861: Fix possible crash in PyAnextAwaitable_New (GH-25005) https://github.com/python/cpython/commit/919d42d477093154a30b55d9d79f02

[issue41064] Specialise syntax error of **dict in f-string field

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23764 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25006 ___ Python tracker <https://bugs.python.org/issu

[issue41064] Specialise syntax error of **dict in f-string field

Pablo Galindo Salgado added the comment: > I don't recall if this is really only a "skip leading whitespace" problem, or > if there's some other reason they're required. IIRC, this forces the expression inside to be parsed as an expression. This helps

[issue31861] add aiter() and anext() functions

Change by Pablo Galindo Salgado : -- pull_requests: +23766 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/25008 ___ Python tracker <https://bugs.python.org/issu

[issue31861] add aiter() and anext() functions

Pablo Galindo Salgado added the comment: Fixed by PR25008 -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue31861] add aiter() and anext() functions

Pablo Galindo Salgado added the comment: New changeset a02683ac38183fa3a45c32319dfd329c5e622f0e by Pablo Galindo in branch 'master': bpo-31861: Fix reference leak in builtin_anext_impl() (GH-25008) https://github.com/python/cpython/commit/a02683ac38183fa3a45c32319dfd32

[issue41064] Specialise syntax error of **dict in f-string field

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue41064] Specialise syntax error of **dict in f-string field

Pablo Galindo Salgado added the comment: New changeset 8efad61963809d239cac986e3f3bc4cb505ab8fe by Pablo Galindo in branch 'master': bpo-41064: Improve syntax error for invalid usage of '**' in f-strings (GH-25006) https://github.com/p

[issue43636] test_descr fails randomly when executed with -R :

New submission from Pablo Galindo Salgado : ❯ ./python -m test test_descr -m test_slots -R 3:3 0:00:00 load avg: 0.26 Run tests sequentially 0:00:00 load avg: 0.26 [1/1] test_descr beginning 6 repetitions 123456 test test_descr failed -- Traceback (most recent call last): File "/home/pabl

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Bisecting points at: commit ee48c7d54147ae906776b9f6f96e8920e097d0c4 Author: Dino Viehland Date: Sat Mar 20 12:12:05 2021 -0700 bpo-43452: Micro-optimizations to PyType_Lookup (GH-24804) The common case going through _PyType_Lookup is to

[issue43452] Microoptimize PyType_Lookup for cache hits

Pablo Galindo Salgado added the comment: Seems that commit ee48c7d54147ae906776b9f6f96e8920e097d0c4 has introduced a regression: https://bugs.python.org/issue43636 -- ___ Python tracker <https://bugs.python.org/issue43

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Dino, could you take a look? -- ___ Python tracker <https://bugs.python.org/issue43636> ___ ___ Python-bugs-list mailin

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- nosy: +methane ___ Python tracker <https://bugs.python.org/issue43636> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Seems that the problem is removing the check: if (MCACHE_CACHEABLE_NAME(name) && _PyType_HasFeature(type, Py_TPFLAGS_VALID_VERSION_TAG)) { -- ___ Python tracker <https://bugs

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23780 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25032 ___ Python tracker <https://bugs.python.org/issu

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: I think I have it, we still neet to validate that the version tag is correct. Can you take a look at https://github.com/python/cpython/pull/25032 ? -- stage: patch review -> ___ Python tracker <

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: Yup, that makes sense. Let me update the PR -- ___ Python tracker <https://bugs.python.org/issue43636> ___ ___ Pytho

[issue43636] test_descr fails randomly when executed with -R :

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43636] test_descr fails randomly when executed with -R :

Pablo Galindo Salgado added the comment: New changeset 11b85abbae8aaa8410b19f358abd7b401881bb1c by Pablo Galindo in branch 'master': bpo-43636: Validate the version tag in _PyType_Lookup (GH-25032) https://github.com/python/cpython/commit/11b85abbae8aaa8410b19f358abd7b

[issue1634034] Show "expected" token on syntax error

Pablo Galindo Salgado added the comment: Closing as per above -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/

[issue25643] Python tokenizer rewriting

Change by Pablo Galindo Salgado : -- keywords: +patch nosy: +pablogsal nosy_count: 7.0 -> 8.0 pull_requests: +23799 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25050 ___ Python tracker <https://bugs.p

[issue25643] Python tokenizer rewriting

Pablo Galindo Salgado added the comment: New changeset 261a452a1300eeeae1428ffd6e6623329c085e2c by Pablo Galindo in branch 'master': bpo-25643: Refactor the C tokenizer into smaller, logical units (GH-25050) https://github.com/python/cpython/commit/261a452a1300eeeae1428ffd6e6623

[issue25643] Python tokenizer rewriting

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40645] Use OpenSSL's HMAC API

Pablo Galindo Salgado added the comment: Seems that commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 introduced some reference leaks: commit 933dfd7504e521a27fd8b94d02b79f9ed08f4631 Author: Christian Heimes Date: Sat Mar 27 14:55:03 2021 +0100 bpo-40645: use C implementation of HMAC

[issue40645] Use OpenSSL's HMAC API

Pablo Galindo Salgado added the comment: See for instance: https://buildbot.python.org/all/#/builders/75/builds/224 -- ___ Python tracker <https://bugs.python.org/issue40

[issue40645] Use OpenSSL's HMAC API

Change by Pablo Galindo Salgado : -- pull_requests: +23813 pull_request: https://github.com/python/cpython/pull/25063 ___ Python tracker <https://bugs.python.org/issue40

[issue43660] Segmentation fault when overriding sys.stderr

New submission from Pablo Galindo Salgado : This code crashes (reported by the one and only Matt Wozniski): import sys class MyStderr: def write(self, s): sys.stderr = None sys.stderr = MyStderr() 1/0 [1]34112 segmentation fault ./python.exe lel.py -- components

[issue43660] Segmentation fault when overriding sys.stderr

Pablo Galindo Salgado added the comment: The problem is that https://github.com/python/cpython/blob/master/Python/pythonrun.c#L1074 doesn't take a strong reference to sys.stderr but code underneath can potentially release the GIL and remove the reference that keeps the object

[issue43660] Segmentation fault when overriding sys.stderr

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23825 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25075 ___ Python tracker <https://bugs.python.org/issu

[issue25643] Python tokenizer rewriting

Change by Pablo Galindo Salgado : -- pull_requests: +23830 pull_request: https://github.com/python/cpython/pull/25080 ___ Python tracker <https://bugs.python.org/issue25

[issue43660] Segmentation fault when overriding sys.stderr

Pablo Galindo Salgado added the comment: New changeset 09b90a037d18f5d4acdf1b14082e57bda78e85d3 by Pablo Galindo in branch 'master': bpo-43660: Fix crash when displaying exceptions with custom values for sys.stderr (GH-25075) https://github.com/python/cpyt

[issue43567] regen.vcxproj cannot regenerate some necessary files

Pablo Galindo Salgado added the comment: > regen.vcxproj is now not capable for the new PEG parse Hu, that file should handle the peg parser already: https://github.com/python/cpython/blob/09b90a037d18f5d4acdf1b14082e57bda78e85d3/PCbuild/regen.vcxproj#L156-L

[issue43660] Segmentation fault when overriding sys.stderr

Change by Pablo Galindo Salgado : -- pull_requests: +23833 pull_request: https://github.com/python/cpython/pull/25085 ___ Python tracker <https://bugs.python.org/issue43

[issue43660] Segmentation fault when overriding sys.stderr

Pablo Galindo Salgado added the comment: New changeset ff4715a7332123713de9920e724bb6c412d8ccef by Miss Islington (bot) in branch '3.9': bpo-43660: Fix crash when displaying exceptions with custom values for sys.stderr (GH-25075) (GH-25083) https://github.com/python/cpyt

[issue43660] Segmentation fault when overriding sys.stderr

Pablo Galindo Salgado added the comment: New changeset 2f01c562be913004e1d46fc02705c51b81638d67 by Pablo Galindo in branch '3.7': [3.7] bpo-43660: Fix crash when displaying exceptions with custom values for sys.stderr (GH-25075). (GH-25085) https://github.com/python/cpyt

[issue43660] Segmentation fault when overriding sys.stderr

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: This is probably complementary or in the avenue of https://www.python.org/dev/peps/pep-0652/ -- nosy: +pablogsal, petr.viktorin ___ Python tracker <https://bugs.python.org/issue43

[issue43719] Master build failure on Windows getting file system encoding

Pablo Galindo Salgado added the comment: Fixed by https://github.com/python/cpython/pull/25172 -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: Unfortunately PR21989 has breaking the refleaks buildbots. Example: https://buildbot.python.org/all/#/builders/320/builds/226/steps/5/logs/stdio To reproduce: ❯ ./python -m test test_pdb -R 3:3 0:00:00 load avg: 1.40 Run tests sequentially 0:00:00

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: Per our buildbot policy (https://discuss.python.org/t/policy-to-revert-commits-on-buildbot-failure/404) we will need to revert this in 24 hours if is not fixed to avoid masking future errors

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: New changeset aadd4e10fda87b64ea527667238503da326a06e7 by Irit Katriel in branch 'master': bpo-24160: Fix test_pdb refleaks failure (GH-25182) https://github.com/python/cpython/commit/aadd4e10fda87b64ea527667238503

[issue24160] Pdb sometimes raises exception when trying to remove a breakpoint defined in a different debugger session

Pablo Galindo Salgado added the comment: PR 25182 fixes the issue, so I am closing this again. Thanks for the quick fix, Irit! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: We could have a buildbot using https://github.com/lvc/abi-compliance-checker -- ___ Python tracker <https://bugs.python.org/issue43

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: For example, the tool generates this report for the two 3.9 versions (attached to the issue). -- Added file: https://bugs.python.org/file49935/compat_report.html ___ Python tracker <https://bugs.python.

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: Also, we can use libabigail. For instance: root@7a3947dec3d8:/pytho# abidiff Python-3.9.2/python Python-3.9.3/python Functions changes summary: 0 Removed, 3 Changed (53 filtered out), 0 Added functions Variables changes summary: 0 Removed, 0 Changed

[issue43725] Create a release branch ABI stability regression test

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +23930 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/25188 ___ Python tracker <https://bugs.python.org/issu

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: Ok, so seems that PR25188 works if the abi dump file for the "correct" version is generated with the same compiler that is used to check the ABI. I think this is acceptable if the workflow is: - As soon as a version is released, we gener

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: Adding the rest of RM to evaluate the proposed solution -- nosy: +lukasz.langa, ned.deily, steve.dower ___ Python tracker <https://bugs.python.org/issue43

[issue27129] Wordcode, part 2

Pablo Galindo Salgado added the comment: Closing as this is fixed. Feel free to reopen if there is something missing -- nosy: +pablogsal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracke

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: Ok, will create PRs for the release branches that are receiving fixes -- ___ Python tracker <https://bugs.python.org/issue43

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: > Do we need separate jobs and ABI dumps for each platform and arch? I guess we > need at least separate dumps for 32 and 64bit. Not really, check what happened in my 64 build system when I did the changes that broke the ABI in the latest 3.9 r

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: If I understand correctly, this is analyzing the DWARF information on the binaries, so is quite coupled to the platform you compile to, but you can detect violations that affect other platforms if they share the same code

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: Yeah, I subscribe what Greg said. Let's start with *something* and let's improve upon. -- ___ Python tracker <https://bugs.python.o

[issue43725] Create a release branch ABI stability regression test

Change by Pablo Galindo Salgado : -- pull_requests: +23967 pull_request: https://github.com/python/cpython/pull/25230 ___ Python tracker <https://bugs.python.org/issue43

[issue43725] Create a release branch ABI stability regression test

Change by Pablo Galindo Salgado : -- pull_requests: +23969 pull_request: https://github.com/python/cpython/pull/25232 ___ Python tracker <https://bugs.python.org/issue43

[issue43755] lambda expression no longer valid at comp_if in Python 3.9

Pablo Galindo Salgado added the comment: New changeset 0fdf11e8e901a5f47149232557a7f9726b8177c9 by Saiyang Gou in branch 'master': bpo-43755: Update docs to reflect that lambda is not allowed in `comp_if` since 3.9 (GH-25231) https://github.com/python/cpyt

[issue43755] lambda expression no longer valid at comp_if in Python 3.9

Pablo Galindo Salgado added the comment: Thanks for the quick fix, Saiyang Gou -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: I started with two PRs against the 64 bits versions for 3.9 and 3.8. This *should* cover 32 bits as well (see previous messages), but if we want specific changes for that we need a 32 bit machine or cross-compilation, but I decided to start with

[issue43755] lambda expression no longer valid at comp_if in Python 3.9

Pablo Galindo Salgado added the comment: New changeset f91fc7a679e076cb9a703f6db4d95b63935562e3 by Miss Islington (bot) in branch '3.9': bpo-43755: Update docs to reflect that lambda is not allowed in `comp_if` since 3.9 (GH-25231) (GH-25233) https://github.com/python/cpyt

[issue36540] PEP 570: Python Positional-Only Parameters

Pablo Galindo Salgado added the comment: New changeset 58d72cab89cf9652acc0bf0007aa20b2bcc98499 by Saiyang Gou in branch 'master': bpo-36540: Improve doc of function definition regarding positional-only arguments (GH-25235) https://github.com/python/cpyt

[issue36540] PEP 570: Python Positional-Only Parameters

Pablo Galindo Salgado added the comment: New changeset 4554ab435727a0f3b6441c9c1a8d3fe6534433c7 by Saiyang Gou in branch '3.8': [3.8] bpo-36540: Improve doc of function definition regarding positional-only arguments (GH-25235) (GH-25260) https://github.com/python/cpyt

[issue36540] PEP 570: Python Positional-Only Parameters

Pablo Galindo Salgado added the comment: New changeset 3b1cf202976d9590d5b453c47b883f2e7cd1a7a5 by Saiyang Gou in branch '3.9': [3.9] bpo-36540: Improve doc of function definition regarding positional-only arguments (GH-25235) (GH-25259) https://github.com/python/cpyt

[issue43779] Fix possible parser/AST ref leaks

Pablo Galindo Salgado added the comment: Thanks Erlend. Mind creating a PR from the patch? -- ___ Python tracker <https://bugs.python.org/issue43779> ___ ___

[issue43779] Fix possible parser/AST ref leaks

Pablo Galindo Salgado added the comment: > We could also adjust Parser/asdl_c.py to decref right after a failed > _PyArena_AddPyObject() call, instead of goto failure and Py_XDECREF. I'm not > sure it's worth it though. I normally recommend having the least amount of e

[issue43751] await anext() returns None when default is given

Change by Pablo Galindo Salgado : -- priority: normal -> release blocker ___ Python tracker <https://bugs.python.org/issue43751> ___ ___ Python-bugs-list mai

[issue43779] Fix possible parser/AST ref leaks

Pablo Galindo Salgado added the comment: New changeset 76d270ec2b776cc5331935cc58c2d63622f1c0e9 by Erlend Egeberg Aasland in branch '3.9': [3.9] bpo-43779: Fix possible refleak involving _PyArena_AddPyObject (GH-25289). (GH-25294) https://github.com/python/cpyt

[issue43779] Fix possible parser/AST ref leaks

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43797] Improve syntax error for invalid comparisons

New submission from Pablo Galindo Salgado : Improve syntax error for invalid comparisons such as: >>> if x = 3: File "", line 1 if x = 3: ^ SyntaxError: invalid syntax to print: >>> if x = 3: File "", line 1 if x = 3: ^ Syn

[issue43797] Improve syntax error for invalid comparisons

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +24052 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25317 ___ Python tracker <https://bugs.python.org/issu

[issue43725] Create a release branch ABI stability regression test

Pablo Galindo Salgado added the comment: > Is there an option to exclude array lengths? Or to treat the API as just a > pointer rather than an array? Technically is not a false positive: https://developers.redhat.com/blog/2019/05/06/how-c-array-sizes-become-part-of-the-binary-interfac

[issue43725] Create a release branch ABI stability regression test

Change by Pablo Galindo Salgado : -- pull_requests: +24057 pull_request: https://github.com/python/cpython/pull/25322 ___ Python tracker <https://bugs.python.org/issue43

[issue43725] Create a release branch ABI stability regression test

Change by Pablo Galindo Salgado : -- pull_requests: +24058 pull_request: https://github.com/python/cpython/pull/25323 ___ Python tracker <https://bugs.python.org/issue43

[issue43798] Add position metadata to alias AST type

Pablo Galindo Salgado added the comment: > Ah and one other question: Is this normally the sort of thing that would get > backported? It should be very straightforward to do so, at least for 3.9 > given the support for the new parser. Unfortunately no, is technically a ne

[issue43797] Improve syntax error for invalid comparisons

Pablo Galindo Salgado added the comment: These are good points, let me investigate a bit -- ___ Python tracker <https://bugs.python.org/issue43797> ___ ___ Pytho

[issue43797] Improve syntax error for invalid comparisons

Pablo Galindo Salgado added the comment: > in invalid_named_expression, but it does not have any effect. That is because the rule for named_expressions are: named_expression[expr_ty]: | a=NAME ':=' ~ b=expression | expression !':=' | invalid_named_exp

[issue43797] Improve syntax error for invalid comparisons

Pablo Galindo Salgado added the comment: I have updated the PR with: * Works for while statements (we can make it work for other kinds of statements but is a bit tricky because those have different grammar paths. We could do this in other PRs. * I changed the error message for when the LHS

[issue43797] Improve syntax error for invalid comparisons

Change by Pablo Galindo Salgado : -- nosy: +lys.nikolaou ___ Python tracker <https://bugs.python.org/issue43797> ___ ___ Python-bugs-list mailing list Unsub

[issue43478] Disallow Mock spec arguments from being Mocks

Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 8.0 -> 9.0 pull_requests: +24069 pull_request: https://github.com/python/cpython/pull/25335 ___ Python tracker <https://bugs.python.org/issu

[issue43478] Disallow Mock spec arguments from being Mocks

Pablo Galindo Salgado added the comment: New changeset 6e468cb16bde483ad73c1eb13b20a08d74e30846 by Pablo Galindo in branch 'master': bpo-43478: Fix formatting of NEWS entry (GH-25335) https://github.com/python/cpython/commit/6e468cb16bde483ad73c1eb13b20a0

[issue40137] TODO list when PEP 573 "Module State Access from C Extension Methods" will be implemented

Pablo Galindo Salgado added the comment: Here are some benchmarks of using lru_cache in 3.9 and 3.10 (PGO/LTO/CPU isol): ❯ ./python -m pyperf timeit "from functools import lru_cache; f = lru_cache(lambda: 42)" "f()" --compare-to ../3.9/python /home/pablogs

[issue40137] TODO list when PEP 573 "Module State Access from C Extension Methods" will be implemented

Pablo Galindo Salgado added the comment: As a Release Manager, I am not very happy with a 6% reduction in speed, especially in these functions. Can someone take a look to see if we can get the performance closer to Python 3.9? -- ___ Python

[issue43751] await anext() returns None when default is given

Pablo Galindo Salgado added the comment: New changeset dfb45323ce8a543ca844c311e32c994ec9554c1b by Dennis Sweeney in branch 'master': bpo-43751: Fix anext() bug where it erroneously returned None (GH-25238) https://github.com/python/cpython/commit/dfb45323ce8a543ca844c311e32c99

[issue43751] await anext() returns None when default is given

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue43809] Improve mismatching parentheses error

New submission from Pablo Galindo Salgado : Consider the following program: ( a + b + c ] ) The current error is: >>> ( a + b + c ] ) File "", line 1 ( a + b + c ] ) ^ SyntaxError: closing parenthesis ']' does not match opening parenthesis &

[issue43809] Improve mismatching parentheses error

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +24082 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25348 ___ Python tracker <https://bugs.python.org/issu

[issue43798] Add position metadata to alias AST type

Pablo Galindo Salgado added the comment: > FYI, probably unavoidable, but this appears to have broken pytest > https://github.com/pytest-dev/pytest/issues/8539 What's the problem? alias objects *have* lineno argument: >>> print(ast.dump(ast.parse("from x import y&q

[issue43774] [Doc] Document configure options in the Python documentation

Pablo Galindo Salgado added the comment: New changeset 2459b92a4db69d9b14d0a86a9b81cc075894e910 by Victor Stinner in branch 'master': bpo-43774: Remove --without-cycle-gc doc (GH-25364) https://github.com/python/cpython/commit/2459b92a4db69d9b14d0a86a9b81cc075894e910 -

[issue43797] Improve syntax error for invalid comparisons

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

<    2   3   4   5   6   7   8   9   10   11   >