[issue38446] Ambiguous signature for builtins.__build_class__

2019-11-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > @pablogsal can we close it? Yup, thanks for the ping, Batuhan -- ___ Python tracker <https://bugs.python.org/issu

[issue34792] Tutorial doesn''t discuss / and * function arguments

2019-11-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I don't think we should backport the changes or modify the file for the 3.7 branch, so I close the issue. Feel free to reopen if you still think it makes sense :) -- resolution: -> fixed stage: -> resolved status: ope

[issue37195] test_utime fails on MacOS Mojave (Kernel Version 18.6.0:)

2019-11-18 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have not noticed it in a while, so I will close it for now unless I can reproduce it again. -- resolution: -> postponed stage: -> resolved status: open -> closed ___ Python tracke

[issue37957] Allow regrtest to receive a file with test (and subtests) to ignore

2019-11-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset e0cd8aa70a3ce19c3d3712568940aa0cbd9aa97b by Pablo Galindo in branch 'master': bpo-37957: Allow regrtest to receive a file with test (and subtests) to ignore (GH-16989) https://github.com/python/cpyt

[issue37957] Allow regrtest to receive a file with test (and subtests) to ignore

2019-11-19 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.8 ___ Python tracker <https://bugs.python.or

[issue38847] AST Optimization for Single Target List Comprehension

2019-11-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: IMHO, I think is such a specific use case that is not worth the maintenance cost. Especially because of such list comprehension is very uncommon as you can simply do `list(it)` which more readable and anecdotally faster. -- nosy: +pablogsal

[issue37957] Allow regrtest to receive a file with test (and subtests) to ignore

2019-11-19 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I reopen until the backports -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/i

[issue38870] Expose ast.unparse in the ast module

2019-11-20 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : As discussed in https://mail.python.org/archives/list/python-...@python.org/thread/JAQDBMC23HW2PQ27HQNJ7G244T423IDD/ I propose to expose the unparse.py tool as part of the standard library in the ast module. The exposed function will have the

[issue38870] Expose ast.unparse in the ast module

2019-11-20 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16794 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17302 ___ Python tracker <https://bugs.python.org/issu

[issue38870] Expose ast.unparse in the ast module

2019-11-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: After PR17302 is merged we need to fix the following cosmetic issues indicated by Victor: (*) unparse adds many useless parentheses. The algorithm seems naive. For example, it adds "()" to "class _AddedDllDirectory():". It also add

[issue38446] Ambiguous signature for builtins.__build_class__

2019-11-24 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38547] test_pty fails when using setsid()

2019-11-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This also happens when running the test suite with high parallelism: ./python -m test -j 20 This fails with: == Tests result: FAILURE == 398 tests OK. 2 tests failed: test_embed test_pty -- nosy: +pablogsal

[issue38547] test_pty fails when using setsid()

2019-11-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Indeed, almost all buildbots have to repeat the test_pty. I think this needs to be fixed or process groups in regrtest should be limited or reverted. -- ___ Python tracker <https://bugs.python.

[issue38546] test_concurrent_futures: reap_children() warnings on RHEL7 and RHEL8 buildbots

2019-11-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ran 168 tests in 160.415s OK (skipped=3) Warning -- multiprocessing.process._dangling was modified by test_concurrent_futures Before: set() After: {} Another failure in AMD64 RHEL8 LTO + PGO 3.x https://buildbot.python.org/all/#/builders/284

[issue38547] test_pty fails when using setsid()

2019-11-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > What do you mean by "limited"? I mean to deactivate it by default and make opt-in. > Process groups really help to prevent to leak grandchild processes in > multiprocessing tests, when tests are interrupted manually by CTRL+C

[issue38870] Expose ast.unparse in the ast module

2019-11-24 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 27fc3b6f3fc49a36d3f962caac5c5495696d12ed by Pablo Galindo in branch 'master': bpo-38870: Expose a function to unparse an ast object in the ast module (GH-17302) https://github.com/python/cpyt

[issue38870] Expose ast.unparse in the ast module

2019-11-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +16858 pull_request: https://github.com/python/cpython/pull/17376 ___ Python tracker <https://bugs.python.org/issue38

[issue38912] test_asyncio altered the execution environment

2019-11-25 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : https://buildbot.python.org/all/#/builders/260/builds/60/steps/5/logs/stdio 0:05:06 load avg: 6.65 [131/423] test_contextlib_async passed -- running: test_signal (1 min 53 sec), test_concurrent_futures (4 min 11 sec), test_zipfile (47.5 sec

[issue38940] Add a new functools.cast() function

2019-11-29 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +rhettinger ___ Python tracker <https://bugs.python.org/issue38940> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38954] test_ssl fails in all Fedora buildbots

2019-12-02 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : This issue is probably duplicate of some other, but I decided to make one new one due to the fact that this affect all Fedora build bots. test test_ssl failed test_timeout_connect_ex (test.test_ssl.NetworkedTests) ... ok

[issue38815] test_ssl: test_min_max_version() fails on FreeBSD and Fedora

2019-12-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Raising the priority to 'critical' as this is masking all other problems on a significant number of buildbots. Christian, could you take a look? -- nosy: +pablogsal priority: normal -> critical _

[issue38815] test_ssl: test_min_max_version() fails on FreeBSD and Fedora

2019-12-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Testing for the latest PR happening here: https://buildbot.python.org/all/#/builders?tags=%2Bstable&tags=%2Bcustom -- ___ Python tracker <https://bugs.python.org/iss

[issue38815] test_ssl: test_min_max_version() fails on FreeBSD and Fedora

2019-12-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: All Fedora tests are successful, so I will de-escalate the priority of the issue. Thank you very much Christian and Tomas Orsava! -- priority: critical -> normal ___ Python tracker <https://bugs.pyth

[issue15273] Remove unnecessarily random behavior from test_unparse.py

2019-12-02 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > @pablogsal should we add Lib/test/test_grammar by default to every test? Also > if this is still needed @Daniel.Cioata do you still want to prepare another > patch for current version? I think is a good idea, let me check how comple

[issue1875] "if 0: return" not raising SyntaxError

2019-12-02 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.o

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : All the refleak build bots for master are reporting reference leaks in subinterpreter related tests: https://buildbot.python.org/all/#/builders/126/builds/6/steps/5/logs/stdio https://buildbot.python.org/all/#/builders/144/builds/6/steps/5/logs

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Actually, that commit has an independent refleak that was fixed (!) regarding the small integer cache. Seems that the actual commit that made the new leak is: commit 2582d46fbcf7bdf86b9cf4016850b8d155267ac6 Author: Victor Stinner Date: Fri Nov 22

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16934 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17453 ___ Python tracker <https://bugs.python.org/issu

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, the problem seems to be that _PyBuiltin_Init() returns a new reference that is not cleared once PyModule_GetDict() and _PyBuiltins_AddExceptions() is called. -- stage: patch review -> needs pa

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Indeed, that fixes the problem in at least 2 modules: ./python -m test test_atexit -R : 0:00:00 load avg: 0.84 Run tests sequentially 0:00:00 load avg: 0.84 [1/1] test_atexit beginning 9 repetitions 123456789 . == Tests result: SUCCESS == 1

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +16935 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17454 ___ Python tracker <https://bugs.python.org/issu

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Opened https://github.com/python/cpython/pull/17454 for the fixing the leak in http_servers -- ___ Python tracker <https://bugs.python.org/issue38

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: For the subinterpreter other leaks it seems that the commit that introduced the leak is: 7247407c35330f3f6292f1d40606b7ba6afd5700 is the first bad commit commit 7247407c35330f3f6292f1d40606b7ba6afd5700 Author: Victor Stinner Date: Wed Nov 20 12:25

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Indeed, reverting commit 7247407c35330f3f6292f1d40606b7ba6afd5700 fixes the issues in test_threading -- ___ Python tracker <https://bugs.python.org/issue38

[issue36854] GC operates out of global runtime state.

2019-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +16936 pull_request: https://github.com/python/cpython/pull/17455 ___ Python tracker <https://bugs.python.org/issue36

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I created https://github.com/python/cpython/pull/17455 to revert commit 7247407c35330f3f6292f1d40606b7ba6afd5700 as it seems that the leak is more complex than the others. If a solution is not found in a couple of days we need to merge it to fix the

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +16937 pull_request: https://github.com/python/cpython/pull/17456 ___ Python tracker <https://bugs.python.org/issue38

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: This patch (which is wrong) fixes the reference issues: diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index cce4783bc1..c354af18db 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -1276,6 +1276,7 @@ finalize_interp_clear

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Opened PR 17457 for the refleaks of test__xxsubinterpreters although I am not very convinced that we can call the GC at that point. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38962] Reference leaks in subinterpreters

2019-12-03 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +16938 pull_request: https://github.com/python/cpython/pull/17457 ___ Python tracker <https://bugs.python.org/issue38

[issue38964] Output of syntax error in f-string contains wrong filename

2019-12-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Although Batuhan is correct maybe we can consider trying to improve the debugging experience off-strings due to the fact that these errors in a big project may be difficult to find. Although you have always the back-trace on the other side

[issue38964] Output of syntax error in f-string contains wrong filename

2019-12-04 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/issue38964> ___ ___ Pyth

[issue38964] Output of syntax error in f-string contains wrong filename

2019-12-04 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Additionally, the idea of moving f-strings into the Python grammar would also > fix this problem. That might be a better way forward, although it has a > number of downsides, too. For considerin this path we would need to wait to see

[issue38980] Compile libpython with -fno-semantic-interposition

2019-12-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I have seen people using LD_PRELOAD to interpose some auditing functions that can modify the actual call into libpython, or to interpose faster versions of some functions or to collect metrics (although there are better ways). If we do this by

[issue38980] Compile libpython with -fno-semantic-interposition

2019-12-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Could these user use a "./configure --with-interposition --enable-shared" > build? Sure, but the problem is the default value, no? Maybe it should only be default when using --wi

[issue38980] Compile libpython with -fno-semantic-interposition

2019-12-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > I think it will add to the complexity of the --with-optimizations flag which > already implies PGO and LTO. That is why I was suggesting it: --with-optimizations for me means "activate everything that you can to make py

[issue38980] Compile libpython with -fno-semantic-interposition

2019-12-05 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > It seems to me that the performance gains here really outweigh any weird > usage of LD_PRELOAD. I am very convinced of this assertion, but other users could not be, I think the discussion is how to provide/activate the option in the less int

[issue36820] Captured exceptions are keeping user objects alive unnecessarily in the stdlib

2019-12-06 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Bisecting points to: commit 81fe5bd3d78f9bb955f8255404d99df27a31c36a Author: Victor Stinner Date: Fri Dec 6 02:43:30 2019 +0100 bpo-38858: new_interpreter() reuses _PySys_Create() (GH-17481) new_interpreter() now calls _PySys_Create

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Per or policy, I will initiate the revert of the commit (and any dependent commit) and will merge if an alternative fix is not done in 1-2 days. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +16985 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17509 ___ Python tracker <https://bugs.python.org/issu

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Similar to https://bugs.python.org/issue38962, test__xxsubinterpreters test_atexit test_capi test_threading are leaking references. Example: https://buildbot.python.org/all/#/builders/158/builds/10 https://buildbot.python.org/all/#/builders/16

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I will try to work on an alternative fix meanwhile, but I need to search for what exactly is leaking first. -- ___ Python tracker <https://bugs.python.org/issue38

[issue38993] cProfile behaviour issue with decorator and math.factorial() lib.

2019-12-08 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : Please, could you write a description to this issue here instead of the attached file? -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue38

[issue38992] testFsum failure caused by constant folding of a float expression

2019-12-08 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue38992> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38996] introduction of default values for collection.namedtuple

2019-12-08 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38997] test__xxsubinterpreters test_atexit test_capi test_threading are leaking references

2019-12-08 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks for the fix, Victor! -- ___ Python tracker <https://bugs.python.org/issue38997> ___ ___ Python-bugs-list mailin

[issue39003] test_unparse leaked [35, 5, 6] references: fail randomly, pass when run again

2019-12-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17014 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17537 ___ Python tracker <https://bugs.python.org/issu

[issue39003] test_unparse leaked [35, 5, 6] references: fail randomly, pass when run again

2019-12-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset ac229116a34a679511c20bfeca167cc6a9df9807 by Pablo Galindo in branch 'master': bpo-39003: Make sure all test are the same when using -R in test_unparse (GH-17537) https://github.com/python/cpyt

[issue39003] test_unparse leaked [35, 5, 6] references: fail randomly, pass when run again

2019-12-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39009] Small typo in Lib/test/test__locale.py: thousauds -> thousands

2019-12-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- assignee: -> pablogsal nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39009> ___ ___ Python-bugs-lis

[issue39009] Small typo in Lib/test/test__locale.py: thousauds -> thousands

2019-12-09 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 2ad7651c00c9b58b2b8b9e3687c82c203ece576c by Pablo Galindo (Tim Gates) in branch 'master': bpo-39009: Fix typo in test__locale (GH-17544) https://github.com/python/cpython/commit/2ad7651c00c9b58b2b8b9e3687c82c

[issue39009] Small typo in Lib/test/test__locale.py: thousauds -> thousands

2019-12-09 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: >From the PR: Christian, can you open the PR against master instead? We will backport the change to 3.8 after is merged. -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issu

[issue39016] Negative Refcount in Python 3.8

2019-12-10 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > No, this appears to be impossible. Oh, I see. Apologies then for the misunderstunding. -- ___ Python tracker <https://bugs.python.org/issu

[issue39028] ENH: Fix performance issue in keyword extraction

2019-12-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39028> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39031> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/issue39031> ___ ___ Python-bugs-list mailing list Unsub

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- components: +Interpreter Core ___ Python tracker <https://bugs.python.org/issue39031> ___ ___ Python-bugs-list mailin

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17058 pull_request: https://github.com/python/cpython/pull/17584 ___ Python tracker <https://bugs.python.org/issue39

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: The same thing happens with 3.8. -- ___ Python tracker <https://bugs.python.org/issue39031> ___ ___ Python-bug

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Hmmm, there is some problem with the CI and the 3.7 branch. Seems like Travis CI is giving some problems again I will investigate or maybe ask Brett to make the check not required again (we still have Azure Pipelines, testing the same thing

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 0ed45d0cbfc7579dfc5527c19aa6e4bb696db2e0 by Pablo Galindo in branch '3.7': [3.7] bpo-39031: Include elif keyword when producing lineno/col-offset info for if_stmt (GH-17582) (#17584) https://github.com/python/cpyt

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3b18b17efcee6f968cf85c543254b3611311e9f4 by Pablo Galindo (Miss Islington (bot)) in branch '3.8': bpo-39031: Include elif keyword when producing lineno/col-offset info for if_stmt (GH-17582) (GH-17589) https://github.com/pyth

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17070 pull_request: https://github.com/python/cpython/pull/17601 ___ Python tracker <https://bugs.python.org/issue39

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: fixed -> status: closed -> open ___ Python tracker <https://bugs.python.org/issue39031> ___ ___ Pyth

[issue39031] Inconsistency with lineno and col_offset info when parsing elif

2019-12-14 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Thanks, Lysandros for the quick fix! -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue38870] Expose ast.unparse in the ast module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset a322f50c369e2e4138266c88e32ef83af95b2da6 by Pablo Galindo (Batuhan Taşkaya) in branch 'master': bpo-38870: Remove dead code related with argument unparsing (GH-17613) https://github.com/python/cpyt

[issue39061] Garbage Collection optimizations cause "memory leak"

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > It happens to cause huge memory leaks if the self-referencing objects > occupies a lot of RAM, which should be expected. The fact that the GC will take longer time does not qualify this as memory leaks. A memory leak is by definition memor

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I will be ok with (no particular order): - Avoid cool enum and functools modules, and use simpler - Accept to make "import ast" slower - Lazy import I think is very important to keep 'ast.unparse' symmetric with 'ast.parse

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue39069> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I think I agree, will make a PR for that. -- assignee: -> pablogsal ___ Python tracker <https://bugs.python.org/issu

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: That will likely be very dependent on the filesystem. For example, in one of my servers without SSDs: Before: Mean +- std dev: 412 ns +- 11 ns After: Mean +- std dev: 472 ns +- 11 ns -- ___ Python tracker

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Also, make sure that the module is not cached, for example: ./python -m pyperf timeit 'import sys; sys.modules.pop("ast",None);sys.modules.pop("enum",None)' 'import ast' -- __

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: One thing to notice: Factoring this into a submodule may be a bit annoying as it will have circular imports as the unparse submodule depends directly on stuff from ast and ast will import unparse. Is possible to make it work if we import it at the

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +17098 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17629 ___ Python tracker <https://bugs.python.org/issu

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Opened https://github.com/python/cpython/pull/17629 in case we decide to go this route. -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issu

[issue39061] Garbage Collection makes some object live for very long

2019-12-16 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- title: Garbage Collection optimizations cause "memory leak" -> Garbage Collection makes some object live for very long ___ Python tracker <https://bugs.pytho

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: If I remember correctly, the people that were concerned mentioned the usage of 'ast.literal_eval' in some simple command line applications were the import may be noticeable but I will be totally ok to just accept the slower imp

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Victor, are you OK if we close this issue and just use the desired imports directly in the PRs for issue 38870? -- ___ Python tracker <https://bugs.python.org/issue39

[issue39069] Move ast.unparse() function to a different module

2019-12-16 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Closing this now that we have consensus. :) Thanks, everyone for your input! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39080] Inconsistency with Starred Expression line/col info

2019-12-17 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 50d4f12958bf806a4e1a1021d70cfd5d448c5cba by Pablo Galindo (Lysandros Nikolaou) in branch 'master': bpo-39080: Starred Expression's column offset fix when inside a CALL (GH-17645) https://github.com/python

[issue39080] Inconsistency with Starred Expression line/col info

2019-12-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17116 pull_request: https://github.com/python/cpython/pull/17649 ___ Python tracker <https://bugs.python.org/issue39

[issue39080] Inconsistency with Starred Expression line/col info

2019-12-17 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue23868] Uninitialized objects are tracked by the garbage collector

2019-12-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: If I understand what you say correctly, it does not seem correct, the object will only be tracked by the collector when you call PyObject_GC_Track. indeed, the documentation warns about this: void PyObject_GC_Track(PyObject *op)¶ Adds the object op to

[issue23868] Uninitialized objects are tracked by the garbage collector

2019-12-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: In summary, a normal allocation for an object tracked by the Garbage collector follows these steps: 1.- Call PyObject_GC_New or PyObject_GC_NewVar or related APIs. 2.- Initialize everything and make sure the object is consistent. 3.- Call

[issue38870] Expose ast.unparse in the ast module

2019-12-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 4b3b1226e86df6cd45e921c8f2ad23c3639c43b2 by Pablo Galindo (Batuhan Taşkaya) in branch 'master': bpo-38870: Refactor delimiting with context managers in ast.unparse (GH-17612) https://github.com/python/cpyt

[issue38870] Expose ast.unparse in the ast module

2019-12-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +17143 pull_request: https://github.com/python/cpython/pull/17687 ___ Python tracker <https://bugs.python.org/issue38

[issue38870] Expose ast.unparse in the ast module

2019-12-23 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset d69cbeb99d5fd0d5464e937202cca6a2024d1bcf by Pablo Galindo in branch 'master': Revert "bpo-38870: Remove dependency on contextlib to avoid performance regression on import (GH-17376)" (GH-17687) https://github.com/p

[issue39114] Python 3.9.0a2 changed how finally/return is traced

2019-12-23 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue39114> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    16   17   18   19   20   21   22   23   24   25   >