[issue45063] PEP 657 Fine Grained Error Locations: omit indicators if they are one the whole line, to make tracebacks shorter

Pablo Galindo Salgado added the comment: >In my example, there are 6 frames. The indicators cover the whole line of 3 >frames: 50%. It's a common case, it's not special. Special is not uncommon, is just some different behaviour rather than the default one. I am not arguin

[issue45063] PEP 657 Fine Grained Error Locations: omit indicators if they are one the whole line, to make tracebacks shorter

Pablo Galindo Salgado added the comment: > Python 3.11 makes it worse: up to 1.5x longer Sound like you likely want to use the environment variable to deactivate the extra information ;) -- ___ Python tracker <https://bugs.python.org/issu

[issue45056] compiler: Unnecessary None in co_consts

Pablo Galindo Salgado added the comment: > I want to backport it to 3.10 or 3.10.1 after Mark's review. Ok, please, add me as a reviewer to the backport once is ready. -- ___ Python tracker <https://bugs.python.org

[issue39758] StreamWriter.wait_closed() can hang indefinitely.

Change by Pablo Galindo Salgado : -- components: -Build, C API, Parser, Tests, email nosy: -pablogsal ___ Python tracker <https://bugs.python.org/issue39

[issue45056] compiler: Unnecessary None in co_consts

Pablo Galindo Salgado added the comment: Let's wait for 3.10.1 to backport this because I prefer to keep pyc files stable for the release candidate. Turns out that people are already preparing wheels to 3.10 and although this may be fine, I don't want to risk incompatibiliti

[issue45056] compiler: Unnecessary None in co_consts

Pablo Galindo Salgado added the comment: I honestly want to backport it because I think it should not have any negative impact, but on the other hand I don't feel very confident as the release candidate phase is supposed to be as close as possible as the final release and this is not f

[issue45086] f-string unmatched ']'

Pablo Galindo Salgado added the comment: > But we've never gotten past just talking about it Stay tuned! :) https://github.com/we-like-parsers/cpython/tree/fstring-grammar -- ___ Python tracker <https://bugs.python.org

[issue24612] not operator expression raising a syntax error

Pablo Galindo Salgado added the comment: I think the best outcome here is to refine the syntax error. Making it behave a bit better is going to be quite a pain because of how unary "-" and "not" work on the priority level in the grammar. I also don't th

[issue24612] not operator expression raising a syntax error

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26599 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28170 ___ Python tracker <https://bugs.python.org/issu

[issue45116] Performance regression 3.10b1 and later on Windows

Change by Pablo Galindo Salgado : -- nosy: -pablogsal ___ Python tracker <https://bugs.python.org/issue45116> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44860] sysconfig's posix_user scheme has different platlib value to distutils's unix_user

Pablo Galindo Salgado added the comment: IIUC we need to backport PR27655 to 3.10 no? Or do we need something else? -- ___ Python tracker <https://bugs.python.org/issue44

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: New changeset 4f88161f07538dfb24a43189fd59bf966cb40817 by Tzu-ping Chung in branch 'main': bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011) https://github.com/python/cpython/commit/4f88161f07538dfb24a43189fd59bf

[issue44963] anext_awaitable is not a collections.abc.Generator

Pablo Galindo Salgado added the comment: New changeset 533e725821b15e2df2cd4479a34597c1d8faf616 by Pablo Galindo Salgado in branch 'main': bpo-44963: Implement send() and throw() methods for anext_awaitable objects (GH-27955) https://github.com/python/cpyt

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: Hum, I reviewed PR 38011 and the change made sense to me, but If you think we should reconsider PR 28011, please say so ASAP because the 3.10 backport is close to be merged -- ___ Python tracker

[issue45123] PyAiter_Check & PyObject_GetAiter issues

Pablo Galindo Salgado added the comment: New changeset 2c3474a637949aa6f2f7e15f9764c2dfc49cdba1 by Yury Selivanov in branch 'main': bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) https://github.com/python/cpython/commit/2c3474a637949aa6f2f7e15f97

[issue44964] Semantics of PyCode_Addr2Line() changed

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26625 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28200 ___ Python tracker <https://bugs.python.org/issu

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: Miro, Petr, do you think then that we should revert PR 28011 -- ___ Python tracker <https://bugs.python.org/issue45

[issue44963] anext_awaitable is not a collections.abc.Generator

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Change by Pablo Galindo Salgado : -- pull_requests: +26626 pull_request: https://github.com/python/cpython/pull/28201 ___ Python tracker <https://bugs.python.org/issue45

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: Ok, I am reverting PR 28011. Someone should check it again and decide what to do, but this won't enter 3.10 -- ___ Python tracker <https://bugs.python.org/is

[issue44964] Semantics of PyCode_Addr2Line() changed

Pablo Galindo Salgado added the comment: New changeset fa2c0b85a8d5c9486661083afdf38cbaadb3432a by Pablo Galindo Salgado in branch 'main': bpo-44964: Add a note explaining the new semantics of f_last_i in frame objects (GH-28200) https://github.com/python/cpyt

[issue44964] Semantics of PyCode_Addr2Line() changed

Change by Pablo Galindo Salgado : -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44860] sysconfig's posix_user scheme has different platlib value to distutils's unix_user

Pablo Galindo Salgado added the comment: New changeset 608a6292366ebba20f33d93d8b52cbb928429e47 by Miss Islington (bot) in branch '3.10': bpo-44860: Make sysconfig posix_user not depend on platlibdir (GH-27655) (GH-28197) https://github.com/python/cpyt

[issue44860] sysconfig's posix_user scheme has different platlib value to distutils's unix_user

Pablo Galindo Salgado added the comment: Petr, is something left to do for this release blocker? I am planning to start the release if everything is OK -- ___ Python tracker <https://bugs.python.org/issue44

[issue45123] PyAiter_Check & PyObject_GetAiter issues

Pablo Galindo Salgado added the comment: New changeset 53257cf19fc06fff446815b3278d4b80ec3e7ba3 by Miss Islington (bot) in branch '3.10': bpo-45123: PyAiter_Check and PyObject_GetAiter fix & rename. (GH-28194) (GH-28199) https://github.com/python/

[issue44860] sysconfig's posix_user scheme has different platlib value to distutils's unix_user

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45123] PyAiter_Check & PyObject_GetAiter issues

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: New changeset 97b754d4b46ad9dd63f68906484f805931578c81 by Pablo Galindo Salgado in branch 'main': Revert "bpo-45035: Make sysconfig posix_home depend on platlibdir (GH-28011)" (GH-28201) https://github.com/p

[issue45052] WithProcessesTestSharedMemory.test_shared_memory_basics fails on Windows

Pablo Galindo Salgado added the comment: This seem to have caused several errors that have manifested on the release of 3.10.0rc2: test test_multiprocessing_fork failed -- Traceback (most recent call last): File "/tmp/tmpu30qfjpr/installation/lib/python3.10/unittest/mock.py",

[issue45035] sysconfig's posix_home scheme has different platlib value to distutils's unix_home

Pablo Galindo Salgado added the comment: I'm doing the release of 3.10.0rc2 as we speak. Please, review this ASAP or otherwise this PR will not be backported to 3.10.0 and will have to wait to 3.10.1 as per the devguide. -- ___ Python tr

[issue45052] WithProcessesTestSharedMemory.test_shared_memory_basics fails on Windows

Pablo Galindo Salgado added the comment: I'm planning to revert PR 28185 because this is blocking the release -- ___ Python tracker <https://bugs.python.org/is

[issue45128] test_multiprocessing fails sporadically on the release artifacts

New submission from Pablo Galindo Salgado : While testing the release artifacts I encountered this failure: test test_multiprocessing_fork failed -- Traceback (most recent call last): File "/tmp/tmpu30qfjpr/installation/lib/python3.10/unittest/mock.py", line 1239, in _dot_lookup

[issue45052] WithProcessesTestSharedMemory.test_shared_memory_basics fails on Windows

Pablo Galindo Salgado added the comment: Opened https://bugs.python.org/issue45128 -- ___ Python tracker <https://bugs.python.org/issue45052> ___ ___ Python-bug

[issue44964] Semantics of PyCode_Addr2Line() changed

Change by Pablo Galindo Salgado : -- pull_requests: +26633 pull_request: https://github.com/python/cpython/pull/28208 ___ Python tracker <https://bugs.python.org/issue44

[issue45083] Need to use the exception class qualname when rendering exception (in C code)

Pablo Galindo Salgado added the comment: The bug is not a crash in the interpreter and this PR touches fundamental code in the interpreter, so I think the safest approach is waiting for 3.10.1 -- priority: release blocker -> ___ Python trac

[issue45147] Typo in "What's New In Python 3.10" documentation

Pablo Galindo Salgado added the comment: > @pablogsal: You might want to merge this back to 3.10.0, once it's merged to > 3.10. I'll merge it shortly, once the tests have run. Thanks for the ping. I have cherry-picked PR

[issue40128] IDLE Show completions pop-up not working on macOS

Pablo Galindo Salgado added the comment: Thanks Terry, I have cherry-picked commit b441e99d89a3f05210cc36ade57699384986ca00 to the 3.10.0 release branch! -- ___ Python tracker <https://bugs.python.org/issue40

[issue45183] Unexpected exception with zip importer

Pablo Galindo Salgado added the comment: I bisected this to: 3abf6f010243a91bf57cbf357dac33193f7b8407 is the first bad commit commit 3abf6f010243a91bf57cbf357dac33193f7b8407 Author: Desmond Cheong Date: Tue Mar 9 04:06:02 2021 +0800 bpo-14678: Update zipimport to support

[issue45183] Unexpected exception with zip importer

Pablo Galindo Salgado added the comment: Brett, can you take a look when you have some time? -- ___ Python tracker <https://bugs.python.org/issue45183> ___ ___

[issue4356] Add "key" argument to "bisect" module functions

Change by Pablo Galindo Salgado : -- nosy: +pablogsal nosy_count: 20.0 -> 21.0 pull_requests: +26752 pull_request: https://github.com/python/cpython/pull/28339 ___ Python tracker <https://bugs.python.org/iss

[issue4356] Add "key" argument to "bisect" module functions

Pablo Galindo Salgado added the comment: New changeset 1aaa85949717e4ab2ed700e58762f0a3ce049a37 by Pablo Galindo Salgado in branch 'main': bpo-4356: Mention the new key arguments for the bisect module APIs in the 3.10 What's new (GH-28339) https://github.com/python

[issue40128] IDLE Show completions pop-up not working on macOS

Pablo Galindo Salgado added the comment: > Pablo, I'm not sure what you cherry-picked, I cherry-picked https://github.com/python/cpython/pull/26684 but this can be easily undone as this is cherry-picked to the 3.10.0 release branch that I have much more control upon. What would yo

[issue4356] Add "key" argument to "bisect" module functions

Pablo Galindo Salgado added the comment: New changeset dda5ff2d095c795f00afaa64505069a2409f6099 by Miss Islington (bot) in branch '3.10': bpo-4356: Mention the new key arguments for the bisect module APIs in the 3.10 What's new (GH-28339) (GH-28340) https://github.com/python

[issue45202] Add 'remove_barry_from_BDFL' future to revert effects of 'from __future__ import barry_as_FLUFL'

Pablo Galindo Salgado added the comment: I think this adds too much complexity for an Easter egg. The compiler flags have been proven to be quite brittle (see past bugs regarding them) so I don't want to add new ones of we can avo

[issue45128] test_multiprocessing fails sporadically on the release artifacts

Pablo Galindo Salgado added the comment: > but quite reliably does occur (three times in three different spots) if the > whole test suite is executed: The thing is that we are running the test suite constantly on CI and buildbots and non of them have seen this problem :( We should see

[issue45204] test_peg_generator: test_soft_keyword() logs many messages into stdout

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26774 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28360 ___ Python tracker <https://bugs.python.org/issu

[issue45204] test_peg_generator: test_soft_keyword() logs many messages into stdout

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

Pablo Galindo Salgado added the comment: > Pablo, should this be a release blocker? How severe is the regression? If is severe enough we can mark it as a release blocker, but a conclusion needs to be reached ASAP because I don't want to change a fundamental macro a few days be

[issue45236] pyperformance fails to build master

New submission from Pablo Galindo Salgado : In the main branch, pyperformance fails to build due to something regarding the freeze module: 2021-09-17 00:03:46,170: /home/pablogsal/cpython_cron/Programs/_freeze_module importlib._bootstrap /home/pablogsal/cpython_cron/Lib/importlib

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

Pablo Galindo Salgado added the comment: If https://bugs.python.org/file50280/310rc2_benchmarks.txt is correct, this means that we have a 7% slowdown in Windows PGO builds for 3.10, which I don't think is acceptable. I am marking this as a release blocker until there is some agreeme

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Pablo Galindo Salgado added the comment: > Pablo: would it be possible to make the Address Sanitizer not mandatory on > pull requests, until this libasan race condition is fixed? I don't think that's a good idea because then people will

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Pablo Galindo Salgado added the comment: I understand what you mean and I sympathize with it, but this is no different to random failures that we get in the other CI. The check is not failing constantly because otherwise no PRs could be merged and that's not what is happenin

[issue45193] IDLE Show completions pop-up not working on Ubuntu Linux

Pablo Galindo Salgado added the comment: > are ready to be cherrypicked into into the 3.10.0 release branch. Once that is done, 'release blocker' can be removed, but issue should remain open for a separate fix for 3.9. Done! I am removing the release blocker and the 3.10, 3.11

[issue45236] pyperformance fails to build master

Pablo Galindo Salgado added the comment: I have checked and indeed this has been fixed already. Thanks a lot, Victor for the fix! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bug

[issue44640] Fix punctuation in isinstance() error message

Pablo Galindo Salgado added the comment: New changeset 9c23a1ebade19f20c7d6e592a7d0329545a9a746 by Miss Islington (bot) in branch '3.10': bpo-44640: Improve punctuation consistency in isinstance/issubclass error messages (GH-27144) (GH-28436) https://github.com/python/cpyt

[issue45121] Calling super().__init__ in subclasses of typing.Protocol raises RecursionError

Pablo Galindo Salgado added the comment: > Pablo, marking as release blocker. PR GH-28232 is merged to 3.10. It should > be cherry-picked for 3.10.0 inclusion. Done! -- resolution: -> fixed stage: patch review -> resolved status: op

[issue44640] Fix punctuation in isinstance() error message

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue30637] Syntax error reported on compile(...), but not on compile(..., ast.PyCF_ONLY_AST)

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26860 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/28459 ___ Python tracker <https://bugs.python.org/issu

[issue30637] Syntax error reported on compile(...), but not on compile(..., ast.PyCF_ONLY_AST)

Pablo Galindo Salgado added the comment: New changeset e6d05a4092b4176a30d1d1596585df13c2ab676d by Pablo Galindo Salgado in branch 'main': bpo-30637: Improve the docs of ast.parse regarding differences with compile() (GH-28459) https://github.com/python/cpyt

[issue45128] test_multiprocessing_fork fails if run sequentially after test_genericalias and test_logging

Pablo Galindo Salgado added the comment: New changeset 1d42408495402b06ecae91420735aeff454be6b5 by Nikita Sobolev in branch 'main': bpo-45128: fixes `test_multiprocessing_fork` mysterious crash (GH-28387) https://github.com/python/cpython/commit/1d42408495402b06ecae91420735ae

[issue45040] [sqlite3] optimise transaction control functions

Pablo Galindo Salgado added the comment: New changeset 771a5467132f0400d4c987db8ba807f845b655bc by Erlend Egeberg Aasland in branch 'main': bpo-45040: Simplify sqlite3 transaction control functions (GH-28019) https://github.com/python/cpython/commit/771a5467132f0400d4c987db8ba807

[issue45040] [sqlite3] optimise transaction control functions

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45041] [sqlite3] simplify executescript()

Pablo Galindo Salgado added the comment: New changeset a6779715c4d0289acb59a8fd3660ab2e5d486c4b by Erlend Egeberg Aasland in branch 'main': bpo-45041: Simplify `sqlite3.Cursor.executescript()` (GH-28020) https://github.com/python/cpython/commit/a6779715c4d0289acb59a8fd3660ab

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

Pablo Galindo Salgado added the comment: > I could not reproduce the crash and from the discussion it seems resolved. Is > there anything left here? No, this should be fixed by now. I just forgot to close the issue. Thanks for th

[issue30637] Syntax error reported on compile(...), but not on compile(..., ast.PyCF_ONLY_AST)

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45128] test_multiprocessing_fork fails if run sequentially after test_genericalias and test_logging

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

Pablo Galindo Salgado added the comment: > I'm thinking that edit to tp_dealloc was incorrect. What edit are you referring to? PR 18749 only touches tp_clear and tp_traverse, not tp_dealloc -- ___ Python tracker <https://bugs

[issue39778] collections.OrderedDict and weakref.ref raises "refcount is too small" assertion

Pablo Galindo Salgado added the comment: Also, the ordered dict dealloc is already doing that: https://github.com/python/cpython/blob/a856364cc920d8b16750fd1fadc902efb509754c/Objects/odictobject.c#L1372-L1373 -- ___ Python tracker <ht

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Pablo Galindo Salgado added the comment: > I didn't check the error rate of this issue. Usually, I'm not sure why, but > I'm the one affected by every single test which fails randomly :-D If you wish, as a compromise we can ignore multiprocessing tests on ASAN build f

[issue45116] Performance regression 3.10b1 and later on Windows: Py_DECREF() not inlined in PGO build

Pablo Galindo Salgado added the comment: Can someone repeat the benchmarks with https://github.com/python/cpython/pull/28475 ? -- ___ Python tracker <https://bugs.python.org/issue45

[issue45249] Fine grained error locations do not work in doctests

Pablo Galindo Salgado added the comment: Hu, could you explain a bit more in detail what is the expected output? I can see highlighting in the exec call that you pasted: exec(compile(example.source, filename, "single", ^^

[issue45249] Fine grained error locations do not work in doctests

Pablo Galindo Salgado added the comment: Ah, but that is a different issue. This is not PEP 657, this is a SyntaxError, so is related how those are printed, which I think is separared. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45249] Fine grained error locations do not work in doctests

Pablo Galindo Salgado added the comment: Can you try a doctest that fails on something that is not a SyntaxError. Something like: >>> def foo(x): ...return x + 42 >>> foo(None) -- ___ Python tracker <https://bugs.

[issue45256] Remove the usage of the cstack in Python to Python calls

New submission from Pablo Galindo Salgado : Removing the usage of the C stack in Python-to-Python calls will allow future optimizations in the eval loop to take place and can yield some speed ups given that we will be removing C function calls and preambles by inlining the callee in the same

[issue45256] Remove the usage of the cstack in Python to Python calls

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +26884 stage: -> patch review pull_request: https://github.com/python/cpython/pull/28488 ___ Python tracker <https://bugs.python.org/issu

[issue44958] [sqlite3] only reset statements when needed

Pablo Galindo Salgado added the comment: New changeset 050d1035957379d70e8601e6f5636637716a264b by Erlend Egeberg Aasland in branch 'main': bpo-44958: Only reset `sqlite3` statements when needed (GH-27844) https://github.com/python/cpython/commit/050d1035957379d70e8601e6f56366

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Change by Pablo Galindo Salgado : -- pull_requests: +26887 pull_request: https://github.com/python/cpython/pull/28492 ___ Python tracker <https://bugs.python.org/issue45

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45200] Address Sanitizer: libasan dead lock in pthread_create() (test_multiprocessing_fork.test_get() hangs)

Pablo Galindo Salgado added the comment: New changeset a356272362c15f2561872f3206baf5e9a0543997 by Pablo Galindo Salgado in branch 'main': bpo-45200: Ignore test_multiprocessing_* in ASAN build due to false positives (GH-28492) https://github.com/python/cpyt

[issue24076] sum() several times slower on Python 3 64-bit

Pablo Galindo Salgado added the comment: Unfortunately commit debd80403721b00423680328d6adf160a28fbff4 introduced a reference leak: ❯ ./python -m test test_grammar -R : 0:00:00 load avg: 2.96 Run tests sequentially 0:00:00 load avg: 2.96 [1/1] test_grammar beginning 9 repetitions 123456789

[issue24076] sum() several times slower on Python 3 64-bit

Change by Pablo Galindo Salgado : -- pull_requests: +26888 pull_request: https://github.com/python/cpython/pull/28493 ___ Python tracker <https://bugs.python.org/issue24

[issue24076] sum() several times slower on Python 3 64-bit

Pablo Galindo Salgado added the comment: Opened #28493 to fix the refleak -- ___ Python tracker <https://bugs.python.org/issue24076> ___ ___ Python-bugs-list m

[issue24076] sum() several times slower on Python 3 64-bit

Pablo Galindo Salgado added the comment: Sorry, I meant PR 28493 -- ___ Python tracker <https://bugs.python.org/issue24076> ___ ___ Python-bugs-list mailin

[issue24076] sum() several times slower on Python 3 64-bit

Pablo Galindo Salgado added the comment: New changeset 1c7e98dc258a0e7ccd2325a1aefc4aa2de51e1c5 by Pablo Galindo Salgado in branch 'main': bpo-24076: Fix reference in sum() introduced by GH-28469 (GH-28493) https://github.com/python/cpython/commit/1c7e98dc258a0e7ccd2325a1aefc4a

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Change by Pablo Galindo Salgado : -- pull_requests: +26893 pull_request: https://github.com/python/cpython/pull/28498 ___ Python tracker <https://bugs.python.org/issue43

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: >From PR 28498: @vstinner @ambv The ABI is not broken, the only thing that this PR change is the size of the struct. All the offsets to the members are the same and therefore will be valid in any compiled code. Any compiled wheels will still w

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: Also, just to clarify, I also opened PR 28498 to discuss the possibility of going ahead, I still don't want to move on without consensus. -- ___ Python tracker <https://bugs.python.org/is

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: Also, I personally thing there is absolutely no guarantee that Cython code generated for 3.9 should work for 3.10 and the thread state is a private structure that has undocumented fields and is not part of the stable API nor the limited API so

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: I'm removing the release blocker as per above, feel free to close of there is nothing else to discuss or act on here. -- priority: release blocker -> ___ Python tracker <https://bugs.python.org

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: I discussed this particular instance with the Steering Council and the conclusion was that this field (use_tracing) is considered an implementation detail and therefore its removal it's justified so we won't be restoring it. I'm th

[issue24076] sum() several times slower on Python 3 64-bit

Pablo Galindo Salgado added the comment: Always happy to help :) -- ___ Python tracker <https://bugs.python.org/issue24076> ___ ___ Python-bugs-list mailin

[issue45256] Remove the usage of the cstack in Python to Python calls

Pablo Galindo Salgado added the comment: What was rejected was https://www.python.org/dev/peps/pep-0651/ which included this idea but had a lot more stuff in it. In particular, it was rejected because it gave semantics to overflow exceptions (two exceptions were proposed), new APIs and it

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: > I'll just note that a change in struct size does technically break ABI, since > *arrays* of PyThreadState will break. Not that matters now because we are not proceeding but just to clarify why I deemed this acceptable: arrays of PyThr

[issue43760] The DISPATCH() macro is not as efficient as it could be (move PyThreadState.use_tracing)

Pablo Galindo Salgado added the comment: Also, I checked the DWARF tree of all existing wheels for 3.10 on PyPI (there aren't many) and none had anything that uses the size of the struct. -- ___ Python tracker <https://bugs.python.org/is

[issue45234] copy_file raises FileNotFoundError when src is a directory

Pablo Galindo Salgado added the comment: Cherry-picked! -- priority: release blocker -> stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45256] Remove the usage of the C stack in Python to Python calls

Pablo Galindo Salgado added the comment: > Though I wouldn't like to lose the ability to extract the Python stack by > inspecting native memory alone. Don't worry about it, I am personally making sure that keeps being possible. it will need some changes in the tools, but n

[issue45274] Race condition in Thread._wait_for_tstate_lock()

Pablo Galindo Salgado added the comment: > Add a context manager which suppresses keyboard interruption. That's not enough technically. This can be any signal handler that raises an exception, no? -- ___ Python tracker <https://bugs

[issue44603] REPL: exit when the user types exit instead of asking them to explicitly type exit()

Pablo Galindo Salgado added the comment: > Typing `import sys; sys.exit()` every time I want to test something quick on > the REPL is awful UX. Without disagreeing with the general sentiment, just note that you can always do

[issue45289] test_gdbm segfaults in M1 Mac

New submission from Pablo Galindo Salgado : 0:04:14 load avg: 3.86 [141/427/1] test_dbm crashed (Exit code -11) Fatal Python error: Segmentation fault Current thread 0x000102e2bd40 (most recent call first): File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/buil

[issue45289] test_gdbm segfaults in M1 Mac

Change by Pablo Galindo Salgado : -- components: +macOS -Tests nosy: +ned.deily, ronaldoussoren ___ Python tracker <https://bugs.python.org/issue45289> ___ ___

<    12   13   14   15   16   17   18   19   20   21   >