Pablo Galindo Salgado added the comment:
New changeset 61eb9b5dfd919ba5d1ec9f7df0137f2e6d196972 by Pablo Galindo in
branch '3.10':
[3.10] bpo-6: support lineno being None in traceback.FrameSummary
(GH-26781) (GH-27072)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issue6>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
Feel free to reopen if we are missing anything
--
___
Python tracker
<https://bugs.python.org/issue6>
___
___
Pytho
Pablo Galindo Salgado added the comment:
New changeset 9f2c63b258846a95393b556fee5e1090173ea717 by Mark Shannon in
branch '3.10':
bpo-44570: Fix line tracing for forward jumps to duplicated tails (GH-27067)
https://github.com/python/cpython/commit/9f2c63b258846a95393b556fee5e10
Pablo Galindo Salgado added the comment:
New changeset da6414f0acf5ec9ea3b07e4b3907bc49c2a61e2f by Mark Shannon in
branch 'main':
bpo-44570: Fix line tracing for forwards jumps to duplicated tails (GH-27068)
https://github.com/python/cpython/commit/da6414f0acf5ec9ea3b07e4b3907bc
Pablo Galindo Salgado added the comment:
Awesome, thanks a lot for the quick resolution, Mark!
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Pablo Galindo Salgado added the comment:
Is anything left here?
--
___
Python tracker
<https://bugs.python.org/issue43908>
___
___
Python-bugs-list mailin
Change by Pablo Galindo Salgado :
--
priority: release blocker ->
___
Python tracker
<https://bugs.python.org/issue43908>
___
___
Python-bugs-list mai
Pablo Galindo Salgado added the comment:
I would say yes. Do you have a compiled list of what's left?
--
___
Python tracker
<https://bugs.python.org/is
Pablo Galindo Salgado added the comment:
New changeset 2f7636887e9f978352aa47b18d5f376263663ba1 by Batuhan Taskaya in
branch '3.10':
[3.10] bpo-43897: ast validation for pattern matching nodes (GH-27074)
https://github.com/python/cpython/commit/2f7636887e9f978352aa47b18d5f37
Pablo Galindo Salgado added the comment:
Yeah, I think these should be changed, but lest give a bit of time for other
core devs to mention what they think
--
___
Python tracker
<https://bugs.python.org/issue43
Pablo Galindo Salgado added the comment:
New changeset f24777c2b329974b69d2a3bf5cfc37e0fcace36c by Pablo Galindo Salgado
in branch 'main':
bpo-44317: Improve tokenizer errors with more informative locations (GH-26555)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 2a722d4fab6a9656f3c03cfdaf6d1684277b8af5 by Miss Islington (bot)
in branch '3.10':
bpo-44317: Improve tokenizer errors with more informative locations (GH-26555)
(GH-27079)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset e14d5ae5447ae28fc4828a9cee8e9007f9c30700 by Filipe LaĆns in
branch 'main':
bpo-29753: revert 0d7ad9f (GH-19850) (GH-27085)
https://github.com/python/cpython/commit/e14d5ae5447ae28fc4828a9cee8e9007f9c30700
--
nosy:
Pablo Galindo Salgado added the comment:
Thanks, Stargirl for opening this issue and for the thorough description and
proposals. I am sympathetic with the idea and the general proposal and
(unsurprisingly) I agree with (1).
For (2) there are some challenges here to consider. The most
Pablo Galindo Salgado added the comment:
For reference, this behaviour lives here:
https://github.com/python/cpython/blob/e14d5ae5447ae28fc4828a9cee8e9007f9c30700/Lib/_sitebuiltins.py#L13-L26
--
___
Python tracker
<https://bugs.python.
Pablo Galindo Salgado added the comment:
Unfortunately, I don't know how that can help because the stack trace is the
same in these two cases:
>>> import traceback
>>> class A:
... def __repr__(self):
... traceback.print_stack()
>>> A()
File "
Pablo Galindo Salgado added the comment:
> However, I disagree that "exit" should not be a special case.
But a special case of *what*? How would you implement this in a
backwards-compatible way?
--
___
Python tracker
<https:/
Pablo Galindo Salgado added the comment:
IPython and other reprs are an entire abstraction layer on top of Python, which
allows them to do a lot of extra things like implement new commands and alters
a lot of behaviours, but the CPython REPL is just the interpreter evaluating
commands, and
Pablo Galindo Salgado added the comment:
For reference, IPython has an entire interception + filtering mechanism to auto
call certain functions:
https://github.com/ipython/ipython/blob/0e4d6390b2174fb1b352a082b72ad387ae696e87/IPython/core/prefilter.py#L414-L425
where exit is one instance of
Pablo Galindo Salgado added the comment:
> would be in the REPL layer by special-casing `exit`
Unfortunately, there is no REPL *layer* as my previous comments mentioned.
There is a few details that change for interactive mode but fundamentally the
pipeline is the same as reading from a f
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25644
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27096
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
One thing we *could* do which is not super invasive, is to match a single AST
node of type NAME at the end of Python run. This seems to work but is a bit
inelegant:
>>> print(exit)
Use exit() or Ctrl-D (i.e. EOF) to exit
>>> [ex
Pablo Galindo Salgado added the comment:
> I do want to be cautious of saying that we can't do it because of the way the
> REPL is currently implemented- which appears to be an implementation driven
> by convenience more than necessity.
Apologies if I have not been clear o
Pablo Galindo Salgado added the comment:
> Are there any downsides to doing it this way? It seems tightly scoped and
> with minimal overhead.
We also need to support quit(), if we go this route.
It makes parsing in the REPL a bit slower because it needs to check for this at
every c
Pablo Galindo Salgado added the comment:
Since Paul is +1 if another core dev (or devs) are +1 as well with the approach
in PR27096 I would feel confident to proceed with this. Alternatively, we could
discuss this more generally in python-dev if someone feels that we should have
a more open
Pablo Galindo Salgado added the comment:
New changeset 1890dd235f618d60c938f6904d2e1a8a56f99c1c by Batuhan Taskaya in
branch 'main':
bpo-43950: Specialize tracebacks for subscripts/binary ops (GH-27037)
https://github.com/python/cpython/commit/1890dd235f618d60c938f6904d2e1a
Pablo Galindo Salgado added the comment:
New changeset 9c3eaf88dc5d5bed80cc45936de06b7b3162bc6d by Ammar Askar in branch
'main':
bpo-43950: Add documentation for PEP-657 (GH-27047)
https://github.com/python/cpython/commit/9c3eaf88dc5d5bed80cc45936de06b
Pablo Galindo Salgado added the comment:
Thanks Steven for your input and your comments and for expressing your
concerns. I will hold the PR then until there is consensus on how to proceed
and all concerns are addressed (eventually closing it if there isn't consensus).
I'm any cas
Pablo Galindo Salgado added the comment:
Marking as release blocker for the first release candidate.
Ned, I assume this comes from some recent bug report in coverage, but it would
be great if you could ask your users to test the latest beta and report any
issue before we release the first
Pablo Galindo Salgado added the comment:
I assume this is due to some artificial bytecode for cleaning the variable in
the exception
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 4a0f1df9527f7d67064d33f5366476b3c93dc86c by Miss Islington (bot)
in branch '3.10':
bpo-44472: Fix ltrace functionality when exceptions are raised (GH-26822)
(GH-26830)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 425756abdc03263ab3a52b068befd1ddb16c2dd2 by Miss Islington (bot)
in branch '3.10':
bpo-44572: On Windows, disconnect STDIN in platform._syscmd_ver() to prevent
erroneous STDIN consumption (GH-27092) (GH-27124)
https://github.
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 054e9c84ac7c394941bba3ea1829d14dce1243fc by Serhiy Storchaka in
branch 'main':
bpo-33346: Allow async comprehensions inside implicit async comprehensions
(GH-6766)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
nosy: +brandtbucher
___
Python tracker
<https://bugs.python.org/issue44617>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue44626>
___
___
Py
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue44622>
___
___
Py
Pablo Galindo Salgado added the comment:
Marking as a release blocker. Mark, please take a look at your earliest
convenience
--
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
New changeset 3048b8bd2a5c62b9c65ff4cf75399c7e732acdea by Miss Islington (bot)
in branch '3.10':
bpo-44639: fix typo in sqlite.rst (transation => transaction) (GH-27145)
(GH-27148)
https://github.com/python/c
Pablo Galindo Salgado added the comment:
New changeset 421b543311c2eee67482bba894e475a2696423d5 by Miss Islington (bot)
in branch '3.9':
bpo-44639: fix typo in sqlite.rst (transation => transaction) (GH-27145)
(GH-27149)
https://github.com/python/c
Pablo Galindo Salgado added the comment:
New changeset d59d7374a364c4e5c2b9a83d8e4543ee494285b8 by Shane Harvey in
branch 'main':
bpo-34932: Add socket.TCP_KEEPALIVE for macOS (GH-25079)
https://github.com/python/cpython/commit/d59d7374a364c4e5c2b9a83d8e4543ee494285b8
-
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 5007a4f23c551f8821483d15e76d0d15d5cb9945 by Erlend Egeberg
Aasland in branch 'main':
bpo-44641: Use vectorcall in sqlite3 collation callback (GH-27158)
https://github.com/python/cpython/commit/5007a4f23c551f8821483d15e76d0d
Pablo Galindo Salgado added the comment:
New changeset a86f7dae0acf918d54086cb85e5a0b0bedeedce7 by Mark Shannon in
branch 'main':
bpo-44626: Merge basic blocks earlier to enable better handling of exit blocks
without line numbers (GH-27138)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 919ad537510fdc2c750109e0bc4eceea234324b2 by Batuhan Taskaya in
branch 'main':
bpo-43950: make BinOp specializations more reliable (GH-27126)
https://github.com/python/cpython/commit/919ad537510fdc2c750109e0bc4ece
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 0e349ea5541104c76cafc173bfcfef8de872f96f by Mark Shannon in
branch '3.10':
[3.10] bpo-44645: Check for interrupts on any potentially backwards edge.
(GH-27167) (GH-27183)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
New changeset 37686f78ccef5f1cf4776419a4270cf0ea7eadf0 by Mark Shannon in
branch '3.10':
bpo-44626: Merge basic blocks earlier to enable better handling of exit blocks
without line numbers (GH-27138) (GH-27182)
https://github.com/pyth
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset 8ce3008585feed51bd08ec256a19923940d744d4 by Ammar Askar in branch
'main':
bpo-44569: Decouple frame formatting in traceback.py (GH-27038)
https://github.com/python/cpython/commit/8ce3008585feed51bd08ec256a1992
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
PR 27167 hangs or fails. in the refleak buildbots, so I am going to proceed to
revert
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Change by Pablo Galindo Salgado :
--
pull_requests: +25729
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/27194
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
To reproduce the problem:
./python -m test test_threading -R : -
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Pablo Galindo Salgado :
--
Removed message: https://bugs.python.org/msg397640
___
Python tracker
<https://bugs.python.org/issue44645>
___
___
Python-bug
Pablo Galindo Salgado added the comment:
To reproduce the problem:
$./python -m test test_threading -R : -v
...
test_original_excepthook (test.test_threading.ExceptHookTests) ... ok
test_system_exit (test.test_threading.ExceptHookTests) ... ok
test_can_interrupt_tight_loops
Pablo Galindo Salgado added the comment:
For attribute errors we just call dir() on the object and we do a suggestion
based on the names so if a name appears in the dir() then we will consider it
for the suggestion.
--
___
Python tracker
<ht
Pablo Galindo Salgado added the comment:
> Maybe don't print the "Did you mean" part if the suggestion is the same as
> the requested attribute?
I think this is a good idea and will take care of many other similar cases.
Thanks for the suggestion, Eric
Change by Pablo Galindo Salgado :
--
keywords: +patch
pull_requests: +25732
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27197
___
Python tracker
<https://bugs.python.org/issu
Pablo Galindo Salgado added the comment:
> it would be nicer if the version with the suggestion were more like the
> version without the suggestion
Agreed, but that is actually not related with the suggestions. We only append a
string at the end of whatever exception it was there
Pablo Galindo Salgado added the comment:
Ah, this is our friend _PyPegen_byte_offset_to_character_offset. I am glad we
refactor it to be used by the Parser and the traceback mechanism. Ammar, would
you like to take a look?
--
___
Python tracker
Pablo Galindo Salgado added the comment:
New changeset 6714dec5e104bdee4a0ed4d9966de27d1bfa1e3d by Pablo Galindo Salgado
in branch 'main':
bpo-44655: Don't include suggestions for attributes that are the same as the
missing one (GH-27197)
https://github.com/python
Pablo Galindo Salgado added the comment:
New changeset a0b1d401db52391d13479c53ee3880e6640df98c by Miss Islington (bot)
in branch '3.10':
bpo-44655: Don't include suggestions for attributes that are the same as the
missing one (GH-27197) (GH-27198)
https://github.com/python
Change by Pablo Galindo Salgado :
--
pull_requests: +25734
pull_request: https://github.com/python/cpython/pull/27199
___
Python tracker
<https://bugs.python.org/issue44
Pablo Galindo Salgado added the comment:
We can probably leverage the unicodedata_UCD_east_asian_width_impl function in
the unicodedata extension module to get the width of every character as emojis
normally take 2 characters in the terminal. We could expose the necessary
functions from
Pablo Galindo Salgado added the comment:
New changeset f783428a2313a729ca8b539c5a86ff114b9ff375 by Pablo Galindo Salgado
in branch 'main':
bpo-44655: Include the name of the type in unset __slots__ attribute errors
(GH-27199)
https://github.com/python/cpyt
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Pablo Galindo Salgado added the comment:
New changeset efda9054b9fc91e69ecb34eae84fdd2ca8e6feef by Miss Islington (bot)
in branch '3.10':
bpo-44655: Include the name of the type in unset __slots__ attribute errors
(GH-27199) (GH-27201)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
Is something left here?
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue44589>
___
___
Python-bug
Change by Pablo Galindo Salgado :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 7.0 -> 8.0
pull_requests: +25773
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +25769
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issue43
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 4.0 -> 5.0
pull_requests: +25771
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 7.0 -> 8.0
pull_requests: +25774
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 5.0 -> 6.0
pull_requests: +25776
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 6.0 -> 7.0
pull_requests: +25770
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 8.0 -> 9.0
pull_requests: +25772
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 4.0 -> 5.0
pull_requests: +25777
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
nosy: +pablogsal
nosy_count: 10.0 -> 11.0
pull_requests: +25775
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issu
Change by Pablo Galindo Salgado :
--
pull_requests: +25778
pull_request: https://github.com/python/cpython/pull/27228
___
Python tracker
<https://bugs.python.org/issue35
Change by Pablo Galindo Salgado :
--
pull_requests: -25777
___
Python tracker
<https://bugs.python.org/issue44040>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25778
___
Python tracker
<https://bugs.python.org/issue35753>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25774
___
Python tracker
<https://bugs.python.org/issue32822>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25775
___
Python tracker
<https://bugs.python.org/issue42686>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25771
___
Python tracker
<https://bugs.python.org/issue44001>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25776
___
Python tracker
<https://bugs.python.org/issue40297>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25769
___
Python tracker
<https://bugs.python.org/issue43822>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25772
___
Python tracker
<https://bugs.python.org/issue38352>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25770
___
Python tracker
<https://bugs.python.org/issue44018>
___
___
Python-bugs-list mailing list
Unsub
Change by Pablo Galindo Salgado :
--
pull_requests: -25773
___
Python tracker
<https://bugs.python.org/issue44025>
___
___
Python-bugs-list mailing list
Unsub
Pablo Galindo Salgado added the comment:
New changeset fbc349ff790c21f1a59af939d42033470790c530 by Batuhan Taskaya in
branch 'main':
bpo-43950: Distinguish errors happening on character offset decoding (GH-27217)
https://github.com/python/cpyt
Pablo Galindo Salgado added the comment:
I will push a fix today
--
___
Python tracker
<https://bugs.python.org/issue42854>
___
___
Python-bugs-list mailin
1301 - 1400 of 4563 matches
Mail list logo