[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-21 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : Trying to build latest development revision: localhost:repo family$ hg summary parent: 73044:a985d733b3a3 tip #12753: Add support for Unicode name aliases and named sequences. branch: default commit: (clean) update: (current) Constantly getting this

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-21 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Oh yes. I am building with this command line: ./configure --with-pydebug && make -j2 -- ___ Python tracker <http://bugs.python.org

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Thank you all for help. I finally managed to build it. :-) So here are complete steps I've taken to build python after OS reinstall: 1. Install XCode 4.2 2. Install MacPorts 3. sudo port -v selfupdate 4. sudo port install gcc46 5. ./configure CC=gcc-m

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- resolution: -> works for me ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Un

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- status: open -> pending ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscri

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- resolution: works for me -> fixed status: pending -> open ___ Python tracker <http://bugs.python.org/issue13241> ___ ___

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- status: open -> pending ___ Python tracker <http://bugs.python.org/issue13241> ___ ___ Python-bugs-list mailing list Unsubscri

[issue13241] Assertion failed in _PyUnicode_CheckConsistency during build of default branch on Mac OS X

2011-10-23 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Ah, of course. Initially I've tried to compile using this: i686-apple-darwin10-llvm-gcc-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.1.00) XCode version 4.2, build 4C199 -- ___ P

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-12 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : I've increased coverage of aifc.py by test_aifc.py: before: [1/1] test_aifc lines cov% module (path) 56063% aifc (/Users/family/Documents/code/python/repo/Lib/aifc.py) ... after: [1/1] test_aifc lines cov% module (path) 561

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-13 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Thanks for your review, Ezio! Here goes new patch with all issues you've mentioned been fixed. -- Added file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker <http://bugs.py

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-20 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23678/test_aifc2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-20 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: 1. Test coverage increased to 95%. 2. G722 compressed files reading in aifc.py fixed (it used to use 0 bytes frame size). 3. audioop's ulaw2lin, alaw2lin and adpcm2lin length checks fixed (width should be used for output only, because input sequence

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-20 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23677/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-20 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Minor style fixes -- Added file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-11-20 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23733/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13438] "Delete patch set" review action doesn't work

2011-11-20 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : I got following error when trying to delete outdated patch set: Environment: Request Method: POST Request URL: http://bugs.python.org/review/13394/patchset/3680/delete Django Version: 1.1.1 SVN-17047 Python Version: 2.5.2 Installed Applications

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23734/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-12-12 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Sounds perfectly reasonable. Here goes the first patch with pure test coverage. -- Added file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : 1. Fixed _write_float to handle infinity, NaN and negative numbers correctly. 2. Renamed _write_long to _write_ulong because it actually writes unsigned value. 3. Added _read_ushort as counterpart of _write_ushort. This is never used anywhere except test

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Patch must be applied after http://bugs.python.org/file23931/test_aifc.patch from issue 13394. Not sure if review tool can handle this correctly. -- ___ Python tracker <http://bugs.python.org/issue13

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Second patch goes to issue 13589 -- ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailin

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-12-12 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Second patch goes to issue 13589 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailin

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bugs-list mailing list Unsubscri

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23931/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage with couple of minor fixes

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23934/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Forget about "patch must be applied before" thing. I've made independent patch. :-) -- Added file: http://bugs.python.org/file23935/aifc_numbers_fix.patch ___ Python tracker <http://bugs.pyt

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23932/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Pytho

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23935/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Pytho

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23939/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bug

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23939/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Pytho

[issue13589] Aifc float serialization fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file23940/aifc_numbers_fix.patch ___ Python tracker <http://bugs.python.org/issue13589> ___ ___ Python-bug

[issue13589] Aifc low level serialization primitives fix

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- title: Aifc float serialization fix -> Aifc low level serialization primitives fix ___ Python tracker <http://bugs.python.org/issu

[issue13394] Patch to increase aifc lib test coverage

2011-12-12 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : -- title: Patch to increase aifc lib test coverage with couple of minor fixes -> Patch to increase aifc lib test coverage ___ Python tracker <http://bugs.python.org/issu

[issue13594] Aifc markers write fix

2011-12-13 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : 1. Markers serialization test coverage improved. 2. Marker name changed from string to bytes, because _write_string function uses bytes. 3. Check for closed file handle moved to 'close' method, because otherwise I caught 'attempt to write

[issue13394] Patch to increase aifc lib test coverage

2011-12-13 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file23934/test_aifc.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage

2011-12-13 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: The split is in progress. There will be at least two more patches. Regarding your comments: 1) Sorry for my english :-) It is fully determined by the input. With this particular test input the assertNotEqual will always pass. So I've removed it. 2)

[issue13394] Patch to increase aifc lib test coverage

2011-12-13 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Third patch goes to issue 13594 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailin

[issue13680] Aifc comptype write fix

2011-12-30 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : Two changes have been made to the library: 1. Lowercase compression type support have been added to the sample width validation routine during write operation. Everywhere else compression types are used in both lowercase and uppercase. 2. Redundant

[issue13394] Patch to increase aifc lib test coverage

2011-12-30 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Fourth patch goes to issue 13680 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bugs-list mailin

[issue13681] Aifc read compressed frames fix

2011-12-30 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : This patch resolves two issues: 1. ADPCM compressed audio files reading. Such files have frame size of 4 bits. Aifc lib cannot represent 4 bits frame size because it uses integer bytes count variable. I have replaced it with bits count. 2. ALAW/ULAW

[issue13681] Aifc read compressed frames fix

2011-12-30 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: I have put changes to both aifc and audioop module in this single patch. The reason is that aifc test reading compressed frames will work properly only after audioop fix has been applied. -- ___ Python tracker

[issue13394] Patch to increase aifc lib test coverage

2011-12-30 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: The last, fifth, patch goes to issue 13681 -- ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13589] Aifc low level serialization primitives fix

2012-01-17 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: I have absolutely no idea :-) I just covered every line of code with tests. Some bugs prevented me from do it, so I fixed them. -- ___ Python tracker <http://bugs.python.org/issue13

[issue13806] Audioop decompression frames size check fix

2012-01-17 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : According to documentation (http://docs.python.org/library/audioop.html), adpcm2lin, alaw2lin and ulaw2lin are using 'width' argument to represent output frames width. However, in audioop.c module there are checks that are raising exception

[issue13681] Aifc read compressed frames fix

2012-01-17 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24112/aifc_compression.patch ___ Python tracker <http://bugs.python.org/issue13681> ___ ___ Pytho

[issue13681] Aifc read compressed frames fix

2012-01-17 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Ok, I have opened issue 13806 with audioop fix alone. However, I cannot change current issue's dependencies to reflect that current issue depends on issue 13806. Could anyone do this for me please? -- Added file: http://bugs.python.org/file

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24260/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Pytho

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Yep, you're right. Didn't noticed audioop_check_size() function at first. The fact that audioop accepts unicode strings seems weird to me too. I've replaced strings with bytes in tests. However, I'm afraid to add restrictions to libra

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24284/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Pytho

[issue13806] Audioop decompression frames size check fix

2012-01-19 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Pytho

[issue13806] Audioop decompression frames size check fix

2012-01-27 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24285/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13806> ___ ___ Pytho

[issue13806] Audioop decompression frames size check fix

2012-01-27 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Yes, that tests really should be there too. Added them to patch. -- Added file: http://bugs.python.org/file24344/audioop_size_check.patch ___ Python tracker <http://bugs.python.org/issue13

[issue14089] Patch to increase fractions lib test coverage

2012-02-22 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : The last few missing bits to complete test coverage of 'fractions.py' library. ./python.exe -E -Wd -m test -v -T -D ../coverage/test_fractions test_fractions lines cov% module (path) 270 100% fractions (/Users/family/Documents/c

[issue14089] Patch to increase fractions lib test coverage

2012-02-24 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24605/test_fractions.patch ___ Python tracker <http://bugs.python.org/issue14089> ___ ___ Python-bug

[issue14089] Patch to increase fractions lib test coverage

2012-02-24 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24630/test_fractions.patch ___ Python tracker <http://bugs.python.org/issue14089> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage

2012-02-29 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: For convenience I have uploaded the separate patch without warnings. Which means that it will generate some output during tests run. -- Added file: http://bugs.python.org/file24691/test_aifc_3_2.patch ___ Python

[issue13394] Patch to increase aifc lib test coverage

2012-02-29 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file24691/test_aifc_3_2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue13394] Patch to increase aifc lib test coverage

2012-02-29 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file24692/test_aifc_3_2.patch ___ Python tracker <http://bugs.python.org/issue13394> ___ ___ Python-bug

[issue14796] Calendar module test coverage improved

2012-05-13 Thread Oleg Plakhotnyuk
New submission from Oleg Plakhotnyuk : I've improved calendar.py test coverage a bit. Before: 41071% calendar (.../Lib/calendar.py) After: 41077% calendar (.../Lib/calendar.py) -- components: Tests files: test_calendar.patch keywords: patch messages: 160519

[issue14796] Calendar module test coverage improved

2012-05-13 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: Thanks for the review. I'll happily tune the patch myself. Just when I have some spare time again. -- ___ Python tracker <http://bugs.python.org/is

[issue14796] Calendar module test coverage improved

2012-05-18 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file25562/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bug

[issue14796] Calendar module test coverage improved

2012-05-18 Thread Oleg Plakhotnyuk
Oleg Plakhotnyuk added the comment: I didn't event know that there is such a handy assertRaisesRegex context. Many thanks for pointing this out! -- Added file: http://bugs.python.org/file25632/test_calendar.patch ___ Python tracker

[issue14796] Calendar module test coverage improved

2012-05-25 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Removed file: http://bugs.python.org/file25632/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bug

[issue14796] Calendar module test coverage improved

2012-05-25 Thread Oleg Plakhotnyuk
Changes by Oleg Plakhotnyuk : Added file: http://bugs.python.org/file25705/test_calendar.patch ___ Python tracker <http://bugs.python.org/issue14796> ___ ___ Python-bug