[issue2403] Add figleaf coverage metrics

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Thanks for the patch. It would be nice to get more instrumentation like coverage, performance, etc. Here are some things I noticed while reviewing the patch: * This won't work on unix other than OSX. Can you change ../../py

[issue2409] regrtest should not just skip imports that fail

New submission from Neal Norwitz <[EMAIL PROTECTED]>: Guido mentioned this in python-3000-checkins. I agree the problem should be fixed. """ I think the automatic skip on ImportError is harmful. We should add a helper function to test_support so that

[issue2403] Add figleaf coverage metrics

Neal Norwitz <[EMAIL PROTECTED]> added the comment: > * ../../python.exe changed to sys.executable. > * Figleaf is 69kb. It seems to work fine doing it all in one read() > call. Should it be chunked? At 69kb, nah. It should be good enough for the first cut. > * O

[issue2183] optimize list comprehensions

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Ya, I'll get around to it...hopefully soon. But if someone wants to do it for me, I won't complain. :-) __ Tracker <[EMAIL PROTECTED]> <http://

[issue1068881] TclError not a subclass of StandardError

Neal Norwitz <[EMAIL PROTECTED]> added the comment: StandardError has been removed from Python 3.0. It's use is deprecated. Instead of catching StandardError, do: try: # ... except Exception: # ... -- assignee: loewis -> nnorwitz nosy: +nnorwitz resoluti

[issue2470] Need fixer for dl (removed) -> ctypes module

New submission from Neal Norwitz <[EMAIL PROTECTED]>: r61837 removed the dl module. It needs a 2to3 fixer written to use ctypes. -- assignee: collinwinter components: 2to3 (2.x to 3.0 conversion tool) messages: 64394 nosy: collinwinter, nnorwitz priority: critical severity:

[issue2477] parser support for future import of unicode_strings

New submission from Neal Norwitz <[EMAIL PROTECTED]>: This is a patch that modifies the parser to allow getting the future import flags into the AST. There are 2 approaches that are embedded within the patch. Both approaches can be seen in Python/pythonrun.c. 1) update_flags_fro

[issue2491] io.open() handles errors differently on different platforms

New submission from Neal Norwitz <[EMAIL PROTECTED]>: The attached file has a snapshot of the python.org homepage that was causing test_urllibnet to fail on some platforms (2 sparc, and ia64 at least), but not other platforms. This should be handled consistently. I don't know i

[issue2459] speedup loops with better bytecode

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Antoine, I hope to look at this patch eventually. Unfortunately, there are too many build/test problems that need to be resolved before the next release. If you can help out with those, I will be able to review this patch

[issue1503] test_xmlrpc is still flakey

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Ugh. The manpage for accept on Ubuntu 6.10 says: """ On Linux, the new socket returned by accept() does not inherit file status flags such as O_NONBLOCK and O_ASYNC from the listening socket. This behaviour diffe

[issue2477] parser support for future import of unicode_strings

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Christian checked this in a few days ago in r61953 and a few other revisions. -- resolution: -> accepted status: open -> closed __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue1631171] implement warnings module in C

Neal Norwitz <[EMAIL PROTECTED]> added the comment: I didn't realize this was waiting for me. You should have just checked it in, that would have gotten me to review faster. :-) pythonrun.c: * Should PyModule_GetWarningsModule() return a valid pointer? * The code below crashe

[issue1631171] implement warnings module in C

Neal Norwitz <[EMAIL PROTECTED]> added the comment: On Tue, Apr 1, 2008 at 6:14 AM, Brett Cannon <[EMAIL PROTECTED]> wrote: > > Brett Cannon <[EMAIL PROTECTED]> added the comment: > > Neal's issues are addressed in this patch. I also finally filled out &

[issue1179] [CVE-2007-4965] Integer overflow in imageop module

Neal Norwitz <[EMAIL PROTECTED]> added the comment: I think this was a module that I skipped. I think Anthony might have had a patch, but if we have a fix, I'm not sure it matters. We need to fix this for 2.5.3, upping the priority. -- nosy: +anthonybaxter priority: high

[issue2515] Segfault while operating on closed sqlite3 cursor.

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Gerhard, could you take a look? -- assignee: -> ghaering nosy: +ghaering, nnorwitz __ Tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2515] Segfault while operating on closed sqlite3 cursor.

Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: -> release blocker __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2515> __ ___ Pyt

[issue2526] str.format() :n format does not appear to work

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Eric, could you take a look? -- assignee: -> eric.smith nosy: +eric.smith, nnorwitz priority: -> high __ Tracker <[EMAIL PROTECTED]> <http://bugs

[issue2546] Python-2.5.2: crash in visit_decref () at Modules/gcmodule.c:270

Neal Norwitz <[EMAIL PROTECTED]> added the comment: I'm setting the priority to release blocker for now. George, please provide a way for us to reproduce with a stock python (ie, no third party extensions). Thanks. -- nosy: +nnorwitz priority: -> r

[issue2548] Undetected error in exception handling

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Brett, didn't you have a similar problem you fixed a while ago? I assigned to you for more input, feel free to reset to nobody. -- assignee: -> brett.cannon nosy: +brett.cannon, nnorwitz priority: ->

[issue2538] memoryview of bytes is not readonly

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Travis, could you take a look? -- assignee: -> teoliphant nosy: +nnorwitz, teoliphant __ Tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2550] SO_REUSEADDR doesn't have the same semantics on Windows as on Unix

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Trent, go ahead and try this out. We should definitely be moving in this direction. So I'd rather fix the problem than keep suffering with the current problems of not being able to run the test suite concurrently. I think bind_po

[issue2611] Extend buildbot web interface to allow for forced tests to be run on a slave in verbose mode.

Neal Norwitz <[EMAIL PROTECTED]> added the comment: > I think this will be fairly difficult to set up. If the clean buildstep > had been executed, you would have to rerun configure and compile before > you can run any tests. We could re-order and do clean first. That woul

[issue2235] __eq__ / __hash__ check doesn't take inheritance into account

Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- assignee: amaury.forgeotdarc -> gvanrossum __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2235> __ __

[issue2541] Unicode escape sequences not parsed in raw strings.

Neal Norwitz <[EMAIL PROTECTED]> added the comment: What is the status of this bug? AFAICT, the code is now correct. Have the doc changes been applied? The resolution on this report should be updated too. It's currently rejected. -- nosy

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Bumping the priority. I'd like to see this fixed before the next release. What version(s) does this problem apply to: 2.5, 2.6, 3.0? -- nosy: +nnorwitz priority: critical -> release blocker

[issue2601] [regression] reading from a urllib2 file descriptor happens byte-at-a-time

Neal Norwitz <[EMAIL PROTECTED]> added the comment: So if the fix was applied to 2.5 branch and 2.6 (3.0 should have picked up from 2.6 automatically), can we close this bug? __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue1496032] test_float segfaults with SIGFPE on FreeBSD 6.0 / Alpha

Neal Norwitz <[EMAIL PROTECTED]> added the comment: I think `uname -m` will be equal to "alpha" in this case. There are several uses of `uname -m` in configure.in. You might need to add a new section. It might also be possible to clean up various special cases to make a g

[issue2772] Add PendingDeprecationWarning for % formatting

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Why not use the normal recursion check mechanism? Specifically, if (Py_EnterRecursiveCall("unicode % ")) return NULL; // err = Warn(); Py_LeaveRecursiveCall(); I don't see where the

[issue2222] Memory leak in os.rename?

Changes by Neal Norwitz <[EMAIL PROTECTED]>: -- priority: normal -> critical __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue> __ ___ Pyt

[issue4264] Patch: optimize code to use LIST_APPEND instead of calling list.append

Neal Norwitz <[EMAIL PROTECTED]> added the comment: Interesting approach. I was surprised to see the change to the AST, but I understand why you did it. I think if the AST optimization approach works out well, we will want to have some more general mechanism to communicate these optimi

[issue4582] type of __builtins__ changes if in main module or not

New submission from Neal Norwitz <[EMAIL PROTECTED]>: This happens on 2.4 and 3.0, probably all versions: When running this simple program (save to a file): print(type(__builtins__)) __import__(__file__.split('/')[-1][:-3]) I get: I would expect the type to be consiste

[issue4597] EvalFrameEx fails to set 'why' for some exceptions

Neal Norwitz <[EMAIL PROTECTED]> added the comment: The patch looks good. These problems also apply to 2.5 I assume? You might want to ping MvL to let him know since he's about to cut that release. -- keywords: -needs review nosy

[issue5023] Segfault in datetime.time.strftime("%z")

Neal Norwitz added the comment: Can you debug this problem any further? What is the C call stack? Does the problem occur if you build in debug mode (./configure --with-pydebug)? Does the problem occur with a different compiler (if you have access to another one on the same box

[issue13764] Misc/build.sh is outdated... talks about svn

Neal Norwitz added the comment: If this script isn't used any more, it should be removed. On Fri, Jan 13, 2012 at 8:31 AM, Antoine Pitrou wrote: > > Antoine Pitrou added the comment: > > I think the script was used by the "period regression test" crontask that >

[issue17068] peephole optimization for constant strings

New submission from Neal Norwitz: I was looking through code like this: foo = '%s%s%s' % ('https://', host, uri) and realized this could be rewritten by the interpreter as: foo = 'https://%s%s' % (host, uri) I tried to determine how much code this might

[issue7008] str.title() misbehaves with apostrophes

Neal Norwitz added the comment: I don't recall anything specifically wrt removing capwords. Most likely it was something that struck me as not widely used or really necessary--a good candidate to be removed. Applications could then write the fucntion however they chose which would avoi

[issue17335] FieldStorageClass is messed up

New submission from Neal Norwitz: This problem goes back to 2.6 at least. In Lib/cgi.py FieldStorageClass = None def read_multi(self, environ, keep_blank_values, strict_parsing): """Internal: read a part that is itself multipart.""" ib =

[issue17430] missed peephole optimization

New submission from Neal Norwitz: >>> def fo(): ... if a: ... if b: ... if c: ...print ... >>> dis.dis(fo) 2 0 LOAD_GLOBAL 0 (a) 3 POP_JUMP_IF_FALSE 28 3 6 LOAD_GLOBAL 1 (

[issue17607] missed peephole optimization (unnecessary jump at end of function after yield)

New submission from Neal Norwitz: >>> def foo(): ... if x: ... yield None ... >>> dis.dis(foo) 2 0 LOAD_GLOBAL 0 (x) 3 POP_JUMP_IF_FALSE 14 3 6 LOAD_CONST 0 (None) 9 YIELD_VALUE

<    1   2