New submission from Nadeem Vawda:
The __init__() function for asynchat.async_chat doesn't allow the caller
to specify a channel map. I thought it would make sense to add an
optional 'map' parameter, for consistency with asyncore.dispatcher. If
the parameter i
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23129/fe2c9998f329.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Nadeem Vawda added the comment:
I've attached another patch (fe2c9998f329.diff) with a more complete
implementation of the lzma module. All that's left now is to write the
documentation, and make sure that the module can build
Nadeem Vawda added the comment:
I've committed your patches. I took the liberty of removing the
"versionadded" tag for ZLIB_VERSION; I don't think many people will need
to worry about compatibility with Python 1.5 ;-)
Once again, thanks for the patches!
--
assign
Nadeem Vawda added the comment:
Issue 12785 has a patch for the test_database failures.
--
___
Python tracker
<http://bugs.python.org/issue12678>
___
___
Pytho
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23158/95016f363e6c.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23159/3017ee1d548d.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23158/95016f363e6c.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23063/f3cf187208ea.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23129/fe2c9998f329.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Nadeem Vawda added the comment:
I've attached another patch that includes proper ReST documentation, a
few more tests, and some fixups following Ezio and Amaury's reviews.
--
stage: needs patch -> patch review
___
Python t
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23168/591277fe6b4a.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23159/3017ee1d548d.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Nadeem Vawda added the comment:
Thanks for getting the ball rolling with that. I'll want to try and
familiarize myself with the code for tarfile module before I start
changing stuff, but those points shouldn't be hard to fix, one way
or
Nadeem Vawda added the comment:
Ah, sorry about that. It probably wasn't necessary to regenerate the
patch after I addressed the comments in each review. The patch should be
stable now; I don't plan to make any further changes for a while.
(At some point I'll want to add a few
Nadeem Vawda added the comment:
Ozan: Thanks for taking the time to backport the patch. Unfortunately, as
Éric said, 2.7 is in maintenance mode, so it no longer receives new features.
--
___
Python tracker
<http://bugs.python.org/issue1
Nadeem Vawda added the comment:
> This is all fine and well, but this is clearly a bug and not a feature.
No, it is not at all clear that this is a bug. I agree that this is a desirable
capability to have, but nowhere does the module claim to support multi-stream
files.
Nor is it an inher
Nadeem Vawda added the comment:
> Change reverted. "make test" should run a comprehensive test of
> Python's facilities
Fair enough.
> If it is easy to detect network availability programmatically, we could
> just use the skip system.
+1. I don't know if ther
Nadeem Vawda added the comment:
Thanks for investigating the Windows situation.
> - liblzma can't be compiled by Visual Studio: too many C99 isms, mostly
> variables declared in the middle of a block. It's doable for sure, but it's a
> lot of work.
I don't thi
Nadeem Vawda added the comment:
Oh, neat. I'll take a look at that when I get a chance.
--
assignee: -> nadeem.vawda
___
Python tracker
<http://bugs.python.org
Nadeem Vawda added the comment:
Wow, this discussion has gotten quite busy while I've been travelling...
Martin, could you explain what the problems are with bundling a precompiled DLL
for Windows? I am willing to do the work of getting liblzma to compile with VS
if necessary, but I don&#
Nadeem Vawda added the comment:
Hmm... according to
http://git.tukaani.org/?p=xz.git;a=blob;f=windows/README-Windows.txt;hb=HEAD#l80,
the MinGW-compiled static libs *can* be used with MSVC. Not sure how
reliable the information is, but it's worth a try at
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue13150>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
Awesome stuff! I'll post an updated patch during the course of the day.
Martin: I've been having problems with Rietveld lately, so I'm posting
my replies to your comments here instead.
>> Modules/_lzmamodule.c:115: return _PyBytes_Resize
New submission from Nadeem Vawda :
As mentioned in issue 6715, the buffer growth strategy used by _io.FileIO
has quadratic running time if each reallocation is O(n). The code in
question is new_buffersize() from Modules/_io/fileio.c:
if (currentsize > SMALLCHUNK) {
/* Keep doubl
Nadeem Vawda added the comment:
> To elaborate on the policy: giving bogus data in cases of race
> conditions is ok; crashing the interpreter or corrupting memory
> is not. If bogus data is given, it would be useful if the bogosity
> can be specified (e.g. when multiple threads r
Nadeem Vawda added the comment:
I've attached a patch that makes the suggested change to FileIO, and also
to _bz2.BZ2Compressor/Decompressor (which currently have the same issue).
--
keywords: +patch
Added file: http://bugs.python.org/file23389/buffer-growth
Changes by Nadeem Vawda :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue13159>
___
___
Python-bugs-list mailing list
Un
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23393/bdf0afbbbd80.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23168/591277fe6b4a.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Nadeem Vawda added the comment:
Patch update time! Noteworthy changes:
* Windows build support, thanks to Amaury
* Thread safety for LZMACompressor and LZMADecompressor, by means of
per-instance locks
* O(n) buffer growth strategy
I've tried running the tests on Windows, but I've be
Nadeem Vawda added the comment:
No problem :)
--
assignee: -> nadeem.vawda
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Nadeem Vawda added the comment:
Confirmed for 3.3. I should be able to post a patch tomorrow.
--
assignee: -> nadeem.vawda
___
Python tracker
<http://bugs.python.org/issu
Nadeem Vawda added the comment:
After disabling a bunch of services and skipping the tests that are
failing on the Windows buildbots, it seems that the failures I was
getting last week have disappeared. It looks like they were due to the
Windows search indexer preventing temp directories from
Nadeem Vawda added the comment:
Fixed for 2.7, 3.2 and 3.3. Thanks for the bug report!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Nadeem Vawda :
Since upgrading to Ubuntu 11.10, I've been getting the following failures in
test_ssl:
==
FAIL: test_protocol_sslv3 (test.test_ssl.ThreadedTests)
Connecting to an SSLv3 s
Nadeem Vawda added the comment:
> Also, how about the system Python? Does it show the same test failures?
Unfortunately, it seems that the system Python package doesn't install the
test suite; if you try to run "python -m test.regrtest", it complains that
it can'
Nadeem Vawda added the comment:
I get (1, 0, 0, 5, 15) for ssl.OPENSSL_VERSION_INFO. A trivial modification
of Victor's patch doesn't seem to fix the failures for me, though :/
--
___
Python tracker
<http://bugs.python.o
Nadeem Vawda added the comment:
Sorry, that wasn't very coherent. What I meant to say is that I tried this:
if ((ssl.OPENSSL_VERSION_INFO, platform.linux_distribution()) in
[((0, 9, 8, 15, 15), ('debian', 'squeeze/sid', '')),
((1, 0,
Nadeem Vawda added the comment:
> Hmm... I guess Ubuntu may have aliased SSLv23 to SSLv3. Can someone take
> a look at Ubuntu patches to OpenSSL?
I don't know enough about OpenSSL to make sense of the actual headers on my
system without spending more time on it, but it seems like
Nadeem Vawda added the comment:
> The test creates a temporary directory which is inserted at the head of
> sys.path.
> packaging.database.get_distribution should thus find Spamlib-0.1.dist-info.
> Can someone with a Windows install help me with this? Printing sys.path and
Nadeem Vawda added the comment:
The AMD64 FreeBSD 8.2 3.x buildbot has been experiencing sporadic
lockups since changeset 8bbfb24d4824 was committed:
http://www.python.org/dev/buildbot/all/builders/AMD64%20FreeBSD%208.2%203.x/builds/1174/steps/test/logs/stdio
http://www.python.org
Nadeem Vawda added the comment:
Sorry, please disregard my last message - I confused the commit times for
8bbfb24d4824 and f6b8e4226260. There haven't been any further lockups
since f6b8e4226260 was committed.
--
___
Python tracker
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23393/bdf0afbbbd80.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23466/371a133b770a.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Nadeem Vawda added the comment:
This seems to be a duplicate of issue 13193.
--
nosy: +nadeem.vawda
resolution: -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Nadeem Vawda added the comment:
Issue 13230 (closed as duplicate) reports another Linux failure in
test_resources.
Changing the title, since it isn't Windows-specific.
--
nosy: +anikom15
stage: -> needs patch
___
Python tracke
Changes by Nadeem Vawda :
--
title: test_packaging and test_distutils failures under Windows ->
test_packaging and test_distutils failures
___
Python tracker
<http://bugs.python.org/issu
Nadeem Vawda added the comment:
> none of the buildbots are having this problem.
Actually, it turns out the Ubuntu ARM builder is hitting the same failures.
First failure for each branch was on 14 October (the day after 11.10 came out):
http://www.python.org/dev/buildbot/all/builders/
Nadeem Vawda added the comment:
> Spamlib-0.1.dist-info is in a directory on sys.path, so the error makes no
> sense to me. Can you inspect the content of that directory? (i.e os.listdir
> and file contents) Also, if you can interrupt the test to get a Python or
> pdb shell, c
Nadeem Vawda added the comment:
I've been able to consistently reproduce the test_resources failure on Ubuntu
11.10 64-bit, FWIW.
--
___
Python tracker
<http://bugs.python.org/is
Nadeem Vawda added the comment:
> New changeset 3c225f938dae by Barry Warsaw in branch '2.7':
> - Issue #13218: Fix test_ssl failures on Debian/Ubuntu.
> http://hg.python.org/cpython/rev/3c225f938dae
This changeset appears to have broken a number of the 2.7 Linux bu
Nadeem Vawda added the comment:
Marking as duplicate.
--
resolution: -> duplicate
stage: needs patch -> committed/rejected
status: open -> closed
superseder: -> zipfile writes incorrect local file header for large files in
zip64
type: crash
Nadeem Vawda added the comment:
Issue 6434 was marked as a duplicate of this issue.
--
nosy: +Paul, amaury.forgeotdarc, enlavin, lambacck, nadeem.vawda, segfault42
stage: -> needs patch
versions: +Python 3.3 -Python 3.1
___
Python tracker
&l
Nadeem Vawda added the comment:
> I added the packaging.database.clear_cache() at the end of setUp(); that
> works, too.
That fixes the InstallDataTestCase failure for me as well
(on both Ubuntu 11.10 64-bit and Windows 7 64-bit).
> I get the opposite failure to Nadeem
Nadeem Vawda added the comment:
How strange. I've had no problem reproducing the failures; they've
occurred every time I've run test_packaging since the bug was opened
(on both Ubuntu and Windows). And the Windows buildbots seem to be
failing consi
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue13309>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
I'm no longer getting the failures on either Ubuntu or Windows (and the
Windows buildbots are now green), so tentatively marking this as fixed.
Feel free to reopen if something is still broken.
--
resolution: -> fixed
stage: needs patch ->
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue13396>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
Everything is ready to go, as far as I'm concerned. Once I've tested the
Windows build using the binary from the externals repository, I'll be ready
to commit it to the main repository.
--
___
Python
Nadeem Vawda added the comment:
I've tested the Windows build, and it works fine. If there are no objections,
I'll commit on Saturday.
Btw, what is the preferred channel for communicating with buildbot owners?
I'll want to send out an email asking that all the *nix bots h
Changes by Nadeem Vawda :
Added file: http://bugs.python.org/file23732/9276fc685c05.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
Removed file: http://bugs.python.org/file23466/371a133b770a.diff
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Python-bugs-list m
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue13453>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
Victor: Thanks for the review; I've replied to your comments and updated
the patch. Let me know what you think of the changes.
--
___
Python tracker
<http://bugs.python.org/i
Nadeem Vawda added the comment:
The patch has been committed. I'm leaving this issue open for a while
longer, until more of the buildbots are building and testing the module.
--
___
Python tracker
<http://bugs.python.org/i
Nadeem Vawda added the comment:
>> Not meaning to sound petty, but wouldn't it be common etiquette to
>> retain some original copyright notice from original code intact..?
>
> It seemed to me that Nadeem had rewritten everything from scratch. Is
> there any code of y
Nadeem Vawda added the comment:
> Instead of duplicating the list of archiving/compression modules in
> each doc, what about only linking to the shutil doc for archives and
> the archiving.rst file?
Sure, go ahead. I actually hadn't realized that each section of the
library d
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue5411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
> As the docs for zlib, gzip, bz2, lzma, zipfile and tarfile are in the
> archiving subsection, there’s already a link to the subsection index,
> so I just removed the “See also zlib, etc.” lines (except for the link
> from zlib to gzip). I added
Nadeem Vawda added the comment:
> I’ll commit my doc patch to all branches later.
OK, great.
> I checked the 4 red 3.3 builbots and they can’t build _lzma.
For the record, the 3.x buildbots that currently aren't able to build the
_lzma module are:
* x86 Ubuntu Shared
* sparc so
Nadeem Vawda added the comment:
> Ok, I've e-mailed the owners.
Thanks. I was just thinking I should send a reminder, in case they
missed the note in my announcement on python-dev.
> Will someone write an entry in the "what's new
Nadeem Vawda added the comment:
Great stuff! I'll close this issue along with issue 6715 once the buildbot
stuff is all sorted out.
--
___
Python tracker
<http://bugs.python.org/i
Nadeem Vawda added the comment:
Yes, almost half of the buildbots still don't have the xz-utils headers
installed, and thus are not building/testing the lzma module. I've kept
the issue open as a reminder to myself to follow
Nadeem Vawda added the comment:
This failure seems to crop up often, but not on every run:
http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/3941/steps/test/logs/stdio
http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/3940/steps/test/logs/stdio
Nadeem Vawda added the comment:
Not to worry - as I said in my previous message, I can reproduce the error
on my own XP machine.
I also noticed that running test_tarfile alone doesn't trigger the errors,
which leads me to suspect that the failure is due to some interaction with
another
Nadeem Vawda added the comment:
Yes, that's a good idea. I've been testing a similar change, and it seems
to drop the peak memory usage for test_tarfile from around 810MB down to
under 200MB. It looks like 2GB genuinely isn't enough to reliably use LZMA
compression with prese
Nadeem Vawda added the comment:
Patch looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue5689>
___
___
Python-bugs-list mailing list
Unsub
Nadeem Vawda added the comment:
Thanks for the patch. I'll review it tomorrow.
--
___
Python tracker
<http://bugs.python.org/issue1625>
___
___
Python-bugs-l
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12167>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
OK, I'll hold off on doing a detailed review until then.
--
___
Python tracker
<http://bugs.python.org/issue1625>
___
___
Nadeem Vawda added the comment:
> False alarm; go ahead with the review. I took a look too early in the
> morning before caffeine kicked in.
No worries. I know the feeling.
The tests look fine. The bodies of testRead() and testReadMultiStream()
appear to have been swapped, thoug
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12190>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
Committed. Once again, thanks for the patch!
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Nadeem Vawda added the comment:
I seem to be unable to log in to rietveld, so I'll reply here.
>> result += decomp.decompress(data)
> Is this efficient? I understood that other Python implementations
> had poorly performing str.__iadd__, and therefore that using a list
>
Nadeem Vawda added the comment:
> If you’re logged into Roundup, you should automatically be logged into
> our Rietveld instance.
I thought this was the case, but it isn't working for me. I've filed a
bug on the meta-tracker.
--
__
Nadeem Vawda added the comment:
> Also, I want to take a fresh look at the cache strategy (saving diffs
> of two files vs saving file contents individually) and think about
> whether than makes any sense at all for real world use cases
> (is there a common need to compare the sam
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12306>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12309>
___
___
Python-bugs-list mailing list
Unsubscribe:
Nadeem Vawda added the comment:
Yes, the fix I provided only eliminated some of the warnings. As of
fd6446a88fe3, test_urllib2net still leaks 5 sockets.
--
___
Python tracker
<http://bugs.python.org/issue10
Nadeem Vawda added the comment:
Here's an updated patch implementing reference counting for ftpwrapper.
It changes the semantics of ftpwrapper.close() to postpone actually closing
the connection until all files have also been closed (like socket.close()).
--
Added file:
Changes by Nadeem Vawda :
--
resolution: -> accepted
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue10883>
___
___
Python-bugs-
Nadeem Vawda added the comment:
The failure seems to occur sporadically. I'm looking into it.
--
___
Python tracker
<http://bugs.python.org/issue10883>
___
___
Nadeem Vawda added the comment:
The problem seems to be that CacheFTPHandler inherits ftp_open() from
FTPHandler - FTPHandler.ftp_open() marks the ftpwrapper object to be closed as
soon as the current transfer is complete. So CacheFTPHandler's cache ends up
full of closed ftpwrappers. I
Nadeem Vawda added the comment:
Updated patch with fixed refcounting mechanism. Also fixes clear_cache() in
CacheFTPWrapper to leave the cache in a consistent state for subsequent use.
--
Added file: http://bugs.python.org/file22609/issue10883-v2.patch
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12576>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Nadeem Vawda :
--
resolution: accepted -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Nadeem Vawda :
--
nosy: +nadeem.vawda
___
Python tracker
<http://bugs.python.org/issue12646>
___
___
Python-bugs-list mailing list
Unsubscribe:
1 - 100 of 535 matches
Mail list logo
