New submission from Milan Oberkirch:
Accorcing to coveragepy there was only one line missing for full line coverage
in Lib/email/policy.py so I added an test to cover it.
It checks that the function email.policy.EmailPolicy.header raises an
ValueError if the second parameter includes newlines
Milan Oberkirch added the comment:
changed 'bytes' and 'byte string' to `bytes-like object` and reviewed usage of
'byte' and 'string' (the letter made sense to me at some points, e.g. something
like "... altchar is a string with two or less let
Milan Oberkirch added the comment:
Added documentation for mangle_from. since the name "mangle_from_" is not
supported by the markup, changed it to "mangle_from" everywhere, which looks
better anyway (I understand why it was the other way so). If it was a bad idea,
I can u
Milan Oberkirch added the comment:
Rollback to mangle_from_, sorry for the noise.
--
Added file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker
<http://bugs.python.org/issue20
Changes by Milan Oberkirch :
Removed file: http://bugs.python.org/file34320/mangle_from_with_doc.patch
___
Python tracker
<http://bugs.python.org/issue20098>
___
___
Pytho
Changes by Milan Oberkirch :
Added file: http://bugs.python.org/file34322/mangle_from_with_doc.patch
___
Python tracker
<http://bugs.python.org/issue20098>
___
___
Pytho
Changes by Milan Oberkirch :
Removed file: http://bugs.python.org/file34321/mangle_from_with_doc.patch
___
Python tracker
<http://bugs.python.org/issue20098>
___
___
Pytho
Milan Oberkirch added the comment:
pyshell.py is not part of CPython, this is the wrong place to report a bug like
this.
--
nosy: +zvyn
___
Python tracker
<http://bugs.python.org/issue29
Milan Oberkirch added the comment:
I added a line stripping dots from name, I think it makes sense to strip at the
end as well (`example.com` is the same domain as `example.com.`).
--
nosy: +zvyn
pull_requests: +8
___
Python tracker
<h
Milan Oberkirch added the comment:
Too bad, I was all exited when I saw that I can paste a PR link here :)
I downloaded the patch from the commit using github, I hope that works?
--
keywords: +patch
Added file: http://bugs.python.org/file46154/ignore_dots-v1.patch
Changes by Milan Oberkirch :
--
type: behavior ->
versions: -Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.python.org/file46168/ignore_dots-v2.patch
___
Python tracker
<http://bugs.python.org/issu
Milan Oberkirch added the comment:
Thanks for the feedback!
I changed the patch to use lstrip so that the FQDN "example.com." would match
the NOPROXY entry "example.com.". I don't think we get FQDNs, but that's just
my guess.
I think ideally "example.com&q
Milan Oberkirch added the comment:
I just wanted to note that this patch works with the current default repo as
expected. I will try to come up with some tests now (PureProxy is not tested at
all right now).
--
___
Python tracker
<h
Milan Oberkirch added the comment:
After looking at this patch and how we implemented SMTPUTF8 in the parent class
again, I think we can come up with a more generic solution. Haven't it figured
out quite yet.
--
___
Python tracker
Milan Oberkirch added the comment:
Here is the patch how it should look like at some point. Question being: How
should we handle backwards-compatibility?
--
keywords: +patch
Added file: http://bugs.python.org/file39699/issue21783.patch
___
Python
Milan Oberkirch added the comment:
Here is the trivial patch for that :)
--
keywords: +patch
nosy: +zvyn
Added file: http://bugs.python.org/file39700/issue22872.patch
___
Python tracker
<http://bugs.python.org/issue22
Milan Oberkirch added the comment:
Is this still relevant? I just made a patch based on the suggestions discussed
and it does not change the behavior of the original bug report (but fixed the
bug regarding '' mentioned by tony_nelson). Maybe I'm missing something?
Milan Oberkirch added the comment:
Here is a simple patch that would solve this issue.
The new fixer 'future_builtins' removes `from future_builtins import foo`
statements if they aren't nested in other constructs (try-except, classes, ...)
and replaces them with `
Milan Oberkirch added the comment:
The other fixers you mentioned are deactivated independently of this patch if
an import from future_builtins exists. I gave it the same run_order as in the
fix for __future__ imports which prevents 2to3 from deleting the calls before
other fixers check for
Milan Oberkirch added the comment:
*ping* This is still a reasonable patch. Would be great if you can apply it :)
--
nosy: +zvyn
versions: +Python 3.5, Python 3.6 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue19
Milan Oberkirch added the comment:
I shouldn't criticize my own patches if I want to have them committed:
Here comes the final and perfect patch for this issue ;)
(I only rephrased the comment for the test to make the intuition clear.)
--
Added file:
http://bugs.python.org/file
Milan Oberkirch added the comment:
Thanks a lot for reviewing my patch! I'm currently travalling so I'm totally
fine with you taking over this issue (would take me a few weeks till I can
work on it).
--
___
Python tracker
<http://bu
101 - 122 of 122 matches
Mail list logo
