[issue21992] New AST node Else() should be introduced

Milan Oberkirch added the comment: Is there a reason for this still being open? /me trying to find issues to work on using [random issue] -- nosy: +zvyn ___ Python tracker <https://bugs.python.org/issue21

[issue37580] Markup typo in http.cookiejar doc

Change by Milan Oberkirch : -- keywords: +patch pull_requests: +14524 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14731 ___ Python tracker <https://bugs.python.org/issu

[issue7202] "python setup.py cmd --verbose" does not set verbosity

Milan Oberkirch added the comment: The help states: > usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...] so I would argue that setup.py ignoring global_opts after cmd1 is not a bug. But I do think that the fact that "python setup.py build --dry-run" does not

[issue9938] Documentation for argparse interactive use

Milan Oberkirch added the comment: This issue is a duplicate of issue 9112 which was resolved by commit 9375492b -- nosy: +zvyn ___ Python tracker <https://bugs.python.org/issue9

[issue30436] importlib.find_spec raises AttributeError when parent is not a package/module

Changes by Milan Oberkirch : -- pull_requests: +1977 ___ Python tracker <http://bugs.python.org/issue30436> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30436] importlib.find_spec raises AttributeError when parent is not a package/module

Milan Oberkirch added the comment: I added a PR changing the exception raised as suggested, reviews welcome! -- nosy: +zvyn ___ Python tracker <http://bugs.python.org/issue30

[issue11783] email parseaddr and formataddr should be IDNA aware

Changes by Milan Oberkirch : -- pull_requests: +1979 ___ Python tracker <http://bugs.python.org/issue11783> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue11783] email parseaddr and formataddr should be IDNA aware

Milan Oberkirch added the comment: I see your point, but I'm not fully convinced it relates to this PR directly: the code here just uses the standard interface to use an 'idna' codec. If that codec is buggy that is a different issue. If it's so buggy that using it is abso

[issue21783] smtpd.py does not allow multiple helo/ehlo commands

Milan Oberkirch added the comment: Thanks for pointing me at this, Berry! I added a PR for aiosmtpd at https://github.com/aio-libs/aiosmtpd/pull/106 -- ___ Python tracker <http://bugs.python.org/issue21

[issue21783] smtpd.py does not allow multiple helo/ehlo commands

Milan Oberkirch added the comment: *Barry :P -- ___ Python tracker <http://bugs.python.org/issue21783> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30542] [EASY] test_files() of test_tools.test_unparse.DirectoryTestCase leaks references

Milan Oberkirch added the comment: I tried to pin this leak down and got to the point where I suspect the compile call: def check_roundtrip(self, code1, filename="internal"): ast1 = compile(code1, filename, "exec", ast.PyCF_ONLY_AST) the leaks occur with o

[issue12815] Coverage of smtpd.py

Changes by Milan Oberkirch : -- nosy: -zvyn ___ Python tracker <http://bugs.python.org/issue12815> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20903] smtplib.SMTP raises socket.timeout

Milan Oberkirch added the comment: The attached patch mentions the exception besides the description of the timeout parameter. It doesn't hurt and makes programmers aware of this common exception. -- keywords: +patch nosy: +zvyn Added file: http://bugs.python.org/file

[issue20098] email policy needs a mangle_from setting

Milan Oberkirch added the comment: Updated the last patch according to the review comments at https://bugs.python.org/review/20098/. -- Added file: http://bugs.python.org/file35020/mangle_from_20140424.patch ___ Python tracker <h

[issue20098] email policy needs a mangle_from setting

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35021/mangle_from_20140424.patch ___ Python tracker <http://bugs.python.org/issue20098> ___ ___ Pytho

[issue20098] email policy needs a mangle_from setting

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file35020/mangle_from_20140424.patch ___ Python tracker <http://bugs.python.org/issue20098> ___ ___ Pytho

[issue21426] Invisible characters in email related souce files.

New submission from Milan Oberkirch: I found non-printable characters in the source files of the email package. Vim rendered it as '^L', pasting it on the linux console has the same effect as CTRL+L. In most places it was combined with regular newlines, sometimes as a replacement,

[issue15014] smtplib: add support for arbitrary auth methods

Milan Oberkirch added the comment: Done. -- Added file: http://bugs.python.org/file35392/smtplib_auth.patch ___ Python tracker <http://bugs.python.org/issue15

[issue15014] smtplib: add support for arbitrary auth methods

Changes by Milan Oberkirch : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue15014> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15014] smtplib: add support for arbitrary auth methods

Milan Oberkirch added the comment: Here comes the patch implementing your suggestions. Changing the API to make adding new auth methods and still using login() would only require to make preferred_auth accessable as you mentioned. Using custom authobjects is possible with this patch

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Milan Oberkirch added the comment: I applied your suggestions. -- Added file: http://bugs.python.org/file35542/smtpd_060914.patch ___ Python tracker <http://bugs.python.org/issue14

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Changes by Milan Oberkirch : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue14758> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20903] smtplib.SMTP raises socket.timeout

Milan Oberkirch added the comment: Should this task get closed? (see comment above) -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue20

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Milan Oberkirch added the comment: Fixed it. -- Added file: http://bugs.python.org/file35556/smtpd_061014.patch ___ Python tracker <http://bugs.python.org/issue14

[issue19662] smtpd.py should not decode utf-8

Changes by Milan Oberkirch : -- nosy: +jesstess, zvyn ___ Python tracker <http://bugs.python.org/issue19662> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8503] smtpd SMTPServer does not allow domain filtering

Milan Oberkirch added the comment: I see no reason to restrict the filtering possibilities to the domain, so I added a method "validate_recipient_address" wich gets an address of the form "local-part@domain" and returns `True`. SMTPChannel.smtp_RCPT checks any address wit

[issue11783] email parseaddr and formataddr should be IDNA aware

Milan Oberkirch added the comment: Ping :) -- nosy: +zvyn ___ Python tracker <http://bugs.python.org/issue11783> ___ ___ Python-bugs-list mailing list Unsub

[issue11783] email parseaddr and formataddr should be IDNA aware

Changes by Milan Oberkirch : -- nosy: +jesstess Added file: http://bugs.python.org/file35565/issue11783.patch ___ Python tracker <http://bugs.python.org/issue11

[issue11783] email parseaddr and formataddr should be IDNA aware

Milan Oberkirch added the comment: Here comes an updated patch based on 'email_address_idna.patch' without breaking smtplib (as the previous patches did). -- Added file: http://bugs.python.org/file35566/issue11783-rdm-fixed.patch ___ Pyth

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: I merged it into https://bitbucket.org/zvyn/cpython and made a diff from that. (I used bash for this so hopefully its compatible to the review system here.) -- Added file: http://bugs.python.org/file35577/issue21725.patch

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35578/issue21725-fixed.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Python-bug

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file35578/issue21725-fixed.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Pytho

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35579/issue21725-fixed.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Python-bug

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35580/issue21725-fixed-hg.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Pytho

[issue20083] smtplib: support for IDN (international domain names)

Changes by Milan Oberkirch : -- nosy: +jesstess, zvyn ___ Python tracker <http://bugs.python.org/issue20083> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: Thanks a lot for your feedback! > Your modifications to the handling of max_command_size are technically buggy > (and clearly there's no test for it): when we aren't in extended smtp mode, > the limit should be the hardcoded value, as i

[issue21783] smtpd.py does not allow multiple helo/ehlo commands

New submission from Milan Oberkirch: Sending HELO or EHLO more then once causes smtpd.SMTPChannel to respond with b'503 Duplicate HELO/EHLO\r\n' (see Lib/test/test_smtpd.py:124 for an example). My interpretation of RFC 821, section 4.1.1.5 is that multiple HELO commands are fine

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: The new patch implements what you suggested, with the following differences: - I still use the default_dict and add the numbers up but maybe it's a bit more readable now? - Support for HELO/EHLO is a seperate issue #21783 -- Added file:

[issue21795] smtpd.SMTPServer should announce 8BITMIME when supported

New submission from Milan Oberkirch: The smtpd.SMTPServer does support 8BITMIME if decode_date is False (#19662) and could be announced under this condition. The patch for #21725 already implements 8BITMIME so this can easily be done afterwards. -- components: email messages: 220868

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: I replied to some review comments, and made a new patch implementing your suggestions. -- Added file: http://bugs.python.org/file35679/issue21725v3.patch ___ Python tracker <http://bugs.python.org/issue21

[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.

Changes by Milan Oberkirch : -- components: email nosy: barry, jesstess, pitrou, r.david.murray, zvyn priority: normal severity: normal status: open title: Implement RFC 6855 (IMAP Support for UTF-8) in imaplib. versions: Python 3.5 ___ Python

[issue21804] Implement thr UTF8 command (RFC 6856) in poplib.

New submission from Milan Oberkirch: The poplib classes already use Unicode internally (for everything but capability names). So to implement the UTF8 part of RFC 6856 we only need to enable the user to switch to UTF-8 mode if supported by the server. -- components: email files

[issue21804] Implement thr UTF8 command (RFC 6856) in poplib.

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file35686/poputf8.patch ___ Python tracker <http://bugs.python.org/issue21804> ___ ___ Python-bugs-list m

[issue21804] Implement thr UTF8 command (RFC 6856) in poplib.

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35687/poputf8.patch ___ Python tracker <http://bugs.python.org/issue21804> ___ ___ Python-bugs-list m

[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.

New submission from Milan Oberkirch: I made a patch implementing the following changes to the IMAP4 class: - add a method 'enable_UTF8_accept()' sending "ENABLE UTF8=ACCEPT" to the server and setting internal encoding to UTF-8 - use the UTF8 extencion in the 'append(

[issue21804] Implement thr UTF8 command (RFC 6856) in poplib.

Milan Oberkirch added the comment: I got the Exception policy of the POP3 class wrong (ignore my review comment on that) and needed to add 'UTF8' to the list of optional commands. -- Added file: http://bugs.python.org/file35823/poputf

[issue21935] Implement AUTH command in smtpd.

New submission from Milan Oberkirch: I implemented message processing for LOGIN and PLAIN authentication in smtpd. I also patched test_smtplib to make use of this functionality. The goal for the API is to provide decryption and message processing in the smtpd library and call a externally

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

Milan Oberkirch added the comment: I patched it as you suggested (9 lines added/changed in total). -- Added file: http://bugs.python.org/file35903/imaplib_interpret_empty_string_as_None.patch ___ Python tracker <http://bugs.python.org/issue18

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

Milan Oberkirch added the comment: Ignore what I just did (the test is obviously dump; it fails if you run it on an IMAP server). I'll make a new attempt after a coffee break ;) -- ___ Python tracker <http://bugs.python.org/is

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

Milan Oberkirch added the comment: I'm still wondering if the test could be done better. At least it fixes the bug. -- Added file: http://bugs.python.org/file35904/imaplib_interpret_empty_string_as_NoneV2.patch ___ Python tracker

[issue12815] Coverage of smtpd.py

Changes by Milan Oberkirch : -- nosy: +zvyn ___ Python tracker <http://bugs.python.org/issue12815> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19806] smtpd crashes when a multi-byte UTF-8 sequence is split between consecutive data packets

Changes by Milan Oberkirch : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue19806> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19806] smtpd crashes when a multi-byte UTF-8 sequence is split between consecutive data packets

Milan Oberkirch added the comment: I do not think that the proposed patch solves the bug because it silently changes binary input. With the patch for issue 19662 a proper solution to avoid this bug has been applied. The only thing left is to prevent the server to raise the exception when in

[issue21935] Implement AUTH command in smtpd.

Milan Oberkirch added the comment: There is no real API in the current patch and authenticating has no effect (other then preventing you from authenticating again and storing the username). I am wondering how the user should turn AUTH on/off. Solution 1: add a keyword argument 'enable

[issue21935] Implement AUTH command in smtpd.

Milan Oberkirch added the comment: Done. I added the keyarg 'enable_AUTH' and two abstract methods to the server: process_auth(user, password) for authentication and accept_recipient(user, mailfrom, rcptto) for authorization. -- Added file: http://bugs.python.org

[issue19806] smtpd crashes when a multi-byte UTF-8 sequence is split between consecutive data packets

Milan Oberkirch added the comment: Note that in this (and my previous) patch the message is sent to the client (the idea was not to raise an exception). Maybe it would be better to raise an exception with the information you mentioned? -- Added file: http://bugs.python.org/file35975

[issue19806] smtpd crashes when a multi-byte UTF-8 sequence is split between consecutive data packets

Milan Oberkirch added the comment: Agreed. It just feels a bit weird to send programming instructions for the server to the client (but it's probably the best we can do here). -- ___ Python tracker <http://bugs.python.org/is

[issue21935] Implement AUTH command in smtpd.

Milan Oberkirch added the comment: We could solve issue 8503 at the same time by always calling 'accept_recipient(mailfrom, rcptto, user=None)' and providing a default implementation for backwards compatibility. -- ___ Python trac

[issue21935] Implement AUTH command in smtpd.

Milan Oberkirch added the comment: My interpretation of this paragraph is the following (English is not my native language so please correct me if I'm wrong): The requirement is to provide a configuration where plain auth is disabled if password snooping would be possible otherwise n

[issue21935] Implement AUTH command in smtpd.

Milan Oberkirch added the comment: After trying to implement SMTPS with asyncore and wrap_socket I agree with David that it is at least hard: somehow the handshake fails (ssl.SSLWantReadError) and I did not really figure out why. Looking at the debugging output of openssl indicates that the

[issue21935] Implement AUTH command in smtpd.

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file35991/smtpd_AUTH_full2.patch ___ Python tracker <http://bugs.python.org/issue21935> ___ ___ Python-bug

[issue22027] RFC 6531 (SMTPUTF8) support in smtplib

New submission from Milan Oberkirch: This patch is related to and depends on issue 21725. I put it here for review, it can be applied (maybe with small changes) as soon as issue 21725 is fixed. -- components: email files: smtplib_smtputf8_issue21725-dependent.patch keywords: patch

[issue12378] smtplib.SMTP_SSL leaks socket connections on SSL error

Milan Oberkirch added the comment: I agree that there is not much we can do on the server side (see issue 19806) and with the fix for issue 19662 the server won't recognize this error at all (patiently waiting for b'\r\n\' which is unlikely to appear in the first handshake-m

[issue16005] smtplib.SMTP().sendmail() and rset()

Milan Oberkirch added the comment: This bug is fixed (at least in 3.5) so you might want to close it. (See the _rset function in smtplib.py:482 and how its used in sendmail.) -- nosy: +jesstess, zvyn ___ Python tracker <http://bugs.python.

[issue1481032] patch smtplib:when SMTPDataError, rset crashes with sslerror

Milan Oberkirch added the comment: This bug was resolved for SMTPServerDisconnected exceptions but not for SSLError. Is it still reproducible? If so, the attached patch should fix it for 3.x (couldn't test if it does because I don't know how to reproduce the error). -- nosy:

[issue22071] Remove long-time deprecated attributes from smtpd

New submission from Milan Oberkirch: I made a patch removing deprecated attributes from smtpd (as suggested by r.david.murray). -- components: Library (Lib) files: smtpd_remove_deprecated_attrs.patch keywords: patch messages: 223969 nosy: jesstess, pitrou, r.david.murray, zvyn priority

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: Thanks for the review and improvements! I fixed the warnings (didn't see them with running tests as described in the dev guide; I may improve that later), updated the docs to RFC 5321 (issue 19679 is referring to RFC 3463 which is not required/up

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36157/issue21725v5.1.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Python-bug

[issue22071] Remove long-time deprecated attributes from smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36158/smtpd_remove_deprecated_attrs_v2.patch ___ Python tracker <http://bugs.python.org/issue22

[issue22027] RFC 6531 (SMTPUTF8) support in smtplib

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36159/smtpd_remove_deprecated_attrs_v2.patch ___ Python tracker <http://bugs.python.org/issue22

[issue22111] Improve imaplib testsuite.

New submission from Milan Oberkirch: The status quo of test_imaplib is a bit frustrating: 4 test functions out of 31 get executed by default while only few seem to need any resources. I tried to solve this in the attached patch. Did I get something wrong or was that checking for network

[issue22111] Improve imaplib testsuite.

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file36170/imaplib_test.patch ___ Python tracker <http://bugs.python.org/issue22111> ___ ___ Python-bug

[issue22111] Improve imaplib testsuite.

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36171/imaplib_test.patch ___ Python tracker <http://bugs.python.org/issue22111> ___ ___ Python-bug

[issue22111] Improve imaplib testsuite.

Milan Oberkirch added the comment: AntoinePitrou: Thanks for the review! I made the suggested changes and could not resist refactoring the hole thing (since I plan to spend some time on that file I wanted it to be readable and pep conform). -- Added file: http://bugs.python.org

[issue22137] Test imaplib API on all methods specified in RFC 3501

New submission from Milan Oberkirch: I finished writing tests for all methods which are specified in RFC 3501 but left out extensions for now. The attached patch will trigger many resource warnings. Do you have an idea why the sockets aren't closed? -- files: imaplib_test_rf

[issue22137] Test imaplib API on all methods specified in RFC 3501

Milan Oberkirch added the comment: Okay that was stupid from me (it was 5am when I submitted it), sorry. -- Added file: http://bugs.python.org/file36271/imaplib_test_rfc3501v2.patch ___ Python tracker <http://bugs.python.org/issue22

[issue22158] RFC 6531 (SMTPUTF8) support in smtpd.PureProxy

New submission from Milan Oberkirch: This issue depends on issue 21725 for the communication with the client and issue 22027 for communicating with the remote server. I think I can come up with a patch for the default branch which is applicable but will not run without the two other issues

[issue22159] smtpd.PureProxy and smtpd.DebuggingServer do not work with decode_data=True

New submission from Milan Oberkirch: I fixed this for smtpd.DebuggingServer in the patch for issue 21725 but think it is an independent issue which is resolvable with a small patch. -- components: Library (Lib) files: decode_data_proxy_debugging_server.patch keywords: patch messages

[issue22158] RFC 6531 (SMTPUTF8) support in smtpd.PureProxy

Changes by Milan Oberkirch : -- keywords: +patch Added file: http://bugs.python.org/file36294/pp_smtputf8.patch ___ Python tracker <http://bugs.python.org/issue22

[issue22027] RFC 6531 (SMTPUTF8) support in smtplib

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file36159/smtpd_remove_deprecated_attrs_v2.patch ___ Python tracker <http://bugs.python.org/issue22

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36323/issue21725v5.2.patch ___ Python tracker <http://bugs.python.org/issue21725> ___ ___ Python-bug

[issue22027] RFC 6531 (SMTPUTF8) support in smtplib

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36324/smtplib_smtputf8_issue21725-dependentV2.patch ___ Python tracker <http://bugs.python.org/issue22

[issue8503] smtpd SMTPServer does not allow domain filtering

Changes by Milan Oberkirch : Added file: http://bugs.python.org/file36325/issue8503v2.patch ___ Python tracker <http://bugs.python.org/issue8503> ___ ___ Python-bug

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: I think that the peer arg is supposed to be set to the address of the peer connecting to our server. The value 'peer' comes from test/mock_socket.py:105 and is the best answer we can get for mock_sock.getpeername() because there is no real c

[issue22027] RFC 6531 (SMTPUTF8) support in smtplib

Milan Oberkirch added the comment: After blindly raising errors for 'SMTPUTF8' without 'BODY=.*' I found out that 'SMTPUTF8' alone is actually perfectly fine (for using international names in addresses but sending ASCII data). Which means I did a mistake in the sm

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: Thanks for your review comments, serhiy.storchaka! I may be blind right now, but where did I add a positional parameter? -- Added file: http://bugs.python.org/file36357/issue21725v5.4.patch ___ Python tracker <h

[issue21795] smtpd.SMTPServer should announce 8BITMIME when supported and accept SMTPUTF8 without it

Milan Oberkirch added the comment: Also the server should accept the SMTPUTF8 mail argument completely independently of 8BITMIME if both are enabled. -- title: smtpd.SMTPServer should announce 8BITMIME when supported -> smtpd.SMTPServer should announce 8BITMIME when supported

[issue21725] RFC 6531 (SMTPUTF8) support in smtpd

Milan Oberkirch added the comment: Sorry, I was blind (switching between languages to much)! Anyway there should be no existing code using decode_data as it was introduced in this development circle. -- ___ Python tracker <http://bugs.python.

[issue21795] smtpd.SMTPServer should announce 8BITMIME when supported and accept SMTPUTF8 without it

Milan Oberkirch added the comment: The proposed patch extends process_message with an **kwargs catch-all which is filled with 'mail_options' and 'rcpt_options' if decode_data is False. I also removed process_smtputf8_message as one can detect the need for supporting

[issue21795] smtpd.SMTPServer should announce 8BITMIME when supported and accept SMTPUTF8 without it

Milan Oberkirch added the comment: Thanks, for the review, here's comes an updated version. -- Added file: http://bugs.python.org/file36370/issue21795v2.patch ___ Python tracker <http://bugs.python.org/is

[issue22216] smtplip STARTTLS fails at second attampt due to unsufficiant quit()

New submission from Milan Oberkirch: When using smtplib.SMTP to connect to a SMTP server the instance variables esmtp_response survives a SMTP.quit() which results in the following error: >>> import smtplib >>> smtp = smtplib.SMTP('mail.oberkirch.org', 25) >&

[issue18540] imaplib.IMAP4() ends with "Name or service not known" on Fedora 18

Milan Oberkirch added the comment: According to the documentation[1] the values for host should be set to 'localhost' by default. I attached a patch that does just that. Also note, that the minimal example at the end of [1] is broken by this bug. [1]: http://docs.python.org

[issue20098] email policy needs a mangle_from setting

Milan Oberkirch added the comment: (@r.david.murray) I just implemented what you suggested: - Policy has a mangle_from_ property, overridden in EMailPolicy - Generator and DecodedGenerator default to policy.mangle_from_ or True if policy is None. Would be glad if it helps :) -- nosy

[issue20098] email policy needs a mangle_from setting

Changes by Milan Oberkirch : Removed file: http://bugs.python.org/file34275/mangle_from.patch ___ Python tracker <http://bugs.python.org/issue20098> ___ ___ Python-bug

[issue20098] email policy needs a mangle_from setting

Milan Oberkirch added the comment: Updates patch to include necessary changes to test_policy.py. -- Added file: http://bugs.python.org/file34277/mangle_from.patch ___ Python tracker <http://bugs.python.org/issue20

[issue15014] smtplib: add support for arbitrary auth methods

Milan Oberkirch added the comment: I implemented one approach to solve this by writing new member functions for each method (see the patch attached). Bonus: It does not change the usage of login() in any way (which uses the new functions internally). Another option would be to make those

[issue15014] smtplib: add support for arbitrary auth methods

Milan Oberkirch added the comment: I looked into imaplib a bit to see how the problem is solved there; what I observed: - login() does 'PLAIN' only (and does not use authobj but smtplib would) - there exists an extra function login_cram_md5() for 'CRAM-MD5' So I guess th

[issue15014] smtplib: add support for arbitrary auth methods

Milan Oberkirch added the comment: Maybe I am a bit hyperactive, but I already was at it when receiving your message, so I finished it. Anyhow most of what I have done is completely independent of the API chosen. What I did: 1. I implemented a new authenticate(self, mechanism, authobject) as

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Milan Oberkirch added the comment: I was going to work on #3461 where IPv6-tests are missing for smtplib and stumbled over this bug. I would be willing to work on this, since it's quiet clear what needs to be done to me: implement what (vsergeev) suggested and write tests (which inc

[issue14758] SMTPServer of smptd does not support binding to an IPv6 address

Milan Oberkirch added the comment: The cleaning up of smtpd.socket was already implemented, so there was nothing to do there. What I did: - Write two TestCases to check if the IP version is chosen depending on the host-parameter - Testing, that everything still works with an IPv6 address by

  1   2   >