Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue36225>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue38880>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue39511>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue36876>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue36877>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue10915>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue15751>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<https://bugs.python.org/issue37292>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue29891>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue29860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
I've confirmed that bug in the latest repo version, still exists. I attach
patch for py3k.
I'll try to have a look at it in the current version, as soon as it will be
fixed I'll port it to 2.7.
--
nosy: +maciej.szulik
versions: +Python
Maciej Szulik added the comment:
I've just checked the patch still applies to current HEAD. What about the
question regarding 0's in date.strptime(...) I asked in previous comment? I'd
like to move this issue forward now when
Maciej Szulik added the comment:
Alexander yes it's correct. It's checking for time part in date.strptime and
for time part in time.strptime. The only problem I came into is that when
passing 0 hours or 0 minutes into date.strptime it won't raise an exception,
though doc
Maciej Szulik added the comment:
You're right, I'll change this description removing 'This is equivalent...'
sentence from description. I guess the same applies to
time.strptime as well.
--
___
Python tracker
<http://bugs.
Maciej Szulik added the comment:
Sorry it took me that long - but I'm finally attaching fixed patch. I've also
checked it again current default branch and updated descriptions accordingly.
--
hgrepos: +232
Added file: http://bugs.python.org/file34778/issue1100942_2014
Changes by Maciej Szulik :
--
hgrepos: -232
___
Python tracker
<http://bugs.python.org/issue1100942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
Sreepriya, are you still working on this issue? If no I'll be happy to take it
over, is yes start with fixing following things:
- start with test - this is the most important to have each feautre tested
- decode_data, as David mentioned, needs to have de
Maciej Szulik added the comment:
I'll try to take care of this issue in the following few days.
--
___
Python tracker
<http://bugs.python.org/issue19662>
___
___
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue21555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
I'm attaching file issue19662_v1.patch. David please have a look at it and let
me know if this is it, if not I'm waiting for your suggestions.
--
Added file: http://bugs.python.org/file35390/issue1966
Maciej Szulik added the comment:
I've implemented all your proposed changes, because for most of your changes I
was thinking pretty the same way for the whole day today, to make the code more
elegant. The current state of work is attached as issue19662_v2.patch
--
Added file:
Maciej Szulik added the comment:
I've included Leslie's comments in rst file. The 3rd version is attached in
issue19662_v3.patch.
--
Added file: http://bugs.python.org/file35409/issue19662_v3.patch
___
Python tracker
<http://bu
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue1100942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
Julian I'm almost done with this issue. I just need to polish that a little bit
and I'll provide working patch withing few hours. Sorry for not writing about
that later, but I'm just starting with this and I had some time
Maciej Szulik added the comment:
I'm attaching merged and fixed patch (issue1100942_full.patch). Though during
testing I found one issue with the patch: during checking for time part in date
class I'm using (in _datetimemodule.c->date_strptime) DATE_GET_HOUR etc, but
when given t
Maciej Szulik added the comment:
Thank you David, of course I'll remind you :)
--
___
Python tracker
<http://bugs.python.org/issue25591>
___
___
Python-bugs-l
Maciej Szulik added the comment:
I tend to agree with Eric Lafontaine, looking at the quote Henning von Bargen
posted the originator address field is also required, but yet we don't
explicitly check its presence in the code, but rely on the SMTP server to error
out.
--
Maciej Szulik added the comment:
I've chatted a bit with David about this feature. Here are some thoughts:
- check what SMTP standard says about some validation rules
- add validate method, probably into email package
--
___
Python tracker
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue27321>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
Thanks, I'll try to update the patch in the following days.
--
___
Python tracker
<http://bugs.python.org/issue25591>
___
___
New submission from Maciej Szulik:
Our current imaplib implementation lacks quite a few of tests and the ones
present are written in different styles. I'd like to propose rewriting the test
case with this new style I've developed during PyCon sprints along with David.
Once we&#
Maciej Szulik added the comment:
Currently working on a patch for this.
--
___
Python tracker
<http://bugs.python.org/issue13940>
___
___
Python-bugs-list mailin
Maciej Szulik added the comment:
>From imaplib.IMAP4 class description we're stating to quote parameters if
>necessary. This patch adds that capability according to
>https://tools.ietf.org/html/rfc3501#section-5.1
--
keywords: +patch
Added file: http://bugs.python
Maciej Szulik added the comment:
I've just found the original issue where I wanted to submit the new tests. I'm
closing this in favor of http://bugs.python.org/issue22137.
--
resolution: -> duplicate
status: open -> closed
___
Pytho
Maciej Szulik added the comment:
Resubmitting from http://bugs.python.org/issue25591, which I filled in
unnecessarily.
Here are the rewritten test case I've developed during PyCon sprints along with
David. Once we'll have the entire test suite in place it'll be safer to
Changes by Maciej Szulik :
--
superseder: -> Test imaplib API on all methods specified in RFC 3501
___
Python tracker
<http://bugs.python.org/issue25591>
___
_
Maciej Szulik added the comment:
Hey Lita, final call ;) Can you address berkerpeksag comments from review?
Otherwise, I'm planning to take ownership of this issue and resubmit your patch
with addressed comments.
--
___
Python tracker
Maciej Szulik added the comment:
Perfect, thanks!
--
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
siemer thx for the comments in the review. I'll try to address them by the end
of this week.
--
___
Python tracker
<http://bugs.python.org/is
Maciej Szulik added the comment:
Per the discussion we've had with David on IRC here's what happening. The last
patch I've submitted is meant to clean up the tests by:
1. having single _setup method
2. the _setup method should addClenup to clean the environment
3. have stubs w
Maciej Szulik added the comment:
I'm reopening this issue per discussion with David we've had on IRC. The scope
of this issue to refactor current tests to make them more readable and clean.
The most important work is:
1. having single _setup method
2. the _setup method should ad
Maciej Szulik added the comment:
Lita if you still have problems or want to ask questions reach out to me on
IRC, I'm soltysh on freenode.
--
___
Python tracker
<http://bugs.python.org/is
Maciej Szulik added the comment:
Lita can you please apply the changes from latest review (from SilentGhost).
Especially the one regarding newline, which currently fails to apply this patch
on default. If all those will be cleaned I'll recommend this patch for David
for incl
Maciej Szulik added the comment:
I've checked the patch: it looks good, applies cleanly to latest default and
passes all the tests. I'm ok with merging this as is.
--
___
Python tracker
<http://bugs.python.o
Maciej Szulik added the comment:
I was looking for that but I missed the Stage field, thanks David will remember
for the future :)
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Maciej Szulik added the comment:
Ezio, I've meant we should provide some guidelines with information the system
will pick whatever they choose based on submission date. More informational
than as a requirement.
--
___
Python tracker
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue11245>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
David can you please take a look once more, I've applied all the changes you've
asked for. I'm currently working on adding the existing tests rewritten to use
the new framework so it's easy to compare. It's still in progress but
Maciej Szulik added the comment:
David I think I've re-implemented, using the new style, all the methods from
ThreadedNetworkedTests and ThreadedNetworkedTestsSSL, the new classes are
NewIMAPTests and NewIMAPSSLTests accordingly.
--
stage: -> patch review
Added fi
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26252>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26110>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26306>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26314>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26375>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
Closing in favor of http://psf.upfronthosting.co.za/roundup/meta/issue580
--
nosy: +maciej.szulik
resolution: -> wont fix
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26176>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue26543>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue27010>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue5996>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Maciej Szulik:
To quote David from
http://bugs.python.org/review/25591/diff/16398/Lib/test/test_imaplib.py:
"I've been thinking I'd like a new assert method that checks an error message
for a list of strings in any order, but I haven't op
Maciej Szulik added the comment:
You could, but then you end up writing nasty regex-es to do that. The idea here
is to create a native function that will verify a number of words in whatever
order.
--
___
Python tracker
<http://bugs.python.
Maciej Szulik added the comment:
David I'm uploading the patch with all the review comments addressed. The
changes from just the review can be seen here:
https://bitbucket.org/soltysh/cpython/commits/91708e0c6e7c5230bd69b1135b82ef47b6dc4d43?at=default
(please ignore the chang
Maciej Szulik added the comment:
Moving this enhancement to python 3.5. I'm adding updated patch plus tests for
debug messages, updated what's new docs
--
nosy: +maciej.szulik
versions: +Python 3.5 -Python 3.4
Added file: http://bugs.python.org/file38924/issue1
Maciej Szulik added the comment:
Lita thanks for your patch!. Are you able to address berkerpeksag comments from
review? Otherwise if you don't mind I'll take it over and I'll do that.
--
nosy: +maciej.szulik
___
Python
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue917120>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
Lita always look for them next to your uploaded file, there's a review link
that points to Rietveld Code Review Tool. There you'll find all those
information, just for future use :)
--
___
Python trac
Maciej Szulik added the comment:
Uploading updated version of the patch.
--
Added file: http://bugs.python.org/file38974/issue16914.patch
___
Python tracker
<http://bugs.python.org/issue16
New submission from Maciej Szulik:
During the lifecycle of a bug you do:
1. submit a patch
2. get a review with some comments
3. re-submit the patch
Talking to R. David Murray I got info there's no convention on naming those, I
think it will be valuable to have some information in the dev
Maciej Szulik added the comment:
Milan, thanks for your patch, I've added comments to it (look for review link
next to submitted file), can you address them please?
Other option is, if you don't mind, I'll take over this issue and finish on top
of your work.
--
nosy:
New submission from Maciej Szulik:
Current imaplib implementation follows obsoleted RFC2060. It should be updated
to follow RFC3501.
--
components: email
messages: 241022
nosy: barry, maciej.szulik, r.david.murray
priority: normal
severity: normal
status: open
title: Update imaplib to
Maciej Szulik added the comment:
I'm volunteering myself to work on this as a follow-up work to
http://bugs.python.org/issue22137.
--
___
Python tracker
<http://bugs.python.org/is
Maciej Szulik added the comment:
One more thing I didn't mention before is, please update it to match current
default, as it's failing patching, right now.
--
___
Python tracker
<http://bugs.python.o
Maciej Szulik added the comment:
Joe is correct, according to the spec the names containing special chars
(atom-specials) require names to be quoted
(https://tools.ietf.org/html/rfc3501#section-5.1):
1)Any character which is one of the atom-specials (see the Formal
Syntax
Maciej Szulik added the comment:
Milan one more thing to change in your patch, in all your TCs you're modifying
client state, I mean this part:
# lets cheat a bit here:
client.state = 'SELECTED'
It's OK to do that on the mocked server, but this is not acceptable doing on
Maciej Szulik added the comment:
After talking to David I'm submitting the patch once again with one slight
change in ACKS file (I've put the names in the sorted order).
--
Added file: http://bugs.python.org/file39073/issue16914.patch
Maciej Szulik added the comment:
Review comments addressed in latest patch.
--
Added file: http://bugs.python.org/file39077/issue16914.patch
___
Python tracker
<http://bugs.python.org/issue16
Maciej Szulik added the comment:
Thanks Milan for the info, I was about to ping you about that. I have a working
prototype for the tests that I've been working on during PyCon sprints with
David. I'll try to submit new patch within a couple of
Maciej Szulik added the comment:
David I did the review and there's one thing that worries me the most, actually
two:
1. changing the usual meaning of None in the IMAP's __init__ method, where None
has the same meaning as True, where I think it should be the opposite.
2. I'm n
Maciej Szulik added the comment:
Yes, I can update that (that IMAP testing bug -
http://bugs.python.org/issue22137, is taking me longer than I expected it ;)).
I just want to make sure if I understand you correctly what's needs to be done
is removing the utf8_enable code from init, we
Maciej Szulik added the comment:
David, I've changed according to your suggestion, appreciate review.
--
Added file: http://bugs.python.org/file39324/issue21800.patch
___
Python tracker
<http://bugs.python.org/is
Maciej Szulik added the comment:
I've just double checked, this patch applies cleanly to latest tip. I wouldn't
mind having this reviewed and merged.
--
___
Python tracker
<http://bugs.python.org
Maciej Szulik added the comment:
Berker per your comment updated patch changing those two new methods (namely
date.strptime and time.strptime) to be classmethod and not staticmethods.
--
Added file: http://bugs.python.org/file39345/issue1100942.patch
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue24211>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
David one small nit in docs, but otherwise the patch looks good, applies
cleanly and works as expected.
--
___
Python tracker
<http://bugs.python.org/issue24
Changes by Maciej Szulik :
--
nosy: +maciej.szulik
___
Python tracker
<http://bugs.python.org/issue24218>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
David one small comment regarding typo in smtplib.py, but most importantly I'd
suggest adding additional test case to cover the path (the newly added one)
where you get a UnicodeEncodeError upon encoding from or to with UTF8 and then
failing to find SMT
Changes by Maciej Szulik :
--
hgrepos: -322
___
Python tracker
<http://bugs.python.org/issue25591>
___
___
Python-bugs-list mailing list
Unsubscribe:
Maciej Szulik added the comment:
David I apologize for 2 emails from Reitveld, for some reason it didn't show me
all in one view :/ (I need to master Reitveld better). I've just updated patch
according to your comments.
--
Added file: http://bugs.python.org/file44896/new_ima
New submission from Maciej Szulik:
According to David [1] hostname validation should be True by default for the
imaplib, my tests clearly show something different. Additionally he states you
Christian were doing so, that's why I'm opening this not to forget about the
problem a
90 matches
Mail list logo
