[issue1702036] Make Turtle thread-safe so it does not crash

2014-07-21 Thread Lita Cho
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue1702036> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-21 Thread Lita Cho
Lita Cho added the comment: Sounds good. I can wait till the sash code gets incorporated in order to add in the font code. I would have to generate a MOUSEWHEEL event and see if it fails. I have generated mouse clicks before. I'll try to see if I can generate a MOUSEWHEEL event and if it e

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-22 Thread Lita Cho
Lita Cho added the comment: I completely agree about the mousewheel. However, would it make sense for OS X to combine command with mousewheel? I have never seen that before. I am not sure if I can bind the zoom gesture with tkinter, but I can find out. I also think the shortcuts are not

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-22 Thread Lita Cho
Lita Cho added the comment: What really? That is so awesome! I will check that out! However, I figure I still need to create separate bindings for Linux, Windows and Mac, right? Or does Tkinter unify all the mousewheel events? Lita On Tue, Jul 22, 2014 at 12:18 AM, Ned Deily wrote: > &g

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-22 Thread Lita Cho
Lita Cho added the comment: Oh I see. And then pinch on the trackpad just generates a overall MouseWheel event, not a specific zoom-in event. For some reason, I thought there was a different event depending on operating systems. Before, Linux would trigger and events and not MouseWheel. On

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-22 Thread Lita Cho
Lita Cho added the comment: I've added it so that if the OS is Mac, it will use Command-minus and Command-=. If it is on Windows, it uses Ctrl-minus and Ctrl-= (I wasn't sure if Windows uses shift sa well, but I don't think it does.) When I tried the "pinch" moveme

[issue21867] Turtle returns TypeError when undobuffer is set to 0 (aka no undo is allowed)

2014-07-22 Thread Lita Cho
Lita Cho added the comment: This is now fixed due to a patch in issue21868. -- resolution: -> fixed ___ Python tracker <http://bugs.python.org/issu

[issue21597] Allow turtledemo code pane to get wider.

2014-07-22 Thread Lita Cho
Lita Cho added the comment: On Tue, Jul 22, 2014 at 8:20 PM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > I reviewed code and made the following changes in uploaded file: > Move some code and blank lines around. > Since you left packing within m

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-22 Thread Lita Cho
Lita Cho added the comment: Sounds good. I will wait till #21587 and create a small patch afterwards. Thanks! On Tue, Jul 22, 2014 at 9:33 PM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > On windows, new patch gives this: > Traceback (most recent call las

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-23 Thread Lita Cho
Lita Cho added the comment: Oops! I was suppose to add 'Control' not 'Ctrl'. I can fix that quickly but I will wait till the other patch goes through. -- ___ Python tracker <http://bug

[issue21597] Allow turtledemo code pane to get wider.

2014-07-23 Thread Lita Cho
Lita Cho added the comment: Just to clarify, should I submit a new patch with outlined style changes? -- ___ Python tracker <http://bugs.python.org/issue21

[issue1598] unexpected response in imaplib

2014-07-23 Thread Lita Cho
Changes by Lita Cho : -- nosy: -Lita.Cho ___ Python tracker <http://bugs.python.org/issue1598> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21597] Allow turtledemo code pane to get wider.

2014-07-23 Thread Lita Cho
Lita Cho added the comment: Sweet! Thank you so much, Terry! On Wednesday, July 23, 2014, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > No, I believe this is done ;-). Onward to font sizing. > Thank you for the hard work on this. It is a gr

[issue21597] Allow turtledemo code pane to get wider.

2014-07-23 Thread Lita Cho
Lita Cho added the comment: Sorry about that!! Thanks for letting me know. -- ___ Python tracker <http://bugs.python.org/issue21597> ___ ___ Python-bugs-list m

[issue22061] turtledemo doesn't launch due to changes in tkinter

2014-07-24 Thread Lita Cho
New submission from Lita Cho: I updated my source code, and it looks like turtledemo doesn't launch anymore. I get the following error: Traceback (most recent call last): File "/Users/litacho/Development/cpython/Lib/runpy.py", line 170, in _run_module_as_main "

[issue22061] turtledemo doesn't launch due to changes in tkinter

2014-07-24 Thread Lita Cho
Lita Cho added the comment: Looks like this method was not doing anything. I removed it and the demo is working just fine. Here is a patch. -- keywords: +patch Added file: http://bugs.python.org/file36076/tk_menubar_fix.patch ___ Python tracker

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-24 Thread Lita Cho
Lita Cho added the comment: Here is an updated version of the patch now that Terry submitted the changes from issue21597. -- Added file: http://bugs.python.org/file36077/window_pane_font_size_v3.patch ___ Python tracker <http://bugs.python.

[issue17172] Add turtledemo to IDLE menu

2014-07-24 Thread Lita Cho
Lita Cho added the comment: Here is a new patch where it checks to see if turtledemo exists first before loading it onto the bindings. -- Added file: http://bugs.python.org/file36081/turtle_demo_v2.patch ___ Python tracker <http://bugs.python.

[issue17172] Add turtledemo to IDLE menu

2014-07-26 Thread Lita Cho
Lita Cho added the comment: I wasn't aware of make patchcheck. I will run this script when submitting patches in the future. Thanks, Ned! -- ___ Python tracker <http://bugs.python.org/is

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-26 Thread Lita Cho
Lita Cho added the comment: I was going to add a dropdown menu to change the font size as well, but I am going to wait till Serhiy's patch gets committed in issue22065 before I submit my patch. -- ___ Python tracker <http://bugs.py

[issue17172] Add turtledemo to IDLE menu

2014-07-26 Thread Lita Cho
Lita Cho added the comment: I've updated this patch to include the changes Ned mentioned. I am waiting to hear from Ronald if he has a better solution about dealing with the focus problem with the keyboard and mouse. -- Added file: http://bugs.python.org/file36121/turtle_demo_v3.

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-26 Thread Lita Cho
Lita Cho added the comment: Hi Terry, I originally had txtfont as a list, but I guess I was worried about readability and accessing attributes by indices being unpythonic. But I might have been over-doing it for this case. :) In Mac, you don't need to divide event.delta by 120, only Wi

[issue17172] Add turtledemo to IDLE menu

2014-07-28 Thread Lita Cho
Lita Cho added the comment: Thanks for the input Ronald! How would I go about forcing the turtledemo to be in the foreground? Do I just need to call 'fg' on the subprocess? I've been Googling and couldn't find anything obvious. -- __

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-07-29 Thread Lita Cho
Lita Cho added the comment: Hi Terry, I've added to the patch, so that the user is able to change the font size through the GUI. I tried to match Google Doc's behaviour. I also added a max font size. I choose 400 since that is what Google Docs limits their font size. If you prefe

[issue6639] turtle: _tkinter.TclError: invalid command name ".10170160"

2014-07-30 Thread Lita Cho
Lita Cho added the comment: I can make it worth such that it doesn't raise a Terminator error. This works great when working with Turtle on the command line. I basically check if the root exists for all Tk canvas calls. If it got destroyed, then it just returns. However, if you ru

[issue1702036] Make Turtle thread-safe so it does not crash

2014-07-31 Thread Lita Cho
Lita Cho added the comment: Hey! So I have been investigating this bug, but I wanted to know is the issue the fact that korka wants to create multiple turtles or do you really want to use multiple threads with Turtle? I feel like this crash is due to Tkinter not being thread safe and I am not

[issue1702036] Make Turtle thread-safe so it does not crash

2014-07-31 Thread Lita Cho
Lita Cho added the comment: I also want to note that you can create duplicate turtles by using clone, and I am not sure why you would use multiple inheritance to draw more than 1 turtle running around. I didn't think turtle was meant to be used this way. In order to draw multiple turtl

[issue1186900] nntplib shouldn't raise generic EOFError

2014-08-04 Thread Lita Cho
Lita Cho added the comment: I'ved changed the comment to say Connection closed unexpectedly. -- Added file: http://bugs.python.org/file36264/nntplib_error_v2.patch ___ Python tracker <http://bugs.python.org/issu

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-08-04 Thread Lita Cho
Lita Cho added the comment: Hi David, I can take this on as I am learning the email api currently. -- nosy: +Lita.Cho ___ Python tracker <http://bugs.python.org/issue21

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-08-04 Thread Lita Cho
Changes by Lita Cho : -- nosy: +jesstess ___ Python tracker <http://bugs.python.org/issue21991> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21585] Run Tkinter tests with wantobjects=False

2014-08-06 Thread Lita Cho
Lita Cho added the comment: Hi Serhiy, This patch was made while I was learning tkinter. I figured out how to run the tests twice while changing wantobjects variable without creating new tests. Fortunately, all the tests seem to fast when wantobjects is 0 or 1. The only annoying thing is

[issue21815] imaplib truncates some untagged responses

2014-08-14 Thread Lita Cho
Lita Cho added the comment: pinging for another review. I have included tests for the patch as well as documentation! -- ___ Python tracker <http://bugs.python.org/issue21

[issue21933] Allow the user to change font sizes with the text pane of turtledemo

2014-08-14 Thread Lita Cho
Lita Cho added the comment: ping! -- ___ Python tracker <http://bugs.python.org/issue21933> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue21585] Run Tkinter tests with wantobjects=False

2014-08-21 Thread Lita Cho
Lita Cho added the comment: Hi Terry, I had no idea we were moving away from using test_main. So instead, of using support.run_unittest, we should import all the unittest from tkinter/test/ and wrap everything with that exec method, setting wantobjects=1 and again with wantobjects=0? Also

[issue1186900] nntplib shouldn't raise generic EOFError

2014-08-21 Thread Lita Cho
Lita Cho added the comment: Thank yo so much, Martin! I will incorporate these changes and add them soon! -- ___ Python tracker <http://bugs.python.org/issue1186

[issue20882] Link to OpenHatch “getting started” page from devguide

2014-03-10 Thread Lita Cho
Lita Cho added the comment: I will go ahead and try to add the link to the page from the devguide. Thanks! -- nosy: +Lita.Cho ___ Python tracker <http://bugs.python.org/issue20

[issue20882] Link to OpenHatch “getting started” page from devguide

2014-03-10 Thread Lita Cho
Lita Cho added the comment: I added a link to the OpenHatch's "Contributing to Python" page right next to the "Getting Started" link. I thought about adding it to Additional Resources, but someone on the mailing list suggested it go somewhere on the top. I also wa

[issue20030] unittest.TestLoader.discover return value incorrectly documented.

2014-03-10 Thread Lita Cho
Lita Cho added the comment: Hello! I would like to tackle this. Does that mean the documentation needs to change such that it states that the TestSuite object is returned? It looks you can iterate over the unittest.suite.TestSuite object, as I am getting something like this

[issue20882] Link to OpenHatch “getting started” page from devguide

2014-03-10 Thread Lita Cho
Lita Cho added the comment: Sure! I've changed it so that it is in the setup.rst. Does that work? -- Added file: http://bugs.python.org/file34342/openhatch_setup.patch ___ Python tracker <http://bugs.python.org/is

[issue20882] Link to OpenHatch “getting started” page from devguide

2014-03-10 Thread Lita Cho
Lita Cho added the comment: Thank you!! -- ___ Python tracker <http://bugs.python.org/issue20882> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20030] unittest.TestLoader.discover return value incorrectly documented.

2014-03-10 Thread Lita Cho
Lita Cho added the comment: Hello! I have created a patch for the new documentation. I would love it if I could get feedback. Thanks! -- keywords: +patch Added file: http://bugs.python.org/file34345/unittest_doc.patch ___ Python tracker <h

[issue20030] unittest.TestLoader.discover return value incorrectly documented.

2014-03-10 Thread Lita Cho
Lita Cho added the comment: Good catch! I fixed that and loaded it in the attached patch! -- Added file: http://bugs.python.org/file34348/unittest_doc.patch ___ Python tracker <http://bugs.python.org/issue20

[issue21815] imaplib truncates some untagged responses

2014-11-02 Thread Lita Cho
Lita Cho added the comment: Sure, let me combine it into one change. -- ___ Python tracker <http://bugs.python.org/issue21815> ___ ___ Python-bugs-list mailin

[issue21815] imaplib truncates some untagged responses

2014-11-22 Thread Lita Cho
Lita Cho added the comment: Here is the patch merged together. I apologize for not getting it to you sooner. -- Added file: http://bugs.python.org/file37245/imaplib_bracket_fix.patch ___ Python tracker <http://bugs.python.org/issue21

[issue21815] imaplib truncates some untagged responses

2015-12-08 Thread Lita Cho
Lita Cho added the comment: I apologize, I completely forgot. I will do it this week. Thanks for the reminder! -- ___ Python tracker <http://bugs.python.org/issue21

[issue21815] imaplib truncates some untagged responses

2015-12-16 Thread Lita Cho
Lita Cho added the comment: Had some trouble setting up my dev environment for Python. Definitely going to work on it today and tomorrow. On Tue, Dec 8, 2015 at 12:33 PM, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Per

[issue21815] imaplib truncates some untagged responses

2015-12-19 Thread Lita Cho
Lita Cho added the comment: Applied the changes that berkerpeksag made. Please review, and let me know if further changes need to be made. -- Added file: http://bugs.python.org/file41366/imaplib_after_review.patch ___ Python tracker <h

[issue21815] imaplib truncates some untagged responses

2015-12-22 Thread Lita Cho
Lita Cho added the comment: Sounds good. On Tuesday, December 22, 2015, Maciej Szulik wrote: > > Maciej Szulik added the comment: > > Lita can you please apply the changes from latest review (from > SilentGhost). Especially the one regarding newline, which currently fails

[issue21815] imaplib truncates some untagged responses

2015-12-22 Thread Lita Cho
Lita Cho added the comment: Here is a patch after SlientGhost's review. I have added back the newline and included the comments for the imaplib documentation. -- Added file: http://bugs.python.org/file41395/imaplib_after_silentghost_review.

[issue21815] imaplib truncates some untagged responses

2015-04-13 Thread Lita Cho
Lita Cho added the comment: Hi Maciej, I am not seeing berkerpeksag review...? What was his comment? I apologize, but I haven't used the bug tracker in awhile. -- ___ Python tracker <http://bugs.python.org/is

<    1   2