[issue22662] subprocess.Popen.communicate causing local tty terminal settings to change inconsistently

2014-10-17 Thread Kyle
New submission from Kyle: I'm not sure if this is a bash or Python issue. I'm trying to run a command on a remote server, using the subprocess module. I call ssh inside of subprocess.Popen(...).communicate(), like so: output = subprocess.Popen(["/bin/env %s /usr/bin/ssh -

[issue46871] BaseManager.register no longer supports lambda callable 3.8.12+

2022-02-26 Thread Kyle Smith
New submission from Kyle Smith : The below code works on versions 3.5.2 to 3.8.10. Higher versions tested, such as 3.9.12 and 3.10.2 result in the error: "AttributeError: Can't pickle local object". from multiprocessing import Lock from multiprocessing.managers impor

[issue46871] BaseManager.register no longer supports lambda callable 3.8.12+

2022-02-27 Thread Kyle Smith
Kyle Smith added the comment: Interesting. I did try between MacOS (12.2) and Ubuntu since I have servers with older python versions. For scoping then, this appears to be related only to MacOS since you were able to confirm it working correctly on Linux. The code is the same, but here&#

[issue46871] BaseManager.register no longer supports lambda callable 3.8.12+

2022-02-27 Thread Kyle Smith
Kyle Smith added the comment: Since you were able to help me scope that this is probably an MacOS specific issue, I was able to find this report: https://github.com/pytest-dev/pytest-flask/issues/104 Setting `multiprocessing.set_start_method("fork")` _BEFORE_ the code is called

[issue46871] Lambda can't be pickled with "spawn" and only "fork"

2022-02-27 Thread Kyle Smith
Change by Kyle Smith : -- title: BaseManager.register no longer supports lambda callable 3.8.12+ -> Lambda can't be pickled with "spawn" and only "fork" ___ Python tracker <htt

[issue46871] Lambda can't be pickled with "spawn" and only "fork"

2022-03-01 Thread Kyle Smith
Kyle Smith added the comment: I think that's fair, thanks for the conversation at least. I understand python mp a little bit more now... -- status: pending -> open ___ Python tracker <https://bugs.python.org

[issue46871] Lambda can't be pickled with "spawn" and only "fork"

2022-03-01 Thread Kyle Smith
Change by Kyle Smith : -- status: open -> closed ___ Python tracker <https://bugs.python.org/issue46871> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue12129] Document Object Model API - validation

2011-06-02 Thread Kyle Keating
Kyle Keating added the comment: This looks to break pretty good... I did confirm this on 3.0, I'm guessing 3.2 is the same. import sys import xml.dom doc = xml.dom.getDOMImplementation().createDocument(None, 'xml', None) doc.firstChild.appendChild(doc.createElement('ele

[issue12129] Document Object Model API - validation

2011-06-02 Thread Kyle Keating
Kyle Keating added the comment: oops, the first xml element in the output should read "" not "" just a typo! don't get confused! -- ___ Python tracker <http:

[issue12825] Missing and incorrect link to a command line option.

2011-08-23 Thread Kyle Simpson
New submission from Kyle Simpson : The documentation for the runpy module has a link to the -m command line option. In version 2.7.2 of the docs, the link doesn't exist. http://docs.python.org/release/2.7/library/runpy.html http://docs.python.org/release/2.7.2/library/runpy.html If yo

[issue12602] Missing using docs cross-references

2011-08-23 Thread Kyle Simpson
Changes by Kyle Simpson : -- nosy: +Kyle.Simpson ___ Python tracker <http://bugs.python.org/issue12602> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12129] Document Object Model API - validation

2011-05-20 Thread Kyle Keating
New submission from Kyle Keating : I was doing some tests on using this library and I noticed xml elements and attribute names could be created with mal-formed xml because special characters which can break validation are not cleaned or converted from their literal forms. Only the attribute

[issue3819] urllib2 sends Basic auth across redirects

2008-09-09 Thread Kyle McFarland
New submission from Kyle McFarland <[EMAIL PROTECTED]>: when you request a url that requests Basic authentication info HTTPBasicAuthHandler adds the Authorization header to the request as a normal (not unredirected) header, then if the server returns a 301 or 302 redirect HTTPRedirectH

[issue3819] urllib2 sends Basic auth across redirects

2008-09-09 Thread Kyle McFarland
Changes by Kyle McFarland <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11442/untest.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3819] urllib2 sends Basic auth across redirects

2008-09-09 Thread Kyle McFarland
Changes by Kyle McFarland <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file11443/bug3819.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue8235] Support FreeBSD's SO_SETFIB in socketmodule.c

2010-03-25 Thread Kyle VanderBeek
New submission from Kyle VanderBeek : FreeBSD has a [gs]etsockopt() constant used to cause a given socket to use an alternate routing table (FIB); it appeared in FreeBSD 7.1. It would be useful to have this exposed as a constant in the socket module to allow special routing rules in complex

[issue8086] ssl.get_server_certificate new line missing

2010-03-26 Thread Kyle VanderBeek
Changes by Kyle VanderBeek : -- keywords: +patch Added file: http://bugs.python.org/file16672/python-ssl-PEM_FOOTER.patch ___ Python tracker <http://bugs.python.org/issue8

[issue8086] ssl.get_server_certificate new line missing

2010-03-26 Thread Kyle VanderBeek
Kyle VanderBeek added the comment: Forgot to note that my patch is against 2.7 current trunk. -- nosy: +kylev ___ Python tracker <http://bugs.python.org/issue8

[issue1692335] Fix exception pickling: Move initial args assignment to BaseException.__new__

2010-04-12 Thread Kyle VanderBeek
Kyle VanderBeek added the comment: Ping? Is anyone working on this? Have Eric's concerns been addressed and can we pickle/unpickle all exceptions yet? -- nosy: +kylev ___ Python tracker <http://bugs.python.org/issu

[issue4310] Comparison of two ints returns wrong result

2008-11-12 Thread Kyle Brandt
New submission from Kyle Brandt <[EMAIL PROTECTED]>: The attached program returns a false result on one of my computers with a Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz processor. Is seems the comparison of two int does not perform correctly. I have python 2.5.2 and 2.6.27-7-generic kernel

[issue47260] os.closerange() can be no-op in a seccomp sandbox

2022-04-08 Thread Kyle Evans
Kyle Evans added the comment: Sure, sounds good to me. The original theory (IIRC, I've slept many times since then :-)) was that we already know first/last are valid and there are no other defined errors, so 'other errors' must be because close_range has started percolati

[issue34155] email.utils.parseaddr mistakenly parse an email

2019-08-16 Thread Kyle Stanley
Kyle Stanley added the comment: > This is already backported to 3.6. I am not sure about what gets backported > to 3.5 right now, I don't even see a 'Backport to 3.5' label on Github (which > made me think we are discouraged to backport to 3.5). I can work on a manu

[issue37890] Modernize several tests in test_importlib

2019-08-19 Thread Kyle Stanley
New submission from Kyle Stanley : Last month, several tests were moved into test_importlib (https://bugs.python.org/issue19696): "test_pkg_import.py", "test_threaded_import.py", and "threaded_import_hangers.py". Those tests were created quite a while ago thoug

[issue37890] Modernize several tests in test_importlib

2019-08-19 Thread Kyle Stanley
Kyle Stanley added the comment: I'm not entirely certain as to which parts should be modernized, and which ones can remain the same. A large part of my uncertainty is that there are no header comments for "test_pkg_import.py" to explain the test coverage, so I don'

[issue37890] Modernize several tests in test_importlib

2019-08-19 Thread Kyle Stanley
Change by Kyle Stanley : -- nosy: +eric.snow, ncoghlan ___ Python tracker <https://bugs.python.org/issue37890> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37890] Modernize several tests in test_importlib

2019-08-19 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: -> needs patch type: -> enhancement ___ Python tracker <https://bugs.python.org/issue37890> ___ ___ Python-bugs-list

[issue37890] Modernize several tests in test_importlib

2019-08-20 Thread Kyle Stanley
Kyle Stanley added the comment: Ah okay, I wasn't sure what exactly would be involved with the "modernization" process, so those points were just rough ideas more than anything. I haven't started working on anything yet since I figured it'd be worthwhile to wait

[issue37890] Modernize several tests in test_importlib

2019-08-20 Thread Kyle Stanley
Kyle Stanley added the comment: > This might be a decent way to prevent the AttributeErrors, but still allows > for differentiation of actual None values Another alternative solution might be to use hasattr() before getattr(), if it is not desirable for test_pkg_import.py to

[issue37890] Modernize several tests in test_importlib

2019-08-21 Thread Kyle Stanley
Kyle Stanley added the comment: > A key question here is why are you trying to avoid the AttributeError case so > much? > but there's a reason that we don't have attribute existence tests before > every single attribute access throughout the test suite Hmm, good

[issue37890] Modernize several tests in test_importlib

2019-08-22 Thread Kyle Stanley
Kyle Stanley added the comment: > I would just read through the other tests files under test_importlib to see > how other tests were done. Okay, I'll start with that and report back with any ideas for potential changes to test_pkg_imp

[issue37585] Comparing PyDictValues does not give expected results

2019-08-23 Thread Kyle Stanley
Kyle Stanley added the comment: Reopening the issue for adding the documentation clarification, that comparing the values view of two dictionaries will always return false (as was suggested in the ML discussion https://mail.python.org/archives/list/python-...@python.org/message

[issue37585] Comparing PyDictValues does not give expected results

2019-08-23 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue37585> ___ ___ Python-bugs-list mailing list Un

[issue37934] Docs: Clarify NotImplemented use cases

2019-08-23 Thread Kyle Stanley
New submission from Kyle Stanley : In the documentation for the NotImplemented constant (https://docs.python.org/3/library/constants.html#NotImplemented), the only use case mentioned is for binary special methods, (such as object.__eq__(other)). However, based on a conversation in a recent

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-23 Thread Kyle Stanley
Kyle Stanley added the comment: > python-dev likely isn't the right place. That is a forum for more mature > ideas. Agreed, that idea should be posted to python-list if they're having issues posting to python-ideas. Python-dev certainly wouldn't be

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-23 Thread Kyle Stanley
Change by Kyle Stanley : -- type: -> enhancement ___ Python tracker <https://bugs.python.org/issue37812> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-08-24 Thread Kyle Stanley
Kyle Stanley added the comment: > May I suggest directing your efforts towards fixing known bugs or > implementing requested features. It isn't our goal to create more work for > one another There frequently is value in improving code readability, as it can improve maintain

[issue34679] asyncio.add_signal_handler call fails if not on main thread

2019-08-24 Thread Kyle Stanley
Kyle Stanley added the comment: > Skipping this call for non-main thread in proactor implementation makes sense. How do we identify whether or not set_wakeup_fd() is being called from a non-main thread? -- nosy: +aeros167 ___ Python trac

[issue34679] asyncio.add_signal_handler call fails if not on main thread

2019-08-24 Thread Kyle Stanley
Kyle Stanley added the comment: > How do we identify whether or not set_wakeup_fd() is being called from a > non-main thread? Never mind, I think I found the answer to my own question and tested a patch locally, I'll open a PR. -- ___

[issue34679] asyncio.add_signal_handler call fails if not on main thread

2019-08-24 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +15163 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15477 ___ Python tracker <https://bugs.python.org/issu

[issue34679] asyncio.add_signal_handler call fails if not on main thread

2019-08-24 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +needs review -patch ___ Python tracker <https://bugs.python.org/issue34679> ___ ___ Python-bugs-list mailing list Unsub

[issue34679] asyncio.add_signal_handler call fails if not on main thread

2019-08-25 Thread Kyle Stanley
Kyle Stanley added the comment: > Kyle, thanks for the fix. > I have basically the same change in my PR but with test and news note. No problem, that works for me. I was mostly just trying to help with resolving some of the release blockers for

[issue23933] Struct module should accept arrays

2019-08-25 Thread Kyle Stanley
Change by Kyle Stanley : -- nosy: +mark.dickinson, meador.inge ___ Python tracker <https://bugs.python.org/issue23933> ___ ___ Python-bugs-list mailing list Unsub

[issue37934] Docs: Clarify NotImplemented use cases

2019-09-01 Thread Kyle Stanley
Kyle Stanley added the comment: Thanks for the feedback Vedran and Raymond. > It is not the purpose of the docs to list use cases. Mostly we say what > something does or how it is defined. As Vedran says, how people use it is > their own business. The underlying issue here se

[issue37934] Docs: Clarify NotImplemented use cases

2019-09-01 Thread Kyle Stanley
Kyle Stanley added the comment: > Would it be viable to rephrase the existing section in a manner that explains > the functional purpose of NotImplemented without revolving around its use > case in binary special methods? To expand further upon this, here's an initial idea for

[issue37934] Docs: Clarify NotImplemented use cases

2019-09-02 Thread Kyle Stanley
Kyle Stanley added the comment: Thanks for the explanation. > Of course, you might argue that _once Python has NotImplemented_, it can be > used elsewhere - but as I said, I don't think it should be encouraged. Hmm, okay. My understanding of Raymond's explanation was mo

[issue18049] Re-enable threading test on macOS

2019-09-04 Thread Kyle Stanley
Kyle Stanley added the comment: Ronald, is it feasible that the changes made in https://github.com/python/cpython/pull/14748/files to THREAD_STACK_SIZE in Python/thread_pthread.h could be causing intermittent failures for the Azure macOS PR tests? In a recent PR (https://github.com/python

[issue37934] Docs: Clarify NotImplemented use cases

2019-09-04 Thread Kyle Stanley
Kyle Stanley added the comment: > As you say, we currently have only one usage of NotImplemented outside its > intended purpose. Maybe we should wait to see whether it becomes at least a > little bit more popular, before thinking about blessing it. > I know at least 3 in CPyt

[issue37245] Azure Pipeline 3.8 CI: multiple tests hung and timed out on macOS 10.13

2019-09-05 Thread Kyle Stanley
Kyle Stanley added the comment: It looks like the Azure macOS tests timed out again in the recently opened PR-15688. Specifically, for test_multiprocessing_spawn and test_functools (both of which also timed out in PR-15651, which Victor mentioned earlier): 0:26:41 load avg: 2.89 [418/419/1

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-09-06 Thread Kyle Stanley
Kyle Stanley added the comment: > Any plan to reapply my change, or fix it? I can try to help with this. I'm not the most familiar with the internals of asyncio, but I think it would provide a good learning experience. -- nosy: +

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-09-08 Thread Kyle Stanley
Change by Kyle Stanley : -- pull_requests: +15390 pull_request: https://github.com/python/cpython/pull/15735 ___ Python tracker <https://bugs.python.org/issue34

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-09-08 Thread Kyle Stanley
Kyle Stanley added the comment: I've opened PR-15735 which applies the same functionality as Victor's PR-13786, but adds the public getter and setter methods (for both AbstractEventLoop and BaseEventLoop) as requested by Andrew. Since this is still causing intermittent CI fai

[issue37635] Using constant for whence arg in seek()

2019-09-14 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +15757 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16147 ___ Python tracker <https://bugs.python.org/issu

[issue37635] Using constant for whence arg in seek()

2019-09-14 Thread Kyle Stanley
Kyle Stanley added the comment: Created GH-16147 for replacing the *from_what* argument with *whence* in the IO tutorial. I would like to consider following up on this with another PR that adds the IO constants `SEEK_SET`, `SEEK_CUR`, and `SEEK_END` to the tutorial. Those constants would

[issue37635] Using constant for whence arg in seek()

2019-09-14 Thread Kyle Stanley
Kyle Stanley added the comment: > Thanks you Kyle! No problem, thanks for merging it Antoine! What do you think of the followup PR to make use of the SEEK_* constants listed in the documentation? I think it would be useful to at least mention them in the tutorial, or even make use of t

[issue26360] Deadlock in thread.join on Python 2.7/macOS

2019-09-14 Thread Kyle Stanley
Kyle Stanley added the comment: > FWIW, I've confirmed again that the exact same script on the same machine > seems fine under Python 3.x. Given the imminent demise of Python 2, perhaps > this issue is just destined to be an unsolved historical oddity. Since it doesn't s

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-15 Thread Kyle Stanley
Kyle Stanley added the comment: Upon digging through Modules/_xxsubinterpretersmodule.c, I noticed that on line 2059, `PyInterpreterState_Delete(interp);` is commented out (https://github.com/python/cpython/blob/bf169915ecdd42329726104278eb723a7dda2736/Modules/_xxsubinterpretersmodule.c

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-15 Thread Kyle Stanley
Kyle Stanley added the comment: Note that I'm not particularly experienced with the c-api, I'm just trying to take a stab at understanding why the buildbot failure is occuring. -- ___ Python tracker <https://bugs.python.o

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-15 Thread Kyle Stanley
Kyle Stanley added the comment: Clarification: In the above comment when I was referring to the commit made by Eric Snow, I meant to link to https://github.com/python/cpython/commit/7f8bfc9b9a8381ddb768421b5dd5cbd970266190. -- ___ Python tracker

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-15 Thread Kyle Stanley
Kyle Stanley added the comment: Upon further reading of the documentation and some experimentation, it would definitely not make sense to call `PyInterpreterState_Delete` here (since we're only closing the sub-interpreter in the current thread), so that's not the issue. I still ha

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-15 Thread Kyle Stanley
Kyle Stanley added the comment: Clarification: "If I'm not mistaken doesn't mean that the `return -1` within ..." Should instead be: "If I'm not mistaken doesn't this mean that the `return -1` within ..." (I am really looking forward to moving issue

[issue38154] test__xxsubinterpreters: random failures on AMD64 FreeBSD CURRENT Shared 3.x

2019-09-16 Thread Kyle Stanley
Kyle Stanley added the comment: I believe I found a potential fix, see https://bugs.python.org/issue37224?@ok_message=msg%20352516%20created%0Aissue%2037224%20message_count%2C%20messages%20edited%20ok&@template=item#msg352514. Should I attach the PR to that issue or this

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-16 Thread Kyle Stanley
Kyle Stanley added the comment: Upon further consideration, I don't think this will address the issue. If the RuntimeError was not being raised, this failure would be consistent rather than intermittent. I think I have have gotten a bit mixed up, even if the return value of PyErr_F

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2019-09-19 Thread Kyle Stanley
Kyle Stanley added the comment: > Thanks, Kyle! No problem, and thanks for all of the help from Andrew, Yury, and Victor! > IMHO it will make asyncio more reliable, especially for tests on the CI. Awesome, that was my primary intention. (: > If it becomes an issue in Python 3.9

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-19 Thread Kyle Stanley
Kyle Stanley added the comment: > I'm one of the first to advocate to replace ugly macros with clean static > inline functions. Macros are evil and can be too easily misused. As someone who has only more recently started learning the C-API (and C in general), I'm certa

[issue37224] test__xxsubinterpreters failed on AMD64 Windows8.1 Refleaks 3.8

2019-09-19 Thread Kyle Stanley
Kyle Stanley added the comment: Is there a currently reliable way of accessing the GIL functions within the sub-interpreters, without causing deadlock issues? I was trying to follow the advice in the documentation (https://docs.python.org/3/c-api/init.html?highlight=global%20interpreter

[issue38154] test__xxsubinterpreters: random failures on AMD64 FreeBSD CURRENT Shared 3.x

2019-09-20 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +15879 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16293 ___ Python tracker <https://bugs.python.org/issu

[issue38154] test__xxsubinterpreters: random failures on AMD64 FreeBSD CURRENT Shared 3.x

2019-09-20 Thread Kyle Stanley
Kyle Stanley added the comment: For an updated explanation of the PR, see https://bugs.python.org/msg352835 or the comments in the PR itself. -- stage: patch review -> ___ Python tracker <https://bugs.python.org/issu

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-20 Thread Kyle Stanley
Kyle Stanley added the comment: > You can find my email in Git, and I'm on Zulip and Discourse; and I'd be > happy to start or follow a thread in a forum you think appropriate. Or if > you'd rather drop it entirely, that's fine too. I think opening a thread in

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-21 Thread Kyle Stanley
Kyle Stanley added the comment: > Is there an "aesthetic code cleanup" patch that's ever turned out well? ;-) >From what I can tell, any remotely extensive aesthetic code patch I've seen >has been highly controversial. I think they can have value in some cases

[issue38242] Revert the new asyncio Streams API

2019-09-23 Thread Kyle Stanley
Change by Kyle Stanley : -- nosy: +aeros167 ___ Python tracker <https://bugs.python.org/issue38242> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38242] Revert the new asyncio Streams API

2019-09-23 Thread Kyle Stanley
Kyle Stanley added the comment: > We have to document that Process objects use a third kind of stream object > that doesn't match either the old or new APIs, and how this one works >From my perspective, this point would have the largest user learning cost due >to the strea

[issue38267] Add thread timeout for loop.shutdown_default_executor

2019-09-24 Thread Kyle Stanley
New submission from Kyle Stanley : Currently, for the recently added coroutine `loop.shutdown_default_executor()`, the executor shutdown can wait indefinitely for the threads to join. Under normal circumstances, waiting on the threads is appropriate, but there should be a timeout duration in

[issue38267] Add thread timeout for loop.shutdown_default_executor

2019-09-24 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +15941 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16360 ___ Python tracker <https://bugs.python.org/issu

[issue38242] Revert the new asyncio Streams API

2019-09-27 Thread Kyle Stanley
Kyle Stanley added the comment: > Andrew, do you want me to submit a PR or you can do it? Since this has been elevated to a release blocker, I wouldn't mind helping to revert this ASAP. I can open a PR to fix it today. -- ___ Python

[issue38242] Revert the new asyncio Streams API

2019-09-27 Thread Kyle Stanley
Kyle Stanley added the comment: > You'll need to be careful to only revert the new functions & the > asyncio.Stream class. So far the trickiest part has proven to be the tests (specifically test_streams.py) and keeping the deprecation warning for passing explicit loop argu

[issue38242] Revert the new asyncio Streams API

2019-09-27 Thread Kyle Stanley
Kyle Stanley added the comment: Currently focusing on the Lib/asyncio/* and Lib/test/* changes. Working on doc changes next, but that should be significantly easier. In addition to https://github.com/python/cpython/commit/23b4b697e5b6cc897696f9c0288c187d2d24bff2 (main commit from Andrew

[issue38242] Revert the new asyncio Streams API

2019-09-27 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +16024 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16445 ___ Python tracker <https://bugs.python.org/issu

[issue38242] Revert the new asyncio Streams API

2019-09-27 Thread Kyle Stanley
Change by Kyle Stanley : -- pull_requests: +16035 pull_request: https://github.com/python/cpython/pull/16455 ___ Python tracker <https://bugs.python.org/issue38

[issue38164] polishing asyncio Streams API

2019-09-29 Thread Kyle Stanley
Kyle Stanley added the comment: This should no longer be a release blocker for 3.8 with the reversion of the new asyncio streaming API in GH-16455. -- nosy: +aeros167 ___ Python tracker <https://bugs.python.org/issue38

[issue38242] Revert the new asyncio Streams API

2019-09-29 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: commit review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue38242> ___ ___ Pyth

[issue38242] Revert the new asyncio Streams API

2019-09-29 Thread Kyle Stanley
Kyle Stanley added the comment: > I've reverted the code. Andrew, would really appreciate if you could quickly > do a post commit review. Oops, I'll reopen it. -- ___ Python tracker <https://bugs.py

[issue38242] Revert the new asyncio Streams API

2019-09-29 Thread Kyle Stanley
Change by Kyle Stanley : -- status: closed -> open ___ Python tracker <https://bugs.python.org/issue38242> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue38242] Revert the new asyncio Streams API

2019-09-29 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: resolved -> commit review ___ Python tracker <https://bugs.python.org/issue38242> ___ ___ Python-bugs-list mailing list Un

[issue38164] polishing asyncio Streams API

2019-09-29 Thread Kyle Stanley
Kyle Stanley added the comment: Closed by the new asyncio stream API reversion in GH-16485 and GH-16482. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/i

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: Welcome back from the OOOS break Mariatta! > My question (and it's just that) is whether we've made a decision to prefer > one formatting syntax over others (outside of examples discussing the > formatting approaches themselves). I agree t

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > so it would be a good candidate for the "newcomer friendly" label Never mind, just noticed this was already labeled as newcomer friendly. I only saw the "easy" label at first. (: If consensus is reached for this, we can open a separa

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: I can try to work on fixing this. -- nosy: +aeros167 ___ Python tracker <https://bugs.python.org/issue38356> ___ ___ Python-bug

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > I definitely think we should not modify any code in the stdlib just to switch > to f-strings. Does this also apply to updating code to use f-strings in an area that's already being modified for a functional purpose? I agree that that we shoul

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: First I'll work on adding a new method. Here's a few potential names, ordered roughly by my preferences: 1) join_threads() 2) shutdown_threads() 3) shutdown_threadpool() The first and second options are roughly equal, but I think join_threads()

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > Another consideration is if we want this method to join the threads to be > called in `ThreadedChildWatcher.close()`. An additional benefit of having the method called from `close()` is that it means we don't have to modify the tests dir

[issue38356] test_asyncio: SubprocessThreadedWatcherTests leaks threads

2019-10-02 Thread Kyle Stanley
Change by Kyle Stanley : -- keywords: +patch pull_requests: +16140 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16552 ___ Python tracker <https://bugs.python.org/issu

[issue38351] Modernize email example from %-formatting to f-string

2019-10-02 Thread Kyle Stanley
Kyle Stanley added the comment: > For the most part, templating examples can be switched to the .format() style > but shouldn't be switched to f-strings. Is there no specific use case for the older "%s" % sub template that .format() doesn't have? > The former

[issue38344] activate.bat else needs to be on the same line as the if

2019-10-10 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: patch review -> commit review ___ Python tracker <https://bugs.python.org/issue38344> ___ ___ Python-bugs-list mai

[issue38355] ntpath.realpath() fails on sys.executable

2019-10-10 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: backport needed -> commit review ___ Python tracker <https://bugs.python.org/issue38355> ___ ___ Python-bugs-list mai

[issue38359] pyw.exe opens console window in Windows 10

2019-10-10 Thread Kyle Stanley
Change by Kyle Stanley : -- stage: backport needed -> commit review ___ Python tracker <https://bugs.python.org/issue38359> ___ ___ Python-bugs-list mai

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Kyle Meyer
Kyle Meyer added the comment: I've performed a bisect the issue with the following script: #!/bin/sh make -j3 || exit 125 ./python <<\EOF || exit 1 import sys import mimetypes res = mimetypes.MimeTypes(strict=False).guess_type(";1.tar.gz")

[issue37224] test__xxsubinterpreters fails randomly

2019-10-14 Thread Kyle Stanley
Kyle Stanley added the comment: > Kyle Stanley proposed a fix: PR 16293. Note that I'm not confident about the fix I proposed in GH-16293, it was more of an idea to fix the intermittent failures more than anything. It definitely needs review from someone knowledgeable about sub-inte

[issue31387] asyncio should make it easy to enable cooperative SIGINT handling

2019-10-14 Thread Kyle Stanley
Change by Kyle Stanley : -- nosy: +aeros ___ Python tracker <https://bugs.python.org/issue31387> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28533] Replace asyncore

2019-10-14 Thread Kyle Stanley
Change by Kyle Stanley : -- nosy: +aeros ___ Python tracker <https://bugs.python.org/issue28533> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2019-10-22 Thread Kyle Stanley
Kyle Stanley added the comment: > Is it still open? What else needs to be done? Yes, this patch needs to be translated into a GitHub PR. See https://devguide.python.org/pullrequest/ for more information on our PR workflow if you're not already familiar with it. Since naught101 wrote

  1   2   3   4   5   6   >