[issue17498] error responses from server are masked in smtplib when server closes connection

2013-03-20 Thread Kushal Das
Kushal Das added the comment: Working on a patch for this. -- ___ Python tracker <http://bugs.python.org/issue17498> ___ ___ Python-bugs-list mailing list Unsub

[issue17498] error responses from server are masked in smtplib when server closes connection

2013-03-20 Thread Kushal Das
Kushal Das added the comment: The following patch adds a _rset method which catches any SMTPServerDisconnected exception, also includes the corresponding test and test_421_from_mail_cmd assert statement typo fix. -- keywords: +patch Added file: http://bugs.python.org/file29521

[issue13510] Clarify that readlines() is not needed to iterate over a file

2013-03-28 Thread Kushal Das
Kushal Das added the comment: Working on a patch for this. -- nosy: +kushaldas ___ Python tracker <http://bugs.python.org/issue13510> ___ ___ Python-bugs-list m

[issue17660] mock.patch could whitelist builtins to not need create=True

2013-04-08 Thread Kushal Das
Kushal Das added the comment: Working on this. -- nosy: +kushaldas ___ Python tracker <http://bugs.python.org/issue17660> ___ ___ Python-bugs-list mailin

[issue17660] mock.patch could whitelist builtins to not need create=True

2013-04-08 Thread Kushal Das
Kushal Das added the comment: Initial patchset along with documentation and tests update. -- keywords: +patch Added file: http://bugs.python.org/file29731/issue17660.patch ___ Python tracker <http://bugs.python.org/issue17

[issue17842] Add base64 module tests for a bytearray argument

2013-04-25 Thread Kushal Das
Kushal Das added the comment: Patch with bytearray based tests. -- keywords: +patch nosy: +kushaldas Added file: http://bugs.python.org/file30012/issue17842_v1.patch ___ Python tracker <http://bugs.python.org/issue17

[issue17843] Lib/test/testbz2_bigmem.bz2 trigger virus warnings

2013-04-25 Thread Kushal Das
Changes by Kushal Das : -- nosy: +kushaldas ___ Python tracker <http://bugs.python.org/issue17843> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17839] base64 module should use memoryview

2013-04-25 Thread Kushal Das
Kushal Das added the comment: Working on this. -- nosy: +kushaldas ___ Python tracker <http://bugs.python.org/issue17839> ___ ___ Python-bugs-list mailin

[issue17839] base64 module should use memoryview

2013-04-26 Thread Kushal Das
Kushal Das added the comment: A patch with tests update to use memoryview in base64 module. -- keywords: +patch Added file: http://bugs.python.org/file30022/issue17839_v1.patch ___ Python tracker <http://bugs.python.org/issue17

[issue17826] Setting a side_effect on mock from create_autospec doesn't work

2013-04-26 Thread Kushal Das
Kushal Das added the comment: Working on this. -- nosy: +kushaldas ___ Python tracker <http://bugs.python.org/issue17826> ___ ___ Python-bugs-list mailin

[issue17826] Setting a side_effect on mock from create_autospec doesn't work

2013-04-26 Thread Kushal Das
Kushal Das added the comment: Patch along with a test for the same. -- keywords: +patch Added file: http://bugs.python.org/file30025/issue17826_v1.patch ___ Python tracker <http://bugs.python.org/issue17

[issue17842] Add base64 module tests for a bytearray argument

2013-04-26 Thread Kushal Das
Kushal Das added the comment: All the decoders create bytes as result, not sure how to assume if the result should be bytes or bytearray. -- ___ Python tracker <http://bugs.python.org/issue17

[issue17842] Add base64 module tests for a bytearray argument

2013-04-27 Thread Kushal Das
Kushal Das added the comment: Bytearray encoding and decoding -- Added file: http://bugs.python.org/file30041/issue17842_v2.patch ___ Python tracker <http://bugs.python.org/issue17

[issue17861] put opcode information in one place

2013-04-28 Thread Kushal Das
Kushal Das added the comment: Here is a simple script which prints the opcode.h in console. We can redirect it as required. -- nosy: +kushaldas Added file: http://bugs.python.org/file30045/generate_opcode_h.py ___ Python tracker <h

[issue17861] put opcode information in one place

2013-04-28 Thread Kushal Das
Kushal Das added the comment: Second version of the script with the fix for HAVE_ARGUMENT -- Added file: http://bugs.python.org/file30046/generate_opcode_h.py ___ Python tracker <http://bugs.python.org/issue17

[issue17861] put opcode information in one place

2013-04-28 Thread Kushal Das
Kushal Das added the comment: Third revision with fixed empty spaces at the end of the lines. -- Added file: http://bugs.python.org/file30048/generate_opcode_h.py ___ Python tracker <http://bugs.python.org/issue17

[issue17826] Setting a side_effect on mock from create_autospec doesn't work

2013-04-28 Thread Kushal Das
Kushal Das added the comment: Version 2 of the patch, with typo fixed also one more addition test to check callable side effect in create_autospec. -- Added file: http://bugs.python.org/file30055/issue17826_v2.patch ___ Python tracker <h

[issue17861] put opcode information in one place

2013-04-29 Thread Kushal Das
Kushal Das added the comment: As we discussed on #python-dev channel this new patch includes the script in Tools/scripts/generate_opcode_h.py and it also contains the required Makefile.pre.in change so that it gets auto(re)generated at compile time if required. -- keywords: +patch

[issue17861] put opcode information in one place

2013-04-29 Thread Kushal Das
Kushal Das added the comment: Version 2 of the patchset edited as per review. -- Added file: http://bugs.python.org/file30066/issue17861_v2.patch ___ Python tracker <http://bugs.python.org/issue17

[issue1475692] replacing obj.__dict__ with a subclass of dict

2013-04-29 Thread Kushal Das
Kushal Das added the comment: In Objects/typeobject.c we have subtype_setdict function, in which at line 1830 we have PyDict_Check() macro call, which checks if it is a subclass of dict or not. The definition is in Include/dictobject.h #define PyDict_Check(op

[issue17914] add os.cpu_count()

2013-05-06 Thread Kushal Das
Kushal Das added the comment: I am interested to submit a patch on this. Should I move the implementation to os module and made the multiprocessing one as an alias ? or keep it in both places ? I prefer the idea of returning -1 instead of the current way of raising NotImplementedError in

[issue12458] Tracebacks should contain the first line of continuation lines

2013-05-07 Thread Kushal Das
Kushal Das added the comment: I have been able to get the logical line details (start of it), now working on to print the required lines. The current way of showing source lines removes any indentation, but to show all the physical lines (related to the logical line) one should show the

[issue21600] mock.patch.stopall doesn't work with patch.dict to sys.modules

2014-10-14 Thread Kushal Das
Kushal Das added the comment: I will do that. New job is taking time. -- ___ Python tracker <http://bugs.python.org/issue21600> ___ ___ Python-bugs-list mailin

[issue21238] unittest.mock.Mock should not allow you to use non-existent assert methods

2015-07-13 Thread Kushal Das
Kushal Das added the comment: It is a typing mistake many people make. We just want to catch those as otherwise mock will silently pass those. -- ___ Python tracker <http://bugs.python.org/issue21

[issue19006] UnitTest docs should have a single list of assertions

2016-01-03 Thread Kushal Das
Kushal Das added the comment: The patch looks good to me. Commit :) -- ___ Python tracker <http://bugs.python.org/issue19006> ___ ___ Python-bugs-list mailin

[issue26323] Add a assert_called() method for mock objects

2016-02-17 Thread Kushal Das
Kushal Das added the comment: Go ahead and update the patch for assert_called_once and related tests. -- nosy: +kushal.das ___ Python tracker <http://bugs.python.org/issue26

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-12 Thread Kushal Das
Kushal Das added the comment: Working on it. Will submit the patch tomorrow. -- ___ Python tracker <http://bugs.python.org/issue21271> ___ ___ Python-bugs-list m

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Kushal Das
Kushal Das added the comment: A patch without NEWS and whatsnew update. I will fill them before commit. The reset_mock function now has two parameters, return_value, and side_effect. Passing True value to any of these will reset that attribute. -- keywords: +patch Added file: http

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Kushal Das
Kushal Das added the comment: Updated patch with the suggestions from Berker. -- Added file: http://bugs.python.org/file38989/issue21271v2.patch ___ Python tracker <http://bugs.python.org/issue21

[issue23965] test_ssl failure on Fedora 22

2015-04-15 Thread Kushal Das
New submission from Kushal Das: OpenSSL version openssl-1.0.1k-6.fc22.x86_64 >>> ssl.OPENSSL_VERSION 'OpenSSL 1.0.1k-fips 8 Jan 2015' == ERROR: test_protocol_sslv23 (test.test_ssl.ThreadedTests) Connecting

[issue28666] Make test.support.rmtree() able to remove non-writable directories

2016-11-14 Thread Kushal Das
Kushal Das added the comment: The patch looks good to me. This can be applied, and tests are running fine with the patch. https://ci.centos.org/job/cPython-build-patch/25/console -- nosy: +kushal.das ___ Python tracker <http://bugs.python.

[issue28713] Recent tutorial for recent Python3 still uses IOError.

2016-11-16 Thread Kushal Das
Kushal Das added the comment: This following one line change should fix this one. -- keywords: +patch nosy: +kushal.das Added file: http://bugs.python.org/file45504/issue28713.patch ___ Python tracker <http://bugs.python.org/issue28

<    1   2