[issue41483] Do not acquire lock in MemoryHandler.flush() if no target defined

New submission from Kostis Anagnostopoulos : The `logging.handlers.MemoryHandler.flush()` method acquire the lock even if target has not been set, and the method is a noop: ``` def flush(self): # (Docstring skipped) self.acquire() try: if self.target: for

[issue41483] Do not acquire lock in MemoryHandler.flush() if no target defined

Kostis Anagnostopoulos added the comment: Have nothing else to say on top of what iritkatriel discovered, a double-check would be needed, but may be a pointless speed up, if MemoryHandler is impossible to work without a `target`. Fixing the no-target error is more important. Actually

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

Kostis Anagnostopoulos added the comment: Dear Sanyam, My apologies, it's been almost a year that i don't need the fix for this code, my app has been graciously decommissioned, and i don;t have any time for it. Best, Kostis On Fri, 9 Aug 2019 at 21:35, Sanyam Khurana wrote:

[issue26543] [EASY] imaplib noop Debug: bytes vs Unicode bug in debug mode

Kostis Anagnostopoulos added the comment: > > BTW, i went back to my code and pasted what seemed to cure the problem, > added in commit 2b99cec in my PR. But i don't have much time to track if it really works. I hope it will help you resolve the issue.

[issue29757] The loop in utility `socket.create_connection()` swallows previous errors

Kostis Anagnostopoulos added the comment: The problem of not fixing this (and just add a suggestion in the docs saying that the user may re-implement this method) is that frequently this call is hidden at the core of many networking libraries. So monkey-patching is needed instead, which is

[issue29757] The loop in utility `socket.create_connection()` swallows previous errors

New submission from Kostis Anagnostopoulos: ## Context The utility method `socket.create_connection()` currently works like that: 1. resolve the destination-address into one or more IP(v4 & v6) addresses; 2. loop on each IP address and stop to the 1st one to work; 3. if none works, re-raise

[issue29757] The loop in utility `socket.create_connection()` swallows previous errors

Kostis Anagnostopoulos added the comment: > When the list of errors is passed as a second argument to the exception, how > is it rendered? This is how my latest ec887c0c3 looks on Linux: >>> import socket >>> socket.create_connection(('localhost',

[issue29757] The loop in utility `socket.create_connection()` swallows previous errors

Kostis Anagnostopoulos added the comment: > This is a new feature, so we can only push it to 3.7. As it stands now(b39d4b1c6) it hardly contains any change - just in the case of multiple intermediate errors AND final failure, the exception raised is a bit different. AFAICS it would b

[issue29757] The loop in utility `socket.create_connection()` swallows previous errors

Kostis Anagnostopoulos added the comment: Just to remind that as it stands now(b39d4b1c6) it contains no API changes at all, so it should be considered for merge into 3.6.x line. -- ___ Python tracker <http://bugs.python.org/issue29

[issue11245] Implementation of IMAP IDLE in imaplib?

Kostis Anagnostopoulos added the comment: Before merging `imaplib2` please consider making proper use of the Python's standard `logging` module. -- nosy: +ankostis ___ Python tracker <http://bugs.python.org/is

[issue26543] imaplib noop Debug

Kostis Anagnostopoulos added the comment: That is a show-stopper, and the patch works fine. Should I submit a PR with a special test-case with debug >= 3 just for this? -- nosy: +ankostis ___ Python tracker <http://bugs.python.org/issu

[issue26543] imaplib noop Debug

Changes by Kostis Anagnostopoulos : -- pull_requests: +1605 ___ Python tracker <http://bugs.python.org/issue26543> ___ ___ Python-bugs-list mailing list Unsub