[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-03-28 Thread Justin
Justin added the comment: Just following up on this. Now that 3.2 is out, has the patch been committed? -- ___ Python tracker <http://bugs.python.org/issue11

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-05-20 Thread Justin
Justin added the comment: Don't mean to nag. Just checking to see if anyone has taken it upon themselves to commit this yet since it's been a couple more months :P -- ___ Python tracker <http://bugs.python.o

[issue11109] socketserver.ForkingMixIn leaves zombies

2011-02-03 Thread Justin
New submission from Justin : This is the same issue as was reported here: http://bugs.python.org/issue1954. It is still a problem in Python 3.1. I'm writing a server that will be receiving a massive number of requests and I'd like to eliminate the zombie problem. Once I figured ou

[issue11109] socketserver.ForkingMixIn leaves zombies

2011-02-04 Thread Justin
Justin added the comment: I guess I didn't really explain the issue much. The problem is that if the server receives say, 10 requests at once, and then forks a process for each, after those processes finish they will sit as zombies until process_request() is called again, which

[issue11109] socketserver.ForkingMixIn leaves zombies

2011-02-05 Thread Justin
Justin added the comment: Good point. I was just writing up something quick that works. Here's another patch, is this acceptable? -- Added file: http://bugs.python.org/file20690/loop_actions.patch ___ Python tracker <http://bugs.py

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Justin added the comment: I noticed that ForkingMixIn also was overriding handle_timeout() trying to cleanup zombies after 300 seconds of inactivity, which is useless on a busy server. I'm replacing the patch with one that also removes handle_timeout(). -- Added file:

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Changes by Justin : Removed file: http://bugs.python.org/file20690/loop_actions.patch ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list m

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Changes by Justin : Removed file: http://bugs.python.org/file20691/loop_actions.patch ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list m

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Changes by Justin : Added file: http://bugs.python.org/file20693/loop_actions.patch ___ Python tracker <http://bugs.python.org/issue11109> ___ ___ Python-bugs-list mailin

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Justin added the comment: I hope I did that last patch right. I did a 'diff -u' instead of a 'diff -c'. If you need something different, let me know. -- ___ Python tracker <http://bug

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-02-05 Thread Justin
Justin added the comment: Sorry I keep plaguing this with comments and files, but I got to thinking, anyone should be able to override _loop_actions() and implement what they need in the loop. While it's probably a bad idea in most cases, there may be legitimate needs and it's alwa

[issue42640] tkinter throws exception when key is pressed

2020-12-14 Thread Justin
New submission from Justin : On macOs 10.14.6 laptop with a qwerty layout, when I switch my keyboard layout to `French - PC` and use a tkinter keyboard listener and press the '[' button which should be the '^' button on the azerty keyboard, this Error is thrown: ``` 202

[issue42640] tkinter throws exception when key is pressed

2020-12-14 Thread Justin
Justin added the comment: Sorry my verification keyboard listener program is not the pygame one. It is this one: ``` from tkinter import * def keyup(e): print('up', e.__dict__) def keydown(e): print('down', e.__dict__) root = Tk() frame = Frame(root, width=100, he

[issue42640] tkinter throws exception when key is pressed

2020-12-14 Thread Justin
Justin added the comment: Thanks for responding so quickly. 1. My python version is: Python 3.8.6 (default, Oct 8 2020, 14:07:53) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin 2. N/A 3. >>> from tkinter.test.support import * >>> get_tk_patchlevel() (8, 5, 9, 'final

[issue42640] tkinter throws exception when key is pressed

2020-12-20 Thread Justin
Justin added the comment: FYI, I just brew installed python and with: ``` Python 3.9.1 (default, Dec 17 2020, 03:56:09) [Clang 11.0.0 (clang-1100.0.33.17)] on darwin ``` This issue still happens -- ___ Python tracker <https://bugs.python.

[issue42640] tkinter throws exception when key is pressed

2020-12-20 Thread Justin
Justin added the comment: Thank you very much. I understand and just wanted to let you know. In brew I opened up this ticket(https://github.com/Homebrew/homebrew-core/issues/67327) with that team. -- ___ Python tracker <https://bugs.python.

[issue42695] tkinter keysym_num value is incorrect

2020-12-20 Thread Justin
New submission from Justin : Hi there. On my MacOS 10.14.16 laptop with a qwerty keyboard I was testing tkinter keyboard listening for an azerty keyboard layout by switching the layout to `French - PC` When I press qwerty keys Shift + \ I expect to see 'μ' printed. When looking at t

[issue42695] tkinter keysym_num value is incorrect

2020-12-20 Thread Justin
Justin added the comment: TK bug ticket has been created at https://core.tcl-lang.org/tk/tktview/ffe6925b916caac02acae53f745e95dd1c557019 -- ___ Python tracker <https://bugs.python.org/issue42

[issue35531] xml.etree.ElementTree Elment.find bug, fails to find tag

2018-12-18 Thread Justin
New submission from Justin : When the following text it loaded in to an ElementTree Element, the find method is unable to find one of the elements without a namespace assigned to it. ``` import xml.etree.ElementTree as ElementTree xml_text = """ http://schemas.xmlsoap.or

[issue35531] xml.etree.ElementTree Elment.find bug, fails to find tag

2018-12-18 Thread Justin
Justin added the comment: Issue was user error. I though that find did a full search of the tree when it only searches children. Solution is: ele = xml.find('.//faultstring') -- resolution: -> not a bug stage: -> resolved status

[issue29837] python3 pycopg2 import issue on solaris 10

2017-03-17 Thread justin
New submission from justin: Hi, I have installed psycopg2 through pip3, but when I tried to import it, I got the following error. what could be the problem? help> psycopg2 problem in psycopg2 - ImportError: ld.so.1: python3.3: fatal: relocation error: file /opt/csw/lib/python3.3/s

[issue7190] TCP/IP?

2009-10-23 Thread Justin
New submission from Justin : Mac OS X IBook G4 PowerPC when running target.py it works fine until i close the app without ending the process. (before 'q' is entered by the user). sometimes python will not allow the user to click in the window and have the ability to type after r

[issue23429] -5**4 returns -625 instead of 625

2015-02-09 Thread Justin
New submission from Justin: C:\Users\Justin>python Python 3.4.2 (v3.4.2:ab2c023a9432, Oct 6 2014, 22:15:05) [MSC v.1600 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> print(-5**4) -625 &g

[issue23429] -5**4 returns -625 instead of 625

2015-02-10 Thread Justin
Justin added the comment: I think there is a misunderstanding of precedence here. If we had an operation were -1 * 5**4, I could fully understand the statement of precedence. However, in the absence of the "-1 *", the -5 becomes a single atom. For example: >>> myVal =

[issue23429] -5**4 returns -625 instead of 625

2015-02-10 Thread Justin
Justin added the comment: Thank you for the link. I can understand the language definition and I can accept it at face value. The confusion I have is that it does not appear to be consistent. My example of -5**4 vs 4**-2 would both have literals with a unary sign. One works as expected

[issue1220] popen3 website documentation inconsistency

2007-09-29 Thread Justin Bronn
New submission from Justin Bronn: The Python website says that the following tuple is returned from popen3: "Returns the file objects (child_stdout, child_stdin, child_stderr)." See http://docs.python.org/lib/module-popen2.html. However, the docstring of popen3 gets the order ri

[issue13031] [PATCH] small speed-up for tarfile.py when unzipping tarballs

2011-09-22 Thread Justin Peel
New submission from Justin Peel : Attached small diff speeds up extracting a gzipped tarball on my machine using python 3.2 by 3-5%. It will probably be a larger percentage on machines that have faster hard drives (mine is 5400rpm). Basically, the changes speed up calculating the checksums by

[issue13031] [PATCH] small speed-up for tarfile.py when unzipping tarballs

2011-09-22 Thread Justin Peel
Changes by Justin Peel : -- type: -> performance ___ Python tracker <http://bugs.python.org/issue13031> ___ ___ Python-bugs-list mailing list Unsubscri

[issue13031] small speed-up for tarfile.py when unzipping tarballs

2011-09-23 Thread Justin Peel
Justin Peel added the comment: poq, You're quite right. I've added that change too. By the way, four unnecessary extra tuples are no longer being created for each call to this function too because of these changes. -- Added file: http://bugs.python.org/file23232/cpytho

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-09-23 Thread Justin Love
Justin Love added the comment: Sorry, it's been sitting at the bottom of my starred list for months, the prospect of reloading context always making it a little less attractive than something else. I turned out I had to update to even have 'packaging' Error was caused by an a

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-09-25 Thread Justin Love
Justin Love added the comment: Incorporated some formatting suggestions. Removed _actions. Just as well, as I accidentally left in the 'blarg' bogus action ;^) Added a test for implicit-include. Whether 'this cannot happen' can happen depends on the output of _parse_te

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-10-18 Thread Justin Love
Justin Love added the comment: re: test_glob_to_re Could not reproduce (OS X 10.6) I built branch 2.7, and also tried the expressions from glob_to_re on my system 2.7 and 3.2, all returned the (?ms) version. -- ___ Python tracker <h

[issue11751] Increase distutils.filelist / packaging.manifest test coverage

2011-10-21 Thread Justin Love
Justin Love added the comment: Still can't reproduce (though I got one failure and three other errors) $ patch -p 1 <http://bugs.python.org/issue11751> ___ ___ Python-bugs-list mailing list Unsubsc

[issue11109] socketserver.ForkingMixIn leaves zombies, also fails to reap all zombies in one pass

2011-05-26 Thread Justin Warkentin
Justin Warkentin added the comment: Sorry, I haven't had a chance to look at this in a couple days. I've been very busy with work. I'm not sure exactly how to write the test for this, so I don't know that I'd be much help there. One last thing, I was just looking

[issue12537] mailbox's _become_message is very fragile

2011-09-01 Thread Justin Wehnes
Changes by Justin Wehnes : -- nosy: +jwehnes ___ Python tracker <http://bugs.python.org/issue12537> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10415] readline.insert_text documentation incomplete

2010-11-13 Thread Justin Lebar
New submission from Justin Lebar : The readline documentation currently says: > readline.insert_text(string) > Insert text into the command line. But as far as I can tell, readline.insert_text() does something only when called from startup_hook or pre_input_hook. Here's an

[issue10415] readline.insert_text documentation incomplete

2010-11-13 Thread Justin Lebar
Justin Lebar added the comment: Actually, maybe startup_hook doesn't do what it sounds like it does and insert_text() only works from startup_hook. If this is the case, then the documentation for startup_hook could also be improved: > The startup_hook function is called with no a

[issue11751] Increase distutils/filelist test coverage

2011-04-03 Thread Justin Love
New submission from Justin Love : Increase test coverage of distutils/filelist.py from 49% to 100%. One line was marked as excluded because it was a "this cannot happen" error, and I agreed. -- components: Tests files: increase_distutils_filelist_test_coverage.patch keywo

[issue11751] Increase distutils.filelist test coverage

2011-04-07 Thread Justin Love
Justin Love added the comment: Removed NO COVER Combined test_translate_pattern Added on to some test names to make them more descriptive -- Added file: http://bugs.python.org/file21562/increase_distutils_filelist_test_coverage_v2.patch

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-11-21 Thread Justin Cappos
Justin Cappos added the comment: > Apparently, the designers of BSD thought differently. Remember that > it is them who defined the socket API in the first place, so they > have the right that their design decisions are considered. I think there is a bit of confusion here. The &#

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-11-21 Thread Justin Cappos
Justin Cappos added the comment: >> This implementation assumes that the OS sets any socket it receives >> via accept to nonblocking. (this is a false assumption on BSD) > > Not true. It doesn't assume that (it doesn't assume the reverse, > either). The Pyt

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-11-21 Thread Justin Cappos
Justin Cappos added the comment: > > Well, I don't think setting a timeout on a listening socket and then > > expecting the socket received through accept() to be non-blocking (but > > only on BSD) is a legitimate application. > > > Right. But setting the server

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-11-21 Thread Justin Cappos
Justin Cappos added the comment: >> The Python implementation sets timeout=None (which implies that the >> underlying socket is blocking). > >No, it doesn't. A socket may be non-blocking without having a timeout; > that's the socket API (on all systems, not ju

[issue10667] collections.Counter object in C

2010-12-09 Thread Justin Peel
New submission from Justin Peel : I put the Counter's update and __missing__ methods into C code. The rest of the existing methods remain the same. The new Counter is at least 2x-10x (or more) faster for updating depending on the input. I also added a new method, update_fromsubs, whi

[issue10667] collections.Counter object in C

2010-12-10 Thread Justin Peel
Justin Peel added the comment: I've done as Antoine asked and made a pure Python PyCounter class and a C-enhanced Counter class that both use the mixin CounterBase class. I also added to the tests so that both PyCounter and Counter are tested. I left the update_fromsubs() method in Co

[issue10667] collections.Counter object in C

2010-12-10 Thread Justin Peel
Justin Peel added the comment: Okay, I was done submitting. I thought that Antoine was asking for a version that kept a pure Python version so I did that. -- ___ Python tracker <http://bugs.python.org/issue10

[issue8637] Add PYDOCPAGER envvar to specify pager for pydoc

2011-02-07 Thread Justin Bronder
Justin Bronder added the comment: On Thu, Feb 3, 2011 at 7:39 PM, Éric Araujo wrote: .. > Justin: what exactly is a pager that does not support man pages? vimpager is the one I'm using. For man pages there's vimmanpager. -- ___ P

[issue8637] Add PYDOCPAGER envvar to specify pager for pydoc

2011-02-07 Thread Justin Bronder
Justin Bronder added the comment: > Éric Araujo added the comment: > > Excuse me if I was unclear: I wasn’t asking for program names but for a > definition of “don’t support” or description of problematic behavior. In headers with vimpager ^H is not rendered(?) correctly.

[issue3144] popen / popen[234] inconsistent fd behavior

2008-06-19 Thread Justin Cappos
New submission from Justin Cappos <[EMAIL PROTECTED]>: The behavior of popen vs popen[2-4] differs with respect to open file descriptors (at least on the Linux implementation of popen). popen does not close file descriptors, thus processes retain open file descriptors from their parent.

[issue3335] subprocess lib - opening same command fails

2008-07-10 Thread Justin Harper
New submission from Justin Harper <[EMAIL PROTECTED]>: When I make the same shell call a second time, a weird error occurs. It appears that the system is caching the call and then returning the same object the second time, which causes a problem because the stream is at EOF and there

[issue3335] subprocess lib - opening same command fails

2008-07-10 Thread Justin Harper
Justin Harper <[EMAIL PROTECTED]> added the comment: Correction: line two should actually be: self.output = fout.readlines() The bug still exists with this change. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3335] subprocess lib - opening same command fails

2008-07-14 Thread Justin Harper
Justin Harper <[EMAIL PROTECTED]> added the comment: Further research reveals that the problem appears to be with the gtk.Assistant class in PyGTK 2.10, not the subprocess lib. Report can be closed. ___ Python tracker <[EMAIL PROTECTE

[issue7746] Nit: Extra comma in itertools doc

2010-01-20 Thread Justin Lebar
New submission from Justin Lebar : At http://docs.python.org/3.1/library/itertools.html, "For instance, SML provides a tabulation tool: tabulate(f) which produces a sequence f(0), f(1), But, this effect can be achieved in Python by combining map() and count() to form map(f,

[issue7797] base64 module docs should indicate that encode methods return bytes, not strings

2010-01-27 Thread Justin Lebar
New submission from Justin Lebar : It's not at all clear from the documentation that base64.base64encode() and its kin return bytes, rather than strings. Since this matters now, the docs should be clear on this point. http://docs.python.org/3.1/library/base64.html -- ass

[issue7809] Documentation for random module should indicate that a call to seed() is not required

2010-01-29 Thread Justin Lebar
New submission from Justin Lebar : Many programmers are used to languages where the RNG is deterministic unless it's explicitly seeded. This does not appear to be the case in Python. The documentation for random should indicate that Random objects are seeded on construction, and tha

[issue7809] Documentation for random module should indicate that a call to seed() is not required

2010-01-29 Thread Justin Lebar
Justin Lebar added the comment: Ack. I read it twice looking for that line! Perhaps it should still indicate that new Random objects are automatically seeded. And perhaps the line I missed should be a little bit louder? -- status: pending -> o

[issue7864] Deprecation markers in unittest docs are unclear

2010-02-05 Thread Justin Lebar
New submission from Justin Lebar : The documentation for assertTrue/assert_/failUnless reads: assertTrue(expr, msg=None) assert_(expr, msg=None) failUnless(expr, msg=None) ... Deprecated since version 3.1: failUnless(). The deprecation warning is confusing, since it appears to suggest

[issue7864] Deprecation markers in unittest docs are unclear

2010-02-05 Thread Justin Lebar
Justin Lebar added the comment: Oh, I see. I still think a complete sentence would be helpful here, although now that I understand that the colon doesn't mean "use instead" I suppose I'm less confused... -- ___ P

[issue7995] On Mac / BSD sockets returned by accept inherit the parent's FD flags

2010-02-22 Thread Justin Cappos
New submission from Justin Cappos : Suppose there is a program that has a listening socket that calls accept to obtain new sockets for client connections. socketmodule.c assumes that these client sockets have timeouts / blocking in the default state for new sockets (which on most systems

[issue7850] platform.system() should be "macosx" instead of "Darwin" on OSX

2010-02-22 Thread Justin Cappos
Justin Cappos added the comment: Perhaps the right way to fix the problem without breaking code would be to propose a new function for platform which would return a 'newbie readable' string of the system type? -- nosy: +Justin.Cappos

[issue8637] [PATCH] pydoc should respect MANPAGER over PAGER.

2010-05-06 Thread Justin Bronder
New submission from Justin Bronder : Similar to man(1), pydoc should respect the environment variable MANPAGER over PAGER. The current behavior causes issues when using a PAGER that does not support man pages. Patch based off of trunk, r80871 -- components: Library (Lib) files

[issue8637] pydoc should respect MANPAGER over PAGER.

2010-05-06 Thread Justin Bronder
Justin Bronder added the comment: I chose MANPAGER as the command line pydoc utility already clones some of the man functionality, but I'm fine with PYDOCPAGER or anything else that allows me to use pydoc without having to change PAGER

[issue2586] Integer signedness bugs in zlib modules

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: The zlib module in multiple places fails to adequately check the sanity of its arguments resulting in memory corruption, please see two attached PoCs. -- components: Extension Modules files: python-2.5.2-zlib-u

[issue2586] Integer signedness bugs in zlib modules

2008-04-08 Thread Justin Ferguson
Changes by Justin Ferguson <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file9984/python-2.5.2-zlib-unflush-signedness.py __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2587] PyString_FromStringAndSize() to be considered unsane

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: The PyString_FromStringAndSize() function takes a pointer and signed integer as input parameters however it fails to adequately check the sanity of the integer argument. Because of the failure to check for negative values and beca

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: The PyOS_vsnprintf() contains the caveat that the length parameter cannot be zero, however this is only enforced via assert() which is compiled out. As a result if the length parameter is zero then the function will underflow and w

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-08 Thread Justin Ferguson
Changes by Justin Ferguson <[EMAIL PROTECTED]>: -- components: +Interpreter Core -Distutils __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2588> __ _

[issue2589] PyOS_vsnprintf() potential integer overflow leads to memory corruption on esoteric architectures

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: On architectures that do not have a vsnprintf() in their standard library Python attempts to emulate it. When doing so, the implementation ambitiously allocates more memory than requested without verifying the sanity of the summed

[issue2590] S_unpack_from() Read Access Violation

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: The S_unpack_from() function in Modules/_struct.c does not adequately validate its arguments, potentially causing an out-of-bounds read access. It should be noted that the check at line 1561 is inadequate for obscene values of

[issue2591] ErrorHandler buffer overflow in ?unused? SGI extension module almodule.c

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: I don't think any of these SGI modules even get used, but they're really buggy-- you guys might want to consider just dropping them all together. When printing errors larger than 128 bytes a stack based overflow occurs.

[issue2593] alp_ReadFrames() integer overflow leads to buffer overflow

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: Please see bug 2591 for a suggestion on what to do with these SGI modules. (sorry I don't have any pocs/repros I dont have an sgi box handy atm) Integer overflow/invalid allocation at 768, write to memory at 773 716 stat

[issue2587] PyString_FromStringAndSize() to be considered unsane

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: The problem with assert()'s is they require debugging to be enabled, obviously, who compiles it that way? You may not even want to worry about the second check, when you pass it into the allocator it gets converted to an unsigne

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: I can generally agree with that, and I admit I haven't verified all of the code paths here- theres several hundred of them leading into this function, are you positive all of them are safe? (seems like it would be easier to ju

[issue2587] PyString_FromStringAndSize() to be considered unsane

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Adding a poc from 2586 to demonstrate my point, this causes a call to the allocator requesting zero bytes. Added file: http://bugs.python.org/file9985/python-2.5.2-zlib-unflush-misallocation.py __ T

[issue2594] alp_readsamps() overflow leads to memory corruption in ?unused? SGI extension module almodule.c

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: You guys should probably just remove the SGI modules, the code looks like it hasn't been touched in some time and hasn't gone through the same security checks as other pieces of code. Sorry I have no repro's/pocs, I d

[issue2586] Integer signedness bugs in zlib modules

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Just so you know, the scripts actually do two different things-- the bugs are both related to negative values though. One causes PyString_FromStringAndSize() to try an allocate zero bytes (the -24 one), the other causes like 22 bytes

[issue2595] Multiple integer overflows in imgfile extension module lead to buffer overflow

2008-04-08 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: The imgfile module contains multiple integer overflows, this module is only used on SGI boxes and is likely mostly unused and thus is fairly low priority imho-- no repros, no poc, no sgi box :/ I'm only going to post one to g

[issue2595] Multiple integer overflows in imgfile extension module lead to buffer overflow

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: I'm not going to file a different bug for rgbimgmodule.c, it has the same types of issues. Sorry, I don't mean to drop a ton of bugs, I'm prepping up to do a talk on attacking the metadata in scripting languages (i.e.

[issue2587] PyString_FromStringAndSize() to be considered unsane

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: As an addemdum, consider the following code (theres no assert, but it wouldnt have helped you outside of debug builds anyways): 488 static PyObject *PySSL_SSLread(PySSLObject *self, PyObject *args) 489 { 490 PyObject *bu

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-08 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: I do agree with your point about snprintf(..., sizeof(x), ...)-- my single biggest point (and maybe i'm just not seeing it), is that there appears to be no good reason for having this caveat and in turn its essentially just code

[issue2587] PyString_FromStringAndSize() to be considered unsafe

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: While I think its a mistake that will cause security concerns in Python for quite some time to come, thats fair enough. I will refile all the places that this messes up individually __ Tracker &

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Actually, I'm not sure things are any better today- even the same operating system but different versions have inconsistencies, for instance on some versions of RHEL the vsnprintf() can fail during unicode conversion. MSVCRT still

[issue2587] PyString_FromStringAndSize() to be considered unsafe

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Do I need to create proof of concepts for each of these bugs, or can I reference this ticket? __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2588] PyOS_vsnprintf() underflow leads to memory corruption

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Yep, that works for me. __ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2588> __ ___ Python-bugs

[issue2587] PyString_FromStringAndSize() to be considered unsafe

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Okay, so I'm not sure whose point of view takes precedence here? Also, to answer the question asked, I'm doing this manually. __ Tracker <[EMAIL PROTECTED]> <http://

[issue2587] PyString_FromStringAndSize() to be considered unsafe

2008-04-09 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: > 1. If you change PyString_FromStringAndSize, you should change > PyBytes_FromStringAndSize and PyUnicode_FromStringAndSize for > consistency. Okay, if we don't patch the API call itself, I will look at the users of th

[issue2587] PyString_FromStringAndSize() to be considered unsafe

2008-04-10 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: The use of signed integers in Python is (imho) the single largest threat to the security of the interpreter. I'm probably preaching to the choir there though. I really dislike have to return values and indicate error in the r

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
New submission from Justin Ferguson <[EMAIL PROTECTED]>: 174 static 175 int unicode_resize(register PyUnicodeObject *unicode, 176 Py_ssize_t length) 177 { [...] 201 202 oldstr = unicode->str; 203 PyMem_RESIZE(unicode->str, Py_UNICODE, length + 1)

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
Changes by Justin Ferguson <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10012/python-2.5.2-unicode_resize-utf8.py __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
Changes by Justin Ferguson <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10013/python-2.5.2-unicode_resize-utf16.py __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2590] S_unpack_from() Read Access Violation

2008-04-11 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: What I was originally thinking was if offset was larger than buf_len, that would cause the check at 1561 to fail due to the subtraction. That said, I'm not sure what type its being compared against so I need to check this further,

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Yes, excuse me-- this should be 32-bit specific as I believe Python will not let me get a string long enough to overflow the integer on 64-bit. It's a big string, the only realistic scenario I can see is XML parsing or simil

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: i pulled the Macros out of pymem.h in a Vanille 2.5.2? -- components: +None versions: +Python 3.0 __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2620] Multiple buffer overflows in unicode processing

2008-04-11 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: sorry didnt mean to change components and version-- I'm typing this from my phone and its being uncooperative at the moment -- components: +Library (Lib) __ Tracker <[EMAIL PRO

[issue2620] Multiple buffer overflows in unicode processing

2008-04-12 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: just fixing the modifications my phone made earlier tonight -- components: -Library (Lib), None versions: -Python 3.0 __ Tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2620] Multiple buffer overflows in unicode processing

2008-04-12 Thread Justin Ferguson
Justin Ferguson <[EMAIL PROTECTED]> added the comment: Additionally-- the PyMem_NEW()/PyMem_New() macro's need to be fixed: 231 static 232 PyUnicodeObject *_PyUnicode_New(Py_ssize_t length) 233 { 234 register PyUnicodeObject *unicode; 235 236 /* Optimization for em

[issue38032] lib2to3 doesn't parse Python 3 identifiers containing non-spacing marks

2019-09-04 Thread Justin ARthur
New submission from Justin ARthur : Python 3 code with an identifier that has a non-spacing mark in it does not get tokenized by lib2to3 and will result in an exception thrown in the parsing process. Parsing the attached file (badvar.py), results in `ParseError: bad token: type=58, value

[issue38032] lib2to3 doesn't parse Python 3 identifiers containing non-spacing marks

2019-09-05 Thread Justin Arthur
Justin Arthur added the comment: Ned, can you confirm that 2to3 is not intended for cumulative/incremental runs over the same codebase? If it's not intended to be run on previously ported code, this will just need to be fixed on the lib2to3 downstream projects like awpa and Black tha

[issue12731] python lib re uses obsolete sense of \w in full violation of UTS#18 RL1.2a

2019-09-07 Thread Justin Arthur
Change by Justin Arthur : -- nosy: +JustinTArthur ___ Python tracker <https://bugs.python.org/issue12731> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38166] ast identifies incorrect column for compound attribute lookups

2019-09-13 Thread Justin McCann
New submission from Justin McCann : This issue is related to https://github.com/microsoft/vscode-python/issues/7327 and https://github.com/PyCQA/pylint/issues/3103 For compound attribute access in variable references like a.b.c.d, the AST reports the column of the first variable/attribute in

  1   2   3   >