Josiah Carlson added the comment:
Giampaolo pinged me over email...
These additional conditions look good, and should be targeted for 3.3 .
Thank you :)
--
nosy: +josiahcarlson
___
Python tracker
<http://bugs.python.org/issue11
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
My suggestion: don't do that. Asynchronous sockets, and
asyncore/related libraries are not designed for, nor intended to be used
as part of a threaded IO application. Why? Because most protocols are
very concerned with data or
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in 64080.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
This isn't about packing arrays of long integers in an array. I know
the discussion is old, and I know the discussion is long, and honestly,
I don't really need this particular functionality anymore (in the struct
module in
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Generally speaking, delayed calls, and/or a practical scheduling
algorithm are useful for async servers. Since 2.6 and 3.0 are on
feature freeze right now, this is going to have to wait for 2.7 and 3.1
. I'll make sure to get som
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
We are actually closing the socket before returning in the latest
version of asyncore. Closing as fixed.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I forgot to fix this in my most recent commits, but I'll fix it this
weekend for Python 2.6 .
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in trunk, will be fixed in 3.0 this weekend.
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in trunk, will be fixed in 3.0 this weekend.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.p
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in trunk, will be fixed in 3.0 this weekend.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I have applied my variant patch to trunk, which will be in 3.0 this weekend.
--
resolution: -> out of date
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<h
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in trunk, will be fixed in 3.0 this weekend.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Committed to trunk a bit ago, will be in 3.0 this weekend.
--
resolution: -> accepted
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Changes by Josiah Carlson <[EMAIL PROTECTED]>:
--
status: pending -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2808>
___
__
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I agree with Martin. Why are you sure that this is a Python bug and not
a FreeBSD bug? As per the documentation of OOB data, it's not supported
by all operating systems or TCP/IP stacks.
--
nosy: +jo
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in 3.0 .
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed for 2.6 in changelist 64768.
Fixed for 3.0 in changelist 64770.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.p
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed for 2.6 in changelist 64768.
Fixed for 3.0 in changelist 64770.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed for 2.6 in changelist 64768.
Fixed for 3.0 in changelist 64770.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.p
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
The current revision of 3.0 handles the case where reading from the
socket returns a Python 3.0 str object, which it then translates into
bytes objects. This is sufficient for passing the 3.0 unittests. See
asynchat.async_chat.use_en
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Asyncore and asynchat are not going to be removed, and were not being
seriously discussed as being removable in Python 3.0 since January of
2007 when I took over maintenance. If there was a miscommunication in
an email thread on pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Sounds good. I look forward to seeing the patch :) .
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Sadly, this isn't quite as easy as it would seem. The O(1) memory
overhead version of this requires 2n reads and 2n writes, but does both
reads and writes at two memory locations at a time, which may have
nontrivial performance i
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
In order for MemoryView to know what bytes it is pointing to in memory,
it (generally) keeps a pointer with a length. In order to rotate the
data without any copies, you need a pointer and length for each rotation
plus the original
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Here's an alternate version with most of bsddb's interface intact.
--
nosy: +josiahcarlson
Added file: http://bugs.python.org/file11412/sq_dict.py
___
Python tracker <[EMAI
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I tried passing the db name as a parameter with '?', it doesn't always
work. Also, there shouldn't be any SQL injection issues here unless
someone designed their system wrong (if a third party is allowed to pa
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed in 66281.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I reverted the change I made to 2.6, see 66282.
The handle_close_event() method also doesn't exist in 3.0, which is why
it (and the reference) were removed in revision 64883. Giampaolo needs
to update his Python 3.0 checkout.
Changes by Josiah Carlson <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file11412/sq_dict.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
> I like Skip's version better, because it's closer to the dbm
> "specification" instead of trying to mimic bsddb (first, last, etc.).
> I'd like to keep such things out.
dbm.sqlite is meant as a po
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
> I would find it strange to potentially ruin performance just for a
> guarantee which has no useful purpose.
Benchmarks to prove or disprove performance changes? Subclasses to
offer different order by semantics (see the versio
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
> If you like, but "ordering semantics" is something which is just as
> easily done in Python, so I don't understand the point of integrating
> it in the dbm layer...
Actually, the db layer is *exactly*
Changes by Josiah Carlson <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file11467/sq_dict.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Josiah Carlson <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file11470/sq_dict.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Here's a version with views from Python 3.0 for keys, values, and items
:) . I know that no one hear likes my particular implementation (though
it offers more or less the full interface), but the Keys, Values, and
Items cla
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Fixed documentation in revision 66510. Also, the parameters changed
long before rc2. ;)
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PR
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I have an updated sched.py module which significantly improves the
performance of the cancel() operation on scheduled events (amortized
O(log(n)), as opposed to O(n) as it is currently). This is sufficient
to make sched.py in
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Being able to test the async features of both sides of the SSL
connection is a good thing.
Also, the subclass provides a useful example for users who want to use
asyncore and ssl servers without blocking on an incoming conn
Changes by Josiah Carlson <[EMAIL PROTECTED]>:
Removed file: http://bugs.python.org/file11472/sq_dict.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Thank you for the report (fixed in the newly attached version) :) .
Added file: http://bugs.python.org/file11602/sq_dict.py
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
The patch does not work as Giampaolo intends. If the patch were applied
as-is, no emails longer than 998 bytes could be sent.
Instead, incrementing linelen in the collect_incoming_data() method
should only be performed if self.term
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
While handle_expt() is documented has only being called when OOB data is
known, it has become the catch-all for "something strange is happening
on the socket".
The reason it wasn't changed/fixed in Python 2.6 is becaus
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
3.0 is a no-go, no non-documentation changes allowed.
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Zope's medusa was relying on internal details of asyncore (the
ac_out_buffer attribute), which is no longer applicable. It also seems
as though much of medusa itself borrows from asynchat.async_chat, which
suggests that it shou
Josiah Carlson added the comment:
The suggested documentation changes sound good to me. Those items that aren't
documented may need a note that they are deprecated and will be removed in the
future, but I'd consider that optional.
--
New submission from Josiah Carlson :
This patch is against Python trunk, but it could be easily targeted for Python
3.2 . It is meant to extract the scheduler updates from issue1641 without
mucking with asyncore. It's reach is reduced and simplified, which should make
maintenance
Josiah Carlson added the comment:
Some prodding from Giampaolo got me to pull out and simplify the sched.py
changes here: issue8684 .
That should be sufficient to add scheduling behavior into async socket servers
or otherwise.
--
___
Python
Josiah Carlson added the comment:
The patches that giampaolo sent you were for 2.x, not 3.x . Arguably
they should be applied to 2.6 first, tested, etc., then be run through
the 2.6 to 3.0 converter, then adjusted for str/bytes stuff.
One of my concerns with your changes (which are hard to
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
I agree with Giampaolo. In the case of non-blocking sockets, if reading
from the ssl stream fails because there is no data on the socket, then
sitting in a while loop is just going to busy-wait until data is
discovered.
Never min
Josiah Carlson <[EMAIL PROTECTED]> added the comment:
Oy. You are right. Fixed in Py3k in r67286, in trunk (2.7) in r67287,
and 2.6-maintenance in r67288.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PR
Josiah Carlson added the comment:
Feel like writing some documentation?
___
Python tracker
<http://bugs.python.org/issue5097>
___
___
Python-bugs-list mailing list
Unsub
Josiah Carlson added the comment:
Considering that we're looking at 2.7 and 3.1, I think that
(paraphrased) "logging fallout from changes to 2.4" are a bit out-of-
date. People who have continued to use asyncore/asynchat in the last 4
years have already changed their code. P
Josiah Carlson added the comment:
According to Garth, sockets that don't connect on Windows get put into
the error sockets list.
According to John, you need to poll sockets to determine whether or not
the attempted connection was refused.
If Garth is right, the problem is fixed, thou
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1260171>
___
___
Python-bugs-list mailing list
Unsubscribe:
Josiah Carlson added the comment:
Someone else can resurrect this concept and/ore patch if they care about this
feature. Best of luck to future readers.
--
stage: test needed -> resolved
status: open -> closed
___
Python tracker
Change by Josiah Carlson :
--
nosy: -josiah.carlson, josiahcarlson
___
Python tracker
<https://bugs.python.org/issue4277>
___
___
Python-bugs-list mailin
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1442493>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue6911>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue13372>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue35913>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1043134>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiah.carlson, josiahcarlson
___
Python tracker
<https://bugs.python.org/issue13451>
___
___
Python-bugs-list mailin
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue3783>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1453973>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1572968>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Josiah Carlson :
--
nosy: -josiahcarlson
___
Python tracker
<https://bugs.python.org/issue1509060>
___
___
Python-bugs-list mailing list
Unsubscribe:
Josiah Carlson added the comment:
Due to some rumblings over on the mentors list and python-dev, this is now
getting some love.
Guido has stated that something should make it into the subprocess module for
3.5 in this email:
https://groups.google.com/d/msg/dev-python/I6adJLIjNHk/Usrvxe_PVJIJ
Changes by Josiah Carlson :
--
versions: +Python 3.5 -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issue1191964>
___
___
Python-bugs-list m
Josiah Carlson added the comment:
Had some time to work on this today.
I was missing something in my earlier versions of the code, and have managed to
get overlapped IOs to work, so at least I'm not quite so far behind the dozen
or so core developers who know more about the Windows p
Josiah Carlson added the comment:
Quick update before I head to bed.
Thank you for the input, I had gotten the individual async calls working a
couple days ago, and I was just working to replace the communicate() method for
Windows.
Yes, I'm using asyncio._overlapped, though asyncio
Josiah Carlson added the comment:
All of the standard tests plus another few that I added all pass on Windows and
Linux. I've got some cleanup and a couple more tests to add tomorrow, then I'll
post a patch.
I ended up not using any overlapped IO cancellation in the Windows
Josiah Carlson added the comment:
Should have uploaded this yesterday, but I got caught up with typical weekend
activities. The docs probably need more, and I hear that select.select() is
disliked, so that will probably need to be changed too.
--
Added file: http://bugs.python.org
Josiah Carlson added the comment:
Submitting an updated patch addressing Giampaolo's comments.
--
Added file: http://bugs.python.org/file34774/subprocess_2.patch
___
Python tracker
<http://bugs.python.org/issu
Josiah Carlson added the comment:
I added the chunking for Windows because in manual testing before finishing the
patch, I found that large sends on Windows without actually waiting for the
result can periodically result in zero data sent, despite a child process that
wants to read.
Looking
Josiah Carlson added the comment:
No, the problem is that that ov.cancel() will attempt to cancel the IO, but a
subsequent ov.getresult(True) doesn't always return what was *actually* written
to the pipe unless you explicitly wait for the result to be available. But even
if you expli
Josiah Carlson added the comment:
I ended up eliminating the overlapped IO cancel call on Windows. Better to be
correct than to minimize internal state. Instead, we keep a reference to the
overlapped IO object, and any attempts to write to the child stdin before the
previous overlapped IO
Changes by Josiah Carlson :
Added file: http://bugs.python.org/file34861/subprocess_5.patch
___
Python tracker
<http://bugs.python.org/issue1191964>
___
___
Python-bug
Josiah Carlson added the comment:
Victor, I addressed the majority of your comments except for a couple stylistic
pieces. Your annoyance with the short poll time for Windows made me re-read the
docs from MS, which made me realize that my interpretation was wrong. It also
made me confirm
Josiah Carlson added the comment:
Richard: short timeouts are no longer an issue. Nothing to worry about :)
--
___
Python tracker
<http://bugs.python.org/issue1191
Josiah Carlson added the comment:
First off, thank you everyone who has reviewed and commented so far. I very
much appreciate your input and efforts.
Does anyone have questions, comments, or concerns about the patch? If no one
mentions anything in the next week or so, I'll ping the
Josiah Carlson added the comment:
I submitted an issue to the tulip/asyncio bug tracker:
https://code.google.com/p/tulip/issues/detail?id=170
And I am uploading a new patch that only includes non-tulip/asyncio related
changes, as tulip/asyncio changes will eventually be propagated to Python
Josiah Carlson added the comment:
First, with the use of Overlapped IO on Windows, BlockingIOError should never
come up, and we don't even handle that exception.
As for BrokenPipeError vs. EOF; while we do treat them more or less the same,
we aren't killing the process or reportin
Josiah Carlson added the comment:
The attached patch cleans up the remnants of the "handle_expt is for
exceptions", which isn't the case, as well as makes the "connection
refused" fix actually work on Windows. Nirs, could you verify this on
*nix?
--
as
Josiah Carlson added the comment:
Firstly, it expects that handle_expt_event() is for handling exceptional
conditions. This is not the case. handle_expt_event() is meant for
handling "OOB" or "priority" data coming across a socket. FTP and some
other protocols use th
Josiah Carlson added the comment:
Originally, handle_expt_event() was described as "handles OOB data or
exceptions", but over-using handle_expt_event() as an error/close
handler is a bad idea. The function asyncore.readwrite() (called by
asyncore.poll2()) does the right
Changes by Josiah Carlson :
Removed file: http://bugs.python.org/file14581/asyncore_fix_refused.patch
___
Python tracker
<http://bugs.python.org/issue6550>
___
___
Pytho
Changes by Josiah Carlson :
Removed file: http://bugs.python.org/file14585/asyncore_fix_refused-2.patch
___
Python tracker
<http://bugs.python.org/issue6550>
___
___
Pytho
Josiah Carlson added the comment:
handle_expt_event was removed in the test classes because it is no
longer being used by any of the tests. None of them send OOB data (also
known as priority data), so handle_expt_event should never be called.
When I have a chance to compare your patch to
Josiah Carlson added the comment:
I'm not a big fan of the names, but as long as the functionality exists,
people can easily alias them as necessary.
I've not actually looked at the patch, but as long as it does what it
says it does, it looks good.
My only question, does it make
Josiah Carlson added the comment:
Forest:
To answer your question, yes, that blog post discusses a better variant
of sched.py , but no, there isn't a bug. I should probably post it some
time soon for 2.7/3.1 inclusion.
___
Python tracker
Josiah Carlson added the comment:
I've just attached a patch to sched.py and asyncore.py to offer a richer
set of features for sched.py, with a call_later() function and minimal
related classes for asyncore.py to handle most reasonable use-cases.
There is no documentation or tests, but
Changes by Josiah Carlson :
Removed file: http://bugs.python.org/file13237/scheduler_partial.patch
___
Python tracker
<http://bugs.python.org/issue1641>
___
___
Python-bug
Josiah Carlson added the comment:
Here's a better patch without tabs.
Added file: http://bugs.python.org/file13238/scheduler_partial.patch
___
Python tracker
<http://bugs.python.org/i
Josiah Carlson added the comment:
Actually, that's exactly what it does. If the count is missing, it
defaults to None. The code that is executed is exactly:
if count is None:
while map:
poll_fun(timeout, map)
It will loop until the map is
Josiah Carlson added the comment:
Well...the loop can also die if an uncaptured exception is raised, but
I'm not sure that is necessary to spell out explicitly.
--
message_count: 2.0 -> 3.0
___
Python tracker
<http://bugs.python.or
Josiah Carlson added the comment:
I don't believe this should be closed. The functionality is still
desired by me and others who have posted on and off since the patch was
created. This patch definitely needs some love (tests m
Josiah Carlson added the comment:
Your analysis WRT handle_expt_event() is correct. I've been meaning to
fix that for a while, but I forgot to do it in 2.6/3.0 with all of the
other changes/fixes. Looking at the docs, you are also right about
POLLNVAL.
I also don't *know* what
Josiah Carlson added the comment:
When push is called in the current trunk (as of 2.6), the data is
automatically chopped up into self.ac_out_buffer_size blocks for later
writing.
In order to force the use of the asynchat.simple_producer class (which
takes an argument for the block size to
Josiah Carlson added the comment:
You are right. Handling OOB data is within the "exceptional condition"
that the select document specifies.
I've added a check for error conditions within handle_expt_event(),
which induces a handle_close() on discovery of an error, handle_ex
Changes by Josiah Carlson :
Removed file: http://bugs.python.org/file13516/async_no_warn.patch
___
Python tracker
<http://bugs.python.org/issue1161031>
___
___
Python-bug
1 - 100 of 134 matches
Mail list logo