[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
New submission from John Still: The function `register` of the `webbrowser` module was updated a little while back to use the newish keyword-only argument syntax; however, the function `_synthesize` (also in `webbrowser`) is still using the outdated positional arguments only calling

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
John Still added the comment: What would a new test be testing? I only found this behaviour because two existing tests were failing (with the PR they pass, of course). I'm happy to write a test, I'm just not sure what the test should be testing that the existing tests don'

[issue31014] webbrowser._synthesize uses outdated calling signature for webbrowser.register

2017-07-24 Thread John Still
John Still added the comment: Ok I understand what you mean. I think the only conditions for test failure are (A) $BROWSER is set and (B) $BROWSER is set to an actual executable that should be caught by ``register_standard_browsers`` prior to execution reaching the last if clause of