Joannah Nanjekye added the comment:
> You mention here that your tool automatically "repairs" the code. Could you
> >submit a sample PR with the repairs that your tool does so we can evaluate
> it?
I second this.
I obviously, am assuming good intentions from the aut
Joannah Nanjekye added the comment:
paul.j3,
The fix looks promising. Do you want to open a PR with this fix?
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue25
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue1615158>
___
___
Python-bugs-list mailing list
Unsub
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue20861>
___
___
Python-bugs-list mailing list
Unsubscribe:
Joannah Nanjekye added the comment:
Could be related to some discussions in this PR:
https://github.com/python/cpython/pull/14842
--
___
Python tracker
<https://bugs.python.org/issue20
Change by Joannah Nanjekye :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue20861>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Joannah Nanjekye :
--
nosy: +eric.snow, ncoghlan, vstinner
___
Python tracker
<https://bugs.python.org/issue37866>
___
___
Python-bugs-list mailin
New submission from Joannah Nanjekye :
Following a PR review here: https://github.com/python/cpython/pull/15057 by
@ericsnowcurrently i.e :
Please move both these statics to the top of the file (next to CACHEDIR) as
globals.
To keep the diff in the above PR simple, I am tracking this
Joannah Nanjekye added the comment:
Relevant comment from @gnprice.
I think it would be better to make that as a separate change. This style where
they're block-local is the way the existing code works, which keeps the diff
simple.
It's also the way that every use of _Py_IDE
Joannah Nanjekye added the comment:
Keeping this until the PR https://github.com/python/cpython/pull/15057 is
merged.
--
___
Python tracker
<https://bugs.python.org/issue37
Joannah Nanjekye added the comment:
See issue25299 also.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue24754>
___
___
Python-bug
Joannah Nanjekye added the comment:
> this argument defaults to "None"
Am leaning to the fact that this works as required. The documentation does not
just say defaults to none. It says:
With the 'store_const' and 'append_const' actions, the const keyword a
New submission from Joannah Nanjekye :
I just noticed that PyThreadState_DeleteCurrent()in Python/pystate.c is not
documented.
Relevant documentation should go in Doc/c-api/init.rst If no one objects to
this.
--
assignee: docs@python
components: Documentation
keywords: easy
messages
Change by Joannah Nanjekye :
--
title: sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? ->
Sub-ineterpreters : Document PyThreadState_DeleteCurrent() ?
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
title: Sub-ineterpreters : Document PyThreadState_DeleteCurrent() ? ->
Sub-Interpreters : Document PyThreadState_DeleteCurrent()
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15034
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15315
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
Since both the docs and implementation now match, I suggest we close this and
open a new issue suggesting to change the implementation back to make
const=None when action='store_const'.
--
stage: needs patch -
New submission from Joannah Nanjekye :
Currently, when `parser.add_argument()` is given argument with
`action='store_const'` and no `const` argument , it throws an exception :
>>> from argparse import ArgumentParser
>>> parser = ArgumentParser()
&g
Joannah Nanjekye added the comment:
Opened issue37880 to track this change.
--
___
Python tracker
<https://bugs.python.org/issue25299>
___
___
Python-bugs-list m
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue16468>
___
___
Python-bugs-list mailing list
Unsubscribe:
Joannah Nanjekye added the comment:
>From what I know the GIL is released by calling PyEval_ReleaseThread() or
>PyEval_SaveThread().
I see we can use PyThreadState_Delete() to clean up-specifically destroy thread
state but does not release the GIL and requires a thread state. On the
New submission from Joannah Nanjekye :
In the documentation for Py_NewInterpreter(): It is said that :
The return value points to the first thread state created in the new
sub-interpreter. This thread state is made in the current thread state.
I think changing :
This thread state is made
Change by Joannah Nanjekye :
--
title: python imaplib - error 'unexpected repsonse' -> python imaplib - error
'unexpected response'
___
Python tracker
<https://
Joannah Nanjekye added the comment:
There is a pending PR here : https://github.com/python/cpython/pull/4435 by
phaqui. @phaqui do you want to finish your PR ?
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue31
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15164
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15478
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
Since this has taken long on the tracker, I just opened a PR with proposed
changes from Aaron.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue15
Joannah Nanjekye added the comment:
Since this is a PEP related issue, it should be moved to the PEP Github
repository here : https://github.com/python/peps . If it still exists.
--
nosy: +nanjekyejoannah
___
Python tracker
<ht
Joannah Nanjekye added the comment:
This is has taken years but am curious, are we allowed to patch Python 2 given
its EOL is almost due.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue13
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15165
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15479
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
I opened a PR for this. @david please review.
--
nosy: +nanjekyejoannah
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
Serhiy,
This sounds good.
I will update the PR.
--
___
Python tracker
<https://bugs.python.org/issue20806>
___
___
Pytho
Change by Joannah Nanjekye :
--
title: Struct module should acept arrays -> Struct module should accept arrays
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15186
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15496
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
I updated the PR to make the function internal.
--
___
Python tracker
<https://bugs.python.org/issue37878>
___
___
Python-bug
Joannah Nanjekye added the comment:
I updated the PR to reference times(2) and times(3) along with an MSDN link.
--
___
Python tracker
<https://bugs.python.org/issue20
Joannah Nanjekye added the comment:
> Also, the note about not splitting netloc is misleading; the components > of
> netloc (username, password, hostname, and port) are available as >extra
> attributes of the returned SplitResult.
Also, the docs in urllib.parse.rst should als
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue32847>
___
___
Python-bugs-list mailing list
Unsubscribe:
Joannah Nanjekye added the comment:
See also #37970
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue37973>
___
___
Python-bugs-list m
Joannah Nanjekye added the comment:
I just referenced another area that may need help updating/improving doc
strings.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Joannah Nanjekye :
--
pull_requests: +15356
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15702
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
My searches show references to this function in CPython cloned repositories.
From @pitrous's views, I think it is better to deprecate it with a removal
notice for a later release.
I have deprecated the Function instead and will be removed in the
Joannah Nanjekye added the comment:
@petere do you want to open a PR with your patch here:
https://github.com/python/cpython/pulls
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue14
Joannah Nanjekye added the comment:
I will look after my next meeting which is in 10 minutes. In the meantime have
you perused this PR : https://github.com/python/cpython/pull/15701 If it can
solve this?
--
___
Python tracker
<ht
Joannah Nanjekye added the comment:
tp_doc is now const char*. So this should be closed.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue21
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue27718>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue16649>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15426
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15773
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15427
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15773
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
pull_requests: +15463
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/15815
___
Python tracker
<https://bugs.python.org/issue1
Change by Joannah Nanjekye :
--
nosy: +pitrou, vstinner
___
Python tracker
<https://bugs.python.org/issue38109>
___
___
Python-bugs-list mailing list
Unsub
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue10108>
___
___
Python-bugs-list mailing list
Unsubscribe:
Joannah Nanjekye added the comment:
This is nolonger an issue. All references to tp_name are as below.
const char *tp_name;
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue21
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +15767
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16157
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
All enhancements specified in this issue have since been done.
PyStructSequence_NewType() calls PyType_FromSpecWithBases() which sets the
needed flags and even the qualname:
PyObject *
PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases
Joannah Nanjekye added the comment:
As commented in issue15729, the Py_TPFLAGS_HEAPTYPE flag is now set in
PyType_FromSpecWithBases() which is called by PyStructSequence_NewType(). I
think this is no longer an issue.
--
nosy: +nanjekyejoannah
Joannah Nanjekye added the comment:
Update, Some user of this function just complained on the merged pull requests
here : https://github.com/python/cpython/pull/15315#issuecomment-534522962.
Do we revert and deprecate ? cc @victor
--
___
Python
Joannah Nanjekye added the comment:
I am okay with the revert but @victor may still have some reservations on this.
--
___
Python tracker
<https://bugs.python.org/issue38
Joannah Nanjekye added the comment:
+1 for moving from Include/pystate.h to Include/cpython/pystate.h
--
___
Python tracker
<https://bugs.python.org/issue38
Joannah Nanjekye added the comment:
I will handle this later today.
--
___
Python tracker
<https://bugs.python.org/issue38266>
___
___
Python-bugs-list mailin
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +16148
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16558
___
Python tracker
<https://bugs.python.org/issu
Change by Joannah Nanjekye :
--
pull_requests: +16149
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16558
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
I remember julien wanting to check this out during a discussion we had at the
sprints hence the loop in.
--
nosy: +mdk
___
Python tracker
<https://bugs.python.org/issue36
Joannah Nanjekye added the comment:
> Oh, I didn't notice something in the review: the revert moved
> >PyThreadState_DeleteCurrent() definition from Include/pystate.h to
> >Include/cpython/pystate.h. Previously, it was defined in >
> Include/pystate.h, see the c
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue38379>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue38388>
___
___
Python-bugs-list mailing list
Unsubscribe:
Joannah Nanjekye added the comment:
> Should I update the Status and Resolution of the issue here, or wait for some
> kind of confirmation?
The status is changed after the patch is merged. The person that merges will
usually change the status of the issue or If he/she forgets, anyon
Change by Joannah Nanjekye :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue38445>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Joannah Nanjekye :
Use getvar for all still existing sysconfig.get_config_var() calls.
--
messages: 354591
nosy: nanjekyejoannah
priority: normal
severity: normal
status: open
title: Refactor python-config.in - use getvar()
versions: Python 3.9
Change by Joannah Nanjekye :
--
keywords: +patch
pull_requests: +16323
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16749
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
New changeset 3cd21aa6a1467723ccc85e6411a6cbe7fa81ef76 by Joannah Nanjekye in
branch 'master':
bpo-38468 : Refactor python-config (#16749)
https://github.com/python/cpython/commit/3cd21aa6a1467723ccc85e6411a6cb
Change by Joannah Nanjekye :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Joannah Nanjekye added the comment:
@benedwards14 Feel free to open a PR. @netbnd said anyone can take on the issue
since he may take long to revert with a PR.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue37
Joannah Nanjekye added the comment:
Actually there is a patch. So please @netbnd please open a PR
https://github.com/python/cpython
--
___
Python tracker
<https://bugs.python.org/issue37
Joannah Nanjekye added the comment:
Can you give the original authors some credit too on the PR, if you built on
their work, please?
We usually do it by putting co-author: in the PR comment.
--
nosy: +nanjekyejoannah
___
Python tracker
<ht
Joannah Nanjekye added the comment:
New changeset 2138b2edaf5acb3b9c162a9ba620923e286239a8 by Jürgen Gmach in
branch 'main':
bpo-44045: fix spelling of uppercase vs upper-case (GH-25985)
https://github.com/python/cpython/commit/2138b2edaf5acb3b9c162a9ba620923e286239a8
-
Joannah Nanjekye added the comment:
New changeset 5f28752f5b51a1866f2428eeaf6082266723c78d by Zackery Spytz in
branch 'main':
bpo-43750: Fix incorrect reference to PACKET_MULTIHOST in the docs (GH-25241)
https://github.com/python/cpython/commit/5f28752f5b51a1866f2428eeaf6082
Joannah Nanjekye added the comment:
New changeset 4eed2821d40373345ed133b2b8d912fef59acab7 by Zackery Spytz in
branch 'main':
bpo-39560: Document PyUnicode_FromKindAndData() kind transformation (GH-23848)
https://github.com/python/cpython/commit/4eed2821d40373345ed133b2b8d912
Change by Joannah Nanjekye :
--
stage: patch review -> resolved
___
Python tracker
<https://bugs.python.org/issue39560>
___
___
Python-bugs-list mai
Change by Joannah Nanjekye :
--
nosy: +nanjekyejoannah, pablogsal
___
Python tracker
<https://bugs.python.org/issue44310>
___
___
Python-bugs-list mailin
Joannah Nanjekye added the comment:
I saw the thread but the idea was rejected by @rhettinger who seems to suggest
the changes in the documentation this time himself.
Maybe he has changed his mind, in which case he can explain the circumstances
of his decisions if he wants
Joannah Nanjekye added the comment:
Am inclined to merge the former PR because yours is just an exact replica.
Please note that we can merge such small fixes without the author signing the
CLA but the author is advised to sign the CLA for future contributions.
Source: informed by other core
Joannah Nanjekye added the comment:
@jack__d, please feel free to work on a PR.
Also, do not hesitate to ask any questions along the way.
Thanks for contributing to CPython.
--
___
Python tracker
<https://bugs.python.org/issue37
Joannah Nanjekye added the comment:
New changeset cb7230c7a7d6d497e54c25e9ba640eec79de10f2 by Erlend Egeberg
Aasland in branch 'main':
bpo-44389: Remove duplicate SSL_OP_NO_TLSv1_2 flag (GH-26680)
https://github.com/python/cpython/commit/cb7230c7a7d6d497e54c25e9ba640e
Joannah Nanjekye added the comment:
@Bonifacio2, As commented on the PR, I think opening a PR with a patch close to
what @berker.peksag suggested looks more elaborate, IMHO.
Thanks for your contribution.
--
nosy: +nanjekyejoannah
___
Python
Joannah Nanjekye added the comment:
Since this is the intended behavior, we can just close the issue.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue44
Joannah Nanjekye added the comment:
I mean intended wording
--
___
Python tracker
<https://bugs.python.org/issue44526>
___
___
Python-bugs-list mailin
Joannah Nanjekye added the comment:
New changeset 66c5853406bbcccecf35372795078c0641a5f385 by Furkan Onder in
branch 'main':
bpo-26329: update os.path.normpath documentation (GH-20138)
https://github.com/python/cpython/commit/66c5853406bbcccecf35372795078c
Joannah Nanjekye added the comment:
I can reproduce the described scenario. I will nosy Pablo and Neil for another
eye.
I suggest that if it's not a bug, then maybe the docs should be updated to
explain this behavior.
The only part that talks about exceptions in the documentatio
Change by Joannah Nanjekye :
--
keywords: +patch
nosy: +nanjekyejoannah
nosy_count: 2.0 -> 3.0
pull_requests: +27437
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/29163
___
Python tracker
<https://bugs.p
Joannah Nanjekye added the comment:
@bernat and ncoghlan, please see if the wording I have used in the linked PR
helps to clarify this.
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
I opened a documentation PR agreeing with @ncoghlan, that adds this behavior.
See https://bugs.python.org/issue44665
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue42
Joannah Nanjekye added the comment:
I meant, "that describes the behaviour"
--
___
Python tracker
<https://bugs.python.org/issue42538>
___
___
Python-b
Joannah Nanjekye added the comment:
Closing this, someone else can reopen if they see the same.
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Joannah Nanjekye added the comment:
I wonder if this is worth keeping open, since it's old and no one has
reproduced it. I propose closing or OP to share environment details.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.py
New submission from Joannah Nanjekye :
I don't see any tests for the following:
dis.distb
dis.findlabels
They are documented, I wonder if it was intentional.
dis.findlabels is also not dicumented.
--
components: Tests
messages: 404805
nosy: nanjekyejoannah
priority: normal
sev
Change by Joannah Nanjekye :
--
title: Missing tests for he dis module -> Missing tests for the dis module
___
Python tracker
<https://bugs.python.org/issu
Joannah Nanjekye added the comment:
maybe the latter is not a public function.
--
___
Python tracker
<https://bugs.python.org/issue45578>
___
___
Python-bug
Joannah Nanjekye added the comment:
It looks like it actually
--
___
Python tracker
<https://bugs.python.org/issue45578>
___
___
Python-bugs-list mailin
Joannah Nanjekye added the comment:
I left a review on the PR requesting for some tests, if it makes sense.
--
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issue15
Joannah Nanjekye added the comment:
I wonder if the circumstances changed since this is an old issue? the method
looks to have a deprecation warning and changed a bit too, I stand to be
corrected.
--
nosy: +nanjekyejoannah
___
Python tracker
1 - 100 of 379 matches
Mail list logo