[issue10740] sqlite3 module breaks transactions and potentially corrupts data

2014-06-13 Thread Jim Jewett
Jim Jewett added the comment: Removing the existing behavior will almost certainly not be accepted, because of backwards compatibility. Adding new functionality is generally acceptable. Doing that through a new keyword that defaults to the old behavior is fairly common, and generally better

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

2014-06-14 Thread Jim Jewett
Jim Jewett added the comment: On Jun 14, 2014 4:05 AM, "Aymeric Augustin" > preserving the same behavior by default That is a requirement, because of backwards compatibility. > providing more control for users who need a different behavior, for instance people who use SQLite a

[issue18874] Add a new tracemalloc module to trace memory allocations

2013-11-27 Thread Jim Jewett
Jim Jewett added the comment: These comments refer to http://hg.python.org/cpython/file/5c9af8194d3b/Doc/library/tracemalloc.rst which is newer than the current patches. I believe I have consolidated the still-open issues that I see (including those that aren't mine) for this file:

[issue18874] Add a new tracemalloc module to trace memory allocations

2013-11-27 Thread Jim Jewett
Jim Jewett added the comment: Drat: forgot one at line 277 .. function:: get_traced_memory() Get the current size and maximum size of memory blocks traced by the :mod:`tracemalloc` module as a tuple: ``(size: int, max_size: int)``. I have a tendency to read "maximum size" a

[issue8110] subprocess.py doesn't correctly detect Windows machines

2014-06-20 Thread Jim Jewett
Jim Jewett added the comment: It would be good to have the library work unchanged on both implementations. If subprocess only failed later, it would be less good, as the stdlib would then set an example that doesn't actually succeed. Note that the attached patch (by flox) does NOT impl

[issue8110] subprocess.py doesn't correctly detect Windows machines

2014-06-20 Thread Jim Jewett
Jim Jewett added the comment: (The above concerns -- other than whether it is sufficient to work -- do not apply to the change at https://bitbucket.org/ironpython/ironlanguages/commits/b6bb2a9a7bc5/ ) -- ___ Python tracker <http://bugs.python.

[issue21800] Implement RFC 6855 (IMAP Support for UTF-8) in imaplib.

2014-06-23 Thread Jim Jewett
Changes by Jim Jewett : -- stage: -> needs patch type: -> enhancement ___ Python tracker <http://bugs.python.org/issue21800> ___ ___ Python-bugs-list

[issue22000] cross type comparisons clarification

2014-07-17 Thread Jim Jewett
New submission from Jim Jewett: https://docs.python.org/3.5/library/stdtypes.html says "Objects of different types, except different numeric types, never compare equal." Despite the location, this seems to strong a statement, because of subclasses and classes which define __eq__

[issue22001] containers "same" does not always mean "__eq__".

2014-07-17 Thread Jim Jewett
New submission from Jim Jewett: https://docs.python.org/3.5/reference/expressions.html#not-in Containers are permitted to (and generally do) read "same as" as "is or __eq__), which can be confusing -- particularly in the section defining __eq__. Several suggested changes:

[issue22001] containers "same" does not always mean "__eq__".

2014-07-20 Thread Jim Jewett
Jim Jewett added the comment: Ah... "be the same object or compare equal" sounds much better. I don't want "same" to sound like an informal wording for equal, because getting rid of the confusion over NaN and similar objects is the whole point of the revision. On the

[issue19861] Update What's New for Python 3.4

2014-03-11 Thread Jim Jewett
Jim Jewett added the comment: Many people will not realize that the interactive help is affected by inspect or pydoc; it would be courteous to mention this. (Viewing http://docs.python.org/dev/whatsnew/3.4.html#summary-release-highlights ) In the highlights (table of contents?) section

[issue19861] Update What's New for Python 3.4

2014-03-11 Thread Jim Jewett
Jim Jewett added the comment: I do not think it is sufficient to mention the help change under "Other Language Changes", because the people who know to look at that level of detail (let alone that particular location) are not the ones who will b

[issue19861] Update What's New for Python 3.4

2014-03-11 Thread Jim Jewett
Jim Jewett added the comment: "(If the installation has Internet access, it is of course possible to upgrade pip to a release more recent than the bundled pip by using the bundled pip command itself once it is installed.)" --> "(If the installation has Internet acces

[issue19861] Update What's New for Python 3.4

2014-03-11 Thread Jim Jewett
Jim Jewett added the comment: "wave can now write output to unssekable files. " --> "wave can now write output to unseekable files. " -- ___ Python tracker <http://

[issue19861] Update What's New for Python 3.4

2014-03-11 Thread Jim Jewett
Jim Jewett added the comment: Changes in the Python API: "If you use pyvenv in a script and desire that pip not be installed, you must add --wihtout-pip to your command invocation." --> "If you use pyvenv in a script and desire that pip not be installed, you must add --w

[issue5397] PEP 372: OrderedDict

2009-03-01 Thread Jim Jewett
Jim Jewett added the comment: I would try to make it more explicit that updates do not reset the order, but deleting a item and re-inserting it *does*. (So it isn't the first insertion of the key, it is the first that hasn't yet been followed by a deletion.) Maybe change:

[issue5397] PEP 372: OrderedDict

2009-03-01 Thread Jim Jewett
Jim Jewett added the comment: I would also recommend strengthening some of the tests with regard to ordering stability across update vs delete-and-reinsert. TestOrderedDict.test_update does verify that updated items are not moved to the end, but the comment suggests it is only checking that

[issue5402] MutableMapping code smell (see OrderedDict)

2009-03-01 Thread Jim Jewett
New submission from Jim Jewett : Copy of issue 5397 In python 3, UserDict (and DictMixin) are gone; presumably they should be replaced by either a dict subclass or the ABC MutableMapping. Unfortunately, there doesn't seem to be a clean way to inherit from both. In python 2.x, you

[issue1943] improved allocation of PyUnicode objects

2009-05-30 Thread Jim Jewett
Jim Jewett added the comment: There were a number of patches to support sharing of data between unicode objects. (By Larry Hastings?) They were rejected because (a) they were complicated, and (b) it was possible to provoke pathological memory retention. -- nosy: +jimjjewett

[issue6094] Python fails to build with Subversion 1.7

2009-05-30 Thread Jim Jewett
Jim Jewett added the comment: Would this patch mean that users of pre-1.7 subversion would get build failures? Is it possible to support both forms of wording? -- nosy: +jimjjewett ___ Python tracker <http://bugs.python.org/issue6

[issue28968] xml rpc server fails with connection reset by peer error no 104

2016-12-22 Thread Jim Jewett
Jim Jewett added the comment: When I see a message like that, it normally means there is a firewall getting in my way. -- nosy: +Jim.Jewett ___ Python tracker <http://bugs.python.org/issue28

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

2016-08-25 Thread Jim Jewett
Jim Jewett added the comment: What does overriding to put it back require? Does it require a re-compile, or can it be done via a config file? Taking it out of the default set sounds reasonable, but requiring a recompile for people who want to retain backwards compatibility strikes me as too

[issue27425] Tests fail because of git's newline preferences on Windows

2016-08-25 Thread Jim Jewett
Jim Jewett added the comment: I think if the test is ensuring one line-ending type, then there should be another test ensuring the other... but I think it would be best if there were a single test file that had both types of line-endings, just to ensure that the code doesn't cheat by re

[issue25878] CPython on Windows builds with /W3, not /W4

2016-08-25 Thread Jim Jewett
Jim Jewett added the comment: Is there a way to document why certain warnings are being suppressed, in case someone wants to revisit the suppression later? -- nosy: +Jim.Jewett ___ Python tracker <https://bugs.python.org/issue25

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

2016-08-26 Thread Jim Jewett
Jim Jewett added the comment: I think a python call is fine to require ... if they don't have the python source they should have a support contract. I assume the advice followed is intermediate, based on the earlier comment about xp and ie? On Aug 26, 2016 9:46 AM, "Christian Heim

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-13 Thread Jim Jewett
Jim Jewett added the comment: I'm not sure I correctly understand skrah's proposal. If I do, then (1) The first several lines ( "/* pymacro.h */" until "/* could go into a separate header file */" ) would not be written at all, and are just there to help r

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-03 Thread Jim Jewett
Jim Jewett added the comment: If I know that a Counter (or any class X) can be updated in place, I will be surprised to find out that I'm using a different instance after a successful in-place operation. I would even consider that (replacement of the original instance) a security

[issue22766] collections.Counter's in-place operators should return NotImplemented for unsupported types

2014-11-06 Thread Jim Jewett
Jim Jewett added the comment: I wish there were an APIMismatchError superclass to unify (AttributeError, TypeError). But the wart probably isn't enough to justify the surgery. On Thu, Nov 6, 2014 at 8:48 AM, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > >

[issue16329] mimetypes does not support webm type

2014-12-03 Thread Jim Jewett
Jim Jewett added the comment: I interpreted Issue 15's closure as being about the distinction between Application/webm vs Video/webm, etc. As far as I understand it, the python stdlib doesn't actually care what the major Mime type is, or, frankly, even whether the definition makes

[issue14014] codecs.StreamWriter.reset contract not fulfilled

2015-01-13 Thread Jim Jewett
Jim Jewett added the comment: That sounds like a bug magnet to me; my mental model is that the codec is my output; flushing it will push things out, and resetting it will erase anything pending. I don't care if some implementation detail means that some other object technically owns the b

[issue16991] Add OrderedDict written in C

2015-05-25 Thread Jim Jewett
Jim Jewett added the comment: Eric I realize that O (1) deletion is hard, and don't see a good way around it without changing the implementation ... I just think that the preserving the current C layout may be forcing an even more complicated solution than neccessary. I am nervous

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

2015-08-18 Thread Jim Jewett
Jim Jewett added the comment: I've changed the stage to "test needed". At a minimum, an interactive test should be written and added to the documentation. Better would be an automated test (perhaps via subprocess). The documentation should also be updated; at a minimum, th

[issue24790] Idle: improve stack viewer

2015-08-18 Thread Jim Jewett
Jim Jewett added the comment: Terry: Was removing the public attribute keys OK? -- nosy: +Jim.Jewett ___ Python tracker <http://bugs.python.org/issue24

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

2015-08-20 Thread Jim Jewett
Jim Jewett added the comment: Instead of using python directly in a subprocess, try calling a shell command that in turns calls python. (Admittedly, this may look like the pipe scenario...) In theory, you could even drive another python interactively, using a GUI runner, but I'm not

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

2015-08-20 Thread Jim Jewett
Jim Jewett added the comment: On windows, when python is started from the command line without a GUI, os.isatty(sys.stdin) raises an error, but os.isatty(sys.stdin.fileno()) returns true. Within IDLE, os.isatty(sys.stdin.fileno()) also raises an error, but os.isatty(0), os.isatty(1), and

[issue25216] Warnings stacklevel frames to skip

2015-09-22 Thread Jim Jewett
New submission from Jim Jewett: warnings.warn(stacklevel=2) is a longstanding idiom. It broke in 3.3 because python itself added some additional infrastructure frames in between; now stacklevel should be 8 or 10 in some releases. issue24305 adds a workaround for 3.5, to ignore internal frames

[issue25216] Warnings stacklevel frames to skip

2015-09-22 Thread Jim Jewett
Changes by Jim Jewett : -- stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue25216> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue26286] dis module: coroutine opcode documentation clarity

2016-02-04 Thread Jim Jewett
New submission from Jim Jewett: https://docs.python.org/3/library/dis.html includes a section describing the various opcodes. Current documentation: """ Coroutine opcodes GET_AWAITABLE Implements TOS = get_awaitable(TOS), where get_awaitable(o) returns o if o is a corout

[issue26204] compiler: ignore constants used as statements (don't emit LOAD_CONST+POP_TOP)

2016-02-09 Thread Jim Jewett
Jim Jewett added the comment: I think the warning was helpful; it just had confusing wording. Instead of: """ >>> def f(): ... False ... :2: SyntaxWarning: ignore constant statement """ perhaps: """ >>> def f(): ... False

[issue25937] DIfference between utf8 and utf-8 when i define python source code encoding.

2016-02-10 Thread Jim Jewett
Jim Jewett added the comment: Does (did?) the utf8 special case allow for a much faster startup time, by not requiring all of the codecs machinery? -- nosy: +Jim.Jewett ___ Python tracker <http://bugs.python.org/issue25

[issue26324] sum() incorrect on negative zeros

2016-02-10 Thread Jim Jewett
Jim Jewett added the comment: Even if Ethan's argument about an explicit start value were not convincing, Mark + Raymond would count as authoritative for floats. Anyone can reopen if needed; I just don't want the issue to languish forever if there is at least grudging

[issue26312] Raise SystemError on programmical errors in PyArg_Parse*()

2016-02-10 Thread Jim Jewett
Jim Jewett added the comment: It feels a bit odd to say that I've performed a triage review given the three people already involved -- but I did, and I think it is ready to commit. I believe it is a bug fix, but too subtle a bug to justify backporting. The only question is whether

[issue26296] colorys rgb_to_hls algorithm error

2016-02-10 Thread Jim Jewett
Jim Jewett added the comment: The modulus fixes it for exact numbers. It doesn't produce exactly the same result with floats, because of rounding. Is that a problem? -- nosy: +Jim.Jewett ___ Python tracker <http://bugs.python.org/is

[issue27032] Remove deprecated html.parser.HTMLParser.unescape()

2016-05-23 Thread Jim Jewett
Jim Jewett added the comment: Looks Good To Me -- nosy: +Jim.Jewett ___ Python tracker <http://bugs.python.org/issue27032> ___ ___ Python-bugs-list mailin

[issue27038] Make os.DirEntry exist

2016-05-23 Thread Jim Jewett
Changes by Jim Jewett : -- stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue27038> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27021] It is not documented that os.writev() suffer from SC_IOV_MAX

2016-05-23 Thread Jim Jewett
Changes by Jim Jewett : -- stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue27021> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23491] PEP 441 - Improving Python Zip Application Support

2015-02-26 Thread Jim Jewett
Jim Jewett added the comment: I think that instead of application/zip, you want application/zipped-python (or whatever the precise term was). This was one reason to register the MIME type. That said, application/zip is probably not harmful; the worst it should do it hand the archive to a

[issue24088] yield expression confusion

2015-04-30 Thread Jim Jewett
New submission from Jim Jewett: https://docs.python.org/3/reference/expressions.html#yield-expressions Current: """ When a generator function is called, it returns an iterator known as a generator. That generator then controls the execution of a generator function. The execut

[issue24088] yield expression confusion

2015-05-04 Thread Jim Jewett
Jim Jewett added the comment: OK, then how about Current: """ When a generator function is called, it returns an iterator known as a generator. That generator then controls the execution of a generator function. The execution starts when one of the generator’s methods is called

[issue16991] Add OrderedDict written in C

2015-05-22 Thread Jim Jewett
Jim Jewett added the comment: Why does generated file Include/opcode.h show up as changed? It looks like pure whitespace, but I wonder if a similar whitespace change might be making something a space too long somewhere. -- nosy: +Jim.Jewett

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: Eric, unless I'm misreading your debugging info, it is the other way around -- something is in the dict, but not in the list that you iterate over. And since the list that you iterate over looks right, I have to wonder if it was something intern

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: (Just putting my review summary in the main ticket) I'm going to echo the previous comment that maybe trying to emulate the existing dict implementation too carefully just adds complexity. The split-keys implementation shows that there is at least

[issue16991] Add OrderedDict written in C

2015-05-23 Thread Jim Jewett
Jim Jewett added the comment: Should dictobject.h get a bit more changes? In particular, should the following be expanded? #define PyDictKeys_Check(op) (Py_TYPE(op) == &PyDictKeys_Type) #define PyDictItems_Check(op) (Py_TYPE(op) == &PyDictItems_Type) #define PyDictValues_Check(op)

[issue24274] erroneous comments in dictobject.c

2015-05-23 Thread Jim Jewett
New submission from Jim Jewett: https://hg.python.org/cpython/file/2df7c958974e/Objects/dictobject.c#l451 The comments near lookdict suggest that specialized versions such as lookdict_unicode and lookdict_unicode_nodummy cannot return NULL, as that would indicate an Exception was raised

[issue24275] lookdict_* give up too soon

2015-05-23 Thread Jim Jewett
New submission from Jim Jewett: The specialized lookdict_* variants replace themselves with the generic lookdict as soon as a non-unicode key is looked up. They could reasonably leave the replacement to insertdict (line 819, currently assert rather than a replacement), when a non-unicode

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

2016-09-07 Thread Jim Jewett
Jim Jewett added the comment: On Sep 6, 2016 10:55 PM, Donald Stufft added the comment: > In the hypothetical case we don't backport ChaCha20 support and 3DES and AES constructs in TLS are no longer secure... what do you do? Do you just plug your fingers in your ears and hope nobody att

[issue27850] Remove 3DES from cipher list (sweet32 CVE-2016-2183)

2016-09-08 Thread Jim Jewett
Jim Jewett added the comment: In general, the rule is that micro versions (such as 3.4.4 to 3.4.5) should not make any changes that are not clearly bug fixes. If users would call the new API (or ABI) differently, it is almost certainly a change that should be reserved for a development release

[issue27400] Datetime NoneType after calling Py_Finalize and Py_Initialize

2016-09-21 Thread Jim Jewett
Jim Jewett added the comment: Having to (re-)fill the cache once per interpreter seems like a reasonable price to pay. Why is 3.5 not included? Did this not cause problems before the import change, or is it just that this bug is small enough that maybe it isn't worth backpo

[issue28286] gzip guessing of mode is ambiguous

2016-10-03 Thread Jim Jewett
Changes by Jim Jewett : -- title: gzip guessing of mode is ambiguilous -> gzip guessing of mode is ambiguous ___ Python tracker <http://bugs.python.org/issu

[issue28612] str.translate needs a mapping example

2016-11-04 Thread Jim Jewett
New submission from Jim Jewett: One commonly needed string transformation is stripping out certain characters (or only keeping certain characters). This is common enough that it might be worth a dedicated method, except, that, as Stephen J. Turnbull wrote in https://mail.python.org/pipermail

[issue28612] str.translate needs a mapping example

2016-11-04 Thread Jim Jewett
Jim Jewett added the comment: https://mail.python.org/pipermail/python-ideas/2016-November/043539.html by Chris Barker points out that a custom object (which doesn't ever store the missing "keys") may be better still... though I'm not sure it is better enough to

<    1   2   3