[issue9734] ABC issubclass/isinstance leaks in Python 2

2010-09-01 Thread Jim Fulton
New submission from Jim Fulton : I assume ABCs use some sort of cache for issubclass checks. I also assume the cache doesn't use weakrefs, leading to leaks in classes created on the fly (as is common in tests). The attached script demonstrates the leak. The leak doesn't seem t

[issue9736] doctest.DocTestSuite doesn't handle test globs correctly

2010-09-01 Thread Jim Fulton
New submission from Jim Fulton : We often run test suites repeatedly using a debug build of python to look for memory leaks. We also got in the bad habit of using a fork of doctest. Recently, we've switched away from our fork and have noticed a problem with the standard doctest's h

[issue9736] doctest.DocTestSuite doesn't handle test globs correctly

2010-11-02 Thread Jim Fulton
Jim Fulton added the comment: On Tue, Nov 2, 2010 at 5:55 PM, Éric Araujo wrote: > > Éric Araujo added the comment: > > Would you like to work on a patch? Sure. Jim -- ___ Python tracker <http://bugs.pytho

[issue7372] Regression in pstats

2010-01-26 Thread Jim Fulton
Jim Fulton added the comment: On Mon, Jan 25, 2010 at 7:35 PM, Ezio Melotti wrote: > > Ezio Melotti added the comment: > > See also #7372. > > AFAIU add_callers can receive either a tuple or an int (and this is what is > not working now). When I looked at #7372 I wasn&#

[issue8501] --dry-run option doesn't work

2010-04-22 Thread Jim Fulton
New submission from Jim Fulton : The --dry-run option is ignored by the install command. It leads to an error when used as a global option. It should be fixed or removed. I vote for removal, but don't really care. Removal seems easier. :) To reproduce, create the simple project:

[issue14279] simple indexes (in wrappers) should support flat directories of distributions

2012-03-12 Thread Jim Fulton
New submission from Jim Fulton : Currently, distutils2.pypi.wrapper has a notion of a simple index, which has subdirectories for each project as pypi/simple does. This is good. It should also support flat indexes ala a directory of files. -- assignee: eric.araujo components

[issue14280] simple indexes (in wrappers) should not require md5 hashes

2012-03-12 Thread Jim Fulton
New submission from Jim Fulton : Requiring md5s makes it hard to implement simple indexes with simple web servers, where simple indexes include flat directories of distributions. -- assignee: eric.araujo components: Distutils2 messages: 155542 nosy: alexis, eric.araujo, j1m, tarek

[issue14279] packaging.pypi should support flat directories of distributions

2012-03-15 Thread Jim Fulton
Jim Fulton added the comment: Note that "ala a directory of files" wasn't meant to imply local files. It could be a directory of files served via a HTTP (or sftp) server. -- ___ Python tracker <http://bugs.pyt

[issue14280] packaging.pypi should not require checksums

2012-03-15 Thread Jim Fulton
Jim Fulton added the comment: I just clarified that 14279 doesn't imply local files. I'd be fine with a warning about lack of checksums for downloads. -- ___ Python tracker <http://bugs.python.o

[issue31280] Namespace packages in directories added to path aren't importable if packages from the same namespace are in site-packages

2017-08-25 Thread Jim Fulton
New submission from Jim Fulton: I'm having an issue importing from namespaces packages whose directories are added to sys.path and have other packages from the same namespace in site-packages. To reproduce: - Create a virtualenv and install zc.buildout in it (``envdir/bin/pip in

[issue31280] Namespace packages in directories added to path aren't importable if packages from the same namespace are in site-packages

2017-08-25 Thread Jim Fulton
Jim Fulton added the comment: No, but I managed to unattach it, because "Choose File" always feels like a submit button to me. Sorry. Attached. -- Added file: http://bugs.python.org/file47101/z.py ___ Python tracker <http://bu

[issue31280] Namespace packages in directories added to path aren't importable if packages from the same namespace are in site-packages

2017-08-26 Thread Jim Fulton
Jim Fulton added the comment: Wow, OK. It didn't occur to me to look for .pth files. (Buildout doesn't use them.) I guess this is a pip bug or misfeature. I'll head over to pypa. Thanks! -- stage: -> resolved status: open -> closed _

[issue31280] Namespace packages in directories added to path aren't importable if packages from the same namespace are in site-packages

2017-08-26 Thread Jim Fulton
Jim Fulton added the comment: See: https://github.com/pypa/pip/issues/4695 -- ___ Python tracker <http://bugs.python.org/issue31280> ___ ___ Python-bugs-list m

[issue27391] server_hostname should only be required when checking host names

2017-09-17 Thread Jim Fulton
Jim Fulton added the comment: OMG, >1year. :) This was always a minor issue. I still think the current asyncio behavior is dumb, but whatever. FWIW, I tripped on this when adding SSL support to ZEO, which is a client-server *database* protocol used by ZODB, having nothing to do with

[issue25910] Fixing links in documentation

2017-06-03 Thread Jim Fulton
Jim Fulton added the comment: Zope Corporation no longer exists. Any references to it should be in the past tense and without a link. (The http://www.zope.org is for the Zope Foundation, which is a different thing.) -- ___ Python tracker <h

[issue25910] Fixing links in documentation

2017-06-05 Thread Jim Fulton
Jim Fulton added the comment: +1 -- ___ Python tracker <http://bugs.python.org/issue25910> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue25910] Fixing links in documentation

2017-12-06 Thread Jim Fulton
Change by Jim Fulton : -- nosy: -j1m ___ Python tracker <https://bugs.python.org/issue25910> ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue6710] hotshot stats load causes TypeError when multiple files are loaded

2009-08-15 Thread Jim Fulton
New submission from Jim Fulton : I've attached a script that demonstrates the problem. When run with Python 2.5, it outputs statistics. When run with Python 2.6.2 it generates a TypeError: python2.6 hotshotbug.py Traceback (most recent call last): File "hotshotbug.py&qu

[issue6710] hotshot stats load causes TypeError when multiple files are loaded

2009-08-15 Thread Jim Fulton
Jim Fulton added the comment: Fred might be interested. :) -- nosy: +fdrake ___ Python tracker <http://bugs.python.org/issue6710> ___ ___ Python-bugs-list mailin

[issue1641] asyncore delayed calls feature

2009-04-02 Thread Jim Fulton
Jim Fulton added the comment: > Looking back, I think Zope and Medusa should have adopted and evolved > their own copy of asynchat a long time ago... This statement is puzzling. No big deal, but I'm curious why you say this. --

[issue1641] asyncore delayed calls feature

2009-04-02 Thread Jim Fulton
Jim Fulton added the comment: For the record, afaict, Zope wasn't broken by this. Supervisor isn't part of Zope. -- ___ Python tracker <http://bugs.python.

[issue1641] asyncore delayed calls feature

2009-04-02 Thread Jim Fulton
Jim Fulton added the comment: On Apr 2, 2009, at 1:27 PM, Guido van Rossum wrote: > > Guido van Rossum added the comment: > > [Guido] >>> Looking back, I think Zope and Medusa should have adopted and >>> evolved >>> their own copy of asynchat a long

[issue1641] asyncore delayed calls feature

2009-04-02 Thread Jim Fulton
Jim Fulton added the comment: On Apr 2, 2009, at 3:35 PM, Josiah Carlson wrote: > > Josiah Carlson added the > comment: > > I'm not defending the documentation, I'm merely reposting it. > > The documentation for asyncore says, "The full set of meth

[issue9220] Modules no longer usable as context managers

2010-07-10 Thread Jim Fulton
New submission from Jim Fulton : In python 2.7 a module can't be used as a context manager. For example, given the module, t.py: def __enter__(*args): print 'enter', args def __exit__(*args): print 'exit', args In Python 2.6: >>

[issue9220] Modules no longer usable as context managers

2010-07-10 Thread Jim Fulton
Jim Fulton added the comment: On Sat, Jul 10, 2010 at 4:08 PM, Éric Araujo wrote: > > Éric Araujo added the comment: > > Confirmed: http://docs.python.org/reference/datamodel#specialnames > Closing. Sorry! (BTW, using import hackery and a custom module type, you > could

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-25 Thread Jim Fulton
New submission from Jim Fulton: I recently ported ZEO to asyncio. We'd had a bug in our old asyncore-based server where the server would hang if several connections were made and then immediately disconnected on Mac OS X. This was due to an error-handling bug in our code that we fixed

[issue27391] server_hostname should only be required when checking host names

2016-06-26 Thread Jim Fulton
New submission from Jim Fulton: If the given ssl context has check_hostname set to False, then the server_hostname shouldn't be required. -- components: asyncio messages: 269292 nosy: gvanrossum, haypo, j1m, yselivanov priority: normal severity: normal status: open

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-26 Thread Jim Fulton
New submission from Jim Fulton: The event loop create_connection method can take a socket to create a connection on an existing socket, including sockets obtained via an external listener. If an SSL context is provided, however, it assumes it's creating a client connection, maki

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-26 Thread Jim Fulton
Jim Fulton added the comment: FWIW, using uvloop avoids the hang. -- ___ Python tracker <http://bugs.python.org/issue27386> ___ ___ Python-bugs-list mailin

[issue27391] server_hostname should only be required when checking host names

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: It's not bug, it's a misfeature, IMO. If you pass an SSL context and either don't pass a hostname or pass an empty string, then server_hostname is required, even if check_hostname is false for the context. The fix is trivial. I'd be h

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: This is already pretty minimal. There are no external dependencies. -- ___ Python tracker <http://bugs.python.org/issue27

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Tests are also unstable with uvloop. (Although uvloop doesn't have http://bugs.python.org/issue27386 at least.) I was eventually able to wrestle the test into submission using asyncio.Server. I suspect that some of this had to do with issues closing connec

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Guido, IMO, there's value in having the ability to accept connections independently of handling them. It wasn't clear to me from reading the documentation that create_connection is only meant for making client connections, especially given that it c

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: I agree that if create_server (or asyncio.Server) is buggy, it should be fixed! However, IMO, it's useful to be able to accept a connection outside of an asyncio event loop and then hand the loop the connected s

[issue27391] server_hostname should only be required when checking host names

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: I'm not sure I understand your question. The documentation for create_connection, https://docs.python.org/3/library/asyncio-eventloop.html#creating-connections states that server_hostname is required if the host is empty. (I'm generalizing "em

[issue27391] server_hostname should only be required when checking host names

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Consider this a suggestion. Do with it what you will. I'm closing this as I don't want to spend more time on it other than creating a PR if requested. -- status: open -> closed ___ Python t

[issue27391] server_hostname should only be required when checking host names

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: No need to apologize! My capitulation was just due to the fact that this isn't a big deal. (My tone probably came across as cranky; sorry) WRT backward compatibility, I suspect that there's a bit of wiggle here between loop implementations and I doubt

[issue27391] server_hostname should only be required when checking host names

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: OK, sure, I'll make a PR. -- ___ Python tracker <http://bugs.python.org/issue27391> ___ ___ Python-bugs-list mailing list

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Yury, I'm curious what you think the socket argument to create_connection is about. -- ___ Python tracker <http://bugs.python.org/is

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: BTW, a problem with this proposal that I realized after submitting it is that it changes an API that has multiple implementations, including implementations outside of the Python codebase. Arguably, this would require a PEP, at which point the change is no

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Changes by Jim Fulton : Removed file: http://bugs.python.org/file43540/echo.py ___ Python tracker <http://bugs.python.org/issue27386> ___ ___ Python-bugs-list mailin

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: OK, I *was* able to simplify it a fair bit. I'm uploading a new version. I left prints in because I think you'd find them helpful, but I'll upload another version without prints. -- Added file: http://bugs.python.org/fi

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Here's a version sans prints -- Added file: http://bugs.python.org/file43581/echo-no-print.py ___ Python tracker <http://bugs.python.org/is

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: >> Yury, I'm curious what you think the socket argument to create_connection is >> about. > > :) The current intended purpose of create_connection is to create a client > connection. You're proposing to add a new argument -- serve

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: See: https://bugs.launchpad.net/zodb/+bug/135108/comments/9 Sorry, I should have sent that link sooner. In my flailing to come up with a simple case, I forgot the importance of that setting. -- ___ Python tracker

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Guido, are you saying that the script runs without hanging for you? (If you get a boatload of tracebacks, that's due to another asyncio bug in error handling.) Are you running the version with prints? This is an adaptation of the echo server and client fro

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Sorry, ignore my last message -- ___ Python tracker <http://bugs.python.org/issue27392> ___ ___ Python-bugs-list mailing list Unsub

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: Yuri, right you are. Thanks. Марк, see https://bugs.launchpad.net/zodb/+bug/135108/comments/9 -- ___ Python tracker <http://bugs.python.org/issue27

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: WRT CPython/sockets this problem doesn't happen if I use asyncore to accept connections and hand them off to create_connection. :) It also doesn't occur with uvloop, which I assume still uses sockets. Also, FWIW, the relevant ZEO test passes if I use

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: With SSL, the protocol is a little different clients and servers, although that may just be in the handshake. I'm no SSL expert by any means. When you call wrap_socket on an SSLContext, you can pass server_side, which defaults to False. If you get this

[issue27392] Add a server_side keyword parameter to create_connection

2016-06-29 Thread Jim Fulton
Jim Fulton added the comment: :) I'm not a fan of monkey patching code in production, unless the code I'm monkey patching is code I control. (And since releasing code now is a lot easier than it used to be, I have much less occasion to monkey-patch code I control.) (I'm a bi

[issue27456] TCP_NODELAY

2016-07-05 Thread Jim Fulton
New submission from Jim Fulton: tl;dr TCP_NODELAY should be set by default and/or there should be a proper way to set it. I've ported ZEO, ZODB's client-server networking layer to asyncio. Things were going pretty well. I've been developing on a Mac. Yesterday, I ran s

[issue27456] TCP_NODELAY

2016-07-05 Thread Jim Fulton
Jim Fulton added the comment: Gaaa, forgot to set meta data. -- components: +asyncio nosy: +gvanrossum, haypo, yselivanov type: -> performance versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue27456] TCP_NODELAY

2016-07-05 Thread Jim Fulton
Jim Fulton added the comment: I forgot to switch to the asyncio branch of ZEO when testing on the Amazon/RedHat linux. When I do, the tests run slow there too. Asyncio is dog slow on every linux I've tried. -- ___ Python tracker

[issue27456] TCP_NODELAY

2016-07-05 Thread Jim Fulton
Jim Fulton added the comment: Yury, I'd be fine with you making a PR. :) Is there a similar update that can be made to uvloop? -- ___ Python tracker <http://bugs.python.org/is

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-07-06 Thread Jim Fulton
Changes by Jim Fulton : -- type: behavior -> security ___ Python tracker <http://bugs.python.org/issue27386> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue27456] TCP_NODELAY

2016-07-07 Thread Jim Fulton
Jim Fulton added the comment: I missed the point that you can get a transport's socket using get_extra_info. IMO, this provides an adequate escape from the default and qualifies as a "proper way to set it". I still think the default should be to ena

[issue27392] Add a server_side keyword parameter to create_connection

2016-07-09 Thread Jim Fulton
Jim Fulton added the comment: I'd still like to find a way to handle already accepted server sockets. Can we decide on either: - a server_side flag to create_connection or - A new interface for handling an already accepted socket? I would call this handle_connection, but I'll tak

[issue27392] Add a server_side keyword parameter to create_connection

2016-07-09 Thread Jim Fulton
Jim Fulton added the comment: We need an executive (Guido) decision on the name of the new API. Yury wants wrap_socket. I don't like wrap_socket because: - It implies that it's for wrapping client and server sockets. (It shouldn't be for wrapping client sockets because

[issue27392] Add a server_side keyword parameter to create_connection

2016-07-09 Thread Jim Fulton
Jim Fulton added the comment: > Why can't `wrap_socket` be used for wrapping client sockets? TOOWTDI and create_connection. I suppose we could remove (unadvertise) this functionality from create_connection. Then we'd have code bloat because backward

[issue27392] Add a server_side keyword parameter to create_connection

2016-07-14 Thread Jim Fulton
Jim Fulton added the comment: Here's a daft doc update. -- keywords: +patch Added file: http://bugs.python.org/file43718/connect_accepted_socket-doc.patch ___ Python tracker <http://bugs.python.org/is

[issue27392] Add a server_side keyword parameter to create_connection

2016-07-18 Thread Jim Fulton
Jim Fulton added the comment: Does the draft doc change look OK? -- ___ Python tracker <http://bugs.python.org/issue27392> ___ ___ Python-bugs-list mailin

[issue27392] Add a server_side keyword parameter to create_connection

2016-08-07 Thread Jim Fulton
Jim Fulton added the comment: FTR another use case for this. :) We have a ZEO applications where individual database users authenticate via self-signed certs. The server's SSL connection has to have this collection of certs. User CRUD operations can add and remove certs to authent

[issue27392] Add a server_side keyword parameter to create_connection

2016-08-08 Thread Jim Fulton
Jim Fulton added the comment: idk if the patch got merged. I just added the last comment for informational purposes. :) Perhaps this issue can be closed. -- ___ Python tracker <http://bugs.python.org/issue27

[issue27392] Add a server_side keyword parameter to create_connection

2016-08-09 Thread Jim Fulton
Jim Fulton added the comment: WRT boolean for SSL, I think it's very common for clients to verify server certificates, but relatively uncommon for servers to require client certificates. The impression I have from reading docs and stack overflow posts that the most common use case fo

[issue27392] Add a server_side keyword parameter to create_connection

2016-08-09 Thread Jim Fulton
Jim Fulton added the comment: +1 restricting uvloop to AF_INET or AF_UNIX and SOCK_STREAM, at least until someone requests something else. -- ___ Python tracker <http://bugs.python.org/issue27

[issue27391] server_hostname should only be required when checking host names

2016-09-15 Thread Jim Fulton
Jim Fulton added the comment: SSL is used for more than just HTTP. The are applications in which clients have server public keys that they use to authenticate servers rather than using certificate authorities. For these applications, server host names are irrelevant. This is why it makes

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-09-16 Thread Jim Fulton
Jim Fulton added the comment: Cool, I will verify soon. -- ___ Python tracker <http://bugs.python.org/issue27386> ___ ___ Python-bugs-list mailing list Unsub

[issue27391] server_hostname should only be required when checking host names

2016-09-16 Thread Jim Fulton
Jim Fulton added the comment: I'm not ignoring anything AFAICT. There are applications where server hostname isn't useful (no virtual hosts, client has server's public key). I'm not positive we're disagreeing, so let me put this another way. 1. If the given SSL conte

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-09-17 Thread Jim Fulton
Jim Fulton added the comment: Yes, that change addresses this issue. Thanks! Will this be backported? -- resolution: -> fixed ___ Python tracker <http://bugs.python.org/issu

[issue27386] Asyncio server hang when clients connect and immediately disconnect

2016-09-26 Thread Jim Fulton
Jim Fulton added the comment: This is arguably a security issue because it's a DoS vector. I don't feel strongly about it though. -- ___ Python tracker <http://bugs.python.o