Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue22490>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
I've filed [Homebrew/brew#7204](https://github.com/Homebrew/brew/issues/7204)
to track the testing/validation of this change against Homebrew.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
New changeset 9a81ab107a54b8ca320fb703f7c68e14ccd9d016 by Zackery Spytz in
branch 'master':
bpo-39830: Add zipfile.Path to __all__ (GH-19115)
https://github.com/python/cpython/commit/9a81ab107a54b8ca320fb703f7c68e
Jason R. Coombs added the comment:
New changeset 15e5024d04fc89d948ae761d88048bc58a56b650 by Roman Yurchak in
branch 'master':
bpo-40029 mark test_importlib.test_zip as requiring zlib (#19105)
https://github.com/python/cpython/commit/15e5024d04fc89d948ae761d88048bc58a56b650
-
Jason R. Coombs added the comment:
Thanks for the report and the fix.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 4b4e90a51848578dc06341777a929a0be4f4757f by Jason R. Coombs in
branch 'master':
bpo-35967: Baseline values for uname -p (GH-12824)
https://github.com/python/cpython/commit/4b4e90a51848578dc06341777a929a
Jason R. Coombs added the comment:
New changeset 3e72de9e08b03a15875f5b226c5f096e567dab42 by Miss Islington (bot)
in branch '3.8':
[3.8] bpo-39667: Sync zipp 3.0 (GH-18540) (GH-18701)
https://github.com/python/cpython/commit/3e72de9e08b03a15875f5b226c5f09
Jason R. Coombs added the comment:
In the 3.8 backport, I retained API compatibility and backported only the
performance improvement code.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Change by Jason R. Coombs :
--
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue35967>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
The aformentioned test broke tests in buildbots:
https://buildbot.python.org/all/#builders/105/builds/779
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Jason R. Coombs :
--
pull_requests: +18891
pull_request: https://github.com/python/cpython/pull/19544
___
Python tracker
<https://bugs.python.org/issue35
Jason R. Coombs added the comment:
I'm hoping that PR 19544 fixes the issue.
--
___
Python tracker
<https://bugs.python.org/issue35967>
___
___
Pytho
Jason R. Coombs added the comment:
New changeset e72cbcb346cfcc1ed7741ed6baf1929764e1ee74 by Jason R. Coombs in
branch 'master':
bpo-35967: Make test_platform.test_uname_processor more lenient to satisfy
build bots. (GH-19544)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 518835f3354d6672e61c9f52348c1e4a2533ea00 by Jason R. Coombs in
branch 'master':
bpo-35967 resolve platform.processor late (GH-12239)
https://github.com/python/cpython/commit/518835f3354d6672e61c9f52348c1e
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +19044
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19722
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 7f7e706d78ab968a1221c6179dfdba714860bd12 by Jason R. Coombs in
branch 'master':
bpo-39791: Add files() to importlib.resources (GH-19722)
https://github.com/python/cpython/commit/7f7e706d78ab968a1221c6179dfdba
Jason R. Coombs added the comment:
It was intentional to address issue35967, although it was meant to remain
compatible.
Is len(uname()) an important behavior to retain? It feels like an
implementation detail to me.
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
If it is important to retain the `len`, it's probably also important to retain
the `[-N]` accesses and possibly other behaviors of a length 6 tuple.
--
___
Python tracker
<https://bugs.python.org/is
Change by Jason R. Coombs :
--
pull_requests: +19326
pull_request: https://github.com/python/cpython/pull/20015
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
I've merged PR 19722. Some follow up actions I'd like to do:
- Add hooks for `.files()` on built-in loaders.
- Replace `loader.get_resource_reader()` with adapters around `.files()` for
built-
Jason R. Coombs added the comment:
Thanks David for the report and the draft PR (which helped me validate my
thinking on the matter). In PR 20015, I've included additional tests. I've also
re-written the compatibility functions to rely on the main `__iter__` override.
Another
New submission from Jason R. Coombs :
In issue40570, I learned that some users are still relying on legacy tuple-like
behaviors of `platform.uname()`, namely the access by item position and length:
```
platform.uname()[0]
len(platform.uname())
```
I propose to deprecate these behaviors and
Jason R. Coombs added the comment:
Thanks Marc-Andre for the suggestion, but I don't think that approach is viable
here. The whole point of issue35967 was to defer the execution of the
`.processor` behavior until it was requested. The intention is not to extend
the tuple, but to short
Jason R. Coombs added the comment:
New changeset 2c3d508c5fabe40dac848fb9ae558069f0576879 by Jason R. Coombs in
branch 'master':
bpo-40570: Improve compatibility of uname_result with late-bound .platform
(#20015)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
I've gone ahead and merged PR 20015 to fix the issue, but I'm happy to revisit
if a better approach is proposed.
--
keywords: +3.9regression -patch
resolution: -> fixed
stage: patch review -> resolved
status
Jason R. Coombs added the comment:
In https://github.com/jaraco/cpython/tree/bc73729eb9, I started drafting a
proposed implementation to address this concern, but ran into a snag - the
tests immediately reveal that `tuple(platform.uname())` invokes `__len__`,
triggering the deprecation
Jason R. Coombs added the comment:
> you added a late binding optimization for the whole uname return
tuple to save the effort of ... shell access.
It wasn't to save the effort and it wasn't an optimization. There was a
fundamental race condition where it became impossible t
Jason R. Coombs added the comment:
In issue40570, Marc-Andre writes:
> I don't think that deprecating standard tuple access is an option
for the uname() return value, since it's documented to be a tuple.
My thinking here is that as part of the deprecation, the documentation woul
Jason R. Coombs added the comment:
My bad. I probably could have been more proactive about providing a reproducer.
The problem, as described above (msg335220) and in the associated cmdix ticket,
is that invocation of `platform.(anything)` causes shelling out to execute
"uname", s
Jason R. Coombs added the comment:
Today I ran into an issue due to this change. I have a test that sets
`os.environ['HOME']` in order to ensure that `os.path.expanduser(~)` returns
that value
(https://github.com/pypa/setuptools/blob/f6f25adfc81df76e186bf6c3738a1baa0f92be05/setupt
Jason R. Coombs added the comment:
I should also point out that this was a documented feature of Python that was
removed without any deprecation period.
--
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
I addressed the [setuptools test suite
issue](https://github.com/pypa/setuptools/issues/2112) with [this
commit](https://github.com/pypa/setuptools/commit/f866311d60f54499c3637309e3429780d8c8f218).
What was a one-line elegant solution is now multiple lines
Jason R. Coombs added the comment:
> Platform differences can be papered over with functions.
I’m not suggesting that from within Python there should be another way to
detect a home directory. The expanduser functionality as written is just fine
for that, though I agree with Steve that us
Jason R. Coombs added the comment:
> I thought it might be useful for testing purposes if os.path (i.e. ntpath and
> posixpath) had a way to set the home directory that it uses in way that
> wouldn't affect other libraries and child processes.
I was thinking about this, and
New submission from Jason R. Coombs :
In https://github.com/jaraco/path/issues/186, the Path project discovered a
regression with Python 3.8. It seems that if one creates a symlink with an
absolute path. I used `shutil.copytree('temp', 'temp2', True)` and it p
Jason R. Coombs added the comment:
Thank you Eryk for the thorough and informative investigation. Seriously, wow.
> Do you want 3.8 to revert to using the print name, at least for symlinks?
> (ntpath._readlink_deep would need to be modified to support long target
> paths.) Or
Jason R. Coombs added the comment:
I strongly suspect bpo-37834 and GH-15231 is where the difference was
introduced.
--
___
Python tracker
<https://bugs.python.org/issue40
Jason R. Coombs added the comment:
> This is only an issue for broken symlinks, right? (More precisely, those that
> cannot be resolved, which may include very long paths on some machines.)
Unfortunately, no. In the original post above, you can see temp/bar points to
C:\Users\jarac
Jason R. Coombs added the comment:
Thanks William for the detailed problem description.
If the issue has been fixed on Python 3.9 but not on 3.8, then it was likely a
redesign that enabled the improved behavior, a redesign that won't be ported
back to Python 3.8 and earlier. In
Jason R. Coombs added the comment:
I'll take a look at the patch and convert it to a PR.
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org
Jason R. Coombs added the comment:
I've applied the patches and pushed them to
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780.
```
cpython master $ http
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
| git apply
cpython master
Change by Jason R. Coombs :
--
versions: +Python 3.10 -Python 2.7, Python 3.7
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list m
Change by Jason R. Coombs :
--
pull_requests: +22527
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23661
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Erlend, inspired by your patches, I created
https://github.com/python/cpython/pull/23661/commits/e9723003d49c722d57a69e5016b442d4d752fc6d,
which uses a NullSocket instance instead of None, allowing the
behavior-suppression to be encapsulated in a single
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
I've ported the initial patch over to the backport and am exploring options in
https://github.com/python/importlib_metadata/pull/266.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
In discussion, I realized that I don't yet understand what use-cases drive this
demand? What code is it that requires resolving a distribution from an entry
point?
--
___
Python tracker
<https://bugs.py
Jason R. Coombs added the comment:
This issue was implemented, just not as fully as I'd have hoped. Still lacking
is native support for .files on the built-in package providers and removing the
legacy APIs or at least configuring them to rely on the files API, but as far
as supplyin
Change by Jason R. Coombs :
--
pull_requests: +22614
pull_request: https://github.com/python/cpython/pull/23758
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
The PR for the related issue does address pickling. Do you expect pickles to
work across Python versions?
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +22672
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset dfdca85dfa64e72df385b3a486f85b773fc0f135 by Jason R. Coombs in
branch 'master':
bpo-42382: In importlib.metadata, `EntryPoint` objects now expose `dist`
(#23758)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
I started work on a test in
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780-test, but (a) the test
was failing to exhibit the expected failures, and (b) I realized that the fix
isn't having the intended effect either, because for unix so
Change by Jason R. Coombs :
--
assignee: jaraco ->
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mai
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
> Regardless of whether PR 23611 is accepted, the test that it adds should be
> added to Python master to guard against regressions. I can submit that as a
> separate PR. Before I do that, do I need to create a new bpo ticket, or can I
> ju
Jason R. Coombs added the comment:
Can you tell me more about the use-case that exhibited this undesirable
behavior? That is, what loader is it that supports `open_binary` but not
`is_resource` and doesn't have a `__origin__`?
--
___
P
Jason R. Coombs added the comment:
In [this
commit](https://github.com/python/importlib_resources/commit/bd20d893f11f387d285c666bc99fd2d4a7c33ef8),
I've reconciled and merged the changes from importlib_resources 3.2-5.0,
mainly the namespace package support
(https://impo
Jason R. Coombs added the comment:
Thanks!
No rush, but ideally soon enough to be merged before the beta release of Python
3.10 (2021-05-03).
--
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
> Why do we keep setuptools?
I agree; would be good to remove it if possible.
There are many packages that fail to build without Setuptools being present or
--use-pep517 indicated. It would be nice if pip could make --use-pep517 the
default, update t
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue42531>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
pull_requests: +23055
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23057
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23056
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
I've encountered this issue again with a different use-case.
I'm attempting to add a doctest to a routine that emits the paths of the files
it processes. I want to use ellipses to ignore the prefixes of the output
because they're not pertin
Jason R. Coombs added the comment:
The change to error handling for zipp.Path was added in
https://github.com/jaraco/zipp/issues/46 and released as
[3.1.0](https://zipp.readthedocs.io/en/latest/history.html#v3-1-0). Probably
that change was incorporated into CPython shortly thereafter with
Jason R. Coombs added the comment:
Today I encountered another situation where it would be convenient to allow an
ellipsis at the beginning of the syntax:
>>> pathlib.Path('abc')
...Path('abc')
Because pathlib.Path resolves to `PosixPath` and `WindowsPath` d
Jason R. Coombs added the comment:
As of June last year, Python 3.7 is in security fix only mode, so there's
nothing more to be done here.
--
nosy: +jaraco
resolution: -> fixed
stage: patch review -> resolved
status: pending -> closed
Jason R. Coombs added the comment:
For the first two errors, the issue seems to be that CPython includes tests for
the ResourceReader ABC and asserts that .contents() returns an empty list as
the default degenerate behavior
(https://github.com/python/cpython/blob
Jason R. Coombs added the comment:
> I would harmonize towards what the concrete implementations...
For FileReader and ZipReader, both rely on TraversableResources to implement
contents, which rely on `files().iterdir()`, which could raise
FileNotFoundError and definitely don't retu
Jason R. Coombs added the comment:
I've pushed [this
branch](https://github.com/python/cpython/tree/feature/42129-resources-namespace-packages),
which includes fixes for the above two identified issues. Still one issue
remains:
ERROR: test_package_has_no_reader_fal
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +23456
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24670
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've stumbled into this issue and it's started occurring reliably on keyring in
Python 3.6 as found on Github CI
(https://github.com/jaraco/keyring/runs/1994652010?check_suite_focus=true).
It's not a highly-reproducible environment. I can&#x
Jason R. Coombs added the comment:
I started tracking it down in https://github.com/jaraco/keyring/issues/494 and
found I'd previously delved deep into a related issue
(https://github.com/jaraco/keyring/issues/281).
--
___
Python tracker
&
Jason R. Coombs added the comment:
All good. Thanks for the references. As with the prior issues, I'm going to
just suppress those failures.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
Hey Steve. Thanks for the clarification. I'd forgotten the context,
specifically that any patches needed to be merged before the PEP was accepted,
and was working from a memory that we were willing to accept this change. Happy
to revert it, as that
Change by Jason R. Coombs :
--
pull_requests: +23524
pull_request: https://github.com/python/cpython/pull/24753
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset fbf75b9997e280b1220755d0a17dbed71240d42e by Jason R. Coombs in
branch 'master':
Revert "bpo-42405: fix C extensions build on Windows ARM64 (GH-23399)" (#24753)
https://github.com/python/cpython/commit/fbf75b9997e280b12207
Jason R. Coombs added the comment:
New changeset 67148254146948041a77d8a2989f41b88cdb2f99 by Jason R. Coombs in
branch 'master':
bpo-42129: Add support for resources in namespaces (GH-24670)
https://github.com/python/cpython/commit/67148254146948041a77d8a2989f41
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
For posterity, I'll share my motivation.
> Why is it a problem that people are using something which is documented as a
> tuple?
It's not a problem that they access it by tuple if it's documented.
The problem is that it's docume
New submission from Jason R. Coombs :
While troubleshooting a strange problem
(https://github.com/jaraco/keyring/issues/498) where a program worked on Python
3.7+ but failed on Python 3.6, I discovered a somewhat unintuitive behavior. On
Python 3.7+, keyword arguments to tuple subclasses are
Jason R. Coombs added the comment:
To be abundantly clear, the downstream issue was a coding error, but the coding
error was masked on Python 3.7+ when the subclass didn't reject the invalid
usage.
--
___
Python tracker
<https://bugs.py
Jason R. Coombs added the comment:
I see that changelog entry traces back to bpo-29695, but I don't believe it's
relevant to this issue.
--
___
Python tracker
<https://bugs.python.o
Jason R. Coombs added the comment:
I suspect bpo-20186 is implicated.
--
___
Python tracker
<https://bugs.python.org/issue43413>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
I suspect change in this issue led to issue43413.
--
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue20
Jason R. Coombs added the comment:
In particular, [this
commit](https://github.com/python/cpython/commit/0b5615926a573c19c887a701a2f7047f4fd06de6).
--
___
Python tracker
<https://bugs.python.org/issue43
701 - 800 of 1490 matches
Mail list logo
