Change by Jason R. Coombs :
--
pull_requests: +15899
pull_request: https://github.com/python/cpython/pull/16321
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +15900
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16321
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've added PR 16321 illustrating my proposed solution. This solution, while
more invasive than Tim's more surgical solution, addresses the concerns brought
about by this issue as well as those articulated originally in issue36274.
I'm sligh
Jason R. Coombs added the comment:
I should say, though, this issue is a long-standing regression from Python 3.0.
Although intentional, the inability for a client to override the encoding of
the request line does make it impossible without replacing all of .putrequest
to override that
Jason R. Coombs added the comment:
In https://github.com/cherrypy/cherrypy/pull/1807, I discovered that there is
already a fairly straightforward means for a third-party package to override
the putrequest character validation (just monkeypatch
http.client._contains_disallowed_url_pchar_re
Jason R. Coombs added the comment:
Also, with the CherryPy approach, the Python 2.7 story is more complicated. I
haven't yet addressed that in the CherryPy 17 maintenance branch (which
supports Python 2.7).
--
___
Python tracker
&
Change by Jason R. Coombs :
--
pull_requests: +16027
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16448
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +16028
pull_request: https://github.com/python/cpython/pull/16448
___
Python tracker
<https://bugs.python.org/issue36
Jason R. Coombs added the comment:
New changeset 7774d7831e8809795c64ce27f7df52674581d298 by Jason R. Coombs in
branch 'master':
bpo-38216, bpo-36274: Allow subclasses to separately override validation and
encoding behavior (GH-16448)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 7774d7831e8809795c64ce27f7df52674581d298 by Jason R. Coombs in
branch 'master':
bpo-38216, bpo-36274: Allow subclasses to separately override validation and
encoding behavior (GH-16448)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
pull_requests: +16044
pull_request: https://github.com/python/cpython/pull/16461
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: +16045
pull_request: https://github.com/python/cpython/pull/16461
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16047
pull_request: https://github.com/python/cpython/pull/16462
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16046
pull_request: https://github.com/python/cpython/pull/16462
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
New changeset 80dd66ac278ecbabbf843526e3a56f5031da9562 by Jason R. Coombs in
branch '3.7':
[3.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation
and encoding behavior (GH-16448) (GH-16461)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
New changeset 80dd66ac278ecbabbf843526e3a56f5031da9562 by Jason R. Coombs in
branch '3.7':
[3.7] bpo-38216, bpo-36274: Allow subclasses to separately override validation
and encoding behavior (GH-16448) (GH-16461)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
> Someone should look at how to do similar in 2.7 _if_ the project(s) that
> complained about the problem rely on such behavior in their last 2.7
> compatible releases.
Looking at the history, it seems that only two projects were mentioned,
Che
Change by Jason R. Coombs :
--
pull_requests: +16059
pull_request: https://github.com/python/cpython/pull/16475
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: +16060
pull_request: https://github.com/python/cpython/pull/16475
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16062
pull_request: https://github.com/python/cpython/pull/16476
___
Python tracker
<https://bugs.python.org/issue36
Change by Jason R. Coombs :
--
pull_requests: +16061
pull_request: https://github.com/python/cpython/pull/16476
___
Python tracker
<https://bugs.python.org/issue38
Jason R. Coombs added the comment:
I believe importlib/metadata/__init__ was moved to importlib.metadata. I’ll
inspect the repo for correctness, but there may be another issue with the old
files lingering.
--
___
Python tracker
<ht
Jason R. Coombs added the comment:
I've confirmed that the `metadata` directory doesn't exist in the repo. It also
doesn't appear on my Python 3.8.0b4 installation on macOS:
```
cpython master $ ls
/Library/Frameworks/Python.framework/Versions/3.8/lib/pyth
Jason R. Coombs added the comment:
New changeset f917efccf8d5aa2b8315d2a832a520339e668187 by Jason R. Coombs in
branch 'master':
bpo-43428: Sync with importlib_metadata 3.7. (GH-24782)
https://github.com/python/cpython/commit/f917efccf8d5aa2b8315d2a832a520
Change by Jason R. Coombs :
--
pull_requests: +23618
pull_request: https://github.com/python/cpython/pull/24858
___
Python tracker
<https://bugs.python.org/issue43
Jason R. Coombs added the comment:
New changeset 35d5068928ab5485e5f28b60b1e33062bc2c46cc by Jason R. Coombs in
branch 'master':
bpo-43428: Improve documentation for importlib.metadata changes. (GH-24858)
https://github.com/python/cpython/commit/35d5068928ab5485e5f28b60b1e330
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
assignee: -> jaraco
nosy: +jaraco
___
Python tracker
<https://bugs.python.org/issue43569>
___
___
Python-bugs-list mai
Jason R. Coombs added the comment:
Interestingly, the pull request never alerted to any buildbot failures.
Any idea how I can reproduce the issue locally? Is there a docker image that
would likely replicate the environment in which the tests are failing
Jason R. Coombs added the comment:
Oh, "installed python". So maybe Python requires one register files in more
than one place to add them to the installation.
--
___
Python tracker
<https://bugs.python.o
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +23710
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24952
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've submitted a PR and triggered build by buildbots, but I don't see that the
indicated builder is building the PR. Shall I just submit and see what happens?
Any other ideas how to verify the installed builder
Jason R. Coombs added the comment:
Unfortunately, it seems the patch didn't have the intended effect. The [build
is still failing](https://buildbot.python.org/all/#/builders/14/builds/810). So
I'm left without a way to test without committing code to the main branch.
--
Jason R. Coombs added the comment:
Okay, I think you may be right. I saw your name on the build and assumed that
meant the merge triggered that build. I'll trigger a build now.
--
___
Python tracker
<https://bugs.python.org/is
Jason R. Coombs added the comment:
Assuming Antoine is correct (a likely story), I'm closing and will only re-open
if a subsequent failure is confirmed to have run and failed after the
submission. Sorry for the noise.
--
resolution: -> fixed
status: open -
New submission from Jason R. Coombs :
As reported in https://github.com/python/importlib_resources/issues/210, the
`as_file` function of importlib.resources is undocumented in CPython.
--
messages: 389624
nosy: jaraco
priority: normal
severity: normal
status: open
title
Change by Jason R. Coombs :
--
assignee: -> jaraco
components: +Documentation
type: -> enhancement
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/i
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +23796
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25048
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset af50c84643ce21cfbdfdabbdfae6bd5e1368c542 by Jason R. Coombs in
branch 'master':
bpo-43644: Add docs for importlib.resources.as_file. (#25048)
https://github.com/python/cpython/commit/af50c84643ce21cfbdfdabbdfae6bd
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
No. The issue remains open.
--
stage: -> needs patch
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issu
New submission from Jason R. Coombs :
Incorporate importlib_metadata changes from 3.8 through 3.10:
https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-10-0
Two main changes:
- Add mtime-based caching during distribution discovery.
- Flagged use of dict result from
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +24028
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25297
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
At least I and Ethan and Martin have expressed a desire for the default,
preferred usage work well in a portable environment. Requiring
`delete_on_close=False` violates that expectation.
How about something like this instead:
- Add an `delete_when=None
Change by Jason R. Coombs :
--
pull_requests: +24147
pull_request: https://github.com/python/cpython/pull/25415
___
Python tracker
<https://bugs.python.org/issue37
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue43856>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
pull_requests: +24177
pull_request: https://github.com/python/cpython/pull/25448
___
Python tracker
<https://bugs.python.org/issue43
Change by Jason R. Coombs :
--
pull_requests: +24217
pull_request: https://github.com/python/cpython/pull/25494
___
Python tracker
<https://bugs.python.org/issue43
Change by Jason R. Coombs :
--
pull_requests: +24218
pull_request: https://github.com/python/cpython/pull/25495
___
Python tracker
<https://bugs.python.org/issue43
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Jason R. Coombs :
[importlib_metadata
4.0](https://importlib-metadata.readthedocs.io/en/latest/history.html#v4-0-0)
introduced these important changes to the `metadata` function:
``PackageMetadata`` as returned by ``metadata()``
and ``Distribution.metadata()`` now
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +24284
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/25565
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset c6ca368867bd68d44f333df840aa85d425a51410 by Jason R. Coombs in
branch 'master':
bpo-43780: Sync with importlib_metadata 3.10 (GH-25297)
https://github.com/python/cpython/commit/c6ca368867bd68d44f333df840aa85
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Using zipfile.Path with several files prematurely closes zip
___
Python tracker
<https://bugs.python
Jason R. Coombs added the comment:
Thanks Andrei
--
___
Python tracker
<https://bugs.python.org/issue41350>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Thanks Paul!
--
nosy: +jaraco
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 37e0c7850de902179b28f1378fbbc38a5ed3628c by Jason R. Coombs in
branch 'master':
bpo-43926: Cleaner metadata with PEP 566 JSON support. (GH-25565)
https://github.com/python/cpython/commit/37e0c7850de902179b28f1378fbbc3
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
Sounds good to me. In general, it's easier to contribute first to
https://github.com/jaraco/zipp and those changes can be readily merged into
CPython. No worries, though. If these changes can be accepted here, I should be
able to graft them onto j
Jason R. Coombs added the comment:
Thanks for the excellent patch. I've created
https://github.com/jaraco/zipp/issues/74 to track the backport of these changes.
--
resolution: -> fixed
stage: patch review -> resolved
status: ope
Jason R. Coombs added the comment:
New changeset ab1c3d99f51188d1a6b5f7797294b056279f62e0 by Miss Islington (bot)
in branch '3.9':
bpo-37741: make importlib.metadata docs discoverable through a module
directive. (GH-25415) (GH-25417)
https://github.com/python/cpyt
Jason R. Coombs added the comment:
I'd intended for the changes in 5.1 to make it into CPython, but I've missed
the deadline, so I've backported the referenced commits to importlib_resources
5.0.5 in order to sync into CPython.
--
version
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +24890
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26284
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Thanks for tracking this down, Filipe. Agreed it sounds like it's fixed in
Python 3.10. It's unlikely the fix will be backported to Python 3.9. Instead,
if this behavior affects your usage, consider using the `importlib_resources`
backport,
Change by Jason R. Coombs :
--
resolution: -> not a bug
___
Python tracker
<https://bugs.python.org/issue44162>
___
___
Python-bugs-list mailing list
Un
Change by Jason R. Coombs :
--
pull_requests: +24912
pull_request: https://github.com/python/cpython/pull/26317
___
Python tracker
<https://bugs.python.org/issue44
Jason R. Coombs added the comment:
I don't believe a `TraversableReader` protocol was intended. Instead, the
referenced change introduced the `TraversableResources` ABC. There's a typo in
the docs. I created PR 26317 instead to correct the mis
Jason R. Coombs added the comment:
After reviewing the PR, I'm not convinced the Traversable methods need any
specification about when to raise FileNotFoundError (or other exceptions).
Let's flesh out what conditions demand prescribed
Jason R. Coombs added the comment:
Having a look at the `open` function
(https://docs.python.org/3/library/functions.html#open), it does not define
which exceptions might be thrown. Similarly for pathlib.Path.open
(https://docs.python.org/3/library/pathlib.html#pathlib.Path.open) and
Jason R. Coombs added the comment:
The problem with the `__fspath__` protocol is that it assumes a file system.
The `importlib.resources` and `Traversable` protocols are trying to provide a
lower-level interface that doesn't assume a file system. Fortunately, there
already exists a h
Jason R. Coombs added the comment:
It would be straightforward to add that parameter to `read_text` but I'm
uncertain if it will be needed. Since a Traversable already provides an open
method which _does_ explicitly pass through keyword arguments to the underlying
opener, perhaps it
Jason R. Coombs added the comment:
I've not previously seen a definition of resources. The original implementation
of importlib_resources excluded 'directories' as resources and excluded support
for resources being in subdirectories (only files in packages were allowed).
No
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
> I think `as_file` should learn to behave like `path`, if `__fspath__` is
> available, it will use that path.
Oh, that's an interesting idea. And that's effectively what happens
[here](https://github.com/python/importli
Jason R. Coombs added the comment:
> are people supposed to be implementing readers with just files(), or are they
> always expected to inherit TraversableResources?
A resource provider could potentially implement only the `files()` method (what
I think you're calling `Traver
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
The patch for this change has broken code that relied on the old behavior. For
example:
```
import fileinput
import bz2
import pathlib
target = pathlib.Path('data.bz2')
target.write_bytes(bz2.compress(b'Foo\nBar\nBiz'))
inp = file
Jason R. Coombs added the comment:
A backport now exists (https://pypi.org/project/backports.hook_compressed) and
addresses the issue (https://github.com/jaraco/cmdix/actions/runs/873404846).
--
___
Python tracker
<https://bugs.python.
Jason R. Coombs added the comment:
I did consider and confirm that mode="rb" does also provide a uniform solution,
but it also regresses the behavior of uncompressed inputs, making them bytes
where they were text. This approach feels like the "Python 1" compatibility
ap
Change by Jason R. Coombs :
--
components: Library (Lib)
nosy: jaraco
priority: normal
severity: normal
status: open
title: Sync importlib_metadata enhancements through 4.1.
versions: Python 3.10, Python 3.11
___
Python tracker
<ht
New submission from Jason R. Coombs :
Importlib_metadata 4.1.0 made some minor tweaks. Let's sync those.
--
___
Python tracker
<https://bugs.python.org/is
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +24974
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26382
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 6.0 -> 7.0
pull_requests: +24975
pull_request: https://github.com/python/cpython/pull/26383
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset 06ac3a4742228b0230981720060248a7425b2486 by Jason R. Coombs in
branch 'main':
bpo-44241: Incorporate changes from importlib_metadata 4.1. (#26382)
https://github.com/python/cpython/commit/06ac3a4742228b0230981720060248
Change by Jason R. Coombs :
--
nosy: +jaraco
nosy_count: 3.0 -> 4.0
pull_requests: +24979
pull_request: https://github.com/python/cpython/pull/26387
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
pull_requests: +24980
pull_request: https://github.com/python/cpython/pull/26387
___
Python tracker
<https://bugs.python.org/issue38
Change by Jason R. Coombs :
--
pull_requests: -24979
___
Python tracker
<https://bugs.python.org/issue33693>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
New changeset 97b4576f655c09e32d2cbcdcdbda72b1bf9f438a by Miss Islington (bot)
in branch '3.10':
bpo-38693: Prefer f-strings in importlib.resources (importlib_resources 5.0.6).
(GH-26387) (#26389)
https://github.com/python/cpyt
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
If this issue affects you, please use the `zipp` backport. I realize there are
some use-cases that aren't readily amenable to relying on the backport. Please
report any such use-case here as they may provide a justification for
back-porting the c
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Jason R. Coombs :
--
title: tuple subclasses allow kwargs -> tuple subclasses allow arbitrary kwargs
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
The preferred API as implemented in Python 3.9 and importlib_resources 1.1 is
the `files()` API. This simpler API returns a Traversable object, a
pathlib-like handle to the contents of a package. This approach side-steps the
issues described above. In
Jason R. Coombs added the comment:
This backward incompatibility was unintentionally introduced in
importlib_metadata 3.6
(https://importlib-metadata.readthedocs.io/en/latest/history.html#v3-6-0,
released Feb 23) and was previously reported in
https://github.com/python/importlib_metadata
Jason R. Coombs added the comment:
Yes, perhaps the What's New could be refreshed.
There is a Compatibility Note in the docs for `entry_points` about the
deprecated usage
(https://docs.python.org/3.10/library/importlib.metadata.html?highlight=importlib%20metadata#entry-points).
I wan
Jason R. Coombs added the comment:
In the What's New, I used :func:`importlib.metadata.entry_points`, but that
doesn't seem to resolve to the docs for the function. I need to figure out how
to link to the entry_points anchor th
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +25001
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26408
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Although it feels the topic has shifted from the original concern (an
unintentional incompatibility) to the broader topic of the API change to
entry_points generally, I'm happy to address your comments:
> - I don't think they were discussed th
401 - 500 of 1490 matches
Mail list logo
