Ivan Levkivskyi added the comment:
> Using `__wrapped__` if present sounds like a good idea.
Yeah, I like this idea, this will likely cover most use cases (since most
people actually do use @wraps).
--
___
Python tracker
<https://bugs.pyth
Change by Ivan Levkivskyi :
--
keywords: +newcomer friendly
___
Python tracker
<https://bugs.python.org/issue37838>
___
___
Python-bugs-list mailing list
Unsub
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue37835>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
Thanks for reporting!
I spent some time thinking about this and I can't find any reasonable way of
doing this, sorry. Anyway, let's keep this open, maybe someone will come up
with a proposal.
--
Change by Ivan Levkivskyi :
--
pull_requests: +15104
pull_request: https://github.com/python/cpython/pull/15396
___
Python tracker
<https://bugs.python.org/issue28
Ivan Levkivskyi added the comment:
There is an (old) similar proposal https://github.com/python/typing/issues/402
btw.
Taking into account that this can be made only in 3.9, what is the benefit over
``from __future__ import annotations`` (that one can use already) do you see?
IMO there are
Ivan Levkivskyi added the comment:
Somewhat related to https://bugs.python.org/issue37496
--
nosy: +eric.snow, yselivanov
___
Python tracker
<https://bugs.python.org/issue37
Ivan Levkivskyi added the comment:
It looks like https://github.com/python/cpython/pull/9518 will fix also this
one.
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue37
Ivan Levkivskyi added the comment:
> Maybe any upcoming python version could store this information in __local__ ?
> So maybe we could clone this ticket to the python core in order to address
> this?
I would say it is a too big change, and it is unlikely to happen only for the
re
Change by Ivan Levkivskyi :
--
Removed message: https://bugs.python.org/msg350980
___
Python tracker
<https://bugs.python.org/issue37835>
___
___
Python-bug
Ivan Levkivskyi added the comment:
(Sorry for typos, fixed now.)
> Maybe any upcoming python version could store this information in __local__ ?
> So maybe we could clone this ticket to the python core in order to address
> this?
I would say it is a too big change, and it is un
Ivan Levkivskyi added the comment:
> I'd like to take a stab at putting up a patch for this
Great, thanks! Go ahead and try it.
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org
Ivan Levkivskyi added the comment:
> I anyway always wonder, why functions, which are methods, do not hold a
> reference to the class, which they belong to.
This may indeed be a useful feature on its own, but it will also require a much
more wider disc
Ivan Levkivskyi added the comment:
New changeset 692a0dc91597b7fb350383b633dc4d044cbd360e by Ivan Levkivskyi
(Divij Rajkumar) in branch 'master':
bpo-38008: Move builtin protocol whitelist to mapping instead of list (GH-15647)
https://github.com/python/cpyt
Change by Ivan Levkivskyi :
--
components: +Library (Lib)
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.5, Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
New changeset e082e7cbe4a934b86f7a07354d97d4e14a9dd46a by Ivan Levkivskyi
(plokmijnuhby) in branch 'master':
bpo-37953: Fix ForwardRef hash and equality checks (GH-15400)
https://github.com/python/cpython/commit/e082e7cbe4a934b86f7a07354d97d4
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Ivan Levkivskyi :
--
pull_requests: +15808
pull_request: https://github.com/python/cpython/pull/16204
___
Python tracker
<https://bugs.python.org/issue28
Ivan Levkivskyi added the comment:
New changeset 81528ba2e81c39f4d6bca5b785e818c7d08b8501 by Ivan Levkivskyi in
branch 'master':
bpo-28556: Update the opening note in typing docs (GH-16204)
https://github.com/python/cpython/commit/81528ba2e81c39f4d6bca5b785e818
Ivan Levkivskyi added the comment:
As Serhiy explained, there is no bug here, _potentially_ we could change AST so
that attribute name (i.e. "b" in "a.b") is wrapped in a special node holding
the position info (similar to ``ast.arg``), but it is a breaking change and i
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
Guido, what is your final opinion on this?
--
nosy: +gvanrossum, levkivskyi
___
Python tracker
<https://bugs.python.org/issue38
Ivan Levkivskyi added the comment:
Yes, it is unfortunately hard to support with the new design. Also note that
this was previously discussed at https://github.com/python/typing/issues/629. I
think we can close this, since the other issue has more context.
--
resolution
Ivan Levkivskyi added the comment:
> So, my request is: In the sections for the IO/TextIO/BinaryIO and
> Pattern/Match classes, include text warning the user that these types are not
> imported when you do `from typing import *`.
I don't think this should really be a warning,
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38348>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
The downside however is that exception messages can become very long. So I am
not sure we should change this.
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue38
Ivan Levkivskyi added the comment:
New changeset d47f0dd2e85ce032aebfedbde18cdb2e728fa79f by Ivan Levkivskyi (M.
Eric Irrgang) in branch 'master':
bpo-32996: Documentation fix-up. (GH-16646)
https://github.com/python/cpython/commit/d47f0dd2e85ce032aebfedbde18cdb2e728fa79f
-
Ivan Levkivskyi added the comment:
I don't have any strong opinion either way, so it looks like we need to wait
until someone else will ask for this.
--
___
Python tracker
<https://bugs.python.org/is
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38431>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
___
Python tracker
<https://bugs.python.org/issu
Ivan Levkivskyi added the comment:
If you would like to propose a doc fix, then please go ahead and make a PR.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Ivan Levkivskyi :
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
___
Python tracker
<https://bugs.python.org/issu
Ivan Levkivskyi added the comment:
Actually Serhiy is right, I just checked and found this sentence:
```
Alternatively, annotate your generator as having a return type of either
Iterable[YieldType] or Iterator[YieldType]
```
--
resolution: -> works for me
stage: -> resolved
Ivan Levkivskyi added the comment:
The docs for typing module are clear about this:
```
Using a generic class without specifying type parameters assumes Any for each
position.
```
There is also an example involving a base class.
--
resolution: -> not a bug
stage: -> resolved
Change by Ivan Levkivskyi :
--
pull_requests: +16320
pull_request: https://github.com/python/cpython/pull/16743
___
Python tracker
<https://bugs.python.org/issue28
Ivan Levkivskyi added the comment:
I think adjusting the docs would be less disruptive than changing
implementation. Would you like to make a PR?
--
___
Python tracker
<https://bugs.python.org/issue38
Ivan Levkivskyi added the comment:
New changeset fdfe2833ace93021278fe4c41c40e1d08d70abf9 by Ivan Levkivskyi
(Sebastian Rittau) in branch 'master':
bpo-38467: Fix argument name of typing functions (GH-16753)
https://github.com/python/cpython/commit/fdfe2833ace93021278fe4c41c40e1
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
IMO 3.10 would be better, since 3.9 would be too soon (it would be like a
schedule for a normal deprecation).
Also if we are really doing this, I think it is better to announce this soon.
Also we should try to fix relevant issues related to string
Ivan Levkivskyi added the comment:
Btw this reminds me I should make a PyPI release of typing_inspect (last
release was May 2020), hopefully will make a release on this weekend.
--
___
Python tracker
<https://bugs.python.org/issue44
Ivan Levkivskyi added the comment:
Uploaded typing_inspect 0.7.0 to PyPI (it should work with Python 3.9 hopefully)
--
___
Python tracker
<https://bugs.python.org/issue44
Ivan Levkivskyi added the comment:
You can remove me from both.
--
___
Python tracker
<https://bugs.python.org/issue44659>
___
___
Python-bugs-list mailin
Ivan Levkivskyi added the comment:
Thank you everyone! I hope our paths will cross someday.
--
___
Python tracker
<https://bugs.python.org/issue44659>
___
___
Ivan Levkivskyi added the comment:
> Was it mistake to make isinstance(list[int], type) returning True?
What was the motivation for this? At first glance returning True looks wrong.
--
___
Python tracker
<https://bugs.python.org/issu
Ivan Levkivskyi added the comment:
We already have https://github.com/python/typing/issues/508 for "smart"
`get_type_hints()` that would use LBYL. Also we had a similar discussion about
PathLike, and ultimately decided not to make `typing` a place for generic
versions of
Change by Ivan Levkivskyi :
--
pull_requests: -16560
___
Python tracker
<https://bugs.python.org/issue37838>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
keywords: -patch
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue37838>
___
___
Python-
Ivan Levkivskyi added the comment:
The PR was linked by mistake (it is for a different issue), so I unlinked it.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38782>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
> I'm not sure what can be done with this. The problem is that the decorator
> doesn't know what's in the caller's namespace. The type being added is
> "typing.Any". If the caller doesn't import typing, then get_t
Ivan Levkivskyi added the comment:
No objections from me assuming you are going forward along the way proposed by
Serhiy (i.e. only skip values for certain fields if value is the default, not a
blanket skip for all Nones and empty lists
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
New changeset 0aca3a3a1e68b4ca2d334ab5255dfc267719096e by Ivan Levkivskyi
(benedwards14) in branch 'master':
bpo-37838: get_type_hints for wrapped functions with forward reference
(GH-17126)
https://github.com/python/cpyt
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
> So why is it bad that in the example class B is considered a "subclass" of
> os.PathLike by implementing the protocol?
This is not bad, my understanding of the problem is that currently B is
considered a subclass of A, while the latt
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Ivan Levkivskyi :
The PEP 544 specifies that:
A protocol can be used as a second argument in isinstance() and issubclass()
only if it is explicitly opt-in by @runtime_checkable decorator.
It is not specified exactly whether this should be enforced by static type
checkers
Ivan Levkivskyi added the comment:
Cross-ref to the typing issue https://github.com/python/typing/issues/593. It
looks like there is some interest in this feature.
--
___
Python tracker
<https://bugs.python.org/issue27
Ivan Levkivskyi added the comment:
I see the point in using ``__class_getitem__`` in Python classes too, we can
probably start using a dummy method returning class object itself now. Also PEP
585 already has a long list of candidates for "proper" ``__class_getitem__``
support. Ma
Change by Ivan Levkivskyi :
--
keywords: +easy (C)
___
Python tracker
<https://bugs.python.org/issue38979>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue38947>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue39046>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue39102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
New changeset eae87e3e4e0cb9a0ce10c2e101acb6995d79e09c by Ivan Levkivskyi (Bar
Harel) in branch 'master':
bpo-38878: Fix os.PathLike __subclasshook__ (GH-17336)
https://github.com/python/cpython/commit/eae87e3e4e0cb9a0ce10c2e101acb6
Ivan Levkivskyi added the comment:
New changeset 59d06b987db34cde8783e265709366d244c9e35b by Ivan Levkivskyi (Bar
Harel) in branch '3.7':
[3.7] bpo-38878: Fix os.PathLike __subclasshook__ (GH-17336) (GH-17685)
https://github.com/python/cpython/commit/59d06b987db34cde8783e265709366
Ivan Levkivskyi added the comment:
New changeset 0846e5d4603434c2bbf8a528677cf1ff3fe29b95 by Ivan Levkivskyi (Bar
Harel) in branch '3.8':
[3.8] bpo-38878: Fix os.PathLike __subclasshook__ (GH-17336) (GH-17684)
https://github.com/python/cpython/commit/0846e5d4603434c2bbf8a528677cf1
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
New changeset 4dc5a9df59837446ec1dc5b7a0e6ce95ae5b5cec by Ivan Levkivskyi
(Batuhan Taşkaya) in branch 'master':
bpo-39019: Implement missing __class_getitem__ for subprocess classes (GH-17558)
https://github.com/python/cpyt
Ivan Levkivskyi added the comment:
New changeset 09c482fad11c769be38b2449f1056e264b701bb7 by Ivan Levkivskyi
(Batuhan Taşkaya) in branch 'master':
bpo-39019: Implement missing __class_getitem__ for SpooledTemporaryFile
(GH-17560)
https://github.com/python/cpyt
Ivan Levkivskyi added the comment:
This issue came up few times before (although I can't find an issue here on
b.p.o., maybe it was on typing-sig list). Although in micro-benchmarks the
impact may seem big, in vast majority of applications it is rarely more that a
percent or so.
O
Ivan Levkivskyi added the comment:
OK, here is the original issue https://github.com/python/typing/issues/681. I
asked the author to open an issue here instead, but likely they didn't open one.
--
___
Python tracker
<https://bugs.py
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue39204>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
> Once PEP 585 is implemented these should be rolled back and replaced with
> that, right?
I would say that ideally yes.
--
___
Python tracker
<https://bugs.python.org/i
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue39810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
New changeset 34b0598295284e3ff6cedf5c05e159ce1fa54d60 by Furkan Önder in
branch 'master':
bpo-40086: Update/fix test_etree test case in test_typing (GH-19189)
https://github.com/python/cpython/commit/34b0598295284e3ff6cedf5c05e159
Ivan Levkivskyi added the comment:
FWIW I like the idea. There are many objects in typing module that are not
classes, it would be great to display docs for them.
--
___
Python tracker
<https://bugs.python.org/issue40
Ivan Levkivskyi added the comment:
New changeset a25a04fea5446b1712cde0cff556574be139285a by HongWeipeng in branch
'master':
bpo-39942:Fix failure in `TypeVar` when missing `__name__` (GH-19616)
https://github.com/python/cpython/commit/a25a04fea5446b1712cde0cff55657
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
I think it should return empty tuple: First, for consistency with other things
like get_args(Tuple) == () and get_args(List) == (). Second, although Callable
is equivalent to Callable[..., Any] in the static world, authors of some
runtime checkers might
Ivan Levkivskyi added the comment:
Oh my, this looks like another bug. I don't have Python 3.8 at hand so just
tried `typing_inspect` on Python 3.6. I think this may be caused by the "double
use" of _GenericAlias for which you ope
Ivan Levkivskyi added the comment:
> But this behavior is not specified and is not covered by tests.
FWIW, to be most close to the static type checkers behavior, both D[int][str]
and D[int, str] should fail for D = Dict[T, List]. Not important however, since
this is a really rare cor
Ivan Levkivskyi added the comment:
Here I think the behavior of typing.Callable is correct.
--
___
Python tracker
<https://bugs.python.org/issue40494>
___
___
Ivan Levkivskyi added the comment:
Yes, this is as expected. A recommended workaround is to define a type alias
like `Match = re.Match` before the class body. You can also suppress the
exception with `from __future__ import annotations` (so that the annotations
are not evaluated), but
Ivan Levkivskyi added the comment:
I think a better question is why the `typing` in site packages is ever
imported? I thought that an stdlib module always takes precedence over an
installed one with the same name.
--
nosy: +levkivskyi
___
Python
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue40606>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
This is actually a specified behavior (motivated by memory savings for class
objects, that are already pretty large). If you scroll down the link you posted
it says:
> Note that if annotations are not found statically, then the
> ``__annotat
Ivan Levkivskyi added the comment:
> I was thinking that similarly to __required_keys__ and __optional_keys__, the
> TypedDict could preserve its original bases in a new dunder attribute, and
> get_type_hints could work off of that instead of MRO when it is dealing with
> a
Ivan Levkivskyi added the comment:
FWIW I like Guido's suggestion in the PR, I would rather use "importance order"
than alphabetical order.
--
___
Python tracker
<https://bugs.pyt
Ivan Levkivskyi added the comment:
> I don't think there's an actionable bug here.
OK, then taking into account there is a decent workaround, I am closing this.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
Change by Ivan Levkivskyi :
--
nosy: +levkivskyi
___
Python tracker
<https://bugs.python.org/issue36881>
___
___
Python-bugs-list mailing list
Unsubscribe:
Ivan Levkivskyi added the comment:
Is PEP the best place for such updates? Maybe we can add a `versionchanged`
note in
https://docs.python.org/3/reference/simple_stmts.html#annotated-assignment-statements
instead?
--
___
Python tracker
<ht
Ivan Levkivskyi added the comment:
I think this is related to how `__subclasscheck__` is implemented in `ABCMeta`.
I just checked this also happens in Python 3.6 (i.e. it is not something
specific to the C version introduced in Python 3.7
Ivan Levkivskyi added the comment:
New changeset 4c7a46eb3c009c85ddf2eb315d94d804745187d4 by Ivan Levkivskyi (Paul
Dagnelie) in branch 'master':
bpo-36972: Add SupportsIndex (GH-13448)
https://github.com/python/cpython/commit/4c7a46eb3c009c85ddf2eb315d94d804745187d4
-
Change by Ivan Levkivskyi :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Ivan Levkivskyi added the comment:
New changeset 933e1509ec6efa8e6ab8c8c7ce02059ce2b6d9b9 by Ivan Levkivskyi
(Michael J. Sullivan) in branch 'master':
bpo-36878: Track extra text added to 'type: ignore' in the AST (GH-13479)
https://github.com/p
Change by Ivan Levkivskyi :
___
Python tracker
<https://bugs.python.org/issue36985>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/o
New submission from Ivan Levkivskyi :
The actual implementation is performed by type checkers like mypy. We just need
to add the names to the `typing` module.
--
assignee: levkivskyi
components: Library (Lib)
messages: 343501
nosy: gvanrossum, levkivskyi, msullivan
priority: normal
Change by Ivan Levkivskyi :
--
keywords: +patch
pull_requests: +13479
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13571
___
Python tracker
<https://bugs.python.org/issu
New submission from Ivan Levkivskyi :
The actual implementation is performed by type checkers like mypy. We just need
to add `Literal` to the `typing` module.
--
assignee: levkivskyi
components: Library (Lib)
messages: 343503
nosy: gvanrossum, levkivskyi, michael0x2a
priority: normal
1 - 100 of 681 matches
Mail list logo