[issue3392] subprocess fails in select when descriptors are large

2009-03-31 Thread Frank Chu
Frank Chu added the comment: Hi, This is a patch that uses poll() in subprocess.communicate() if it is available. This is my first patch and may contain style errors. I try to conform to PEP 8 as close as I can. Besides the discussion here, I would like to add this is desired because select

[issue3392] subprocess fails in select when descriptors are large

2009-03-31 Thread Frank Chu
Frank Chu added the comment: Updated with new patch. I moved the try: except logic in the module initialization step so I get a global has_poll, similar to the global mswindows already there. I now use a try/except/else to be more robust (not needed now since it's only "has_poll =

[issue3392] subprocess fails in select when descriptors are large

2009-07-04 Thread Frank Chu
Frank Chu added the comment: Thanks! Good to hear it's checked in finally :-). Frank On Fri, Jul 3, 2009 at 7:47 PM, Gregory P. Smith wrote: > > Gregory P. Smith added the comment: > > Merged to py3k in r73833. > > -- > > ___