Change by Emily Morehouse :
--
pull_requests: +15572
pull_request: https://github.com/python/cpython/pull/15935
___
Python tracker
<https://bugs.python.org/issue35
Emily Morehouse added the comment:
All areas that were identified for additional work have been addressed.
If there is anything else that needs to be improved or updated, please create a
new issue.
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status
Emily Morehouse added the comment:
YAHO (yet another humble opinion), I support improving the current re.compile
documentation by adding a link to the regular expression object documentation.
Great way to point a user to the complete list of methods and attributes while
keeping match() and
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30628>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
You're certainly right. venv uses ensurepip to install pip when creating a
virtual environment and does not access the internet/upgrade any packages.
ensurepip was specifically designed to use the bundled version of setuptools.
The bundled versi
Changes by Emily Morehouse :
--
pull_requests: +2220
___
Python tracker
<http://bugs.python.org/issue30656>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
Good catch, fixed in PR.
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30656>
___
___
Python-bug
Emily Morehouse added the comment:
A quick note on how to include system packages in the "How Do I..?" section
could be helpful, though does not necessarily solve the current issue. I would
be hesitant to instruct people to use the system-site-packages flag simply to
have an updat
Emily Morehouse added the comment:
Looks great, thanks for the updates.
Mariatta, can you get this merged in?
--
___
Python tracker
<http://bugs.python.org/issue30
Emily Morehouse added the comment:
I also found what Eric did, specifically lines 4913-4918 in the commit he
mentioned introduced the bug:
if (PyBytes_GET_SIZE(key2) == 0 ||
strchr(PyBytes_AS_STRING(key2) + 1, '=') != NULL)
{
PyErr_SetString(PyExc_ValueError
Changes by Emily Morehouse :
--
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue30769>
___
___
Python-bugs-list mailing list
Unsubscrib
Emily Morehouse added the comment:
I concur with Martin, whitespace is not expected to be preserved on
whitespace-only lines nor even considered when finding common leading
whitepace. To illustrate this, see the examples below:
The following yields the same (expected) results:
> pyth
Emily Morehouse added the comment:
@georg.brandl and @terry.reedy, this issue was mentioned again recently
(http://bugs.python.org/issue30754).
Would you like to revisit it?
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30773>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Emily Morehouse :
--
pull_requests: +2477
___
Python tracker
<http://bugs.python.org/issue30769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
This is the expected functionality of linecache. As each file is read, it is
stored in a cache, subsequent calls using linecache do not check to see if the
file has changed.
If you know that the file has changed, you should call linecache.checkcache()
to
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30759>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
I think I need a bit more direction for the 3.5 backport. The original test
below passes:
./python -m test -R 3:3 -m test_execve_invalid_env test_os
--
___
Python tracker
<http://bugs.python.org/issue30
Changes by Emily Morehouse :
--
pull_requests: +2503
___
Python tracker
<http://bugs.python.org/issue30769>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
Resolving this since the fix and backports have been merged in.
--
___
Python tracker
<http://bugs.python.org/issue30
Emily Morehouse added the comment:
And thank you to Serhiy and Victor for the assistance and attention to this
issue!
--
___
Python tracker
<http://bugs.python.org/issue30
Emily Morehouse added the comment:
Thanks Christopher, you are absolutely correct. There are a few ways in which
this code could be optimized (and many other small optimizations probably exist
elsewhere in the code).
If you are interested in submitting a PR for this, you are more than welcome
Emily Morehouse added the comment:
I concur with Raymond, particularly because paragraph 1 of section 8.5 links to
the Classes tutorial which covers inheritance. I think the documentation is
sufficient as is.
--
nosy: +emilyemorehouse
___
Python
Emily Morehouse added the comment:
PR 3211 - LGTM, but is not CLA signed.
Elena, a couple of notes on your patch. Using :ref:`regular expression object
` to link to the section of the documentation is preferred, as it
does not rely on a consistent URL. Also, be mindful of line lengths, feel
Change by Emily Morehouse :
--
pull_requests: +9865
___
Python tracker
<https://bugs.python.org/issue30455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Emily Morehouse :
--
pull_requests: +11441
___
Python tracker
<https://bugs.python.org/issue33416>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
New changeset 8f59ee01be3d83d5513a9a3f654a237d77d80d9a by Emily Morehouse in
branch 'master':
bpo-35224: PEP 572 Implementation (#10497)
https://github.com/python/cpython/commit/8f59ee01be3d83d5513a9a3f654a23
Emily Morehouse added the comment:
@vstinner Is there something I could/should have checked other than the CI
displayed in GitHub before merging? Let me know if I can help.
Here's a brief summary of the differences between the PEP spec and
implementation:
>From the "Scope
Emily Morehouse added the comment:
Yes, you're exactly correct! Feel free to submit a PR and add me as a reviewer
when you're ready.
--
assignee: -> xtreak
stage: -> needs patch
___
Python tracker
<https://bugs.py
Emily Morehouse added the comment:
New changeset 075de6cf6cb0f5f4d3711fc07f023a9a7a0a816b by Emily Morehouse
(Joannah Nanjekye) in branch 'master':
bpo-35861: Fix SyntaxWarning in test_named_expressions.py (GH-11722)
https://github.com/python/cpyt
Emily Morehouse added the comment:
New changeset d4fceaafb8e3f8700d9ec6ab37a51e903392f74f by Emily Morehouse
(Xtreak) in branch 'master':
bpo-35877: Make parenthesis optional for named expression in while statement
(GH-11724)
https://github.com/python/cpyt
Change by Emily Morehouse :
--
pull_requests: +11608, 11609
___
Python tracker
<https://bugs.python.org/issue35877>
___
___
Python-bugs-list mailing list
Unsub
Change by Emily Morehouse :
--
pull_requests: +11608
___
Python tracker
<https://bugs.python.org/issue35877>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Emily Morehouse :
--
pull_requests: +11608, 11609, 11610
___
Python tracker
<https://bugs.python.org/issue35877>
___
___
Python-bugs-list mailin
Emily Morehouse added the comment:
Thanks, Karthikeyan! I added an additional test to make sure this gets
coverage. I'll close out this issue once tests pass and I can merge that.
--
___
Python tracker
<https://bugs.python.org/is
Change by Emily Morehouse :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Emily Morehouse added the comment:
New changeset ac19081c26eaa7de3e6aabeb789ddc2e7cdd5b24 by Emily Morehouse in
branch 'master':
bpo-35877: Add test for while loop named expression without parentheses
(GH-11726)
https://github.com/python/cpyt
Change by Emily Morehouse :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Emily Morehouse added the comment:
@rhettinger absolutely, I'm going to include that in my documentation PR which
is currently in progress. :)
--
___
Python tracker
<https://bugs.python.org/is
Emily Morehouse added the comment:
I have a work-in-progress (WIP) documentation branch I've been working on that
I'll push up this week to address the following:
- Add summary to What's New in Doc/whatsnew/3.8.rst
- Add to list of delimiters in Doc/reference/lexical_analysis.
Emily Morehouse added the comment:
You should look in Python/ast.c. The naming convention follows some form of
"named expression" (e.g. NamedExpr, ast_for_namedexpr).
I'll have more time to look later this week, but let me know if you have
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30388>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
Raymond, I'm willing to take over this issue with your guidance if you're open
to it.
--
nosy: +emilyemorehouse, rhettinger
___
Python tracker
<http://bugs.python.o
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue30501>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
The logic in your proof is certainly sound. The only time that the else
statement within Clause 4 (to use terminology from the proof) would execute is
either
1) if margin is equal to indent, which is handled in Clause 2, or
2) if the margin is None
Emily Morehouse added the comment:
Jonathan, could you improve the comments for the dedent function? You have a
great understanding of the logic flow from your proof and it would be
beneficial to document this to avoid future confusion.
Specifically, it should be clear that Clause 2
Emily Morehouse added the comment:
Good catch. We should also add additional tests for a declining indentation
level with a blank line and a declining indentation with a whitespace only
line, as it is a pattern followed throughout the dedent tests.
It should be noted that PR 2014 is the
Emily Morehouse added the comment:
Ned is correct! I will be sprinting on docs for this at PyCon.
--
___
Python tracker
<https://bugs.python.org/issue35
Emily Morehouse added the comment:
My initial reaction is that named expressions should not be valid in f-strings
and should instead raise an exception, the same way that using `a := 10` does.
>>> a := 10
File "", line 1
a := 10
^
SyntaxError: invalid syntax
I
Emily Morehouse added the comment:
Ah yes, that's what I meant. I was thinking about the confusion between
f-strings (evaluated immediately and stored as a string) vs other versions of
string formatting which are evaluated when used. I've seen the mix of the two
confuse p
Change by Emily Morehouse :
--
keywords: +patch
pull_requests: +5228
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32689>
___
___
Py
Emily Morehouse added the comment:
Thanks for the bug report!
shutil.move should certainly accept a path object, as shutil.copy does, though
it should be noted that in your example, 'path' could become out of date as it
does not refresh the path information. For example, with s
Emily Morehouse added the comment:
Ah, you're right. That was a typo when I was redacting my full path. The path
object remains unchanged even though the directory has moved.
Should have been:
>>> import os, pathlib, shutil
>>> os.mkdir('tes
Emily Morehouse added the comment:
Good find -- I agree that when using Path.cwd().glob('*/'), it should only
return directories. This follows the original glob library's functionality as
well as the Unix expectation (I believe Windows as well, but I'll double check).
Change by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue32452>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Emily Morehouse :
--
keywords: +patch
pull_requests: +4954
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32452>
___
___
Py
Change by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue32604>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
Thanks, Philip! If you're interested in submitting a PR, please do! If not,
just comment back so someone else can pick it up.
--
nosy: +emilyemorehouse
stage: -> needs patch
___
Python tracker
Emily Morehouse added the comment:
This is an interesting behavior to note. I think the current behavior makes the
most sense, as it corresponds to the OS-level errors that you get from running
the same operations.
Interestingly, at least on Unix-based file systems, we get different error
Emily Morehouse added the comment:
I'll defer to Serhiy's os.path expertise, but from what I know -- os.dirname is
essentially a helper function for returning the first item of split.
What I'm gathering is that you're looking for a more advanced way of parsing a
file
Emily Morehouse added the comment:
The os.path conventions do follow, '' and '.' are not treated the same here
either --
>>> os.path.exists('')
False
>>> os.path.exists('.')
True
>>> os.path.isdir('')
False
>
Change by Emily Morehouse :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Emily Morehouse added the comment:
This issue was brought to my attention -- I'm helping build the PEP 572
implementation. I'll make sure the docs get updated (and Jonathan, I didn't
actually know that assignment expressions were mentioned in the FAQ, so this
wa
Emily Morehouse added the comment:
I'll have to think through this a bit more, but my gut is that it would be much
more favorable for backwards-compatibility to clarify the documentation instead
of changing the functionality.
In any case, the change would only take effect in 3.8+,
Change by Emily Morehouse :
--
pull_requests: +8783
___
Python tracker
<https://bugs.python.org/issue30455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<https://bugs.python.org/issue33878>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Emily Morehouse :
This issue will serve to track development and PRs for the implementation of
PEP 572: Assignment Expressions.
--
assignee: emilyemorehouse
components: Interpreter Core
messages: 329781
nosy: emilyemorehouse, gvanrossum, tim.peters
priority: normal
Change by Emily Morehouse :
--
keywords: +patch
pull_requests: +9758
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue35224>
___
___
Py
Change by Emily Morehouse :
--
keywords: +patch, patch
pull_requests: +9758, 9759
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Emily Morehouse added the comment:
Aspiring contributor here!
I believe I have narrowed this error down to the inspect module, specifically
in the for loop beginning on line 759.
There's a bit of "acrobatics" (to quote the code comments) that I'm trying to
sift through,
Emily Morehouse added the comment:
I see that path-like objects are indeed mentioned in the documentation
(Doc/library/os.rst), simply stating "Changed in version 3.6: Supports a
path-like object." Other methods, such as os.chroot, also mention such a change.
Comparing the docs
Emily Morehouse added the comment:
Yury, thanks for the encouragement to continue on this patch. I think it will
be a good exercise to dive a bit deeper into Python's bytecode and put some
knowledge to use.
I believe that tuple argument unpacking is handled appropriately, but there i
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue29339>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
Serhiy, thank you for the update. I looked over your patch to ensure that I
understood your solution. I also appreciate your tests, as I was able to see
other edge cases that I perhaps would not have thought of.
Yury, I'm more than happy to help! I
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue28121>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Emily Morehouse :
--
nosy: +emilyemorehouse
___
Python tracker
<http://bugs.python.org/issue26890>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emily Morehouse added the comment:
The reported behavior has been verified -- the documented behavior is indeed
incorrect for both Locator.getColumnNumber() and Locator.getLineNumber(). The
beginning line and column numbers are returned, not the end.
This has been tested and verified for
Emily Morehouse added the comment:
Super straight-forward -- this simply adds to the docs on creating the class
object that the values used in creation are copied to the final object
(including the namespace).
--
keywords: +patch
nosy: +emilyemorehouse
Added file: http
Emily Morehouse added the comment:
Second version of patch for this -- more clearly states the process and outcome
for class creation. Also adds to
https://docs.python.org/3.6/library/functions.html#type to clarify that the
dictionary object is copied to a standard dict.
--
Added
Emily Morehouse added the comment:
Trimmed down by keeping the more explicit explanation and taking into account
suggestions.
--
Added file: http://bugs.python.org/file43127/26829-v3.patch
___
Python tracker
<http://bugs.python.org/issue26
80 matches
Mail list logo
