Emanuel Barry added the comment:
Ping. I'd like to get this merged in time for 3.6. Is there anything I can do
to speed up the review?
Since the change itself is very straightforward, I think this would make sense
to merge it now and then fix the invalid escapes that are found during the
Emanuel Barry added the comment:
Thanks Serhiy; it does look better to me too!
--
Added file:
http://bugs.python.org/file44322/deprecate_invalid_escapes_both_3.patch
___
Python tracker
<http://bugs.python.org/issue27
Emanuel Barry added the comment:
Thanks for the report! I'm unable to reproduce, as `socket.AF_BLUETOOTH`
doesn't exist on my system, but surely someone else can.
--
keywords: +3.5regression
nosy: +ebarry, ned.deily
priority: normal -> high
stage: -> n
Changes by Emanuel Barry :
--
nosy: +ncoghlan, rhettinger
___
Python tracker
<http://bugs.python.org/issue27933>
___
___
Python-bugs-list mailing list
Unsub
Changes by Emanuel Barry :
--
nosy: +ebarry, larry, ned.deily, rhettinger, serhiy.storchaka
priority: normal -> critical
stage: -> needs patch
title: five dictobject issues -> Various segfaults with dict
type: -> crash
___
Python tr
Emanuel Barry added the comment:
Updated and rebased patch. There's a few file tweaks here and there to stay up
to date, otherwise it's mostly the same.
Martin, it may look like I've ignored your comments, but I'm trying to keep the
patches as simple as possible, and s
Emanuel Barry added the comment:
We're one week from the feature freeze, seems like a good time to merge this :)
--
___
Python tracker
<http://bugs.python.org/is
Emanuel Barry added the comment:
Rebased patch after Victor's commit in #16334. Also regenerated
invalid_stdlib_escapes_3 in the hopes that Rietveld picks it up.
--
Added file:
http://bugs.python.org/file44432/deprecate_invalid_escapes_both_4.
Changes by Emanuel Barry :
Added file:
http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch
___
Python tracker
<http://bugs.python.org/issue27
Changes by Emanuel Barry :
Removed file:
http://bugs.python.org/file44433/invalid_stdlib_escapes_3_regen.patch
___
Python tracker
<http://bugs.python.org/issue27
Changes by Emanuel Barry :
Added file: http://bugs.python.org/file44435/invalid_stdlib_escapes_4.patch
___
Python tracker
<http://bugs.python.org/issue27364>
___
___
Pytho
Emanuel Barry added the comment:
Hi Nick, thank you for letting me know! I started trying to fix this, however I
found it very hard to fix the recursive repr issue. I've whipped up an
incomplete (but yet working) patch that fixes all but the recursive repr issue.
Only those two tests
Emanuel Barry added the comment:
Thank you Serhiy for the comments! Here's a new patch. I'm fine with the
recursive repr tests failing for now; it's something I believe we can fix
during the beta phase if we don't have time before (fix as in modify the C
implementation
Changes by Emanuel Barry :
Added file:
http://bugs.python.org/file44457/invalid_stdlib_escapes_3_rebased_2.patch
___
Python tracker
<http://bugs.python.org/issue27
Emanuel Barry added the comment:
Thank you R. David for the review, here's a new patch with the one change.
--
Added file: http://bugs.python.org/file44463/invalid_stdlib_escapes_4.patch
___
Python tracker
<http://bugs.python.org/is
Emanuel Barry added the comment:
All right, since you'll work on it I'm leaving it out. Removed it and
test_bytes (which you already fixed, thanks!) from new patch.
--
Added file: http://bugs.python.org/file44465/invalid_stdlib_escap
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28028>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emanuel Barry added the comment:
Thank you David for taking the time to review and commit this :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Emanuel Barry added the comment:
Can this be merged even with the two failing tests? I have little to no time
available to fix it properly before the feature freeze. We can skip/silence
those tests for a bit; I'll open a new issue and fix it in time for b
Emanuel Barry added the comment:
The patch LGTM and applies fine. Looks like there's no need to wait for beta 2
after all; thanks Serhiy!
--
___
Python tracker
<http://bugs.python.org/is
Emanuel Barry added the comment:
Ping. The built-in dict was considerably changed in #27350; do any of these
issues still persist?
--
___
Python tracker
<http://bugs.python.org/issue27
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28050>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Emanuel Barry:
VS breaks at line Objects/dictobject.c:2339 - 'if
(mp->ma_keys->dk_usable * 3 < other->ma_used * 2)'
I don't have any more useful information; I'm running Windows 7.
--
components: Interpreter Core
mess
New submission from Emanuel Barry:
This is a followup to #27137, where it was found out the repr of a partial
object includes the module (i.e. 'functools') only if it's not a subclass. This
behaviour is surprising at best. Attached patch streamlines the reprs of
partial ob
Emanuel Barry added the comment:
Thank you Nick! I just opened #28062 to fix the repr inconsistency between
functools.partial and any subclass :)
--
___
Python tracker
<http://bugs.python.org/issue27
Emanuel Barry added the comment:
Latest, i.e. https://hg.python.org/cpython/rev/a477ef882a16
--
___
Python tracker
<http://bugs.python.org/issue28061>
___
___
Emanuel Barry added the comment:
I compiled, I got a "Python stopped working" during compiling (but it went on
anyway), and then launched it from VS in Debugging mode. I did 'from test
import support' and then it crashed. VS said this line was the faulty one, and
didn
Changes by Emanuel Barry :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
___
Python tracker
<http://bugs.python.org/issue28
Emanuel Barry added the comment:
Huh, weird. I'm running a win32 build on a 64 bits machine, with VS2015. I
didn't have time to test on a clean checkout, I will do that first thing when
I'm back home tonight. I hope I did something wrong and there really i
Emanuel Barry added the comment:
I don't know what exactly happened that would make it crash, but after wiping
off everything and starting over, it works fine now. Sorry for the noise!
--
components: -Windows
priority: release blocker -> normal
resolution: -> not a bug
s
Emanuel Barry added the comment:
Fair enough; I can see why such an addition would be a good idea. But please
open a new issue for that (add me to nosy); I don't want this issue to be
further cluttered.
--
___
Python tracker
Emanuel Barry added the comment:
I actually did a clean rebuild and could not reproduce, so I'm guessing
something did go wrong on my side.
--
priority: deferred blocker -> normal
resolution: -> not a bug
stage: needs patch -> resolved
status: open -> c
Emanuel Barry added the comment:
Fair enough, but please open a new issue for that.
@Terry - you're welcome; that's exactly the reason I pushed for it :)
--
___
Python tracker
<http://bugs.python.o
Emanuel Barry added the comment:
Hello, and thanks! I'll work on a patch this week, or at most next week. I will
make it so that it's completely uncontroversial to apply it to 3.6 as well
(won't change the actual feature, only prettify the error message), so no need
to w
Emanuel Barry added the comment:
Besides converting the DeprecationWarning to a Syntax{Error,Warning}, I don't
see an easy way to include the offending line (or even file). The place in the
code where the strings are created has no idea *where* they are being defined.
AIUI, either we sp
Emanuel Barry added the comment:
There definitely needs to be a better message for that. The problem is that the
parser doesn't have access to the whole string (of course; it's being
constructed!), so I think there are several possible venues here:
- Change DeprecationWarning to d
Emanuel Barry added the comment:
Thank you Nick for the useful feedback! I think that a subclass of
DeprecationWarning and SyntaxWarning would be a good idea; I'll play around
with that.
As far as when the warning should occur, I agree that erroring out at the
compile step isn'
Emanuel Barry added the comment:
Hmm, I see; I'll need to dig a bit deeper get to and understand that part of
the compile process better. I'll look up where SyntaxErrors are generated
(since they have access to at least the line number at that point), and try to
hook it up
Emanuel Barry added the comment:
This is a duplicate of issue27781.
--
nosy: +ebarry
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Change sys.getfilesystemencoding() on Windows to UTF-8
___
Python tr
Emanuel Barry added the comment:
Personally I'd be fine with only one warning, reporting the first invalid
escape. Presumably the string would be checked as a whole, or would get an r
prefix. Patch seems like a good start; bytes would also need updating in that
regard. Don't worr
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28243>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emanuel Barry added the comment:
Ping. I'd like for this to get merged in beta 2; should I (or Eric if he wants
to) get to work on this? Is the DeprecatedSyntaxWarning subclass route still
desired?
--
___
Python tracker
<http://bugs.py
Emanuel Barry added the comment:
I'm not able to trigger an assertion error when running the latest trunk in
debug mode. I get a "valid" range_iterator object though, and using __reduce__
gives me direct access to `range(0, 0, 0)` (which is completely worthless).
Error or not,
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Emanuel Barry added the comment:
I see the function is private; is there any concern with extending the PyErr_*
API? I think it'd make sense to expose it, since it's a convenient way to do in
C what can already be done easily in Python, but I don't actually have a good
reason
Emanuel Barry added the comment:
This is not a regression, the documentation was just not fully updated when the
new feature was added. Patch looks good. This should probably be applied to the
3.5 branch as well.
--
nosy: +ebarry
stage: patch review -> commit review
versions: +Pyt
Emanuel Barry added the comment:
Could provide more information on the issue? Which program exactly is failing?
Is it the IDLE editor? If you don't know what you're using, you can provide a
screenshot as a last resort (but don't provide one if you can figure out the
progr
Emanuel Barry added the comment:
Following Ned's email to Python-Dev, I'm upping the priority of this issue to
"deferred blocker".
I haven't had a lot of time to work on this, but I had time to think about it,
and I think that resolving #28028 would be the best way
Emanuel Barry added the comment:
Cross-ping from #28128
I think it would be best to solve this issue, solving both #28128 and any
future warning-introducing feature or deprecation. I've marked this issue as a
dependency for #28128 as well as upping the priority. There are less than 7
Emanuel Barry added the comment:
Thank you Eric. Have you looked at making a new DeprecatedSyntaxWarning
subclass of both DeprecationWarning and SyntaxWarning? Hopefully that's of some
help.
I don't see a review link, but from a quick glance this looks go
Emanuel Barry added the comment:
As Nick pointed out in an earlier message on this thread and as Serhiy observed
on GitHub issues, backporting this patch to 3.6 is a must. Large projects' use
of Python 3.6 has shown that it's hard to track down the actual cause of the
error; it
Emanuel Barry added the comment:
Even better than what I was aiming for :)
--
dependencies: -Convert warnings to SyntaxWarning in parser
priority: deferred blocker -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Changes by Emanuel Barry :
--
priority: high -> normal
___
Python tracker
<http://bugs.python.org/issue28028>
___
___
Python-bugs-list mailing list
Unsubscrib
Emanuel Barry added the comment:
That's how strings work, unfortunately. You can't end any string (raw or not)
with an odd number of backslashes. You could do the following to get around
this limitation:
>>> r"C:\Folder" "\\"
'C:\\Folder\\'
A
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28750>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Emanuel Barry :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue28750>
___
___
Python-bugs-list mai
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28751>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Emanuel Barry :
--
nosy: +ebarry
___
Python tracker
<http://bugs.python.org/issue28450>
___
___
Python-bugs-list mailing list
Unsubscribe:
301 - 358 of 358 matches
Mail list logo
