Erlend E. Aasland added the comment:
This change breaks existing behaviour (see test below). Also,
sqlite3_column_count() is implemented as a simple lookup in SQLite; it is never
an expensive function. Suggests to add the following test instead:
diff --git a/Lib/sqlite3/test/dbapi.py b/Lib
Change by Erlend E. Aasland :
--
___
Python tracker
<https://bugs.python.org/issue44041>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Erlend E. Aasland :
The code that used the connection argument was removed one year before pysqlite
was included in CPython, as far as I can see. It can safely be removed.
See also:
https://github.com/ghaering/pysqlite/commit/5a009ed6fb2e90b952438f5786f93cd1e8ac8722
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25126
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26535
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25128
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26537
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Thanks Mike for the report and reproducer, and Pablo for the fix!
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
sqlit3.Cursor is prone to the same bug. Do you want me to create a new issue
for it, or can I reuse this issue number, Pablo? I'll see if I can create a
reproducer for that as well.
--
___
Python tr
Erlend E. Aasland added the comment:
PR 26351 adds the Py_TPFLAGS_IMMUTABLETYPE type flag to all types converted to
heap type during 3.10 development.
--
___
Python tracker
<https://bugs.python.org/issue43
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the __init__ method.
Suggesting to remove this. A couple of lines less of code, a couple of bytes
less per statement object.
--
assignee: erlendaasland
components: Extension Module
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25153
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26564
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
Removed message: https://bugs.python.org/msg395216
___
Python tracker
<https://bugs.python.org/issue44326>
___
___
Python-bug
New submission from Erlend E. Aasland :
The db member of pysqlite_Statement is only "used" in the statement create
method. Suggesting to remove this. A couple of lines less of code, a couple of
bytes less per statement object.
--
Erlend E. Aasland added the comment:
The "sql" member is also unused. Removing this will make the tp_clear method
redundant, as there are no PyObjects to clear anymore.
--
title: [sqlite3] remove unused db member from pysqlite_Statement -> [sqlite3]
remove unused
New submission from Erlend E. Aasland :
The timeout and timeout_started members of pysqlite_Connection are never used.
Suggesting to remove them.
--
assignee: erlendaasland
components: Extension Modules
messages: 395219
nosy: erlendaasland
priority: low
severity: normal
status: open
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25154
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26565
___
Python tracker
<https://bugs.python.org/issu
New submission from Erlend E. Aasland :
Currently, pysqlite_statement_create() approx. looks like this:
1. some sanity checks (type, sql lenght, etc.)
2. allocate (PyObject_GC_New)
3. initialise members
4. determine if statement is a DML statement
5. create the statement (sqlite3_prepare_v2)
6
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25155
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26566
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25156
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26567
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> I am not sure what you mean, in the happy path you still need to GC track and
> allocate.
Currently, we allocate the object, then try to create the statement using the
SQLite API. If we create the statement first, we can do the sanity check
Erlend E. Aasland added the comment:
... to expand: so currently, if statement creation fails, we must deallocate
the PyObject.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Ah, I see I formulated myself a bit unclear:
Yes, we need to allocate/track every time. I just propose to do so as late as
possible, in order to avoid allocating a PyObject before we know if it is
possible to actually create the statement
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44331>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue39573>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Thanks, Victor :)
--
___
Python tracker
<https://bugs.python.org/issue42213>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44359>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44360>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44361>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
Isn't this just an (explicit) SIGKILL? The _exit code_ seems to be -9, not the
signal number.
--
___
Python tracker
<https://bugs.python.org/is
Erlend E. Aasland added the comment:
Oh, right, there is of course a connection between the exit code and the signal
number. Thanks for the reminder :)
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
keywords: +patch
nosy: +erlendaasland
nosy_count: 1.0 -> 2.0
pull_requests: +25266
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26680
___
Python tracker
<https://bugs.p
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue32275>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue33450>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
Thanks for the report, Brother Beer.
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bugs-list m
Erlend E. Aasland added the comment:
But TLSv1.3 is included in openssl 1.1.1, no?
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bug
Erlend E. Aasland added the comment:
Yes, and judging from PEP 644, I figured the TLSv1.3 flag was _not_ deprecated.
Sorry for the misunderstanding/noise.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Let me know if you want me to open a PR that adds the correct flag and adds
deprecation wrappers to the tests.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
Ah, I see now that it's deprecated in the docs as well:
https://docs.python.org/3/library/ssl.html#ssl.OP_NO_TLSv1_3
--
___
Python tracker
<https://bugs.python.org/is
Change by Erlend E. Aasland :
--
pull_requests: +25284
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/26699
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Thanks, Christian.
--
___
Python tracker
<https://bugs.python.org/issue44389>
___
___
Python-bugs-list mailing list
Unsub
Erlend E. Aasland added the comment:
It's not removed, it's renamed (by 84f7382215b9e024a5590454726b6ae4b0ca70a0,
GH-22994, bpo-42157). You can access it using the '_ucnhash_CAPI' attribute.
--
nosy: +erlendaasland
___
Py
Erlend E. Aasland added the comment:
Sounds like an easy solution is to open an issue/PR against rust-cpython to
update the doctest, IMO.
--
___
Python tracker
<https://bugs.python.org/issue44
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25318
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26728
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
> What would be the use case for this?
Quoting D. Richard Hipp, from the sqlite-users mailing list, 2018-03-18, FWIW:
These APIs support the concept of using small databases (small enough
to fit in memory) as a container for passing information aro
Change by Erlend E. Aasland :
--
pull_requests: +25330
pull_request: https://github.com/python/cpython/pull/26745
___
Python tracker
<https://bugs.python.org/issue42
New submission from Erlend E. Aasland :
The threading tests (ThreadTests) in Lib/sqlite3/test/dbapi.py has a lot of
code duplication, and none of the test methods use the
test.support.threading_helper.reap_threads helper. Also, some branches are not
covered by this test class. Suggesting the
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25333
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26748
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
The current code duplication has several negative impacts, IMO:
- Readability
Currently the ThreadTests class spans 173 lines. Refactored, it spans 51
lines (should fit in a screenful), making it easy to see what's actually being
tested.
Curr
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44434>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue44431>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
I'm marking this as closed/fixed. Mark, please reopen if you disagree :)
--
nosy: +erlendaasland
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python t
Change by Erlend E. Aasland :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
> Erlend, is anything left in this issue?
Nothing left; thank you for your guidance and reviews, Dong-hee, Berker,
Serhiy, and Pablo.
--
resolution: -> fixed
stage: patch review -> resolved
status: open
Change by Erlend E. Aasland :
--
pull_requests: +25397
pull_request: https://github.com/python/cpython/pull/26816
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
FYI, bpo-44087 added the Py_TPFLAGS_DISALLOW_INSTANTIATION flag to
sqlite3.Statement.
(Side note: I find the issue title a little bit confusing.)
--
___
Python tracker
<https://bugs.python.org/issue43
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Erlend E. Aasland :
--
pull_requests: +25421
pull_request: https://github.com/python/cpython/pull/26840
___
Python tracker
<https://bugs.python.org/issue42
New submission from Erlend E. Aasland :
https://github.com/python/cpython/pull/26840/checks?check_run_id=2879802998
2021-06-21T22:34:41.2973359Z Current runner version: '2.278.0'
2021-06-21T22:34:41.3112811Z ##[group]Operating System
2021-06-21T22:34:41.3113619Z Microsoft Windows S
Erlend E. Aasland added the comment:
FYI, sqlite3 was converted to Argument Clinic in bpo-40956.
--
___
Python tracker
<https://bugs.python.org/issue20
New submission from Erlend E. Aasland :
Currently, it is possible to clear both the sqlite3 trace callback and progress
handler by passing 'None' as the callback/handler, however it is not possible
to clear the authoriser callback.
Suggesting to allow clearing the authoriser cal
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25438
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26863
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +25452
pull_request: https://github.com/python/cpython/pull/26876
___
Python tracker
<https://bugs.python.org/issue42
New submission from Erlend E. Aasland :
Currently, pysqlite_Connection keeps borrowed references to all the sqlite3
exception types. Suggesting to convert these to strong refs.
See comments on GH-26745:
https://github.com/python/cpython/pull/26745#issuecomment-866810269
--
assignee
Erlend E. Aasland added the comment:
Has these issues (ConnectionRefusedError/ConnectionResetError during handshake)
been reported on other systems than macOS? AFAICS, they've only been reported
for the macOS CI.
--
___
Python tracker
&
Erlend E. Aasland added the comment:
See also bpo-33450.
--
___
Python tracker
<https://bugs.python.org/issue44229>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
pull_requests: +25462
pull_request: https://github.com/python/cpython/pull/26884
___
Python tracker
<https://bugs.python.org/issue42
Change by Erlend E. Aasland :
--
pull_requests: +25463
pull_request: https://github.com/python/cpython/pull/26885
___
Python tracker
<https://bugs.python.org/issue43
Change by Erlend E. Aasland :
--
resolution: fixed ->
status: closed -> open
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/i
Change by Erlend E. Aasland :
--
pull_requests: +25464
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26886
___
Python tracker
<https://bugs.python.org/issu
Change by Erlend E. Aasland :
--
pull_requests: +25466
pull_request: https://github.com/python/cpython/pull/26889
___
Python tracker
<https://bugs.python.org/issue43
Erlend E. Aasland added the comment:
Using this patch, I'm (so far) no longer able to reproduce these test failures:
diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
index cee97a8302..c9c1546467 100644
--- a/Lib/test/test_ssl.py
+++ b/Lib/test/test_ssl.py
@@ -2443,9 +2443,13 @
Erlend E. Aasland added the comment:
... should perhaps also return True in that case, but it does not seem to have
any thing to say.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
I can reproduce these issues easily on 3.7, 3.8, and 3.9:
$ python3.7 -m test test_ssl -u all -F -m test_get_server_certificate -v
[...]
test_get_server_certificate (test.test_ssl.SimpleBackgroundTests) ... server:
new connection from ('127.
Change by Erlend E. Aasland :
--
keywords: +patch
pull_requests: +25469
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26893
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
Closing as a duplicate of bpo-44229. Please revert if you disagree.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> test_ssl: test_get_server_certificate() and
test_msg_callback_deadlock_bpo
Erlend E. Aasland added the comment:
Marking bpo-43855 as a duplicate of this issue.
--
___
Python tracker
<https://bugs.python.org/issue44229>
___
___
Pytho
Erlend E. Aasland added the comment:
Marking bpo-44237 as a duplicate of this issue.
--
___
Python tracker
<https://bugs.python.org/issue44229>
___
___
Pytho
Erlend E. Aasland added the comment:
Marking this as a duplicate of bpo-44229. Please revert if you disagree.
--
dependencies: -test_ssl: test_get_server_certificate() and
test_msg_callback_deadlock_bpo43577() fail randomly on the macOS CI
resolution: -> duplicate
st
Erlend E. Aasland added the comment:
See also bpo-44229.
--
___
Python tracker
<https://bugs.python.org/issue33450>
___
___
Python-bugs-list mailing list
Unsub
Change by Erlend E. Aasland :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Erlend E. Aasland added the comment:
FYI, here's a CI failure against 3.9:
https://github.com/python/cpython/runs/2894813367?check_suite_focus=true
--
___
Python tracker
<https://bugs.python.org/is
New submission from Erlend E. Aasland :
https://github.com/python/cpython/runs/2905621215:
2021-06-24T14:18:23.3772681Z
==
2021-06-24T14:18:23.3773622Z FAIL:
test_sendfile_close_peer_in_the_middle_of_receiving
Change by Erlend E. Aasland :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> [Windows] test_asyncio: Proactor
test_sendfile_close_peer_in_the_middle_of_receiving failure
___
Python tra
Erlend E. Aasland added the comment:
Two new failures today:
https://github.com/python/cpython/runs/2905621215:
2021-06-24T14:18:23.3772681Z
==
2021-06-24T14:18:23.3773622Z FAIL
New submission from Erlend E. Aasland :
Builder: https://buildbot.python.org/all/#/builders/543
The buildbot has failed since 0982ded179f280176868c1c4eccf77bf70687816:
bpo-44032: Move pointer to code object from frame-object to frame specials
array. (GH-26771)
Test stdio log attached
Erlend E. Aasland added the comment:
Fatal Python error: Py_EndInterpreter: thread still has a frame
Python runtime state: initialized
Thread 0x7ff625ee4740 (most recent call first):
File "", line 4 in
make: *** [Makefile:1256: buildbottest] Aborted (core dumped)
program fin
Erlend E. Aasland added the comment:
I haven't observed this issue on the CI since GH-26893 through GH-26896 was
merged. Marking this as resolved. If anyone disagrees, feel free to reopen :)
--
resolution: -> fixed
stage: patch review -> resolved
status: ope
Change by Erlend E. Aasland :
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue42238>
___
___
Python-bugs-list mailing list
Unsubscribe:
Erlend E. Aasland added the comment:
But here, it is write() that returns EPROTOTYPE. See msg394798.
--
___
Python tracker
<https://bugs.python.org/issue44
Erlend E. Aasland added the comment:
I'd be interested in hearing Ronald's opinion. (Added to nosy.)
--
nosy: +ronaldoussoren
___
Python tracker
<https://bugs.python.o
Erlend E. Aasland added the comment:
In inherit_slots() in Objects/typeobject.c, Py_TPFLAGS_HAVE_VECTORCALL
inheritance depends on if the base type is a heap type or not. This aligns with
PEP 590[1]:
Heap types never inherit the vectorcall protocol because that
would not be safe (heap
Change by Erlend E. Aasland :
--
pull_requests: +25562
pull_request: https://github.com/python/cpython/pull/27001
___
Python tracker
<https://bugs.python.org/issue43
Change by Erlend E. Aasland :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Asyncio Event Documentation Links Incorrect
___
Python tracker
<https://bugs.python
Erlend E. Aasland added the comment:
Serhiy/Terry: Is further discussion needed? Can this be closed, or should the
proposed PR be applied (after resolving any issues)?
--
nosy: +erlendaasland
___
Python tracker
<https://bugs.python.org/issue41
Erlend E. Aasland added the comment:
> Is anything left here?
Should the immutable flag also be applied to the heap types converted in and
before Python 3.9 before closing this issue?
--
___
Python tracker
<https://bugs.python.org/issu
Erlend E. Aasland added the comment:
These types now lack the Py_TPFLAGS_IMMUTABLETYPE flag:
## Types converted in Python 3.9
- _abc._abc_data
- _json.Encoder
- _json.Scanner
- _random.Random
- _struct.Struct
- _struct.unpack_iterator
- ast.AST
- posix.DirEntry
- posix.ScandirIterator
Erlend E. Aasland added the comment:
FYI, this buildbot has been green after Victor's git clean adjustment in the
buildbot repo.
I've been trying to reproduce the test_still_running failure on the buildbot,
but have not been able to do so determi
701 - 800 of 1199 matches
Mail list logo
