[issue45512] [sqlite3] simplify "isolation level"

2021-10-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27325 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29053 ___ Python tracker <https://bugs.python.org/issu

[issue36073] sqlite crashes with converters mutating cursor

2021-10-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27326 pull_request: https://github.com/python/cpython/pull/29054 ___ Python tracker <https://bugs.python.org/issue36

[issue39410] CentOS 6.10 SQLite 3.30.1 - _sqlite3 builds successfully but is removed because it cannot be imported.

2021-10-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: If you are building CPython against a specific version of SQLite (for example one you've compiled yourself), make sure that you adjust _both_ CFLAGS and LDFLAGS. Note: since bpo-40810 / GH-24106, SQLite 3.7.15 or newer is required. Closing this as

[issue43851] Optimise SQLite builds on macOS and Windows

2021-10-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue44927] [sqlite3] proposal: add sqlite3.Cursor.insert() method

2021-10-19 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'm closing this for now. As I see it, there is little added value, and it would be hard to make a good API for all invariants. If this idea surfaces again, we can always reopen this issue. Thanks for you interest in improving CP

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-10-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27341 pull_request: https://github.com/python/cpython/pull/29073 ___ Python tracker <https://bugs.python.org/issue42

[issue43239] PyCFunction_New is not exported with PyAPI_FUNC

2021-10-20 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: It seems to me that this issue can be closed as fixed. Do you have further PR's for this, Petr? -- nosy: +erlendaasland status: open -> pending ___ Python tracker <https://bugs.python.org

[issue45459] Limited API support for Py_buffer

2021-10-21 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45459> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: FYI, see bpo-43916 regarding the introduction and rationale of introducing Py_TPFLAGS_DISALLOW_INSTANTIATION. Slightly related: bpo-43908 -- ___ Python tracker <https://bugs.python.org/issue45

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: >> Can I do something for this pending PEP? > > Ask Victor, he should know more. But as far as I know, no one started on it > yet. Quoting PEP 630 (active PEP): Whenever this PEP mentions extension modules, the advice also applies to b

[issue43974] Define Py_BUILD_CORE_MODULE in extensions instead of setup.py and Modules/Setup

2021-10-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > I no longer think that we should define Py_BUILD_CORE_MODULE > unconditionally. Instead I propose to move the defines into each C module. +1. Explicit is nice. -- nosy: +erlendaasland ___ Python t

[issue45126] [sqlite3] cleanup and harden Connection and Cursor __init__

2021-10-22 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27435 pull_request: https://github.com/python/cpython/pull/29160 ___ Python tracker <https://bugs.python.org/issue45

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > My understanding is that this entire class of code changes has been put on > hold pending Steering Council approval. Can you please point me to the official SC statement regarding this? I cannot find it. > It represents a great deal of code

[issue45581] [sqlite3] raise MemoryError if sqlite3_open_v2() returns SQLITE_NOMEM

2021-10-22 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, we call _pysqlite_seterror() if sqlite3_open_v2() returns != SQLITE_OK. However, if a memory failure occurs during sqlite3_open_v2(), the database handle is explicitly set to NULL. This _may_ cause _pysqlite_seterror() to segfault, since we

[issue45581] [sqlite3] raise MemoryError if sqlite3_open_v2() returns SQLITE_NOMEM

2021-10-22 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27444 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29171 ___ Python tracker <https://bugs.python.org/issu

[issue41682] [Windows] test_asyncio: Proactor test_sendfile_close_peer_in_the_middle_of_receiving failure

2021-10-22 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: New failure today: https://github.com/python/cpython/runs/3979900415?check_suite_focus=true test_sendfile_close_peer_in_the_middle_of_receiving (test.test_asyncio.test_sendfile.SelectEventLoopTests) ... ok

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks, Petr. Yes, that is correct. PEP 630 (I assume you meant 630, not 640) still describes the _rationale_ very well. I guess what's needed is a Standards Track PEP based on PEP 630 (IIUC). -- ___ P

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Petr: > Hmm, the best I can find is > https://github.com/python/steering-council/blob/main/updates/2021-02-steering-council-update.md#february-08 Perfect, thanks! Christian: Thanks for your input. If this was a discussion on Discourse, I'd

[issue45113] [subinterpreters][C API] Add a new function to create PyStructSequence from Heap.

2021-10-23 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Oh, I found PEP 3121 (Extension Module Initialization and Finalization). It is a Standards Track PEP and it is accepted. The abstract is pretty short. Let me just repost it here, for convenience: Extension module initialization currently has a few

[issue45608] [sqlite3] some DB-API attributes are undocumented

2021-10-25 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Some DB-API 2.0 attributes are undocumented: - apilevel - threadsafety - paramstyle These attributes should be documented. See also: - bpo-8196 - https://discuss.python.org/t/is-sqlite3-threadsafety-the-same-thing-as-sqlite3-threadsafe-from-the-c

[issue45608] [sqlite3] some DB-API attributes are undocumented

2021-10-25 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27482 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29219 ___ Python tracker <https://bugs.python.org/issu

[issue37095] [Feature Request]: Add zstd support in tarfile

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue37095> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45612] [doc] add sqlite3 module docstring

2021-10-26 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, the sqlite3 module docstring is the old pysqlite copyright comment in the start of Lib/sqlite3/__init__.py. This is not very helpful to the general user. Suggesting to add a more helpful docstring, a la the 're' or 'array'

[issue45612] [doc] add sqlite3 module docstring

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27488 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29224 ___ Python tracker <https://bugs.python.org/issu

[issue10572] Move test sub-packages to Lib/test

2021-10-26 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: A side-effect of keeping tests inside the package, is that they appear in the package contents module docstring, which may be slightly confusing to new users. >>> import sqlite3 >>> help(sqlite3) Help on package sqlite3: NAME sq

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue45613> ___ ___ Python-bugs-list mailing list Unsub

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +paul.moore ___ Python tracker <https://bugs.python.org/issue45613> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : Currently, the sqlite3 DB-API 2.0 attribute 'threadsafety' is hard-coded to 1, meaning "threads may share the module, but not connections". This is not always true, since it depends on the default SQLite threaded mode, selected at c

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: FYI, it is also possible to change the threaded mode using sqlite3_config(), however that API is not exposed to the sqlite3 module, and there is no plans for doing so in the near future :) -- ___ Python

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27491 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29227 ___ Python tracker <https://bugs.python.org/issu

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-10-26 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: BTW, I've verified that the overhead of adding this query is negligible. $ python -m pyperf compare_to --min-speed 1 main.json patched.json Benchmark hidden because not significant (1): sqlite_synth git switch - Switched to branch 'main'

[issue45614] traceback of exception with non-unicode __module__

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45614> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45615] Missing test for type of error when printing traceback for non-exception

2021-10-26 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45615> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45618] Documentation builds fail with Sphinx 3.2.1

2021-10-27 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45618> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42545] Check that all symbols in the limited ABI are exported

2021-10-27 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Pablo, can this be closed? -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue42545> ___ ___ Pytho

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-10-27 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27497 pull_request: https://github.com/python/cpython/pull/29234 ___ Python tracker <https://bugs.python.org/issue42

[issue40866] Use PyModule_AddType() in posix module initialisation

2021-10-27 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> out of date ___ Python tracker <https://bugs.python.org/issue40866> ___ ___ Python-bugs-list mailing list Un

[issue45634] [sqlite3] don't combine error checks when adding integer constants

2021-10-27 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : In Modules/_sqlite/module.c, add_integer_constants() accumulates the return values of repeated PyModule_AddIntMacro() calls. We should change this to instead bailing immediately on error. -- components: Extension Modules messages: 405124 nosy

[issue45634] [sqlite3] don't combine error checks when adding integer constants

2021-10-27 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27515 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29251 ___ Python tracker <https://bugs.python.org/issu

[issue10572] Move test sub-packages to Lib/test

2021-10-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27573 pull_request: https://github.com/python/cpython/pull/29304 ___ Python tracker <https://bugs.python.org/issue10

[issue45677] [doc] improve sqlite3 docs

2021-10-29 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : The sqlite3 docs could need a little makeover. Here's some things that could be improved: - avoid addressing the reader as "you" - avoid using affirmative tone - establish a "Security Considerations" or "Common Mistakes&q

[issue45677] [doc] improve sqlite3 docs

2021-10-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27595 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29326 ___ Python tracker <https://bugs.python.org/issu

[issue10572] Move test sub-packages to Lib/test

2021-10-29 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27596 pull_request: https://github.com/python/cpython/pull/29327 ___ Python tracker <https://bugs.python.org/issue10

[issue45634] [sqlite3] don't combine error checks when adding integer constants

2021-10-31 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27609 pull_request: https://github.com/python/cpython/pull/29343 ___ Python tracker <https://bugs.python.org/issue45

[issue45677] [doc] improve sqlite3 docs

2021-10-31 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > What is wrong with addressing the reader as "you"? I remember this was discussed on python-dev last year (?). IIRC, the majority was in favour of changing the documentation to avoid addressing the reader personally. Let us ask the

[issue45677] [doc] improve sqlite3 docs

2021-10-31 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: (Nosying Mariatta and Carol from the CPython DWG) -- nosy: +Mariatta, willingc ___ Python tracker <https://bugs.python.org/issue45

[issue45634] [sqlite3] don't combine error checks when adding integer constants

2021-10-31 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Thanks for reviewing, Dong-hee! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45243] [sqlite3] add support for changing connection limits

2021-11-01 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27616 pull_request: https://github.com/python/cpython/pull/29356 ___ Python tracker <https://bugs.python.org/issue45

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-11-02 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45691] Partial moving of core objects to interpreter state is incorrect at best, unsafe at worse.

2021-11-02 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45691> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45243] [sqlite3] add support for changing connection limits

2021-11-02 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Steve, do you think it is worth it adding an audit hook for setting connection limits? Most of the limits are harmless, but limits that control recursion are more interesting. SQLITE_LIMIT_EXPR_DEPTH: Maximum Depth Of An Expression Tree SQLite

[issue24139] Use sqlite3 extended error codes

2021-11-02 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue24139] Use sqlite3 extended error codes

2021-11-03 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27640 pull_request: https://github.com/python/cpython/pull/29382 ___ Python tracker <https://bugs.python.org/issue24

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-11-03 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > Congratulations, and thanks for your work and determination to get this done > :) Thanks, and thank you for helping out, Petr :) Also a big thanks to Dong-hee, Berker, Serhiy, Pablo, and Victor for reviews and guidance with this &q

[issue45613] [sqlite3] set threadsafety attribute based on default SQLite threaded mode

2021-11-03 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405698 ___ Python tracker <https://bugs.python.org/issue1635741> ___ ___ Python-bug

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- assignee: docs@python -> components: +Interpreter Core, Subinterpreters -Documentation nosy: +erlendaasland -ahmedsayeed1982, docs@python versions: +Python 3.10 -Python 3.6 ___ Python tracker <

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +Jim Fasarakis-Hilliard, TCsaba, amaury.forgeotdarc, christian.heimes, corona10, eric.snow, h-vetinari, isoschiz, koubaa, kylotan, lukasz.langa, miss-islington, orsenthil, pconnell, petr.viktorin, phsilva, python-dev, santoso.wijaya

[issue28124] Rework SSL module documentation

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405713 ___ Python tracker <https://bugs.python.org/issue28124> ___ ___ Python-bug

[issue28124] Rework SSL module documentation

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- assignee: docs@python -> components: +Documentation, SSL -Build nosy: +cheryl.sabella, christian.heimes, docs@python, miss-islington -ahmedsayeed1982 versions: +Python 3.8 -Python 3.7 ___ Python tracker <

[issue34956] _tkinter built on macOS 10.14 does not link to Tcl and Tk in /Library/Frameworks

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405708 ___ Python tracker <https://bugs.python.org/issue34956> ___ ___ Python-bug

[issue34956] _tkinter built on macOS 10.14 does not link to Tcl and Tk in /Library/Frameworks

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: +macOS -Parser nosy: +anthonypjshaw, dimpase, miss-islington, ned.deily, ronaldoussoren, wordtech -ahmedsayeed1982, lys.nikolaou, pablogsal versions: +Python 3.6, Python 3.8 ___ Python tracker <ht

[issue40257] Improve the use of __doc__ in pydoc

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405706 ___ Python tracker <https://bugs.python.org/issue40257> ___ ___ Python-bug

[issue40257] Improve the use of __doc__ in pydoc

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: +Library (Lib) -Interpreter Core nosy: +eamanu, gvanrossum, levkivskyi, lukasz.langa, mark.dickinson, mbussonn, ncoghlan, serhiy.storchaka, tcaswell, terry.reedy, veky, xtreak -ahmedsayeed1982 versions: +Python 3.9 -Python 3.6

[issue18458] interactive interpreter crashes and test_readline fails on OS X 10.9 Mavericks due to libedit update

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405711 ___ Python tracker <https://bugs.python.org/issue18458> ___ ___ Python-bug

[issue18458] interactive interpreter crashes and test_readline fails on OS X 10.9 Mavericks due to libedit update

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: -email nosy: +Etienne Le Sueur, Russell.Jurney, jcea, mkleehammer, mrichman, ned.deily, nneonneo, python-dev, ronaldoussoren -ahmedsayeed1982, barry, r.david.murray versions: -Python 3.11 ___ Python

[issue14001] CVE-2012-0845 Python v2.7.2 / v3.2.2 (SimpleXMLRPCServer): DoS (excessive CPU usage) by processing malformed XMLRPC / HTTP POST request

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405710 ___ Python tracker <https://bugs.python.org/issue14001> ___ ___ Python-bug

[issue14001] CVE-2012-0845 Python v2.7.2 / v3.2.2 (SimpleXMLRPCServer): DoS (excessive CPU usage) by processing malformed XMLRPC / HTTP POST request

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: +Library (Lib), XML -email nosy: +Arfrever, dmalcolm, ezio.melotti, flox, iankko, loewis, neologix, orsenthil, pitrou, python-dev, rosslagerwall, schmir -ahmedsayeed1982, barry, r.david.murray

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405709 ___ Python tracker <https://bugs.python.org/issue42967> ___ ___ Python-bug

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +AdamGold, eric.araujo, gregory.p.smith, kj, lemburg, mcepl, miss-islington, ned.deily, orsenthil, pablogsal, petr.viktorin, rschiron, serhiy.storchaka, vstinner -ahmedsayeed1982 versions: +Python 3.10, Python 3.6, Python 3.7, Python 3.9

[issue13703] Hash collision security issue

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405707 ___ Python tracker <https://bugs.python.org/issue13703> ___ ___ Python-bug

[issue13703] Hash collision security issue

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: +Interpreter Core -Argument Clinic nosy: +Arach, Arfrever, Huzaifa.Sidhpurwala, Jim.Jewett, Mark.Shannon, PaulMcMillan, Zhiping.Deng, alex, barry, benjamin.peterson, christian.heimes, cvrebert, dmalcolm, eric.araujo, eric.snow, fx5

[issue12419] Add ident parameter to SysLogHandler

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- Removed message: https://bugs.python.org/msg405705 ___ Python tracker <https://bugs.python.org/issue12419> ___ ___ Python-bug

[issue12419] Add ident parameter to SysLogHandler

2021-11-04 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- components: +Library (Lib) -Installation nosy: +flub, python-dev, vinay.sajip -ahmedsayeed1982 versions: -Python 3.6 ___ Python tracker <https://bugs.python.org/issue12

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-11-04 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Yes, cleaning up ahmedsayeed1982 spam. I did my best to revert the nosy list, component, versions, and assigned to changes. What did I mess up? -- ___ Python tracker <https://bugs.python.org/issue42

[issue42967] [CVE-2021-23336] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as a query args separator

2021-11-04 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See bpo-12168 for a similar cleanup by Eryk Sun. There was approx. 20 spammed issues. Eryk fixed most of them; I did a couple. -- ___ Python tracker <https://bugs.python.org/issue42

[issue45292] Implement PEP 654: Exception Groups

2021-11-05 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45292> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45677] [doc] improve sqlite3 docs

2021-11-05 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: See also discussion on Discourse: https://discuss.python.org/t/avoid-addressing-the-user-directly-when-writing-docs/11671 -- ___ Python tracker <https://bugs.python.org/issue45

[issue45731] Handle --enable-loadable-sqlite-extensions in configure

2021-11-05 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45731> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45743] Cleanup and simplify setup.py

2021-11-07 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45743> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45512] [sqlite3] simplify "isolation level"

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: IMO, GH-29053 improves readability, mainly because of these factors: - Argument Clinic now takes care of the ref count dance, and as a bonus, it is more self-documenting (stating clearly that it accepts str and None) - Begin statement validation has been

[issue45723] Improve and simplify configure.ac checks

2021-11-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45723> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45723] Improve and simplify configure.ac checks

2021-11-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27719 pull_request: https://github.com/python/cpython/pull/29466 ___ Python tracker <https://bugs.python.org/issue45

[issue45743] Cleanup and simplify setup.py

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > 1) __APPLE_USE_RFC_3542 should have been in socketmodule.c from the start, > not sure why it was added in setup.py. FTR, it was added by me in bpo-35569, GH-19526. I moved the check to setup.py because Ned made me do it :P https://github.com/

[issue45748] "import ctypes" segfaults on Python 3.6 and Ubuntu 21.10

2021-11-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue45748> ___ ___ Python-bugs-list mailing list Unsub

[issue45748] "import ctypes" segfaults on Python 3.6 and Ubuntu 21.10

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Python 3.6 is in security-fix only mode. I'm sorry, but I don't think this counts as a security issue. -- nosy: +erlendaasland status: open -> pending ___ Python tracker <https://bugs.pytho

[issue45748] "import ctypes" segfaults on Python 3.6 and Ubuntu 21.10

2021-11-08 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- nosy: +ned.deily -serhiy.storchaka status: pending -> open ___ Python tracker <https://bugs.python.org/issue45748> ___ ___ Py

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: BTW, this only affects the code in main. -- components: +Extension Modules type: -> behavior versions: +Python 3.11 ___ Python tracker <https://bugs.python.org/issu

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-08 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : In Modules/_sqlite/statement.c pysqlite_statement_create() and Modules/_sqlite/cursor.c pysqlite_cursor_executescript_impl(), we incorrectly use SQLITE_LIMIT_LENGTH to check statement length. However, the correct limit is *SQLITE_LIMIT_SQL_LENGTH

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-08 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I'm leaning towards alt 1. It is also easy to test all paths with that option. But I also think alt 3 is ok. It makes for easier code to maintain. Alt 2 is, as you say, the weakest alternative. > What happens if set SQLITE_LIMIT_SQL_LENGTH

[issue45723] Improve and simplify configure.ac checks

2021-11-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27736 pull_request: https://github.com/python/cpython/pull/29485 ___ Python tracker <https://bugs.python.org/issue45

[issue45723] Improve and simplify configure.ac checks

2021-11-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27737 pull_request: https://github.com/python/cpython/pull/29486 ___ Python tracker <https://bugs.python.org/issue45

[issue45723] Improve and simplify configure.ac checks

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: AC_CHECK_TYPE is obsolete and it's use is discouraged. There are some gotchas we need to check before switching to AC_CHECK_TYPES. See: - https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html - https://www.gn

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: > > What happens if set SQLITE_LIMIT_SQL_LENGTH to 0 [...] In this case, the limit is actually zero: >>> cx.setlimit(sqlite3.SQLITE_LIMIT_SQL_LENGTH, 0) 1024 >>> cx.execute("select 1") Traceback (most rece

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27740 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29489 ___ Python tracker <https://bugs.python.org/issu

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: Also, SQLITE_LIMIT_LENGTH and SQLITE_LIMIT_SQL_LENGTH is inclusive in SQLite. We should treat them likewise. -- ___ Python tracker <https://bugs.python.org/issue45

[issue45754] [sqlite3] SQLITE_LIMIT_LENGTH is incorrectly used to check statement length

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: I believe it is best to go with alternative 1. The error strings produced by SQLite may change from release to release, so for example a buildbot update may suddenly break the CI. -- ___ Python tracker <ht

[issue45723] Improve and simplify configure.ac checks

2021-11-09 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27749 pull_request: https://github.com/python/cpython/pull/29500 ___ Python tracker <https://bugs.python.org/issue45

[issue45747] Detect dbm and gdbm dependencies in configure.ac

2021-11-09 Thread Erlend E. Aasland
Erlend E. Aasland added the comment: AC_SEARCH_LIBS() will search libc before checking external libraries, FWIW. -- nosy: +erlendaasland ___ Python tracker <https://bugs.python.org/issue45

[issue45774] Detect SQLite in configure.ac

2021-11-09 Thread Erlend E. Aasland
New submission from Erlend E. Aasland : "Autoconfiscate" SQLite detection. Plan: - Detect header/library using AC_CHECK_HEADERS/AC_CHECK_LIB - Check required version using AC_COMPILE_IFELSE - Use AC_CHECK_LIB to check if sqlite3_load_extension is present, and if the result harmo

<    6   7   8   9   10   11   12   >