Change by Dong-hee Na :
--
keywords: +patch
nosy: +corona10
nosy_count: 5.0 -> 6.0
pull_requests: +28303
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30082
___
Python tracker
<https://bugs.p
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 5.0 -> 6.0
pull_requests: +28310
pull_request: https://github.com/python/cpython/pull/30082
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 4.0 -> 5.0
pull_requests: +28309
pull_request: https://github.com/python/cpython/pull/30082
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
New changeset 191c431de7d9b23484dd16f67e62c6e85a1fac7f by Dong-hee Na in branch
'main':
bpo-45919: Use WinAPI GetFileType() in is_valid_fd() (GH-30082)
https://github.com/python/cpython/commit/191c431de7d9b23484dd16f67e62c6
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45919>
___
___
Pyth
Change by Dong-hee Na :
--
nosy: +corona10
nosy_count: 3.0 -> 4.0
pull_requests: +28311
pull_request: https://github.com/python/cpython/pull/30082
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
pull_requests: +28313
pull_request: https://github.com/python/cpython/pull/30090
___
Python tracker
<https://bugs.python.org/issue45
Dong-hee Na added the comment:
New changeset 9130a4d62032468e0d4949aaa49c29afb0d854ca by Dong-hee Na in branch
'main':
bpo-45919: Remove out of date comment (GH-30090)
https://github.com/python/cpython/commit/9130a4d62032468e0d4949aaa49c29
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46106>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue46166>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
keywords: +patch
nosy: +corona10
nosy_count: 2.0 -> 3.0
pull_requests: +28488
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/30273
___
Python tracker
<https://bugs.p
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue45189>
___
___
Pyth
Dong-hee Na added the comment:
New changeset 196b53eb1e62871ca80dee180e4891b4dd5c52ac by Dong-hee Na in branch
'main':
bpo-45189: Drop the "list_frozen" command from _test_embed. (GH-30273)
https://github.com/python/cpython/commit/196b53eb1e62871ca80dee180e4891b4dd5c52a
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46070>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
I can reproduce the crash on my macOS with main branch version.
Fatal Python error: Segmentation fault
Thread 0x700010389000 (most recent call first):
File "/Users/user/oss/cpython/bug.py", line 16 in doIt
File "/Users/user/oss/cpython/L
New submission from Dong-hee Na :
New changeset 66c47b63a0df3143fe48d6efc1183eecda2a363d by David CARLIER in
branch 'main':
bpo-46176: mmap module adding MAP_STACK constant. (GH-30252)
https://github.com/python/cpython/commit/66c47b63a0df3143fe48d6efc1183eecda2a363d
-
Change by Dong-hee Na :
--
nosy: -corona10
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46176>
___
___
Pyth
Change by Dong-hee Na :
--
keywords: +patch
nosy: +corona10
nosy_count: 4.0 -> 5.0
pull_requests: +28504
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30290
___
Python tracker
<https://bugs.python.org/i
Dong-hee Na added the comment:
New changeset d12bec69931503be78cd555cf7bc22ad6f4f2bd5 by Nikita Sobolev in
branch 'main':
bpo-43424: Deprecate `webbrowser.MacOSXOSAScript._name` attribute (GH-30241)
https://github.com/python/cpython/commit/d12bec69931503be78cd555cf7bc22
Dong-hee Na added the comment:
New changeset fb44d0589615590b1e7895ba78a038e96b15a219 by Dong-hee Na in branch
'main':
bpo-46085: Fix iterator cache mechanism of OrderedDict. (GH-30290)
https://github.com/python/cpython/commit/fb44d0589615590b1e7895ba78a038
Dong-hee Na added the comment:
Thanks for reporting Kevin!
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46217>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
New changeset e63066cfed27511c9b786d61761f87f7a532571a by Nikita Sobolev in
branch 'main':
bpo-46299: improve `test_descr.py` with stricter error handling (GH-30471)
https://github.com/python/cpython/commit/e63066cfed27511c9b786d61761f87
Change by Dong-hee Na :
--
pull_requests: +28678
pull_request: https://github.com/python/cpython/pull/30475
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
New changeset 45d44b950f1dab0ef90d0a8f4fa75ffaae71500b by Dong-hee Na in branch
'main':
bpo-46299: Improve test_descr (GH-30475)
https://github.com/python/cpython/commit/45d44b950f1dab0ef90d0a8f4fa75f
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46299>
___
___
Pyth
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46205>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
New changeset e13cdca0f5224ec4e23bdd04bb3120506964bc8b by Sam Gross in branch
'main':
bpo-46205: exit if no workers are alive in runtest_mp (GH-30470)
https://github.com/python/cpython/commit/e13cdca0f5224ec4e23bdd04bb3120
Change by Dong-hee Na :
--
versions: -Python 3.8
___
Python tracker
<https://bugs.python.org/issue46205>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46205>
___
___
Pyth
Dong-hee Na added the comment:
When I take a look at previous PRs, most of adding test cases were not
backported.
The backported cases were triggered by bug issues.
But let's pass this case as an exceptional case.
--
nosy: +corona10
___
P
Dong-hee Na added the comment:
@gvanrossum
Ah okay, Looks like bpo-46195 is the root of this issue.
In this case, backporting is reasonable.
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Dong-hee Na :
--
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issue46345>
___
___
Python-bugs-list mailing list
Unsub
Dong-hee Na added the comment:
@sobolevn
Do you want to close it?
Cleaning up the issue is one of the duties of triage members :)
--
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
New changeset f779faccd3a7a7e8c372492e858d021c449cdd85 by Nikita Sobolev in
branch 'main':
bpo-46358: modernize `test_asyncio` (GH-30562)
https://github.com/python/cpython/commit/f779faccd3a7a7e8c372492e858d021c449cdd85
--
nosy:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46368>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dong-hee Na :
Just experiment how it will be worth :)
Thread: https://github.com/faster-cpython/ideas/issues/224
--
assignee: corona10
messages: 410570
nosy: corona10
priority: normal
severity: normal
status: open
title: Experiment with LLVM BOLT binary optimizer
Change by Dong-hee Na :
--
components: +Build
___
Python tracker
<https://bugs.python.org/issue46378>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
New changeset 09087b8519316608b85131ee7455b664c00c38d2 by Nikita Sobolev in
branch 'main':
bpo-46386: improve `test_typing:test_immutability_by_copy_and_pickle` (GH-30613)
https://github.com/python/cpython/commit/09087b8519316608b85131ee7455b6
Dong-hee Na added the comment:
Thank you @sobolevn !
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Dong-hee Na added the comment:
New changeset 8105dd24112509fab2eabfce5352afc41e3a34b6 by Nikita Sobolev in
branch '3.9':
[3.9] bpo-46425: Fix direct invocation of multiple test modules (GH-30666)
(GH-30700)
https://github.com/python/cpython/commit/8105dd24112509fab2eabfce5352af
Dong-hee Na added the comment:
New changeset a6a088548063226233c08b8d35dde130746fdd10 by Nikita Sobolev in
branch '3.10':
[3.10] bpo-46425: Fix direct invocation of multiple test modules (GH-30666)
(GH-30699)
https://github.com/python/cpython/commit/a6a088548063226233c08b8d35dde1
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
After discussion with Victor by using DM, I decided to provide high-level API
instead of low-level APIs.
- gdbm.open(filename, snapshots=(foo, bar))
will do everything at once.
Regards,
Dong-hee
--
___
Python
Change by Dong-hee Na :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue45452>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue37093>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
New changeset 38afeb1a336f0451c0db86df567ef726f49f6438 by Erlend Egeberg
Aasland in branch 'main':
bpo-46249: Move set lastrowid out of the sqlite3 query loop (GH-30489)
https://github.com/python/cpython/commit/38afeb1a336f0451c0db86df567ef7
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46249>
___
___
Pyth
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46478>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46465>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46476>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dong-hee Na :
Triggered by Victor's suggestion:
- Well-used.
- Easy to enhance performance.
- Performance enhancement is notable.
Mean +- std dev: [weakref_base] 49.3 ns +- 2.2 ns -> [weakref_vectorcall] 27.7
ns +- 0.9 ns: 1.78x faster
--
assignee:
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +29007
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/30820
___
Python tracker
<https://bugs.python.org/issu
Dong-hee Na added the comment:
New changeset 76dc047a0e88d10aad0405228d56e94438cdd91c by Dong-hee Na in branch
'main':
bpo-46481: Implement vectorcall for weakref.ref.__call__ method. (GH-30820)
https://github.com/python/cpython/commit/76dc047a0e88d10aad0405228d56e9
Change by Dong-hee Na :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue46481>
___
___
Pyth
Change by Dong-hee Na :
--
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue46527>
___
___
Python-bugs-list mailing list
Un
Dong-hee Na added the comment:
New changeset 84f093918a4be663775afe2933f4be86f72fe495 by Nikita Sobolev in
branch 'main':
bpo-45578: add a test case for `dis.findlabels` (GH-30058)
https://github.com/python/cpython/commit/84f093918a4be663775afe2933f4be86f72fe495
--
nosy:
Dong-hee Na added the comment:
New changeset b9d8980d89bfaa4bf16d60f0488adcc9d2cbf5ef by Nikita Sobolev in
branch 'main':
bpo-43698: do not use `...` as argument name in docs (GH-30502)
https://github.com/python/cpython/commit/b9d8980d89bfaa4bf16d60f0488adcc9d2cbf5ef
-
Dong-hee Na added the comment:
New changeset ac0c6e128cb6553585af096c851c488b53a6c952 by Jelle Zijlstra in
branch 'main':
bpo-46527: allow calling enumerate(iterable=...) again (GH-30904)
https://github.com/python/cpython/commit/ac0c6e128cb6553585af096c851c48
Dong-hee Na added the comment:
So since no more regression is expected, I would like to propose merging the PR
and once we need to change the implementation, we can revert Vectorcall
anytime, Rollbacking Vectorcall will not raise any behavior regression so
anytime we can rollback it
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue42926>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Dong-hee Na :
Compiling CPython with the PGO option is good for CPython performance but
compile time is very painful since PGO profiling is executed with a single
thread.
When I tested with run -m test --pgo -j8, it doesn't affect to optimized result
with fast build
Dong-hee Na added the comment:
> You only test libregrtest.main and libregrtest.runtest_mp modules which >
> don't execute code. Does it mean that running tests is useless to train > the
> PGO?
Sorry, I didn't check all affects except performance regression,
and
Dong-hee Na added the comment:
Only 1% gain, so we decided not to adopt it yet.
see: https://github.com/faster-cpython/ideas/issues/224#issuecomment-1022371595
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
_
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46593>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46600>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46606>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
assignee: -> corona10
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list mai
Change by Dong-hee Na :
--
keywords: +patch
pull_requests: +29316
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/31138
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
Added file: https://bugs.python.org/file50604/bench_callback.py
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list m
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue46648>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
pull_requests: -29325
___
Python tracker
<https://bugs.python.org/issue46648>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Dong-hee Na :
--
nosy: +corona10, nascheme
___
Python tracker
<https://bugs.python.org/issue46657>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
I add Neil to the nosy list since he is one of the kick-off members with this
amazing works :)
--
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
@hydroflask
It does not show impressive performance enhancement, so I decided not to change
it
See PR 31138
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Pytho
Dong-hee Na added the comment:
@hydroflask
I am one of the big fans of applying vectorcall :)
> The benchmark you did is not reflective of my use-case. I have a codebase
> that I have completely converted into a C extension using mypyc.
Can you provide me a minimal benchmarkable scr
Change by Dong-hee Na :
--
nosy: +corona10
___
Python tracker
<https://bugs.python.org/issue45955>
___
___
Python-bugs-list mailing list
Unsubscribe:
Dong-hee Na added the comment:
@vstinner
I got a similar result from hydroflask's benchmark.
I think that is worth reopening this issue WDYT?
--
nosy: +erlendaasland, vstinner
___
Python tracker
<https://bugs.python.org/is
Dong-hee Na added the comment:
@hydroflask
Would you like to run your benchmark with my latest PR?
--
___
Python tracker
<https://bugs.python.org/issue46
Change by Dong-hee Na :
Added file: https://bugs.python.org/file50610/bench_callback_v3.py
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bug
Dong-hee Na added the comment:
With v3 benchmark
Mean +- std dev: [base] 1.32 us +- 0.02 us -> [opt] 1.18 us +- 0.02 us: 1.13x
faster
--
___
Python tracker
<https://bugs.python.org/issu
Change by Dong-hee Na :
--
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list mailing list
Un
Change by Dong-hee Na :
--
resolution: wont fix ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list
Dong-hee Na added the comment:
@vstinner
PR 31188 cause reference leak, please check
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 5.38 Run tests sequentially
0:00:00 load avg: 5.38 [1/1] test_ctypes
beginning 6 repetitions
123456
..
test_ctypes leaked [1028, 1026, 1028] referen
Dong-hee Na added the comment:
No leak after if I revert PR 31188 on my local
--
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bug
Change by Dong-hee Na :
--
pull_requests: +29379
pull_request: https://github.com/python/cpython/pull/31209
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
@vstinner
PR 31209 is for fixing the leak.
--
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list m
Dong-hee Na added the comment:
New changeset e959dd9f5c1d8865d4e10c49eb30ee0a4fe2735d by Dong-hee Na in branch
'main':
bpo-46323 Fix ref leak if ctypes.CFuncPtr raises an error. (GH-31209)
https://github.com/python/cpython/commit/e959dd9f5c1d8865d4e10c49eb30ee
Dong-hee Na added the comment:
New changeset b5527688aae11d0b5af58176267a9943576e71e5 by Dong-hee Na in branch
'main':
bpo-46323: Use PyObject_Vectorcall while calling ctypes callback function
(GH-31138)
https://github.com/python/cpython/commit/b5527688aae11d0b5af58176267a99
Dong-hee Na added the comment:
@hydroflask
All patches are merged!
Thanks for all your suggestions :)
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Change by Dong-hee Na :
--
pull_requests: +29395
pull_request: https://github.com/python/cpython/pull/31224
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
@hydroflask
Sound reasonable, I submitted a new patch to use alloca which is already used
in _ctypes module.
--
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
And it even better from performance view
--
___
Python tracker
<https://bugs.python.org/issue46323>
___
___
Python-bugs-list m
Dong-hee Na added the comment:
New changeset d2d1d49eaccaa83eb8873ba15f2fc9562143bc56 by Nikita Sobolev in
branch 'main':
bpo-46685: cover `TypeError` of `ForwardRef(1)` in `test_typing` (GH-31223)
https://github.com/python/cpython/commit/d2d1d49eaccaa83eb8873ba15f2fc9
Dong-hee Na added the comment:
New changeset d18120cd67b4297f78bfc9bf7b36774cf0bf15f2 by Dong-hee Na in branch
'main':
bpo-46323: Reduce stack usage of ctypes python callback function. (GH-31224)
https://github.com/python/cpython/commit/d18120cd67b4297f78bfc9bf7b3677
Dong-hee Na added the comment:
@hydroflask @vstinner
Okay let's remove if statement, I will send a patch soon.
--
___
Python tracker
<https://bugs.python.org/is
Change by Dong-hee Na :
--
pull_requests: +29418
pull_request: https://github.com/python/cpython/pull/31249
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
New changeset db052851a70fd95d047c6263fc16a75e4d47b3ed by Dong-hee Na in branch
'main':
bpo-46323: Allow alloca(0) for python callback function of ctypes (GH-31249)
https://github.com/python/cpython/commit/db052851a70fd95d047c6263fc16a7
Change by Dong-hee Na :
--
pull_requests: +29434
pull_request: https://github.com/python/cpython/pull/31272
___
Python tracker
<https://bugs.python.org/issue46
Dong-hee Na added the comment:
> Was reviewing the code and noticed that a double-free was introduced in the
> recent changes:
Thanks, that looks like my mistake
--
___
Python tracker
<https://bugs.python.org/i
1 - 100 of 1592 matches
Mail list logo