Denver Coneybeare added the comment:
That is a very good point, bethard, that setting os.environ["COLUMNS"] in my
suggested patch (test_argparse.py.COLUMNS.patch) is global and should be
test-local. I've attached an updated patch
(test_argparse.py.COLUMNS.update1.patch) w
Denver Coneybeare added the comment:
Thanks for the input, r.david.murray. I've updated my patch and attached it to
take into consideration your comments: test_argparse.py.COLUMNS.update2.patch.
The updated patch uses EnviormentVarGuard as suggested, except that it slightly
t
New submission from Denver Coneybeare :
It would be great if unittest.assertRaises() returned the raised exception when
it passes. This allows the caller to easily perform further checks on the
exception, such as its attribute values. Currently assertRaises() returns None
(when it doesn&#
Denver Coneybeare added the comment:
Michael: Do you disagree with assertRaises() returning the exception object on
principle? Or is this just the consensus that you got from the mailing list,
including Guido's comment. My particular use case is that I want to check
certain attri
New submission from Denver Coneybeare :
dbm.open() with flag="n" raises dbm.error if the given file exists but whichdb
doesn't recognize it. In the documentation for dbm.open() the "n" flag is
documented to "Always create a new, empty database, open for readi
Changes by Denver Coneybeare :
--
nosy: +brian.curtin
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue11491>
___
___
Denver Coneybeare added the comment:
Looks good to me. I thought the same thing about the file not being closed on
error, but all of the other tests in the file also suffer from that problem, so
I just followed the convention set out by the other tests. Maybe if you
eventually commit this
New submission from Denver Coneybeare :
As part of the CPython sprints at PyCon 2011 I am improving the unit test
coverage for the fileinput module. Primarily, this will be adding unit tests
for the global functions, which right now are almost completely untested. I
will be adding
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21139/fileinput_unittests_v2.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21141/fileinput_unittests_v3.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21145/fileinput_unittests_v5.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21147/fileinput_unittests_v6.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21149/fileinput_unittests_v7.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Removed file: http://bugs.python.org/file21138/fileinput_unittests_v1.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21150/fileinput_unittests_v8.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21151/fileinput_unittests_v9.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21153/fileinput_unittests_v10.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21154/fileinput_unittests_v11.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21163/fileinput_unittests_v12.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21193/fileinput_unittests_v12.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file21195/fileinput_unittests_v13.patch
___
Python tracker
<http://bugs.python.org/issue11509>
___
___
Denver Coneybeare added the comment:
fileinput_unittests_v13.patch is the final patch. Test coverage increased from
65% to 93% with this patch. The only code left untested is fileinput._test(),
which by its name suggests that testing is not required
New submission from Denver Coneybeare :
The attached patch increases the test coverage of the module _dummy_thread from
78% to 100%.
--
components: Tests
files: test_dummy_thread_test_coverage_improvement.patch
keywords: patch
messages: 130957
nosy: brian.curtin, denversc
priority
Changes by Denver Coneybeare :
Added file:
http://bugs.python.org/file21206/test_dummy_thread_test_coverage_improvement_v2.patch
___
Python tracker
<http://bugs.python.org/issue11
Changes by Denver Coneybeare :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue11551>
___
___
Python-bugs-list mailing list
Unsubscribe:
Denver Coneybeare added the comment:
For kicks, I just took a look at this old, forgotten issue. I agree with the
submitter that add_argument() should fail if nargs and metavar do not match,
instead of having format_help() raise the exception later on.
I've attached a
Denver Coneybeare added the comment:
Awesome, thanks for committing the patch. Glad I could help.
--
___
Python tracker
<http://bugs.python.org/issue9
Denver Coneybeare added the comment:
I decided to take a look at this old, forgotten issue and propose an updated
patch. I like the submitter's idea that urllib.Request.__init__() should take
a "method" parameter to override the return value of get_method(). I've
cr
Denver Coneybeare added the comment:
Can this issue be closed as a duplicate of #1673007? This specific request for
a "method" parameter to the Request constructor is dealt with there.
--
nosy: +denversc
___
Python tracker
<http://bu
Denver Coneybeare added the comment:
I just re-tested this issue in trunk at changeset 053bc5ca199b and the issue is
still exactly reproducible as originally reported. That is, the match to the
empty string skips a character of the match:
>>> import re
>>> [m.groups() for
New submission from Denver Coneybeare :
Just a very minor bug. The error message in idlelib/PyShell.py that is printed
when importing tkinter fails says that it failed to import "Tkinter", but the
actual module name is "tkinter" (with a lowercase t).
try:
from tki
Changes by Denver Coneybeare :
--
keywords: +patch
Added file: http://bugs.python.org/file21512/patch_idle_tkinter_import_v1.patch
___
Python tracker
<http://bugs.python.org/issue11
Changes by Denver Coneybeare :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue11745>
___
___
Python-bugs-list mailing list
Unsubscri
Denver Coneybeare added the comment:
I just re-tested this in cpython trunk at changeset and the issue does not
appear to be reproducible.
I first launched IDLE by running "python lib\idlelib\idle.py". Then I entered
the following:
Python 3.3a0 (default, Apr 2 2011, 21:55:40) [
Denver Coneybeare added the comment:
Ahh okay. I've reproduced it in trunk at changeset 053bc5ca199b.
As suggested, I ran: PCBuild\pythonw.exe lib\idlelib\idle.py
Python 3.3a0 (default, Apr 2 2011, 21:55:40) [MSC v.1500 32 bit (Intel)] on
win32
Type "copyright", "
Denver Coneybeare added the comment:
I've looked at the review (thanks for the review) and can submit an updated
patch. I don't have the Python source code pulled down to my PC anymore so it
might take a week or two before I'm able to update the patch and test it out.
I ima
New submission from Denver Coneybeare :
Currently, when a subparser is added to an argparse.ArgumentParser the list of
subparsers are stored in the built-in dict type. When these subparsers are
listed when -h is given on the command line they are showed in the order
returned from the
New submission from Denver Coneybeare :
If the COLUMNS environment variable is set to a value other than 80 then
test_argparse.py yields 80 failures. The value of the COLUMNS environment
variable affects line wrapping of the help output and the test cases assume
line wraps at 80 columns. So
New submission from Denver Coneybeare :
Some of the unit testing code in test_argparse.py could be modified to take
advantage of the new unittest features in Python 2.7 and 3.x. My suggested
changes are attached in the patch file test_argparse.py.unittest2.patch
One big one is that
Changes by Denver Coneybeare :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue9553>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Denver Coneybeare :
Removed file: http://bugs.python.org/file18463/test_argparse.py.unittest2.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file18464/test_argparse.py.unittest2.patch
___
Python tracker
<http://bugs.python.org/issue9554>
___
___
Changes by Denver Coneybeare :
Removed file: http://bugs.python.org/file18462/test_argparse.py.COLUMNS.patch
___
Python tracker
<http://bugs.python.org/issue9553>
___
___
Changes by Denver Coneybeare :
Added file: http://bugs.python.org/file18465/test_argparse.py.COLUMNS.patch
___
Python tracker
<http://bugs.python.org/issue9553>
___
___
New submission from Denver Coneybeare:
The __init__() method of threading.Timer uses *mutable* default values for the
"args" and "kwargs" arguments. Since the default argument objects are created
once and re-used for each instance, this means that changing the args list
Denver Coneybeare added the comment:
Thanks r.david.murray for your feedback. Although I disagree with your
conclusion that this does not affect 2.7. Just try running the "sample script
that reproduces the issue" from my first post and you will see the erroneous
behaviour in
Denver Coneybeare added the comment:
Thanks r.david.murray. I appreciate you taking the time to look at this issue!
--
___
Python tracker
<http://bugs.python.org/issue17
47 matches
Mail list logo
