Change by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<https://bugs.python.org/issue24337>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<https://bugs.python.org/issue35292>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<https://bugs.python.org/issue20582>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
What if the docs for socket functions that took system-level flag parameters
had links to relevant online man pages? I don't think a single entry at the top
of the page would be optimal. I know that I tend to skip the preamble and just
go directly t
Change by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<https://bugs.python.org/issue12707>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
@R. David Murray
Is this issue still valid? Running 3.6 it seems that http and ftp are
consistent at any rate (http returns http.client.HTTPMessage and ftp returns
email.message.Message). If it's still an issue, could you please elab
Demian Brecht added the comment:
>>> urlopen('https://example.com').info()
>>> urlopen('http://example.com').info()
>>> urlopen('ftp://speedtest.tele2.net').info()
>>> urlopen('file:///path/to/setup.py').info()
Change by Demian Brecht :
--
nosy: -demian.brecht
___
Python tracker
<https://bugs.python.org/issue17251>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Demian Brecht :
--
nosy: -demian.brecht
___
Python tracker
<https://bugs.python.org/issue3430>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Demian Brecht :
--
keywords: +patch
pull_requests: +11617
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Demian Brecht :
--
keywords: +patch, patch, patch
pull_requests: +11617, 11618, 11619
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Demian Brecht :
--
keywords: +patch, patch
pull_requests: +11617, 11618
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Demian Brecht added the comment:
@xtreak sure, can do. May not have time to do so today but should be able to do
so over the next couple days.
--
___
Python tracker
<https://bugs.python.org/issue12
New submission from Demian Brecht :
Echoing an email sent to python-list:
I recently ran into an issue using the site package and I wanted to confirm
that I'm not doing something wrong here before creating an issue:
I have a need to `git subtree` modules into a Django project and then ad
Change by Demian Brecht :
--
keywords: +patch
pull_requests: +6369
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33399>
___
___
Py
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue18206>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue17908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue17845>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Bump. If the patch (or request) is invalid, might be worthwhile closing this
issue (although I still think it's valid ;)).
--
___
Python tracker
<http://bugs.python.org/is
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue15025>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Indeed the WEBDAV codes were missing across the board. I've added a couple
patches: One (_a) that just adds the missing constants, and another (_b) that
changes how they're defined altogether. The advantage of the second is that
there is much less
Changes by Demian Brecht :
Added file: http://bugs.python.org/file35665/issue15025_b.diff
___
Python tracker
<http://bugs.python.org/issue15025>
___
___
Python-bugs-list m
Demian Brecht added the comment:
I actually made a similar change for issue #15025 earlier today. One of the two
should likely be closed as a dupe.
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue20
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue3430>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue19917>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
I have a few questions about this one:
1. Why is print used to begin with? Surely this should use debug logging. Using
print, you lose the benefits of logging: Timestamps, if used in the configured
logger, can be invaluable to match up against logs generated
New submission from Demian Brecht:
When sending data, the blocksize is currently hardcoded to 8192. It should
likely be set to the value of resource.getpagesize().
--
components: Library (Lib)
files: set_blocksize_to_getpagesize.diff
keywords: patch
messages: 220839
nosy: dbrecht
New submission from Demian Brecht:
This patch is a follow up to an out of scope comment made by R. David Murray in
#20898 (http://bugs.python.org/issue20898#msg213771).
In a nutshell, there is some redundancy between http.client and http.server
insofar as the definition of http status code
Demian Brecht added the comment:
Attached new patch with changes from review and a stab at an update to the docs.
--
Added file: http://bugs.python.org/file35680/refactor_http_status_codes_1.patch
___
Python tracker
<http://bugs.python.
Demian Brecht added the comment:
The problem here as far as I can tell is that the underlying file object
(addinfourl) blocks while waiting for a full response from the server. As
detailed in section 8.1 of RFC 2616, requests and responses can be pipelined,
meaning requests can be sent while
New submission from Demian Brecht:
array.array doesn't implement the buffer interface in 2.7, so memoryviews
cannot be applied to them. As memoryview has been backported to 2.7,
array.array should be updated to support it. Either that, or the 2.7
documentation should be updated to reflec
Demian Brecht added the comment:
Here's a patch for the docs that adds a little clarity.
--
keywords: +patch
Added file: http://bugs.python.org/file28986/buffer.patch
___
Python tracker
<http://bugs.python.org/is
Demian Brecht added the comment:
Strike that patch, this needs a little more love than
during-my-first-coffee-of-the-day work. I'll work on it more and submit a
follow-up for review.
--
___
Python tracker
<http://bugs.python.org/is
Demian Brecht added the comment:
Updated to mmap.PAGESIZE, which seems to be available on all systems.
--
Added file: http://bugs.python.org/file35707/issue21790.patch
___
Python tracker
<http://bugs.python.org/issue21
Demian Brecht added the comment:
New patch attached addressing review comments.
--
Added file: http://bugs.python.org/file35708/issue21793.patch
___
Python tracker
<http://bugs.python.org/issue21
Demian Brecht added the comment:
Updated patch with silly missed doc update.
--
Added file: http://bugs.python.org/file35711/issue21793_1.patch
___
Python tracker
<http://bugs.python.org/issue21
Demian Brecht added the comment:
I very well could be missing something here (and, admittedly, my OS knowledge
is rusty at best), but for the most part, page sizes are 4096, except for
SPARC, which is 8192.
> So your page double the number of calls to read(), right?
No. read() is cal
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue21818>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue17229>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Bump for a follow-up review or merge
--
___
Python tracker
<http://bugs.python.org/issue21793>
___
___
Python-bugs-list mailin
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue8843>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
FWIW, here's my take on this:
RFC 2617 (3.2.2.5) states: This may be "*", an "absoluteURL" or an "abs_path"
as specified in section 5.1.2 of [2], but it MUST agree with the Request-URI.
Note: It must AGREE.
RFC 3986 (6.2.3)
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue14414>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Of /course/ a patch always helps :)
--
___
Python tracker
<http://bugs.python.org/issue14414>
___
___
Python-bugs-list mailin
Demian Brecht added the comment:
Removed draft status code, removed S from VARIANTS_
--
Added file: http://bugs.python.org/file36012/issue21793_2.patch
___
Python tracker
<http://bugs.python.org/issue21
Demian Brecht added the comment:
Being this is tagged for 3.5, I've refactored status codes as part of #21793.
Should that be accepted and merged, that will also clear up this issue.
--
___
Python tracker
<http://bugs.python.org/is
Demian Brecht added the comment:
Attached a simple fix to the problem as written, matching logging method of
HTTPResponse.begin().
--
nosy: +demian.brecht
Added file: http://bugs.python.org/file36018/issue13128.patch
___
Python tracker
<h
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue14301>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22041>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Left a couple comments on Rietveld
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue21850>
___
___
Pytho
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue15267>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue3566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue14044>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Hi Alejandro,
I've spent a little time looking into this. I haven't been able to reproduce
what you're seeing on Windows exactly, but I've encountered other issues along
the same path using a local squid instance (localhost:4242):
from h
Demian Brecht added the comment:
Ignore my previous note. Digging into this a little more, I think I've possibly
found the underlying issue:
If the port is not specified in set_tunnel (as in your example), the buffer
sent over the wire looks like
"send: b'POST [PATH] HTTP/1.1
Demian Brecht added the comment:
I've attached a patch that solves the issue I encountered. It would be great if
you could confirm whether or not it also resolves the issue as reported.
--
keywords: +patch
Added file: http://bugs.python.org/file36066/issue22041.
Demian Brecht added the comment:
Attached a new patch with with a simple test.
--
Added file: http://bugs.python.org/file36079/issue22041_1.patch
___
Python tracker
<http://bugs.python.org/issue22
Demian Brecht added the comment:
To add a little more detail, from what I gather, CONNECT support may be
unsupported or limited (i.e. only allowing SSL connections) on various proxy
servers. If the code snippet in my previous post solves your issue, then I
would assume that to be the case
Demian Brecht added the comment:
Sorry Alejandro, I should have clarified: The attached patch is for dev, so the
failure you're seeing when attempting to apply the patch against 3.3 is
expected. It effectively does the same thing as explicitly setting the port as
you have already atte
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue12319>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Demian Brecht:
Creating this bug for clarity, but was encountered while investigating 22041
(now set as not a bug).
When using set_tunnel with default port, the port value in the host header is
set to "None":
"send: b'POST [PATH] HTTP/1.1\r\nHost: [
Changes by Demian Brecht :
--
keywords: +patch
Added file: http://bugs.python.org/file36140/issue22095.patch
___
Python tracker
<http://bugs.python.org/issue22
Demian Brecht added the comment:
No problem, happy you were able to get things sorted. Feel free to close this
issue as I've opened #22095 to address the host port header issue.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue15082>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22118>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
I've only had a couple minutes to look into this so far, but the bug does
indeed seem to be valid across all versions. In fact, the line "# XXX The stuff
below is bogus in various ways..." in urljoin tipped me off to something
potentia
Demian Brecht added the comment:
Here's an initial patch with a fix that passes all the test cases other than
the ones that are incorrect based on examples and pseudocode in RFC 3986. I
haven't checked obsoleted RFCs yet to ensure consistency, but will do so when I
get a chan
Demian Brecht added the comment:
Update based on review comments, added legacy support, fixed the tests up.
--
Added file: http://bugs.python.org/file36296/issue22118_1.patch
___
Python tracker
<http://bugs.python.org/issue22
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22147>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
Bump for review
--
___
Python tracker
<http://bugs.python.org/issue22095>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22165>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
FWIW, I think that it would be ever so slightly preferable to maintain support
for the old behaviour but perhaps add a deprecation note in the docs. It's a
little difficult to tell how much of an impact this change will have to
existing code. Mainta
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue19494>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
If you can upload a patch (including tests) conforming to Rietveld's
requirements, I'm sure it would help in getting a review done.
--
___
Python tracker
<http://bugs.python.o
Demian Brecht added the comment:
Uploaded new patch. Removed support for RFC1808-specific behaviour. Extracted
non-compliant tests into comment blocks indicating the behaviour is no longer
supported.
--
Added file: http://bugs.python.org/file36347/issue22118_2.patch
Demian Brecht added the comment:
Thanks Mike, it's always nice to get positive feedback :)
--
___
Python tracker
<http://bugs.python.org/issue22118>
___
___
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22197>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Demian Brecht:
This is a proposal for adding SQLite support to http.cookiejar. I've been
working on an implementation for MozillaSQLiteCookieJar and
GoogleSQLiteCookieJar (initial patch will likely only include Mozilla) but
wanted to make sure that the addition has b
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22234>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22233>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Demian Brecht :
--
nosy: +demian.brecht
___
Python tracker
<http://bugs.python.org/issue22231>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Demian Brecht:
Reported by Stefan Behnel in issue22118:
I'm now getting duplicated slashes in URLs, e.g.:
https://new//foo.html
http://my.little.server/url//logo.gif
In both cases, the base URL that gets joined with the postfix had a trailing
slash, e.g.
Changes by Demian Brecht :
--
keywords: +patch
Added file: http://bugs.python.org/file36479/issue22278.patch
___
Python tracker
<http://bugs.python.org/issue22
Demian Brecht added the comment:
I'll try to get some time this week to extend the various test cases, thanks
for pointing that out Antoine.
I also found that, other than the few RFC-specific blocks in the link that Nick
added in the other ticket, not only were they questionable (non-HT
Demian Brecht added the comment:
Antoine: On (finally) getting back to this and re-reading your test case, the
current behaviour is incorrect and is corrected by the patch. I've added a few
more test cases to ensure trailing slashes are handled correctly.
--
Added file:
Demian Brecht added the comment:
Heh, I'd finally gotten a few minutes to address the comments... And it's
already taken care of ;) Thanks Senthil.
--
___
Python tracker
<http://bugs.python.o
Demian Brecht added the comment:
I've given this some more thought and quite a bit more work and reorganization.
I think this clarifies the usage of memoryviews and buffers as well as the
C-level API for each.
This is my first run at contributing a patch of any sort, so please let me kno
Demian Brecht added the comment:
Has there been any further work/review done on this issue? I just ran into the
problem myself on 3.4(dev) and can verify that the patch
(imaplib_authenticate_v.patch) fixes the issue.
--
nosy: +dbrecht
versions: +Python 3.4
Demian Brecht added the comment:
Yes, I agree that passage is a little garbled. I've reworked that particular
paragraph in the new patch.
I had included a little information about 2.6 as it was in the revision prior
to my patch (and there was also some historical context back to 1.6). I
New submission from Demian Brecht:
When assigning a value to an already instantiated Request object's full_url,
unexpected results are found as a consequence in the attributes selector, type
and fragment. Selector, type and fragment are only assigned to during
instantiation. Unless you
Demian Brecht added the comment:
I also meant to mention that of course, the obvious workaround would simply be
to instantiate a new Request object with the new URL, but in my mind, this is
something that should likely be supported by the Request object itself
Demian Brecht added the comment:
It could entirely be my lack of being Dutch that didn't make this obvious
without reading the docs ;)
I guess there's one of three ways that this could go:
To help clarify the intention through code, either
a) Change full_url to _full_url, indic
Demian Brecht added the comment:
Yes, I realized that I had forgotten to add the "do nothing" option after
posting but figured it was relatively obvious :)
"Python doesn't normally make things read-only just because mutating them does
nothing useful. Sometimes we make t
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue16942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
I've changed FileCookieJar to use the ABCMeta metaclass and updated the
concrete implementations. If this patch looks sufficient, I'll make an update
to the docs as well.
--
keywords: +patch
Added file: http://bugs.python.org/file29215/cooki
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue12455>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
According to some digging around that I've done, this issue may be invalid:
(I couldn't find an RFC or detailed spec of the LWP format, so reading from
libwww-perl source @
http://cpansearch.perl.org/src/GAAS/libwww-perl-5.836/lib/HTTP/Cookies.pm)
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue16901>
___
___
Python-bugs-list mailing list
Unsubscribe:
Demian Brecht added the comment:
http://bugs.python.org/issue1690 seems to be a duplicate of this one (at least
the initial report). 16901 (imho) is documented more clearly than this one, so
can this one be closed as duplicate?
--
___
Python
Changes by Demian Brecht :
--
nosy: +dbrecht
___
Python tracker
<http://bugs.python.org/issue12144>
___
___
Python-bugs-list mailing list
Unsubscribe:
1 - 100 of 434 matches
Mail list logo
