Daniel Stutzbach added the comment:
Gladly. :-)
--
resolution: -> out of date
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue13742>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
stage: -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue8777>
___
___
Python-bugs-list mailing list
Un
Daniel Stutzbach added the comment:
> Comment: This rule applies to special methods like __getitem__
> and __setitem__. 'lis.append(item)' is equivalent to
> lis.__setitem__(len(lis):len(lis), item), so it should not be so
> surprising that it has the same return.
It'
Daniel Stutzbach added the comment:
On Wed, Jun 15, 2011 at 8:10 PM, Nick Coghlan wrote:
> I'd like to add a new constant to the math module:
>
> tau = 2*math.pi
>
> Rather than repeating all the reasons for why tau makes more sense than pi
> as the fundamental cir
Daniel Stutzbach added the comment:
On Sat, Jul 16, 2011 at 2:04 AM, Eli Bendersky wrote:
> Therefore, I propose to change this error message to:
> "unicode argument expected, got '%s'"
> as Terry suggested.
>
Sounds good to me.
--
Added file:
Daniel Stutzbach added the comment:
Could you add a comment above the lines defining self._BytesIO, describing why
they're being set? Someone else might see them as unnecessary and rip them out
if there's no explanation.
Can a test launch Python in a subprocess, set up the approp
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue12612>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue12682>
___
___
Python-bugs-list mailing list
Unsubscribe:
Daniel Stutzbach added the comment:
Benjamin,
Thanks for the feedback. Since you only commented on the test case, may I
assume that the fix itself looked good to you?
I will work on revising the test case based on your comments. Since I ran into
the bug while working with the ABCs in the
Changes by Daniel Stutzbach :
--
components: +Library (Lib) -Interpreter Core
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue2521>
___
___
Daniel Stutzbach added the comment:
Attached is a new test case, based on Benjamin's comments.
--
Added file: http://bugs.python.org/file18567/leak_test2.patch
___
Python tracker
<http://bugs.python.org/i
Daniel Stutzbach added the comment:
Attached is a patch implementing the change agreed upon in the earlier
discussion. This will allow wchar_t <-> Py_UNICODE conversions to use memcpy
on systems where wchar_t and Py_UNICODE have the same size but different signs
(e.g.,
Daniel Stutzbach added the comment:
Thanks. I dug into that a little just now, and it turns out to happen
automatically.
If ./configure doesn't define HAVE_WCHAR_H then it also will not define
SIZEOF_WCHAR_T. If SIZEOF_WCHAR_T is not defined, the preprocessor will treat
it as 0 causi
Daniel Stutzbach added the comment:
I suspect that it's not possible.
I'm uploading patches that fix the .close method to avoid referencing globals
that might be None during interpreter shutdown. Since the .close method has
changed significantly in py3k, I'm uploading separ
Changes by Daniel Stutzbach :
--
keywords: +needs review, patch
stage: unit test needed -> patch review
Added file: http://bugs.python.org/file18570/issue808164-27.patch
___
Python tracker
<http://bugs.python.org/issue
Daniel Stutzbach added the comment:
Here is the py3k version of the patch
--
___
Python tracker
<http://bugs.python.org/issue808164>
___
___
Python-bugs-list m
Changes by Daniel Stutzbach :
Added file: http://bugs.python.org/file18571/issue808164-py3k.patch
___
Python tracker
<http://bugs.python.org/issue808164>
___
___
Pytho
Daniel Stutzbach added the comment:
3.1 is long gone. Should this be addressed for 3.2?
--
___
Python tracker
<http://bugs.python.org/issue2226>
___
___
Pytho
Daniel Stutzbach added the comment:
How do we mark a test as implementation specific? Is there a decorator for
that?
--
___
Python tracker
<http://bugs.python.org/issue9
Daniel Stutzbach added the comment:
Thank you for the patch.
We should only iterate over the shorter set if the longer set is really a set
and not just a sequence. PySequence_Contains may take O(n) time on a list,
making the algorithm an expensive O(n**2) overall. I note that
Daniel Stutzbach added the comment:
The patch looks good to me, too. The new tests fail without the fix, and pass
with the fix.
--
assignee: stutzbach -> rhettinger
stage: unit test needed -> patch review
___
Python tracker
Daniel Stutzbach added the comment:
Nevermind, I found it: @support.cpython_only
I'll work on a patch to add the decorator and a comment about why the test is
fragile.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Daniel Stutzbach :
--
keywords: +needs review, patch
resolution: -> accepted
stage: needs patch -> patch review
Added file: http://bugs.python.org/file18591/issue9131.patch
___
Python tracker
<http://bugs.python.org/
Changes by Daniel Stutzbach :
Removed file: http://bugs.python.org/file18591/issue9131.patch
___
Python tracker
<http://bugs.python.org/issue9131>
___
___
Python-bug
Daniel Stutzbach added the comment:
errr... ignore that first patch (now deleted)
:-)
--
Added file: http://bugs.python.org/file18592/issue9131.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Daniel Stutzbach :
Removed file: http://bugs.python.org/file18592/issue9131.patch
___
Python tracker
<http://bugs.python.org/issue9131>
___
___
Python-bug
Changes by Daniel Stutzbach :
Added file: http://bugs.python.org/file18593/issue9131.patch
___
Python tracker
<http://bugs.python.org/issue9131>
___
___
Python-bugs-list m
Daniel Stutzbach added the comment:
Thanks! :-)
--
___
Python tracker
<http://bugs.python.org/issue2521>
___
___
Python-bugs-list mailing list
Unsubscribe:
Daniel Stutzbach added the comment:
I can reproduce it in Python 3.1 and 3.2 I don't have a build of Python 2.7
handy at the moment to test it there.
In Python 3.2 and 2.7, DeprecationWarnings are silenced by default. I had to
start Python 3.2 with "-W always::DeprecationWarni
Daniel Stutzbach added the comment:
Should release27-maint/Modules/_io/_iomodule.c:172 be:
PyAPI_DATA(PyObject *) PyExc_BlockingIOError = (PyObject
*)&_PyExc_BlockingIOError;
?
--
___
Python tracker
<http://bugs.python.org/is
Daniel Stutzbach added the comment:
> Why should it be?
The error indicates that the definition in the .c file doesn't match the
declaration in the .h file, with respect to the funky Windows-specific stuff
('dllimport') that PyAPI_DATA adds.
Roumen's patch suggests
Daniel Stutzbach added the comment:
> Why would this not be required for the standard exceptions then?
It looks like PyAPI_DATA can be defined differently depending on whether we're
building code as a built-in or as a loadable module. If _iomodule.c is really
being built as a modu
Daniel Stutzbach added the comment:
Committed as r84301, r84302, and r84305.
--
keywords: -needs review
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/
Daniel Stutzbach added the comment:
Commited in r84307.
--
keywords: -needs review
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Daniel Stutzbach added the comment:
Thanks, I will take a look sometime today.
--
___
Python tracker
<http://bugs.python.org/issue8781>
___
___
Python-bugs-list m
Daniel Stutzbach added the comment:
The underlying problem here is that SIZEOF_WCHAR_T is not defined in pyconfig.h
on Windows. My patch assumed that it would be defined on all platforms where
HAVE_WCHAR_H is defined (I had checked ./configure, but forgotten Windows).
This has come up
Daniel Stutzbach added the comment:
Adding other Windows developers to the nosy list. See msg114893 where your
input would be helpful.
--
nosy: +brian.curtin, tim.golden
___
Python tracker
<http://bugs.python.org/issue8
Daniel Stutzbach added the comment:
On Windows, the Python headers define HAVE_USABLE_WCHAR_T and Py_UNICODE_SIZE
2, so we are already relying on sizeof(wchar_t) == 2 on Windows.
My patch ran into trouble because it inadvertently disabled that assumption in
a few places, causing code to take
New submission from Daniel Stutzbach :
Presently, the pyconfig.h generated by configure defines SIZEOF_WCHAR_T, but
PC/pyconfig.h does not, periodically causing problems:
http://bugs.python.org/issue8781
http://bugs.python.org/issue4474
http://trac.wxwidgets.org/ticket/12013
Problem and the
Changes by Daniel Stutzbach :
--
dependencies: +PC/pyconfig.h should define SIZEOF_WCHAR_T
___
Python tracker
<http://bugs.python.org/issue8781>
___
___
Python-bug
Daniel Stutzbach added the comment:
After making a Windows build and running the tests, committed in r84317.
--
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Daniel Stutzbach added the comment:
I opened a separate issue for the SIZEOF_WCHAR_T issue so I could refer to that
issue number in Misc/NEWS. Fixed in r84317.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Daniel Stutzbach added the comment:
Committed in r84379
--
keywords: -needs review
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Daniel Stutzbach added the comment:
Fixed in r84380 and r84382.
--
keywords: -needs review
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org
Daniel Stutzbach added the comment:
I don't think I'm familiar enough with 2to3's pattern-matching syntax to write
a good patch.
Here's a rough outline for how a patch would work. There are two cases:
1) When there is already a "from __future__ import". Cur
New submission from Daniel Stutzbach :
In Doc/extending/windows.rst, there's the following text:
If your module creates a new type, you may have trouble with this line::
PyVarObject_HEAD_INIT(&PyType_Type, 0
Daniel Stutzbach added the comment:
The example can be fixed by placing a "b" before the two string literals.
However, pretty much the whole document refers to "strings" and should refer to
"byte sequences" or the "bytes" type.
I thought there
Daniel Stutzbach added the comment:
As most of the code in this patch was copied from EnumValue and EnumKey, it
includes bugs from those functions that have since been fixed. I'm thinking of
Issue #2810, although there might have been other changes.
Instead of duplicating code, it wou
Daniel Stutzbach added the comment:
Raymond, do you agree with Ray's analysis?
--
___
Python tracker
<http://bugs.python.org/issue8743>
___
___
Python-bugs-l
New submission from Daniel Stutzbach :
In Issue 9212, I mused:
> I sort of wonder if .register() should verify that the concrete class
> provides all of the methods of the ABC.
Éric Araujo suggested I open that as an issue for consideration.
I have found a few bugs in the standard l
Daniel Stutzbach added the comment:
Would it be useful to provide a separate function to perform the check, which
could be used by lint-style tools as well as automated tests?
It would be great if every call to .register in the standard library had a
corresponding test that verified that the
Daniel Stutzbach added the comment:
Re-opening and re-titling the issue to that effect.
Proposed syntax and usage:
# in Lib/abc.py
class ABCMeta(type):
# ...
def has_methods(cls, subclass):
"Returns True iff subclass implements the appropriate methods"
#
Daniel Stutzbach added the comment:
I will aim to spend some time with this (and the similar Issue #9213) today
and/or tomorrow, so that it can be committed in time for 3.2a2.
--
resolution: -> accepted
stage: unit test needed -> patch
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue8685>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue8425>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue2459>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue9155>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue1569291>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue2690>
___
___
Python-bugs-list mailing list
Unsubscribe:
Daniel Stutzbach added the comment:
Since this issue doesn't apply in Python 3 and (as I understand it) the 2.7
branch is only open to bug fixes, can we close this performance issue?
--
nosy: +stutzbach
___
Python tracker
<http://bugs.py
Daniel Stutzbach added the comment:
Excluding the future fixer would only get me half of the way there. I would
still need to add "from __future__ import print_statement" to all of my scripts
if I want them to continue to work under 2.6.
(Well, for me personally, I have already do
Daniel Stutzbach added the comment:
Well, I grant you that it's a bit of scope-creep, and if you want to reject it
on those grounds I can't blame you.
To me it seems like a relatively small change that would greatly help people
like myself who want to update older code so that i
Daniel Stutzbach added the comment:
> The operator methods in setobject.c should be liberalized to accept
> instances of collections.Set as arguments.
Under this plan, set() and collections.Set will still have slightly different
behavior. collections.Set will be more liberal and acce
Daniel Stutzbach added the comment:
Committed to py3k in r84435. Raymond, do you want to look the commit over
before I merge it into 3.1 and 2.7?
--
___
Python tracker
<http://bugs.python.org/issue9
Daniel Stutzbach added the comment:
Meant to add:
I made some relatively minor changes to Daniel Urban's patch. Mostly, I
rearranged the order of a few things to avoid unnecessary work (e.g., only
compute "len_other" if we've already checked that "other" is a s
Daniel Stutzbach added the comment:
Also, credited Daniel Urban for the patch in r84436 (forgot that the first time
around -- sorry!).
--
___
Python tracker
<http://bugs.python.org/issue9
Daniel Stutzbach added the comment:
Thank you for the patch.
The patch doesn't handle the case where the object being searched for is
!PyLong_CheckExact. For example, the user might pass in a sub-type of int.
The existing range_contains supports that case, so it seems like we s
New submission from Daniel Stutzbach :
In the list of operations supported by all sequence types, the .index and
.count methods should be included. They are defined by the
collections.Sequence ABC that all sequences support.
(except for range objects, but that will be fixed in Issue9213
New submission from Daniel Stutzbach :
7>..\Python\import.c(1158) : warning C4013: 'mkdir' undefined; assuming extern
returning int
--
assignee: stutzbach
components: Interpreter Core, Windows
keywords: easy
messages: 115428
nosy: stutzbach
priority: low
severity: normal
New submission from Daniel Stutzbach :
The errors below show up on my XP machine in Python 3.1 as well as a recent
build from the py3k branch. I'm not sure why they *don't* show up on the XP
buildbot.
fromfd() ultimately calls dup(), so the underlying problem is likely the same
f
Daniel Stutzbach added the comment:
I just noticed that the previous "new" patch I uploaded was actually my
original patch. Oops. Anyway...
In a discussion on the capi list, a few people objected to compiling in
Unicode-agnostic mode by default (e.g., it would be annoying
Daniel Stutzbach added the comment:
I run it the same way.
I wonder what's different? :-( I will try to find some time to investigate
further.
--
___
Python tracker
<http://bugs.python.org/i
Daniel Stutzbach added the comment:
On Windows, socket.dup is implemented using DuplicateHandle. The documentation
for DuplicateHandle reads:
You should not use DuplicateHandle to duplicate handles to the following
objects:
* I/O completion ports. No error is returned, but the
Daniel Stutzbach added the comment:
Following the advice of DuplicateHandle's documentation, I reimplemented dup on
Windows using WSADuplicateHandle. Attached is a patch. With the patch, the
tests pass on my Windows machine.
Would someone like to review the patch?
--
ass
Changes by Daniel Stutzbach :
Added file: http://bugs.python.org/file18724/issue9753.patch
___
Python tracker
<http://bugs.python.org/issue9753>
___
___
Python-bugs-list m
Daniel Stutzbach added the comment:
Thanks! Updated as you suggested and committed as r84450 and r84451.
--
keywords: -needs review
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.p
Daniel Stutzbach added the comment:
Thanks, Antoine. Those are all good suggestions. Attached is an updated patch.
Marc-Andre, Martin: would you like to look this over as well?
--
Added file: http://bugs.python.org/file18730/unicode-3.patch
Daniel Stutzbach added the comment:
I agree that my original name proposal is terrible. :-) method_check and
verify_full_api both look fine to me.
> If all collection registrations were bundled together in
> collections.py, I think I would expect the tests to be in
> test_collect
New submission from Daniel Stutzbach :
external.bat and external-common.bat take care of downloading most external
packages such as tcl, tk, and openssl. However, the tix package is missing,
but needed to build the msi.
--
components: Build, Windows
messages: 115503
nosy: loewis
New submission from Daniel Stutzbach :
Tools/buildbot/external-common.bat creates tcl-8.5.2.1, but Tools/msi/msi.py
looks for tcl8*. Consequently, Tools/buildbot/buildmsi.py does not work on a
fresh machine.
tk has the same problem.
I encountered this on the py3k branch but have not checked
Daniel Stutzbach added the comment:
Attached is a slightly improved patch. It cleans up some whitespace issues
with James's patch and filters out *_d.pdb files if they exist. I tested it on
my system and it correctly produces a .zip file containing the .pdb files, next
to the .msi
Daniel Stutzbach added the comment:
Ned, thanks for bringing that to my attention. I might have missed it
otherwise.
I had run "autoconf" but had not known to run "autoreconf", so I had missed the
failure there. *embarrassed*
Benjamin, thanks for fixing my err
Daniel Stutzbach added the comment:
As far as I can tell, _mkdir(name) is equivalent to CreateDirectoryA(name,
NULL), except one uses errno and the other uses GetLastErrno. It is definitely
possible that there's something I don't know, though, and the documentation
doesn't e
Changes by Daniel Stutzbach :
--
nosy: +stutzbach
___
Python tracker
<http://bugs.python.org/issue9609>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Daniel Stutzbach :
--
nosy: +georg.brandl
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue9609>
___
___
Python-bugs-list mai
Daniel Stutzbach added the comment:
Committed as r84659. Thanks for the patch!
--
stage: patch review -> committed/rejected
status: open -> closed
type: -> compile error
___
Python tracker
<http://bugs.python.o
Daniel Stutzbach added the comment:
Thanks, Georg, for prodding. As a new committer, I have possibly been erring a
little too far on the side of having my patches thoroughly reviewed before
committing.
I'll commit the patch on Monday if no one raises objections (after re-testing,
of c
Daniel Stutzbach added the comment:
Committed as r84791.
Question: should this bugfix be backported to Python 3.1 and to xrange objects
in Python 2.7? Since it's a bugfix that adds new methods, it's a gray-area.
(same question applies to the closely related I
Daniel Stutzbach added the comment:
Where does/did the FAQ live in the version control tree?
--
___
Python tracker
<http://bugs.python.org/issue9728>
___
___
Daniel Stutzbach added the comment:
It looks like the FAQ used be generated using Tools/faqwiz/faqwiz.py (which no
longer exists). According to that file:
---
This is a CGI program that maintains a user-editable FAQ. It
Daniel Stutzbach added the comment:
Nevermind... archive.org has it. :-)
--
___
Python tracker
<http://bugs.python.org/issue9728>
___
___
Python-bugs-list mailin
Daniel Stutzbach added the comment:
Fixed in r84810, r84811, and 84812.
For anyone curious, the old FAQ entry is here:
http://web.archive.org/web/20010203161100/http://www.python.org/doc/FAQ.html#3.24
--
resolution: -> accepted
stage: needs patch -> committed/rejected
status
Daniel Stutzbach added the comment:
Sounds reasonable to me. I'll close this and the related 9212 (both fixes are
already committed to the py3k branch).
--
stage: patch review -> committed/rejected
status: open -> closed
___
Python tra
Changes by Daniel Stutzbach :
--
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/
Daniel Stutzbach added the comment:
Attached is a script to find all of the mismatches between the C and Python
implementations. There are several. Below is the output:
RawIOBase C is missing: ['readinto', 'write']
StringIO C is missing: ['name']
StringIO pyt
New submission from Daniel Stutzbach :
Recently it came to light that the classes in C and Python implementations of
the io module have slightly different attributes (issue9858). I propose the
addition of a helper function in Lib/test/support.py to verify that the classes
in two different
Daniel Stutzbach added the comment:
FWIW, I just opened Issue9859: Add tests to verify API match of modules with 2
implementations.
--
___
Python tracker
<http://bugs.python.org/issue9
Daniel Stutzbach added the comment:
Yes, exactly. :-)
(see also Issue9731, which has a similar flavor)
--
___
Python tracker
<http://bugs.python.org/issue9
Daniel Stutzbach added the comment:
> These attributes exist; they're just not properties.
Yes, I see. They're added to the instance in the constructor, so they don't
exist as attributes of the class. Also in that category:
BlockingIOError python is missing: ['cha
1 - 100 of 469 matches
Mail list logo
