Collin Winter added the comment:
I don't see the changes to the lnotab format being a roadblock; just
mention it in NEWS. Likewise, the pure-Python compiler package shouldn't
be a high priority; your changes to that package look good enough.
I'm seeing encouraging speed-ups ou
Collin Winter added the comment:
On Fri, Feb 13, 2009 at 10:37 AM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> Hello Collin,
>
> Thanks for taking a look.
>
>> I don't see the changes to the lnotab format being a roadblock; just
>>
Collin Winter added the comment:
Updated the patch to use only PyString_CheckExact(); added a test for
the behaviour of string subclasses wrt the % operator.
There's a very slight performance hit when using % with numbers, but
it's so small as to be statistically insignificant. If it
Changes by Collin Winter :
Removed file: http://bugs.python.org/file12962/faster_modulo.patch
___
Python tracker
<http://bugs.python.org/issue5176>
___
___
Python-bug
Changes by Collin Winter :
--
nosy: -collinwinter
___
Python tracker
<http://bugs.python.org/issue15079>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
components: +Interpreter Core
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue6643>
___
___
Python-bug
Collin Winter added the comment:
FYI, Unladen Swallow includes several regex benchmark suites: a port of
V8's regex benchmarks (regex_v8); some of the regexes used when tuning
the existing sre engine 7-8 years ago (regex_effbot); and a
regex_compile benchmark that tests regex compil
Collin Winter added the comment:
I ran this patch against Unladen Swallow's slowspitfire template
benchmark, which does more int->string conversions than any of our other
benchmarks. When run against Python trunk r74737, I get these results:
slowspitfire:
Min: 0.888772 -> 0.8
Collin Winter added the comment:
Committed as r69811.
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Collin Winter added the comment:
On Fri, Feb 13, 2009 at 3:23 PM, Collin Winter wrote:
> On Fri, Feb 13, 2009 at 10:37 AM, Antoine Pitrou
> wrote:
>> Before committing I want to know what to do with the new jump opcodes,
>> with respect to the alternative proposal
New submission from Collin Winter :
The attached patch adds a --with-py3k-warnings option to configure.
Passing --without-py3k-warnings disables all Py3k compatibility warnings
(the default is to keep the warnings). For production deployments where
performance is more important than warnings no
New submission from Collin Winter :
(Tarek, I've been told you're the new distutils maintainer. Feel free to
unassign this if that isn't the case.)
The test distutils uses to decide whether it needs to recompile an
existing .o file when building extension modules is too sim
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue2636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
Jeffrey: updated the patch to address your concerns.
Martin: I'm not sure I completely understand it either, though it seems
similar to issue4477. In the course of developing this patch, I tried
also #ifdef'ing out all usages of the Py_Py3kWarningF
Changes by Collin Winter :
Removed file: http://bugs.python.org/file13168/no_py3k_warning.patch
___
Python tracker
<http://bugs.python.org/issue5362>
___
___
Python-bug
Collin Winter added the comment:
Bah, forgot to run autoreconf. Fixed.
Added file: http://bugs.python.org/file13184/no_py3k_warning.patch
___
Python tracker
<http://bugs.python.org/issue5
Changes by Collin Winter :
Removed file: http://bugs.python.org/file13183/no_py3k_warning.patch
___
Python tracker
<http://bugs.python.org/issue5362>
___
___
Python-bug
New submission from Collin Winter :
If you pass LIBS to ./configure (as in "LIBS=-lgcov ./configure"),
distutils ignores this when building extension modules, which breaks
when using certain gcc options which require certain libraries (I'm
thinking of -fprofile-generate). The
Collin Winter added the comment:
The patch attached to issue 5060 seems very tightly focused on a problem
with gcc FDO. This is a more general patch that solves the problem of
distutils ignoring LIBS.
--
___
Python tracker
<http://bugs.python.
New submission from Collin Winter :
This patch adds SSL_ROOT, SQLITE_INC and SQLITE_LIB environment
variables used to inject additional libraries/headers for building the
sqlite, hashlib and ssl modules. We've found this very useful for
building these modules against their depende
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue5557>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Collin Winter :
Add the ability to control the random seed used by regrtest.py -r. This
patch adds a --randseed option, and makes regrtest.py -r indicate what
random seed it's using so that that value can later be fed back to
--randseed. This option is useful for tra
Changes by Collin Winter :
Removed file: http://bugs.python.org/file13446/randseed.patch
___
Python tracker
<http://bugs.python.org/issue5588>
___
___
Python-bugs-list m
Collin Winter added the comment:
The "if rand_seed:" bit was a relic from a previous iteration; fixed.
The only reason I didn't use randrange() is that I didn't see it; fixed.
--
Added file: http://bugs.python.org/file13448/randseed.patch
__
Collin Winter added the comment:
Committed as r70672 (trunk) and r70673 (py3k). Thanks for the quick review.
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Collin Winter added the comment:
Do you know of anyone actively working on Windows support? If not, I say
close it as "won't fix".
--
___
Python tracker
<http://bugs.pytho
New submission from Collin Winter :
The attached patch adds more tests for pickling:
- Add tests for the module-level load() and dump() functions.
- Add tests for cPickle's internal data structures, stressing workloads
with many gets/puts.
- Add tests for the Pickler and Unpickler classe
New submission from Collin Winter :
The attached patch adds another version of cPickle.c's batch_dict(),
batch_dict_exact(), which is specialized for "type(x) is dict". This
provides a nice performance boost when pickling objects that use
dictionaries:
Pickle:
Min: 2.216 -> 1.
New submission from Collin Winter :
The attached patch adds another version of cPickle.c's batch_list(),
batch_list_exact(), which is specialized for "type(x) is list". This
provides a nice performance boost when pickling objects that use
lists. This is similar to the approach
Collin Winter added the comment:
On Thu, Apr 2, 2009 at 12:20 PM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> By the way, could the same approach be applied to lists and sets as well?
Certainly; see http://bugs.python.org/issue5671 for the list version.
It doe
Collin Winter added the comment:
No, we haven't started looking at other serialization formats yet.
Marshal will probably be my next target, with json being a lower
priority. There were enough instances of low-hanging fruit in cPickle
that I didn't go looking at the other implement
Collin Winter added the comment:
Antoine: pickletester.py:test_newobj_generic() appears to test dict
subclasses, though in a roundabout-ish way. I don't know of any tests
for dict subclasses in the C level sense (ie, PyDict_Check() vs
PyDict_CheckExact()). I can add more explicit test
Collin Winter added the comment:
I've added a microbenchmark to perf.py called pickle_list. Running that
on this change (perf.py -r -b pickle_list):
pickle_list:
Min: 1.126 -> 0.888: 26.86% faster
Avg: 1.154 -> 0.906: 27.43% faster
Significant (t=115.404547, a=0.95)
That's pr
Collin Winter added the comment:
I've made test_xpickle support Python 2.4 because it uses Python 2.4,
2.5 and 2.6 to check that we haven't broken backwards compatibility with
those versions.
I made AbstractCompatTests use cPickle because that's what I've been
changing :)
Collin Winter added the comment:
test_xpickle currently takes over three minutes on my MacBook Pro to
test compatibility with Python 2.4, 2.5 and 2.6, and adding tests for
the pickle module will at least double that, if not push it well above
10 minutes. That's why I recommend usin
Collin Winter added the comment:
Updated the patch to include a regrtest xpickle resource, which
restricts if the backwards compat tests will be run. For normal
development, the existing tests should be fine; you only need these
tests if you're mucking with the pickle output.
Added back
Changes by Collin Winter :
Removed file: http://bugs.python.org/file13571/pickle_tests.patch
___
Python tracker
<http://bugs.python.org/issue5665>
___
___
Python-bug
Collin Winter added the comment:
FYI, I just added a pickle_dict microbenchmark to perf.py. Using this
new microbenchmark, I see these results (perf.py -r -b pickle_dict):
pickle_dict:
Min: 2.092 -> 1.341: 56.04% faster
Avg: 2.126 -> 1.360: 56.37% faster
Significant (t=216.895643, a=0.
Collin Winter added the comment:
Amaury, I can't reproduce the issue you're seeing with empty dicts.
Here's what I'm doing:
dhcp-172-19-19-199:trunk collinwinter$ ./python.exe
Python 2.7a0 (trunk:71100M, Apr 3 2009, 14:40:49)
[GCC 4.0.1 (Apple Inc. build 5490)]
Changes by Collin Winter :
--
components: Extension Modules
files: cpickle_writes.patch
keywords: needs review, patch
nosy: alexandre.vassalotti, collinwinter
severity: normal
status: open
title: Add a simple pickle optimizer to cPickle
type: performance
versions: Python 2.7, Python 3.1
New submission from Collin Winter :
Bah, hit enter too soon.
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/
New submission from Collin Winter :
This patch simplifies cPickle's complicated internal buffering system.
The new version uses a single buffer closer to the Pickler object,
flushing to a file object only when necessary. This avoids the overhead
of several indirection layers for wha
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue5634>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue3675>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue2389>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue3873>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
If no-one has any objections to the xpickle resource included in the
latest version of the patch, I'd like to commit this soon so that we can
be more confident in the other changes I have queued up. If I no-one
objects, I'll commit this sometime earl
Collin Winter added the comment:
> Ok if it doesn't take too long to run the tests (which may imply
> implementing something like Raymond's suggestion of randomizing test
> order, if you haven't already done so).
I did something similar: if you don't pass the -uxpi
Collin Winter added the comment:
Yes, I'm porting them. I got started, but got distracted by other things
since there were a lot of conflicts in the merge
--
___
Python tracker
<http://bugs.python.org/i
Collin Winter added the comment:
Committed as r71408 (trunk) and r71638 (py3k).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue5794>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
Interestingly, it only fails with protocol 0:
>>> v = ([],)
>>> v[0].append(v)
>>> import pickle,cPickle
>>> cPickle.loads(pickle.dumps(v, 0))
Traceback (most recent call last):
File "", line 1, in
cPick
Collin Winter added the comment:
2009/5/4 <"Tarek Ziadé "@psf.upfronthosting.co.za>:
> About the patch:
>
> is there a particular reason why you have changed the call to
> 'set_library' into calls to 'add_library' in build_ext in your patch ?
New submission from Collin Winter :
Currently (r72643), regrtest.py -R:: says that a test passed even if it
leaked references:
trunk collinwinter$ ./python.exe Lib/test/regrtest.py -R::
test_urllib2_localnet
test_urllib2_localnet
beginning 9 repetitions
123456789
.
test_urllib2_localnet
Changes by Collin Winter :
Added file: http://bugs.python.org/file13986/refleak.patch
___
Python tracker
<http://bugs.python.org/issue6024>
___
___
Python-bugs-list mailin
Changes by Collin Winter :
Removed file: http://bugs.python.org/file13985/refleak.patch
___
Python tracker
<http://bugs.python.org/issue6024>
___
___
Python-bugs-list m
Collin Winter added the comment:
Applied in r72658 (trunk) and r72660 (py3k).
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
New submission from Collin Winter :
Currently (r72673), test_urllib2_localnet leaks references. This is due
to state implicitly shared between tests. The attached patch fixes this
by removing the shared state.
The problem is also present in py3k. I'll port the patch once I commit
to
Collin Winter added the comment:
Yes, this is a patch for issue 6002 (sorry, didn't find it). I haven't
seen any refleaks from issue 1208304, but I was only looking at this one
particular failure (since it was showing up in Unladen Swallow's
Collin Winter added the comment:
Daniel, which patch? freelists2.patch or unialloc4.patch? If these are
targeted py3k (judging by the "Versions" selector above), none of
Unladen Swallow's benchmarks work under 3k (we
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue6042>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
Daniel, did you have any comments on this patch? If not, I'll go ahead
and commit it and close both of these issues.
--
___
Python tracker
<http://bugs.python.org/i
Collin Winter added the comment:
I've posted a patch in issue 6032 (didn't see this one); I'd be
interested in any comments on the approach taken there.
--
nosy: +collinwinter
___
Python tracker
<http://bugs.py
Collin Winter added the comment:
Daniel Diniz reviewed in the other issue.
Fixed in r72777 (trunk), r72778 (py3k).
--
assignee: -> collinwinter
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Collin Winter added the comment:
Applied as r72777 (trunk), r72778 (py3k).
--
assignee: -> collinwinter
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
New submission from Collin Winter :
Lib/pickletools.py incorrectly thinks POP_MARK was part of protocol 0;
POP_MARK was only added with the introduction of protocol 1 in r7753.
This mistake led me down a dead end while fixing another pickling issue.
Alexandre, can you double-check me on this
Collin Winter added the comment:
Applied in r72792 (trunk), r72793 (py3k), r72808 (release26-maint).
--
assignee: -> collinwinter
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.o
Collin Winter added the comment:
Bug-fix patch attached. Alexandre, can you take a look? Feel free to
bounce it back if you don't have time.
I'll port to 2.6 and py3k once this is reviewed for trunk.
--
keywords: +26backport, easy, patch
nosy: +alexandre.vassalotti
stage:
Changes by Collin Winter :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue5866>
___
___
Python-bugs-list mailing list
Unsubscri
Collin Winter added the comment:
Fixed the len(d) == 1 size regression. Final performance of the patch
relative to trunk:
Using Unladen Swallow's perf.py -b pickle,pickle_dict on trunk:
pickle:
Min: 2.238 -> 1.895: 18.08% faster
Avg: 2.241 -> 1.898: 18.04% faster
Significant (t=28
Collin Winter added the comment:
Fixed in r72930 (trunk), r72931 (2.6), r72942 (py3k).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue6132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue6133>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
On Fri, May 29, 2009 at 3:45 PM, Martin v. Löwis wrote:
> py> s = ""
> py> s.join is s.join
> False
>
> Every time you read it, you get a new object. Not what I would call a
> constant. If you don't see how this matter
Collin Winter added the comment:
On Wed, Jun 3, 2009 at 2:36 AM, Marc-Andre Lemburg
wrote:
> Marc-Andre Lemburg added the comment:
>> All this is assuming the speed-up is important enough to bother. Has
>> anyone run a comparison benchmark using the Unladen Swallow benchmarks?
Collin Winter added the comment:
As another data point, Unladen Swallow had to take explicit steps to
deal with this dead code when compiling bytecode to machine code. Since
Python's compiler isn't smart enough to ignore code following a "return"
or "raise" in th
Collin Winter added the comment:
Standalone bytecode-modifying tools almost never check that they're
outputting correct bytecode. http://code.activestate.com/recipes/277940/
makes no attempt to check what version of Python it's running under;
running it under Unladen Swallow 2009Q1
New submission from Collin Winter :
The attached patch fixes a number of tests to work when -OO is given to
Python. The majority of these tests are docstring-related, either doctests
or making assertions about __doc__, with a handful of tests testing that
assert statements will trigger and
New submission from Collin Winter :
This patch makes regrtest.py echo back the contents of sys.flags at the
beginning of a test run. Unladen Swallow has found this useful for
verifying that the regrtest.py settings in the Makefile and in our
Buildbot configs are interacting as expected
Collin Winter added the comment:
I tried making this work early last year as part of Unladen Swallow, and even
though I got it working and it does speed up certain builtin calls, it didn't
move overall application performance at all. I believe this was due to cache
effects, b
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue1731717>
___
___
Python-bugs-list mailing list
Unsub
101 - 181 of 181 matches
Mail list logo
