Changes by Collin Winter:
--
versions: +Python 3.0 -Python 2.6
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1007>
__
___
Python-bugs-list mailing list
Collin Winter added the comment:
I'd like some tests demonstrating where the current implementation fails
and your patch helps, yes.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.or
Collin Winter added the comment:
orsenthil: that this will break external modules is completely
acceptable. Those modules won't work out-of-the-box with Python 3
anyway, and hopefully Paul's patch to 2to3 will alleviate some of the
burden.
--
nosy: +co
New submission from Collin Winter:
This does not implement __context__; it turned out to be much more
difficult than expected and will require some more thought. The new
raise syntax and the __traceback__ and __cause__ attributes are
implemented, however. This does not yet include a docs patch
Changes by Collin Winter:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1066>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Collin Winter:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1066>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Collin Winter:
--
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1066>
__
___
Python-bugs-list mailing list
Uns
Collin Winter added the comment:
Committed as r57783.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1066>
__
___
Python-bugs-list mailing list
Unsubs
Changes by Collin Winter:
--
components: +2to3 (2.x to 3.x conversion tool) -Demos and Tools
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1107>
__
___
Changes by Collin Winter:
--
assignee: -> collinwinter
components: +2to3 (2.x to 3.x conversion tool) -Demos and Tools
nosy: +collinwinter
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Changes by Collin Winter:
--
assignee: -> collinwinter
components: +2to3 (2.x to 3.x conversion tool) -Demos and Tools
nosy: +collinwinter
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Collin Winter added the comment:
I believe this was fixed in r57942; can you test to see if you still
have this problem?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Collin Winter:
--
components: +2to3 (2.x to 3.x conversion tool)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1005>
__
___
Python-bugs-list
Changes by Collin Winter:
--
components: +2to3 (2.x to 3.x conversion tool)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1002>
__
___
Python-bugs-list
Changes by Collin Winter:
--
components: +2to3 (2.x to 3.x conversion tool)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1000>
__
___
Python-bugs-list
Changes by Collin Winter:
--
nosy: +collinwinter
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1000>
__
___
Python-bugs-list mailing list
Unsubs
Changes by Collin Winter:
--
components: +2to3 (2.x to 3.x conversion tool) -None
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1619049>
_
___
Changes by Collin Winter:
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1001>
__
___
Python-bugs
Collin Winter added the comment:
Fixed in r58055, r58056.
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Collin Winter:
Per
http://mail.python.org/pipermail/python-3000/2007-September/010337.html,
2to3 should strip out __future__ imports. This should probably be added
to the existing import fixer.
--
assignee: collinwinter
components: 2to3 (2.x to 3.0 conversion tool
Collin Winter added the comment:
I assume I was added to this thread since I wrote the functional module, so
I'll give my take in that capacity. IMO Python doesn't need a more general
version of partial(); indeed, I question the need for partial() as it is today.
Querying Google C
Collin Winter added the comment:
This wasn't so much a feature request as a request for review. I had already
implemented the necessary changes and provided a patch.
We found this change necessary when working on Unladen Swallow.
--
___
P
Collin Winter added the comment:
I don't know that the variables are Python-specific. We used these variables to
build various Python modules statically against the versions of openssl and
sqlite maintained in Google's internal third-party repository.
--
assignee: co
Collin Winter added the comment:
I have provided justification in the original patch submission. Without this
patch, we were unable to cleanly apply gcc's feedback-directed optimization
system to Python. FDO yields significant performance improve
Collin Winter added the comment:
I have no interest in forward-porting the patch, closing accordingly. At least
there will be a record of this patch for anyone interested in getting a free
10% performance boost for their Python 2.x or 3.[012] systems.
--
assignee: tarek
Changes by Collin Winter :
--
nosy: -collinwinter
___
Python tracker
<http://bugs.python.org/issue2636>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: -collinwinter
___
Python tracker
<http://bugs.python.org/issue9285>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
Christian: yes, that sounds fine.
--
assignee: collinwinter ->
___
Python tracker
<http://bugs.python.org/issue1625576>
___
_
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
assignee: collinwinter ->
resolution: fixed ->
status: closed -> open
__
Tracker <[EMAIL PROTECTED]>
<http://b
Collin Winter <[EMAIL PROTECTED]> added the comment:
Fixed in r63321
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Collin Winter <[EMAIL PROTECTED]> added the comment:
It's doable, but there's no existing support similar to what fix_imports
provides.
I won't have time to work on this for the foreseeable future, but if
someone is interested in working on this, I'd add this challeng
Collin Winter <[EMAIL PROTECTED]> added the comment:
Benjamin, you did the recent merges, no? Can you please fix this breakage?
--
assignee: collinwinter -> benjamin.peterson
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.py
Collin Winter <[EMAIL PROTECTED]> added the comment:
I'm not wild about making this change for such a minimal improvement
(which I would guess falls within the margin of error), since it will
limit extensibility and testability. I think I'd be fine with it if the
benefit
Collin Winter <[EMAIL PROTECTED]> added the comment:
The change to pytree.py doesn't add much speed benefit over the
fix_imports.py change, and causes a test to fail.
The fix_imports.py change, on the other hand, takes the test suite run
time from 8m31s down to 1m45s -- this nee
Collin Winter <[EMAIL PROTECTED]> added the comment:
I don't know why this is assigned to me.
--
assignee: collinwinter ->
components: +None -2to3 (2.x to 3.0 conversion tool)
___
Python tracker <[EMAIL PROTECTED]>
<http://bu
Collin Winter <[EMAIL PROTECTED]> added the comment:
- You should add tests to test_fixers to ensure that this does what you
expect. This will make it much easier for others to modify this fixer
later. You can probably just reuse the tests Brett initially added.
- There's a
Collin Winter <[EMAIL PROTECTED]> added the comment:
So, revisiting this...
On the face of it, I'm not convinced that the isinstance(x, Leaf) ->
type(x) is Leaf changes are correct: certain fixers have in the past
utilized their own subclasses of Node, and I can foresee this being
Collin Winter <[EMAIL PROTECTED]> added the comment:
fix_imports.diff fails to apply cleanly against HEAD of fix_imports.py.
Also, fix_imports2 now inherits from fix_imports, so it needs to be
fixed as well.
+ yield """power< module_name=%r
+
Collin Winter <[EMAIL PROTECTED]> added the comment:
I think the proper way to address this is via the confidence levels that
Rodrigo Bernardo Pimentel is adding for his Summer of Code project. The
idea is that you'll be able to say "let me inspect any changes where the
fixe
Collin Winter <[EMAIL PROTECTED]> added the comment:
Yeah, benchmarking this change against the unmodified HEAD, the
iterative version runs the test suite much slower. Let's file this under
the "didn't work out" category. It was a good idea that you obviated
with th
Collin Winter <[EMAIL PROTECTED]> added the comment:
One option would be to use the faster recursive version, falling back to
the iterative version if you hit a "RuntimeError: maximum recursion
depth exceeded" error. This would keep the speed for most files, but
would allow 2to
Collin Winter <[EMAIL PROTECTED]> added the comment:
Why include a command-line flag? Would you know when to use it? In what
cases would you want to second-guess the app like that?
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Collin Winter <[EMAIL PROTECTED]> added the comment:
Committed as r65397. Nice work!
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Collin Winter <[EMAIL PROTECTED]> added the comment:
Nick, what do you think about that?
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3358>
___
Collin Winter <[EMAIL PROTECTED]> added the comment:
I'd prefer it if someone better-versed in ctypes/dl wrote this fixer (or
at the very least, someone with access to Windows to test the translation).
___
Python tracker <[EMAIL PRO
Collin Winter <[EMAIL PROTECTED]> added the comment:
Victor: that's a common problem in most fixers. The analysis needed to
statically determine whether a given identifier is a module or not is
expensive and heuristic.
One of our Summer of Code students has been working on adding a
Collin Winter <[EMAIL PROTECTED]> added the comment:
I believe the only issue I recall was that the patch didn't work
out-of-the-box for Python 2.6 (changed imports, PEP 8 compliance changes
in the multiprocess module). Has that been fixed?
I disagree with Benjamin: this is an i
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
nosy: -collinwinter
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue214033>
___
__
Collin Winter <[EMAIL PROTECTED]> added the comment:
"I don't think we should force people using it as a library to go
multiprocess."
I don't understand this. What downsides do you perceive in
multiprocessing support? Multiprocessing is a significant speed-up for
Collin Winter <[EMAIL PROTECTED]> added the comment:
You have yet to articulate a reason for that preference.
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Collin Winter <[EMAIL PROTECTED]> added the comment:
Fixed in r66775.
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs
Collin Winter <[EMAIL PROTECTED]> added the comment:
Applied as r66775. I used the example file from issue2532 as test data.
Thanks for the patch, Nick!
--
resolution: -> fixed
status: open -> closed
___
Python tracker <[EMAIL PR
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
assignee: collinwinter ->
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3260>
___
__
Collin Winter <[EMAIL PROTECTED]> added the comment:
Benjamin, what "complexity" did you encounter when trying to use lib2to3
in your own work? Unless there's a concrete use-case where the mere
existence of multiprocessing support (as opposed to actually enabling
that sup
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
nosy: +collinwinter
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1107887>
___
__
Collin Winter added the comment:
Antoine: yes, this optimization is already implemented in the Unladen JIT.
--
___
Python tracker
<http://bugs.python.org/issue1
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue8566>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter:
--
nosy: +collinwinter
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2179>
__
___
Python-bugs-list mailing list
Unsubs
Collin Winter <[EMAIL PROTECTED]> added the comment:
There's currently no central repository that I know of. We should have
an informational PEP on the subject; would you like to start one with
sort/sorted keys as the seed? I've got some notes I can contribute, and
I'd like
Collin Winter <[EMAIL PROTECTED]> added the comment:
A quick test indicates that the old way doesn't work anymore.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Collin Winter <[EMAIL PROTECTED]> added the comment:
Yes, and each new fixer makes it slower. The biggest problem is the
pattern matching system, which tends to take 99% of the running time.
I've talked to several people who are interested in optimizing 2to3 as a
GSoC project, t
Collin Winter <[EMAIL PROTECTED]> added the comment:
Keep in mind that not all fixers use PATTERN, for example fix_ne.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
assignee: collinwinter -> David Wolever
nosy: +David Wolever
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Collin Winter <[EMAIL PROTECTED]> added the comment:
Can you list the mapping you'd like to see? I've never used dl or
ctypes, so I'm not immediately sure how to port from one to the other.
__
Tracker <[EMAIL PROTECTED]>
<ht
Collin Winter <[EMAIL PROTECTED]> added the comment:
With the patch applied, all tests in test_fixers fail.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2431>
__
Collin Winter <[EMAIL PROTECTED]> added the comment:
The updated version of the patch passes the tests and yields a 19-20%
speed increase in the running time of test_all_fixers and the time taken
for 2to3 to translate itself. I've sent David some comments on the
patch, and once it&#
Collin Winter <[EMAIL PROTECTED]> added the comment:
Fixed in r61983.
--
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
components: +2to3 (2.x to 3.0 conversion tool)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2338>
__
Collin Winter <[EMAIL PROTECTED]> added the comment:
The problem with the "fix" in r61755 is that it doesn't distinguish
between stdlib and non-stdlib imports: "import os" becomes "from .
import os", which is clearly wrong.
___
Collin Winter <[EMAIL PROTECTED]> added the comment:
Looking at it, I was confused by a quirk introduced into test_fixers:
Test_import's check_both() helper method does the wrong thing in this case:
a = "import os"
self.check_both(a, a) # Fails, tries to translate &
Collin Winter <[EMAIL PROTECTED]> added the comment:
Yes, this is a known problem with the pattern matching system.
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
New submission from Collin Winter <[EMAIL PROTECTED]>:
2to3 should be able to translate the code snippet below successfully.
First guess: generalizing fix_dict's notion of special contexts would do
the trick.
import random
numbers = range(1, 50)
chosen = []
while len(chosen) <
Collin Winter <[EMAIL PROTECTED]> added the comment:
Fixed in r62232. Verified that the sample code below runs successfully
under Python 3.0a4+ (r62209) after being run through 2to3.
--
resolution: -> fixed
status: open -> closed
title: 2to3's fix_range needs f
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2454>
__
___
Python-b
Collin Winter <[EMAIL PROTECTED]> added the comment:
2to3 running under Python 2.5.1 handles this file just fine. 2to3
running under 3.0a4+ (r62404) fails as detailed below. However, that
file doesn't run correctly under Python itself:
[EMAIL PROTECTED]:~/src/python/py3k$ ./p
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
title: 2to3 throws a utf8 decode error on a iso-8859-1 string -> Py3k fails to
parse a file with an iso-8859-1 string
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Collin Winter <[EMAIL PROTECTED]> added the comment:
Reviewing...
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2412>
__
___
Python-bugs-list mailing list
Collin Winter <[EMAIL PROTECTED]> added the comment:
Agreed. There's code in fix_next to detect this kind of case. I'll see
what I can do about generalizing it to support fix_long.
__
Tracker <[EMAIL PROTECTED]>
<http://
Collin Winter <[EMAIL PROTECTED]> added the comment:
It *could* be implemented for all fixers, but since it's fairly
expensive, I'd rather limit it to cases where the problem is more likely
to occur (for example, unicode -> str doesn't
Collin Winter <[EMAIL PROTECTED]> added the comment:
Looks good to me. Antoine, do you have commit privileges?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Collin Winter <[EMAIL PROTECTED]> added the comment:
I believe you forgot to add fix_operator.py to this patch.
--
components: +Build, Demos and Tools, Distutils, Documentation, Documentation
tools (Sphinx), Extension Modules, IDLE, Installation, Interpreter Core,
Librar
Changes by Collin Winter <[EMAIL PROTECTED]>:
--
components: -Build, Demos and Tools, Distutils, Documentation, Documentation
tools (Sphinx), IDLE, Installation, Interpreter Core, Library (Lib), Macintosh,
Regular Expressions, Tests, Tkinter, Unicode, Windows, XML,
Collin Winter <[EMAIL PROTECTED]> added the comment:
My gut feeling is that the number of cases where both operands are
written as literals is exceedingly small when compared to the number of
cases where one or both is an identifier. Since 2to3 doesn't support
type inference, we
Collin Winter <[EMAIL PROTECTED]> added the comment:
I say do it before the GSoC projects complete. Those projects will take
months, and we can't stop development for that long.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue4074>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue4688>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue2262>
___
___
Python-bugs-list mailing list
Unsubscribe:
Collin Winter added the comment:
Looking at gctrigger5.patch, my only thought is that it would be
helpful for posterity to include more verbose comments about why this
new behaviour was chosen; chunks of Martin's proposal from the
referenced python-dev thread could be included ver
Collin Winter added the comment:
LGTM. Go ahead and commit this.
___
Python tracker
<http://bugs.python.org/issue4074>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue1479611>
___
___
Python-bugs-list mailing list
Unsub
Collin Winter added the comment:
I've backported condbranches-plus.patch to trunk, and I'm getting these
results:
PyBench: 1.84-2.21% faster
2to3: 3.83% faster
Spitfire: 6.13-6.23% faster
PyBench was run with -w=1; 2to3 is translating its entire source
directory five times; S
Collin Winter added the comment:
On Tue, Jan 13, 2009 at 3:25 PM, Antoine Pitrou wrote:
>
> Antoine Pitrou added the comment:
>
> Hello,
>
>> I've backported condbranches-plus.patch to trunk, and I'm getting these
>> results:
>
> Thanks!
>
>&
Collin Winter added the comment:
Looks like this was re-applied in r59943 and r59944. Thanks for taking
care of this, Amaury.
--
nosy: +collinwinter, jyasskin
resolution: accepted -> fixed
status: open -> closed
___
Python tracker
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue4941>
___
___
Python-bugs-list mailing list
Unsub
Collin Winter added the comment:
Another data point: I've tested this patch applied to trunk on Core 2
Duo and Opteron 8214 HE machines using both gcc 4.0.3 and 4.3.1, and I'm
seeing mixed results. Pybench with warp 1 is between ~1.5% slower and
~1% faster, depending on gcc versi
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
type: feature request -> performance
___
Python tracker
<http://bugs.python.org/issue1518>
___
_
Changes by Collin Winter :
--
nosy: +collinwinter
___
Python tracker
<http://bugs.python.org/issue2459>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue5084>
___
___
Python-bugs-list mailing list
Unsub
New submission from Collin Winter :
This patch speeds up the string formatting % operator by avoiding the
unnecessary indirection in PyNumber_Remainder(). This particularly
benefits templating systems that do a lot of string formatting via %.
Performance tested with gcc 4.3.1 x86_64 on Linux
Changes by Collin Winter :
--
nosy: +collinwinter, jyasskin
___
Python tracker
<http://bugs.python.org/issue4751>
___
___
Python-bugs-list mailing list
Unsub
1 - 100 of 181 matches
Mail list logo
