Christian Heimes added the comment:
> While I like fixing the position restore in _fileio.c, I also liked
> Amaury's flush() call in _BufferedIOMixin. Perhaps you can keep that
> part (while losing the position restore)?
Good point. We have to call flush() in _BufferedIOMixin
Christian Heimes added the comment:
> Can you also use a global variable instead of "/etc"? Something like
> ETC_DIR = "/etc" for example. It would allow you to ship samples from
> several distribution and run unit tests against each.
I've attached the two rel
Christian Heimes added the comment:
> I am writing a patch but I have a few questions:
>
> 1) There are at most three places where the distribution name can be
> found. What is the priority order to select only one name ?
> The three places are:
> a) Inside the /etc/lsb-rele
New submission from Christian Heimes:
Here is the long promised bytes iterator view. It was much, *much*
easier to write it than I have thought. In fact I spent more time fixing
the indention than to modify the code from striterator.
I haven't written an unit test for it. The other iter
Christian Heimes added the comment:
The patch doesn't apply (r58677 of release25-maint). Can you please
create an unified diff against the latest subversion checkout with svn
diff or TortoiseSVN?
$ patch -p1 < thread_nt_fix.patch
missing header for context diff at line 3 of patch
patch
New submission from Christian Heimes:
Python 3.0 doesn't run from a directory with umlauts and possible other
non ASCII chars.
I renamed my development folder from C:\dev\ to c:\test äöüß name\.
Python crashes after a few moments before it can reach its shell.
python3
Christian Heimes added the comment:
I think the problem is solved now. I haven't seen glob crashing for a while.
--
nosy: +tiran
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Christian Heimes added the comment:
Here is the patch that contains only the harmless parts of the previous
patches. It changes a bunch of doc strings, changes the name of the
types and their repr() and str(). It also adds __builtin__.buffer but it
leaves __builtin__.bytes, __builtin__.str8 and
Christian Heimes added the comment:
The patch fixes parts of the problem. At least Python doesn't crash any
more when run from a directory with non ASCII chars. It just fails with
an import error in initstdio().
Added file: http://bugs.python.org/file8633/py3k_more_win_fsencoding.
Christian Heimes added the comment:
I've added a fprintf(stderr, "%s", path) to makepathobject(). I suspect
that PC/getpathp.c doesn't handle non ASCII chars correctly. It's using
char instead of w_char all over the place. Could that be related to the
issue, Neal?
Micr
Christian Heimes added the comment:
Warren DeLano wrote:
> So I guess that automatically puts me in the **highly-
> motivated/willing-to-help** camp, if there's anything useful I can
> actually do towards 2.5.2.
You can check every bugs related to 2.5 with urgent, high or no pr
Christian Heimes added the comment:
The patch is fine but you should add a short comment to avoid future
trouble. On the first glance it's not obvious why the StringIO instance
mustn't have a newline argument.
--
nosy: +gvanrossum, tiran
New submission from Christian Heimes:
Index: Lib/test/test_netrc.py
===
--- Lib/test/test_netrc.py (revision 58695)
+++ Lib/test/test_netrc.py (working copy)
@@ -25,7 +25,7 @@
mode = 'w'
if sy
Christian Heimes added the comment:
Confirmed!
Python 3.0 doesn't start at all on Windows when an environment variable
with non ASCII chars is present. This bug is related to
http://bugs.python.org/issue1342.
However on Linux Python 3.0 can handle unicode characters in paths and
environ
Christian Heimes added the comment:
The bug is related to http://bugs.python.org/issue1262
--
nosy: +gvanrossum
severity: normal -> urgent
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
New submission from Christian Heimes:
I always missed a getsize() method on file objects. The patch adds a
method getsize() to all io instances. The method returns a SizeInfo
object which can print a human readable name or the bare size in bytes.
The method is using os.fstat and falls back to
New submission from Christian Heimes:
Here is another patch related to stdio from me. It creates and sets up a
very dumb and easy stderr writer until the new io infrastructure is
initialized. It makes debugging problems in the init phase much easier.
--
components: Interpreter Core
Christian Heimes added the comment:
Guido van Rossum wrote:
> Guido van Rossum added the comment:
>
> D'oh, I submitted to the wrong branch. The py3k branch will have to
> wait until after my son's birthday party. ;-)
Have a nice party! How old is he? IIRC he was about
Christian Heimes added the comment:
Can you try this patch, please? It has the same effect as the other
patch from Neal but it doesn't loose ref counts. I've patched the
dealloc function of _FileIO to keep fd 1 and fd 2 open.
Index: Modules
Christian Heimes added the comment:
Martin v. Löwis wrote:
> I'm skeptical:
>
> - If you add getsize, why not getlastchangeddate, getowner, getpermissions?
getowner() etc. work only with file based streams and not with memory
buffers. getsize() works with every concrete class in
Christian Heimes added the comment:
Here you go, Guido!
Added file: http://bugs.python.org/file8647/py3k_closefd.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1329>
__Index: Python
Christian Heimes added the comment:
Improved patch
--
nosy: +gvanrossum
Added file: http://bugs.python.org/file8648/py3k_preliminary_stderr2.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1352>
___
Christian Heimes added the comment:
Kevin,
It's a known issue which is solved in newer version of OpenSSL. I hope
to convince somebody to update the packages someday.
--
nosy: +tiran
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Christian Heimes added the comment:
Please run the test suite in verbose mode and attach the output:
$ ./python Lib/test/regrtest.py -v test_cookielib test_email test_fileio
test_pipes test_uuid
You seem to missing some packages to build additional extensions. Can
you install sqlite, openssl
Christian Heimes added the comment:
Guido van Rossum wrote:
> Shouldn't closefd be passed as 1 in import.c?
>
> I don't see the point of distinguishing between -1 and +1. The block
> "if (closefd < 0) { closefd = 1; }" looks rather silly.
I used -1 as defaul
Christian Heimes added the comment:
Guido van Rossum wrote:
> Are there any places where PyBytes or PyString are written to stderr?
> Or can you get away with just supporting PyUnicode?
I could have simple copied the write method from _fileio.c and letting
the argument parser do i
Christian Heimes added the comment:
Yann Cointepas wrote:
> I joined a modified version of platform.py. Here is a summary of the
> modification:
> - replaced '/etc' by global variable _etc_dir
> - removed supported_dists parameter of dist()
> - each element of dist()
Changes by Christian Heimes:
--
components: +Library (Lib), Tests
versions: +Python 2.6 -Python 2.5
Added file: http://bugs.python.org/file8664/platform_py25.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Christian Heimes added the comment:
Guido van Rossum wrote:
> Are you sure this is the proper fix? Why does netrc.py insist on not
> having \r\n line endings? It opens the file in text mode so I don't
> quite understand your patch.
I don't quite understand why it fails. :
Christian Heimes added the comment:
Guido van Rossum wrote:
> Guido van Rossum added the comment:
>
> OK, thanks. The closefd part is good, but the stderrprinter part has a
> problem. On Linux, in a non-debug build, this has the odd side effect
> of subtracting one from sys.ma
Changes by Christian Heimes:
Added file: http://bugs.python.org/file8667/py3k_preliminary_stderr3.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1329>
__
__
Christian Heimes added the comment:
Guido van Rossum wrote:
> I've checked in the patch you added to issue 1329, with one mod: where
> you wrote "int fd : 1;" I removed the ": 1" since a field width of one
> bit makes no sense here.
Can you close http:/
Christian Heimes added the comment:
Hi Martin!
Thomas Wouters said on #python that you have the Windows Fu to fix the
problem. Parts of the Python API for file paths, sys.path and os.environ
have to be reimplemented using the wide char API.
--
nosy: +loewis
New submission from Christian Heimes:
Hey Guido!
During my testing and local modifications of the PEP 3137 branch I found
a bunch of unit tests that were choking on bytes(1) where bytes is PyString.
The PEP doesn't list bytes() as a valid constructor, only
buffer(). I don't see a
Christian Heimes added the comment:
Here it is.
patch + unit test
Added file: http://bugs.python.org/file8670/py3k_pystring_ssize.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1365>
__In
Christian Heimes added the comment:
I was able to reproduce the bug on Windows with Python 2.6 and 3.0. I've
added an unit test to both versions.
--
nosy: +tiran
priority: -> low
resolution: -> accepted
versions: +Python 2.6, Python 3.0
___
Christian Heimes added the comment:
Here is a patch that solves the problem. However the patch is against
the py3k sources and I like somebody to review and test it. I don't have
enough disk space in my VMWare box to test it against the trunk or 2.5.
Reason for the problem: Windows&
Christian Heimes added the comment:
Fixed patch. Georg pointed out that PyArg_ParseTuple("s") returns a
reference to the internal data of the PyString object. The new version
copies the path to a fixed width buffer before it mangles the trailing
slashes.
The new patch applies against
Changes by Christian Heimes:
--
keywords: +patch, py3k
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1373>
__
___
Python-bugs-list mailing list
Unsubs
Changes by Christian Heimes:
--
keywords: +patch
priority: -> high
resolution: -> accepted
versions: +Python 2.6, Python 3.0
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Christian Heimes added the comment:
The bug makes debugging a crux :(
--
priority: -> high
resolution: -> accepted
type: -> behavior
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Christian Heimes added the comment:
Applied in r58831
Thanks!
--
keywords: +patch, py3k
nosy: +tiran
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Christian Heimes added the comment:
I'm going to disable the test for now.
--
keywords: +py3k
resolution: -> accepted
superseder: -> Crash on Windows if Python runs from a directory with umlauts
__
Tracker <[EMAIL PROTECTED]>
<ht
Christian Heimes added the comment:
I've checked in part of the patch in r58837. It doesn't solve the
problem but at least it prevents Python from seg faulting on Windows.
--
keywords: +py3k, rfe
priority: -> high
resolution: -> accepted
__
Christian Heimes added the comment:
Why are you using PyUnicode_AsUTF32String(parentname)?
PyUnicode_AsString() is the correct method (although it's not yet in the
docs).
The rest looks fine. PyModule_GetName() returns a char* from
PyUnicode_AsString(). Fixed in r58838.
--
key
Changes by Christian Heimes:
--
keywords: +py3k
priority: -> normal
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1210>
__
_
Christian Heimes added the comment:
Applied in r58843.
Thank you very much!
--
keywords: +patch, py3k
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Christian Heimes:
The patch lower()s the file names on Windows. The tests break on my
system because C:\\... != c:\\...
--
files: py3k_inspect.patch
keywords: patch, py3k
messages: 57105
nosy: tiran
severity: normal
status: open
title: Windows fix for inspect tests
Christian Heimes added the comment:
Applied in r58848. Thanks for removing the annoying warnings!
A small request: Please use self.assert_() and its friends instead of
assert() in unit tests.
--
keywords: +patch, py3k
resolution: -> fixed
status: open ->
Christian Heimes added the comment:
Thanks!
Applied in r58847.
--
keywords: +patch, py3k
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Christian Heimes:
~/dev/python/py3k-pep3137$ ./python Lib/test/regrtest.py -R 3:5 test_ctypes
test_ctypes
beginning 8 repetitions
12345678
test_ctypes leaked [39, -31, 33, -33, 0] references, sum=8
1 test OK.
[101762 refs]
--
assignee: theller
components
New submission from Christian Heimes:
~/dev/python/py3k-pep3137$ ./python Lib/test/regrtest.py -R 2:4 test_struct
test_struct
beginning 6 repetitions
123456
..
test_struct leaked [12, 7, 20, 10] references, sum=49
1 test OK.
[65353 refs]
--
components: Extension Modules
keywords
Christian Heimes added the comment:
Python 3.0 has many more problems at its boundaries to the system on
Windows. Large parts of the API that deals with Windows system calls
have to be rewritten in order to use the wide char API.
--
keywords: +py3k
nosy: +tiran
priority: normal -> h
Christian Heimes added the comment:
Thomas Heller wrote:
> Thomas Heller added the comment:
>
> ./python Lib/test/regrtest.py -R:: test_ctypes does not report a leak,
> so I think there is no leak.
I'm getting
$ ./python Lib/test/regrtest.py -R:: test_ctypes
test_c
New submission from Christian Heimes:
str(bytes()) == repr(bytes()) and str(buffer()) == repr(buffer()) is
causing a bunch bugs which are extremely hard to understand. On several
occasions I didn't understand the problem until I removed a str() call
or made str(bytes()) and str(buffer())
Christian Heimes added the comment:
Err, please remove the (reprfunc) cast and check the language of the
error messages, too :)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Christian Heimes added the comment:
Here is an updated patch that fixes an error in httplib that was causing
the xmlrpc test suite to block.
Added file: http://bugs.python.org/file8695/py3k-pep3137_remove_str_bytes2.patch
__
Tracker <[EMAIL PROTECTED]>
Christian Heimes added the comment:
Guido van Rossum wrote:
> I'll look at the patches later, but we've gone over this before on the
> list. str() of *any* object needs to return *something*. Yes, it's
> unfortunate that this masks bugs in the transitional period, but
Christian Heimes added the comment:
New patch:
static PyObject *
string_str(PyObject *op)
{
return PyObject_CallMethod(op, "decode", "s", "ascii");
}
Added file: http://bugs.python.org/file8696/py3k-pep3137_str_bytes_ascii.patch
Changes by Christian Heimes:
--
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1388>
__
___
Python
Christian Heimes added the comment:
Guido van Rossum wrote:
> Guido van Rossum added the comment:
>
> A compromise I could live with: add a command line option that makes it
> a warning.
Good idea. I can live with it, too. :) How do you like
-b: issue warnings about str(bytes_i
Christian Heimes added the comment:
I've made a patch with -b -> warning and -bb > type error. I'm not happy
with the warning message. Maybe you've a better idea for it.
Added file: http://bugs.python.org/file8697/py3k-pep3137_str_bytes_warning.patch
_
Christian Heimes added the comment:
Guido van Rossum wrote:
> The error message is fine, though you could drop the word "Calling"
> without loss of information. ;-) Also, most warnings don't seem to use
> a trailing period.
>
> Perhaps you could expand this to als
Christian Heimes added the comment:
Ah, os.path has a method for the job. I should have checked the module
before reinventing the wheel ...
For some unknown and mysterious reasons the inspect tests are passing
again on my machine. I've purged the pyc files before I run the
unpatched test
Christian Heimes added the comment:
Pfff! I've written my best code after having one or two beers :)
Updates:
* Added class BytesWarning(Warning)
* Added -b/-bb command line args and Py_BytesWarningFlag
* issue PyErr_WarnEx(PyExc_BytesWarning) when Py_BytesWarningFlag is set.
* Added wa
Changes by Christian Heimes:
--
keywords: +py3k
resolution: -> invalid
status: open -> closed
superseder: -> py3k: duplicated line endings when using read(1)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
New submission from Christian Heimes:
Hi Yhg1s!
svn praise shows your name for Lib/mailbox.py more often then other
names. Can you look at my patch and see if it's correct? It fixes most
of the errors in test_mailbox.py and all tests in test_old_mailbox. I'm
unsure about the pa
Christian Heimes added the comment:
Applied to py3k in r58875. I'm doing a svnmerge later. Thanks again for
your help, pal!
--
components: +Windows
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<ht
Christian Heimes added the comment:
Applied to py3k-pep3137 in r 58876
--
resolution: -> fixed
status: -> closed
title: py3k-pep3137: str(bytes()) and str(buffer()) should raise TypeError
patch -> py3k-pep3137: issue warnings / errors on str(bytes()) and similar
o
Christian Heimes added the comment:
Correction:
The unit test isn't marked as failing but the failing assertion don't
look good.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
New submission from Christian Heimes:
Exception in thread writer 2:
Traceback (most recent call last):
File "/home/heimes/dev/python/py3k-pep3137/Lib/threading.py", line
485, in _bootstrap_inner
self.run()
File "/home/heimes/dev/python/py3k-pep3137/Lib/threading.py&quo
Christian Heimes added the comment:
Yes, Yhg1s is Thomas nick on #python.
On the trunk svn annotate shows Andrew as the author of most lines.
Maybe he can shed some light on the problem. I'm not familiar with the
details of the mailbox format.
--
assignee: twouters -> akuchl
Christian Heimes added the comment:
Guido van Rossum wrote:
> IMO you shouldn't read another chunk when the last character you've seen
> is \r; instead, you should set a flag so that on the next read, you'll
> ignore an initial \n. The flag should be made of the tell/seek
Christian Heimes added the comment:
Thanks for your insight, Andrew! Applied in r58881.
I agree with you but I'm not able to test it with real data. I've no
longer access to our old server at my old dormitory. I had a Qmail
system with maildir there.
Two tests are still failing wit
Christian Heimes added the comment:
Guido van Rossum wrote:
> (1) Don't use s#; it will allow null bytes in the string, which we don't
> want.
>
> (2) Put the entire trailing slash removal inside #ifdef MS_WINDOWS.
Done aand done
> (3) Careful! It seems the code you
Christian Heimes added the comment:
Another patch that uses os.path.normpath.
Added file: http://bugs.python.org/file8704/trailing_slash3.patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1293>
__I
Christian Heimes added the comment:
I've mentioned the platform and db version in the last line. You surely
have missed it:
Ubuntu Linux 7.10, i386, db 4.4.20
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Christian Heimes:
--
nosy: +alexandre.vassalotti
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1395>
__
___
Python-bugs-list mailing list
Changes by Christian Heimes:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1395>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Christian Heimes added the comment:
The new patch fixes test_netrc for me but test_csv and test_mailbox are
still broken.
--
components: +Library (Lib), Windows
keywords: +py3k
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Christian Heimes added the comment:
Good work!
The tests for mailbox, netrc and csv are passing with your test. I'm
going to run the entire suite now.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Christian Heimes added the comment:
I take it back. I accidentally run the unit tests on the trunk instead
of the py3k branch. mailbox and csv are still breaking with your test,
netrc is doing fine.
Added file: http://bugs.python.org/file8709/py3k_windows.log.gz
Christian Heimes added the comment:
By the way what happened to the SoC project related to Python's new IO
subsystem? IIRC somebody was working on a C optimization of the io lib.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Christian Heimes added the comment:
I've checked in a fix in r58903 (py3k branch).
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1293>
__
___
Python-bugs-
Christian Heimes added the comment:
Brett Cannon wrote:
> Modules/getpath.c:joinpath() I think does what you want in C.
I don't see how it is going to help us.
I've a final offer before I declare the bug as SEP (someone else's problem):
pseudo code
#ifdef MS_WINDOWS
rv
Christian Heimes added the comment:
The patch doesn't apply
$ patch -p0 < io4.diff
(Stripping trailing CRs from patch.)
patching file Lib/io.py
patch: malformed patch at line 41: @@ -1133,7 +1160,10 @@
__
Tracker <[EMAIL PROTECTED]>
<http:
Christian Heimes added the comment:
Additional prints make it easy to understand what happens here:
>>> class Anything:
... def __eq__(self, other):
... print("eq")
... return True
... def __ne__(self, other):
... print("ne")
...
Changes by Christian Heimes:
--
resolution: accepted -> remind
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1377>
__
__
Christian Heimes added the comment:
PCBuild is still the default compiler for Python but any patches are
appreciated. You could start by writing a new or updating the old
compiler command to support VS 2005. The old distutils.msvccompiler
supports only MSVC 6 and 7 but not 8.
--
nosy
Changes by Christian Heimes:
--
keywords: +py3k
priority: -> high
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1400>
__
_
Christian Heimes added the comment:
> (a) the SizeInfo class is overkill. getsize() should just return an int.
But I like overkill :)
> (b) getsize() should check self.seekable() first and raise the
appropriate error if the file isn't seekable.
That's easy to implement
>
Christian Heimes added the comment:
Can you create a new patch and verify that the problem still exists?
norawescape3.diff doesn't apply cleanly any more.
--
nosy: +tiran
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.or
Christian Heimes added the comment:
I've validated a) and fixed b) two weeks ago. I'm closing this bug. It
doesn't contain any additional problems for the bug.
I expect the next alpha of Python 3.0 in about two weeks. Please test
the next version, would you? The problems with yo
New submission from Christian Heimes:
$ ./python -bb Lib/compileall.py
Listing /home/heimes/dev/python/py3k/Lib ...
Compiling /home/heimes/dev/python/py3k/Lib/pydoc.py ...
Traceback (most recent call last):
File "Lib/compileall.py", line 162, in
exit_status = int(not main())
Christian Heimes added the comment:
The transition is done. Can you work on a patch and maybe add some
tests, too? It helps when you start Python with the -bb flag:
$ ./python -bb -c 'import imaplib; imaplib.Debug=5;
imaplib.IMAP4("mail.rtmq.infosathse.com")'
52:01.86
Christian Heimes added the comment:
I've applied your patch in r58910. Thanks!
Please open another bug if you have additional tests.
--
nosy: +tiran
resolution: -> fixed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Christian Heimes added the comment:
I'm unable to reproduce the error and I haven't seen it for a long time.
Closing
--
keywords: +rfe
resolution: -> out of date
status: open -> closed
type: -> behavior
__
Tracker <[E
Changes by Christian Heimes:
--
components: +Interpreter Core
priority: -> low
resolution: -> accepted
type: -> rfe
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Christian Heimes added the comment:
It's still breaking but Guido should know how to fix the parser.
--
assignee: -> gvanrossum
keywords: +patch
nosy: +gvanrossum, tiran
priority: normal -> low
resolution: -> accepted
__
Tracker <
New submission from Christian Heimes:
$ ./python Lib/compileall.py
Listing /home/heimes/dev/python/py3k/Lib ...
Compiling /home/heimes/dev/python/py3k/Lib/pydoc.py ...
Traceback (most recent call last):
File "Lib/compileall.py", line 162, in
exit_status = int(not main())
301 - 400 of 6972 matches
Mail list logo