Brian Curtin added the comment:
Can you try http://bugs.python.org/file25583/pcbuildpatch.patch from #13210?
--
___
Python tracker
<http://bugs.python.org/issue14
Brian Curtin added the comment:
Hm, I thought I already responded to this one. PEP 11 states that the w9xpopen
code shouldn't be removed until 3.4. I have a patch on another computer that
adds a deprecation for 3.3 - I'll add it here within the day.
For 3.4 we would actually
Brian Curtin added the comment:
I don't have time at the moment to test it, but the patch looks like it's
probably ok.
--
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue1602>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Would you mind taking a screenshot of where "Build Solution" appears? You'll
probably need to hold CTRL+print screen to make sure the menu doesn't retract.
As seen in http://i.imgur.com/XvXa5.png I have the menu as described in the
guide a
Brian Curtin added the comment:
Weird that they would do that. Given that there is a difference, we should
probably list both. Something like "choose the Build Solution option from
either the Build or Debug menu depending on your Visual Studio version."
Your patch seems to solve
Brian Curtin added the comment:
May as well fix them both.
--
___
Python tracker
<http://bugs.python.org/issue14884>
___
___
Python-bugs-list mailing list
Unsub
Brian Curtin added the comment:
Looks good to me. Feel free to commit it, Eli.
--
assignee: brian.curtin ->
___
Python tracker
<http://bugs.python.org/issu
Brian Curtin added the comment:
2. Yes, only the installation directory, because that's the only directory we
create. Scripts is created by distutils/packaging, but perhaps we could add it
since it is widely used. Anyone have an opinion?
3. Do you have a reason? Many tools that offer
Brian Curtin added the comment:
I'm strongly opposed to enabling this by default at least for 3.3, but does
anyone think something like this dialog http://i.imgur.com/18zPD.png be
helpful? After choosing the directory to install to and before choosing the
features, it's a sim
Brian Curtin added the comment:
I'd rather it tried to stay as version agnostic as could be, but favoring 3.x
in general. I wouldn't tie it down to any particular version because we'll have
to come back in several years and update Python 3.
Brian Curtin added the comment:
#14668
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14941>
___
___
Changes by Brian Curtin :
--
assignee: docs@python -> brian.curtin
components: +Windows
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
New submission from Brian Curtin :
Attached is a patch, originally written by Van Lindberg*, which changes
Python's layout on Windows to more match all of the other operating systems we
support. This patch starts by changing the layout of virtual environments, so
the venv module creat
New submission from Brian Curtin :
IGNORE THIS ISSUE
This is a test of a newer bitbucket mirror setup by Atlassian. I just want to
get a feel for how it works before I post about it on the dev blog.
--
hgrepos: 132
messages: 162392
nosy: brian.curtin
priority: normal
severity: normal
Changes by Brian Curtin :
--
keywords: +patch
Added file: http://bugs.python.org/file25842/e48c54fa4bfb.diff
___
Python tracker
<http://bugs.python.org/issue15
Changes by Brian Curtin :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
hgrepos: +133
keywords: +needs review
___
Python tracker
<http://bugs.python.org/issue15012>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
hgrepos: +134
___
Python tracker
<http://bugs.python.org/issue15012>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
Added file: http://bugs.python.org/file25843/e48c54fa4bfb.diff
___
Python tracker
<http://bugs.python.org/issue15012>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Ah, sorry, the venv change wasn't included for some reason. New patch attached.
I'll look into bdist_msi.
I don't remember there being strong thoughts against this, but I guess I'll go
look again.
--
Added file: http://bugs.
Changes by Brian Curtin :
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Before we miss yet another beta freeze, how does something like this look?
It moves `which` into one function which always yields paths. I don't think
anyone will approve of adding a dual-function API to solve this problem. I
originally tried an app
Brian Curtin added the comment:
> I don't think file is a good name.
Changed to "cmd" for command, and that's what the Unix `which` calls it as well.
> Wait, why are we even returning more than one result? I don't see any use
> cases for that in the issue
New submission from Brian Curtin :
As of http://hg.python.org/cpython/rev/a7ecbb2ad967, the PEP 397 launchers are
included. Their functionality should be documented.
--
assignee: docs@python
components: Documentation, Windows
messages: 163374
nosy: brian.curtin, docs@python
priority
Changes by Brian Curtin :
--
assignee: docs@python -> brian.curtin
___
Python tracker
<http://bugs.python.org/issue15131>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Here's a patch that also works on linux. A pathext specific test is now skipped
since that only matters on Windows, and I forgot a chmod that was making two
tests fail on linux.
--
Added file: http://bugs.python.org/file26078/issue444582_v3
Brian Curtin added the comment:
Attached is a patch which fixes your review comments in Lib/shutil.py, and it
makes an adjustment in the wording of the documentation.
The documentation is a bit more strong in wording that the current directory is
always prepended to the path whether its a
Brian Curtin added the comment:
I don't know. It makes sense to me. I'll try to find someone else to look at it
and adjust it.
--
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
> I don't really understand why you call abspath(). If the caller wants an
> absolute path, they can call abspath() themselves.
Because that is what `which` does.
I just pushed the change before I saw this message, so it went in as the patch
sh
Brian Curtin added the comment:
I updated file to command in 973b4806f760. It needs to be command so it matches
the implementation's argument name, and because it doesn't exactly take a file.
Alexander, can you explain the part about finding a file on PYTHONPATH? I don't
New submission from Brian Curtin :
6>python3.def : error LNK2001: unresolved external symbol PyState_AddModule
6>python3.def : error LNK2001: unresolved external symbol PyState_RemoveModule
6>C:\python-dev\cpython\PCbuild\python3.lib : fatal error LNK1120: 2 unresolved
Brian Curtin added the comment:
No, reverting.
--
___
Python tracker
<http://bugs.python.org/issue15148>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
So I have a patch that does most of what my previous message shows, but I can't
seem to complete it. I don't know if I'm misunderstanding something or this
just can't be done, but I could use the help of someone who understands MSI
thing
Brian Curtin added the comment:
I will take a look at it shortly...was too busy with installer/path issues and
then PEP 397 last week.
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Brian Curtin :
--
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue15011>
___
___
Python-bugs-list mailing list
Unsub
Brian Curtin added the comment:
> == Suggestion 1 ==
I don't think it's that unexpected. I certainly didn't come up with the idea
myself - I've seen them before. Surely it might be new to some people, but is
it confusing? For one, we think it's an option users s
Brian Curtin added the comment:
We don't need to stay with some paradigm if it's not the best way. If I can get
any of these ways to work, I may post some type of survey on python-dev.
Adding to the end wouldn't make this much of a feature. Most users have already
put anot
Brian Curtin added the comment:
Hi mandel :)
With the exception of the "import string" inside of _get_letters (policy is to
do all imports at the top), it looks ok just by reading.
Assigning to myself to complete it after I return from holiday in a few days
(unless someon
Changes by Brian Curtin :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Sorry, I've been too busy to get caught up with this. I'm away most of today
but I can try to take a look tonight.
--
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
Can someone tell me where you want this changed? I guess Lib/imp.py in the
find_module function, based on previous mention of imp.find_module? That's
shown as deprecated so I'm hesitant to start there.
I don't really know anything about import
Brian Curtin added the comment:
I'm not sure what the deal is but I can't get the changes to apply (fitting
Amaury's patch into _boostrap.py), meaning nothing I change to the _boostrap.py
file changes how anything operates.
I don't have much time to learn all of this st
Brian Curtin added the comment:
> I would really like to release beta2 this weekend. Is it possible to get
> this resolved by then?
As others stated, I'm not sure it's entirely necessary. Given the two
dependencies that need to be fixed before this one can move forward, I d
Brian Curtin added the comment:
> Without some change, the Win64 buildbot is relatively irrelevant as it
is nearly always in a state of failure due to these errors.
Not that some change isn't necessary, but what else are you running on your
build slave? I ran a Windows 2008 R2 x64 s
Changes by Brian Curtin :
--
assignee: -> brian.curtin
nosy: +brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
The latest patch to test.support looks reasonable. Go for it.
--
___
Python tracker
<http://bugs.python.org/issue15496>
___
___
Changes by Brian Curtin :
--
assignee: -> brian.curtin
components: +Windows
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
This was added by Vinay in 4a3439ef552c.
--
resolution: -> invalid
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
components: +Build
nosy: +brian.curtin, loewis
___
Python tracker
<http://bugs.python.org/issue15772>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue15779>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue1005895>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I'm not sure Microsoft is going to change anything about this - it has done
this for a long time, if not forever. We recently had #15496 receive changes,
and #7443 is in the same area and has more details and some patches, so I'd
suggest tak
Changes by Brian Curtin :
--
assignee: -> bquinlan
nosy: +bquinlan
___
Python tracker
<http://bugs.python.org/issue15966>
___
___
Python-bugs-list mai
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue9650>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Brian Curtin:
>>> platform.platform()
'Windows-post2008Server-6.2.9200'
The change is trivial, just accounting for a point release of 2 (from the major
release 6).
--- a/Lib/platform.py
+++ b/Lib/platform.py
@@ -595,8 +595,13 @@
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue16175>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
The patch looks alright, but I would remove the lining up of definitions.
It's probably easiest to do a patch against 3.2 and I can handle the porting on
commit.
--
assignee: docs@python -> brian.curtin
components: +Windows
type: -&g
Changes by Brian Curtin :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Docs should match code. If we did it the other way around we'd probably break
something.
Thanks for looking into this. I've been busy the last few days but I will get
to the review and application of the patch
Brian Curtin added the comment:
Pushed fixes for 3.2+
Thanks for the patch!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
It was brought to my attention that this is still an issue and that it was
closed. Reopening.
--
resolution: wont fix ->
status: closed -> open
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
It remains a valid issue. Time is not a factor.
--
___
Python tracker
<http://bugs.python.org/issue900092>
___
___
Python-bug
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue9194>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue8576>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue1559298>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue10765>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue13101>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue9191>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue16218>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Colin - it should work in the same way that setting PYTHONPATH as an
environment variable would work, e.g., semi-colon is the separator on Windows.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
winreg does not have a pure equivalent, nor could it
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue16
Brian Curtin added the comment:
Looks alright so far. I'm working on reviewing and applying it.
--
assignee: docs@python -> brian.curtin
___
Python tracker
<http://bugs.python.org
Brian Curtin added the comment:
Thanks for the patch.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Brian Curtin :
--
assignee: -> brian.curtin
components: +Windows
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue16719>
___
_
Brian Curtin added the comment:
Latest patch looks ok to me and the tests pass.
--
___
Python tracker
<http://bugs.python.org/issue13863>
___
___
Python-bug
Changes by Brian Curtin :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue14470>
___
___
Python-bugs-list
Brian Curtin added the comment:
Here is a patch for the first part (SetValueEx).
--
keywords: +needs review, patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file28412/issue14420_part1.diff
___
Python tracker
&l
New submission from Brian Curtin:
Making this its own issue from msg156935 on #14420:
"Likewise, the winreg.QueryValueEx method returns a signed 32 bit value,
instead of a 32 bit unsigned value."
--
assignee: brian.curtin
components: Extension Modules, Windows
messages: 1
Brian Curtin added the comment:
Marking this dependent on #14420 because we can't reliably test QueryValueEx's
unsigned value without being able to SetValueEx an unsigned value.
--
dependencies: +winreg SetValueEx DWord type incompatible with valu
Brian Curtin added the comment:
Here's a patch. It depends on the patch from #14420 being applied in some way
(I cloned from a branch which included it).
--
keywords: +needs review, patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file28413/issue16
Brian Curtin added the comment:
Yep. The documentation you linked says "A null-terminated string that contains
unexpanded references to environment variables (for example, "%PATH%"). It will
be a Unicode or ANSI string depending on whether you use the Unicode or ANSI
functions
Brian Curtin added the comment:
This went over a year without a request to undo it, and we've since made
several releases that includes it, so I'm closing this. Please re-open if it
does need to be reverted.
--
status: open -> closed
_
Brian Curtin added the comment:
Unassigning myself. Jorge - are you still able to reproduce this, and if so,
are you able to capture the log as mentioned by Martin?
--
assignee: brian.curtin ->
___
Python tracker
<http://bugs.python.org/issu
New submission from Brian Curtin:
While fixing #14470 to remove w9xpopen support, removing it from old Visual
Studio projects came up.
1. I can't imagine anyone is attempting to use most of these.
2. Since we don't backport build changes to these older versions, some of them
are v
Brian Curtin added the comment:
Definitely keeping PC/VS9.0 as it's still fairly common and VS2008 is still
used by us for 2.7.
I would like to remove PC/VS8.0 but if anyone speaks towards keeping it then I
think it's fine.
--
nosy: +
Brian Curtin added the comment:
Here's a patch that fills st_dev, and while we're at it st_rdev (which is the
same value).
I've moved the implementation of samefile/sameopenfile/samestat from
Lib/posixpath.py over to Lib/genericpath.py and then removed the implementation
fro
Changes by Brian Curtin :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue13000>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
Why do you think that? I don't have a mac so I can't test it.
--
___
Python tracker
<http://bugs.python.org/issue11939>
___
__
Brian Curtin added the comment:
Here is an updated patch addressing the sameopenfile that remained in
Lib/ntpath.py, thanks to Sehriy's comment on the review.
--
Added file: http://bugs.python.org/file28429/issue11939_v2.diff
___
Python tr
Brian Curtin added the comment:
Docs and the __all__ changes in V3 patch.
--
Added file: http://bugs.python.org/file28430/issue11939_v3.diff
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
Thanks for the reviews.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
This was fixed as a result of #11939, and I've refactored the tests to add
coverage of hard links in 9e980454b85e.
This was originally a bug report but it requires a 3.4 feature so it can't be
fixed in 3.2 where it originally appeared.
--
Changes by Brian Curtin :
--
assignee: brian.curtin
components: Library (Lib), Windows
nosy: brian.curtin
priority: normal
severity: normal
stage: needs patch
status: open
title: Add samestat to Lib/ntpath.py __all__
type: behavior
versions: Python 3.4
Changes by Brian Curtin :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Brian Curtin added the comment:
Separate issue. Fixed in #16788.
--
___
Python tracker
<http://bugs.python.org/issue11939>
___
___
Python-bugs-list mailin
Brian Curtin added the comment:
This is fixed on 3.2 through 3.4. On 2.7 we get a ValueError trying to do the
same thing so I'll create a separate issue for that since it involves fixing
more than just the change in Py2Reg.
--
resolution: -> fixed
stage: patch review ->
Brian Curtin added the comment:
Never mind msg178303. The fix was roughly the same and in the same area, so now
we're covered on 2.7 as well.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Brian Curtin :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 2.7, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.or
901 - 1000 of 1382 matches
Mail list logo