[issue1778] SyntaxError.offset sometimes wrong

2010-09-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: None offsets gone in r84931. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue1778> ___ ___ Pytho

[issue9582] documentation line needs rewording

2010-09-23 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue9582> ___ ___ Python-bugs-list mailing list Unsubscri

[issue9928] weird oddity with bz2 context manager

2010-09-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/9/23 Antoine Pitrou : > > Antoine Pitrou added the comment: > > Actually, it is because bz2 doesn't call PyType_Ready() but instead sets some > field manually. Perhaps we could have a guard somewhere that raises a fatal > e

[issue9940] Strange error reporting with "with" statement

2010-09-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: I would say it's strange but correct. (and unavoidable I think) -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python

[issue9943] TypeError message became less helpful in Python 2.7

2010-09-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85003 Thanks for the report. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue9943] TypeError message became less helpful in Python 2.7

2010-09-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: Reverted, however. Let me clarify: you think the unhelpful part is that the count includes keyword arguments? This change was intentional, actually wrt to cases like this: >>> def f(a): ...pass >>> f(6, a=4, *(1, 2, 3))

[issue9954] include sqlite3.exe in PythonXX/Scripts

2010-09-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: Indeed, -1. We don't make a habit of distributing 3rd party binaries. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/i

[issue9956] memoryview type documentation lacks versionadded

2010-09-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85022 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue9955] multiprocessing.Pipe segmentation fault when recv of unpicklable object

2010-09-26 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> jnoller nosy: +jnoller ___ Python tracker <http://bugs.python.org/issue9955> ___ ___ Python-bugs-list mai

[issue10000] mark more tests as CPython specific

2010-09-30 Thread Benjamin Peterson
Benjamin Peterson added the comment: This seems rather open-ended and all-encompassing. Wouldn't it be better to have individual issues for specific tests? -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/is

[issue10006] non-Pythonic fate of __abstractmethods__

2010-10-01 Thread Benjamin Peterson
Benjamin Peterson added the comment: I see the problem; will consider/fix later today hopefully. -- assignee: -> benjamin.peterson ___ Python tracker <http://bugs.python.org/issu

[issue10006] non-Pythonic fate of __abstractmethods__

2010-10-01 Thread Benjamin Peterson
Benjamin Peterson added the comment: As of r85154, type.__abstractmethods__ now raises an AttributeError, too. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10006] non-Pythonic fate of __abstractmethods__

2010-10-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/1 Yaroslav Halchenko : > > Yaroslav Halchenko added the comment: > > yikes... surprising resolution -- I expected that fix would either makes > __abstractmethods__ accessible in derived "type"s or becomes absent from >

[issue9533] metaclass can't derive from ABC

2010-10-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: You can now create metaclass abcs. However, having __abstractmethods__ does not prevent instance creation. This is a problem with a builtins, though. -- resolution: -> fixed status: open -> closed ___

[issue10011] `except` doesn't use `isinstance`

2010-10-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: It matters when exceptions are expected or are a normal part of control flow. For example StopIteration. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue10

[issue10021] Format parser is too permissive

2010-10-04 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/4 Eric Smith : > > Eric Smith added the comment: > > Right. It seemed like a hassle to have the str.format parser try to figure > out what a valid identifier is, so it just passes it through. You can always use "str.isid

[issue1104021] wishlist: os.feed_urandom(input)

2010-10-04 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> rejected ___ Python tracker <http://bugs.python.org/issue1104021> ___ ___ Python-bugs-list mailing list Un

[issue10021] Format parser is too permissive

2010-10-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: This should not be classified as an "implementation detail". Either we should document it and cause other implementations to support it or check it ourselves. -- ___ Python tracker <http://bu

[issue10042] total_ordering stack overflow

2010-10-07 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker <http://bugs.python.org/issue10042> ___ ___ Python-bugs-list mai

[issue9951] introduce bytes.hex method

2010-10-09 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- Removed message: http://bugs.python.org/msg117862 ___ Python tracker <http://bugs.python.org/issue9951> ___ ___ Python-bug

[issue10068] global objects created in some module are not destroyed when last reference to that module is released

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: Tricky. I think the only way to do this properly is to call _PyModule_Clear when the dict is destroyed. However, there's no good way to flag a dictionary as a "module" dict. Therefore, I propose we remove the Py_REFCNT == 1 guard in modu

[issue10069] 2to3 crash in fix_urllib.py

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85388. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10069> ___ ___

[issue7140] imp.new_module does not function correctly if the module is returned from a function and used directly

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: Rebroken in r85392. See #10068. -- resolution: fixed -> status: closed -> open ___ Python tracker <http://bugs.python.org/

[issue10068] global objects created in some module are not destroyed when last reference to that module is released

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85392. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10068> ___ ___

[issue10078] Documentation: 'Postive' should be 'Positive'

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85395. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10074] dictobject.c: crash in Py_XDECREF

2010-10-12 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue10074> ___ ___ Python-bugs-

[issue10078] Documentation: 'Postive' should be 'Positive'

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: Done for all branches that are maintained. -- resolution: remind -> fixed ___ Python tracker <http://bugs.python.org/issu

[issue10068] global objects created in some module are not destroyed when last reference to that module is released

2010-10-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85398 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10068> ___ ___

[issue7287] import hook demo does not work

2010-10-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: See r85429. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue7287> ___ __

[issue7287] import hook demo does not work

2010-10-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/13 Sandro Tosi : > > Sandro Tosi added the comment: > > Hi Benjamin, > you are the author of r63966 (I know, it's quite old, sorry about that) where > you removed Demo/imputil/importers.py : do you think Demo/imputil/knee.p

[issue10093] Warn when files are not explicitly closed

2010-10-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: +1 for RuntimeError. -- ___ Python tracker <http://bugs.python.org/issue10093> ___ ___ Python-bugs-list mailing list Unsub

[issue10093] Warn when files are not explicitly closed

2010-10-13 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/13 Alex : > > Alex added the comment: > > RuntimeWarning you mean?  I don't think anyone is suggesting making it an > error. Indeed. -- ___ Python tracker <http://bug

[issue10101] a bug in built-in function round() ?

2010-10-14 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue10101> ___ ___ Python-bugs-

[issue10109] itertools.product with infinite iterator cause MemoryError.

2010-10-14 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker <http://bugs.python.org/issue10109> ___ ___ Python-bugs-list mai

[issue9997] function named 'top' gets unexpected namespace/scope behaviour

2010-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85562. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue10125] Closing a file within its writelines method causes segfault

2010-10-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85574 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-17 Thread Benjamin Peterson
Benjamin Peterson added the comment: Here's a patch. Please review. -- keywords: +patch nosy: +benjamin.peterson Added file: http://bugs.python.org/file19257/hash_t.diff ___ Python tracker <http://bugs.python.org/i

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-17 Thread Benjamin Peterson
Changes by Benjamin Peterson : Added file: http://bugs.python.org/file19258/hash_t.diff ___ Python tracker <http://bugs.python.org/issue9778> ___ ___ Python-bugs-list m

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-17 Thread Benjamin Peterson
Benjamin Peterson added the comment: Dropping the cast was inadvertent. I've now added versionchanged and committed it in r85664. -- resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-17 Thread Benjamin Peterson
Benjamin Peterson added the comment: Good point. Here's another patch: -- Added file: http://bugs.python.org/file19260/deunsignify.diff ___ Python tracker <http://bugs.python.org/i

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-18 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/18 Marc-Andre Lemburg : > > Marc-Andre Lemburg added the comment: > > And related to my previous comment: shouldn't Py_hash_t map to size_t instead > of Py_ssize_t ? No, negative values have to be allowed. -- title:

[issue10091] ast.literal_eval does not handled new set literals

2010-10-18 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/18 Éric Araujo : > > Éric Araujo added the comment: > > Set literals, a new feature indeed, have been backported to 2.7 and 3.1.  The > lack of support in ast.literal_eval is arguably a bug.  Benjamin, can you > make a statement

[issue10152] symtable.c: ste_tmpname uninitialized

2010-10-20 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> benjamin.peterson nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue10152> ___ ___ Py

[issue10152] symtable.c: ste_tmpname uninitialized

2010-10-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85757 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10152> ___ ___

[issue10158] BadInternalCall running test_multiprocessing

2010-10-20 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> jnoller nosy: +jnoller ___ Python tracker <http://bugs.python.org/issue10158> ___ ___ Python-bugs-list mai

[issue10160] operator.attrgetter slower than lambda after adding dotted names ability

2010-10-20 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: d...@python -> rhettinger nosy: +rhettinger ___ Python tracker <http://bugs.python.org/issue10160> ___ ___ Python-

[issue9778] Make hash values the same width as a pointer (or Py_ssize_t)

2010-10-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Thank you. Applied in r85803. -- ___ Python tracker <http://bugs.python.org/issue9778> ___ ___ Python-bugs-list mailin

[issue10186] Invalid SyntaxError pointer offset

2010-10-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85814 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue7696] Improve Memoryview/Buffer documentation

2010-10-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: Let's close then. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python

[issue10189] SyntaxError: no binding for nonlocal doesn't contain a useful traceback

2010-10-24 Thread Benjamin Peterson
Benjamin Peterson added the comment: Technically, it's because the syntax errors come from a latter part of the compiling phase when the origin of names isn't known. Fixing this would involve attaching line numbers and offsets to names somehow. -- nosy: +benjami

[issue10189] SyntaxError: no binding for nonlocal doesn't contain a useful traceback

2010-10-25 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- assignee: -> benjamin.peterson ___ Python tracker <http://bugs.python.org/issue10189> ___ ___ Python-bugs-list mai

[issue10194] Add gc.remap() function to the gc module.

2010-10-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: I think you need to bring this up on python-ideas/python-dev. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue10

[issue10195] Memory allocation fault-injection?

2010-10-25 Thread Benjamin Peterson
Benjamin Peterson added the comment: We should do something like SQLite: http://sqlite.org/testing.html -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue10

[issue10204] exec string fails with trailing whitespace

2010-10-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: That's because it's fixed. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.py

[issue10204] exec string fails with trailing whitespace

2010-10-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/26 R. David Murray : > > R. David Murray added the comment: > > The fix is not something that can be backported to 3.1?  (This is a > regression relative to 2.x). No, it's not. The fix was a bit of "feature&qu

[issue10186] Invalid SyntaxError pointer offset

2010-10-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: r85904 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10186> ___ ___

[issue10093] Warn when files are not explicitly closed

2010-10-29 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2010/10/29 Marc-Andre Lemburg : > > Marc-Andre Lemburg added the comment: > > Antoine Pitrou wrote: >> >> Antoine Pitrou added the comment: >> >>> The warning will trigger without any reason. >> >> Well,

[issue6105] json.dumps doesn't respect OrderedDict's iteration order

2010-10-29 Thread Benjamin Peterson
Benjamin Peterson added the comment: Upon further consideration, I think this could be backported. -- assignee: benjamin.peterson -> rhettinger resolution: wont fix -> status: closed -> open ___ Python tracker <http://bugs.python.o

[issue10268] Add --enable-loadable-sqlite-extensions option to `configure`

2010-10-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86045 -- nosy: +benjamin.peterson resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10264] Fix resource warnings in test_smtplib

2010-10-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86046. Thanks -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10269] Fix some resource warnings in test_sax

2010-10-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86055 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue7059] 'checking getaddrinfo bug' doesn't output the result during ./configure

2010-10-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86075 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue7059> ___ ___

[issue10277] sax leaks a fd if source is a filename

2010-11-01 Thread Benjamin Peterson
Benjamin Peterson added the comment: It is now. -- nosy: +benjamin.peterson resolution: -> fixed status: open -> pending ___ Python tracker <http://bugs.python.org/i

[issue10277] sax leaks a fd if source is a filename

2010-11-01 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: fixed -> out of date status: pending -> closed ___ Python tracker <http://bugs.python.org/issue10277> ___ ___

[issue4510] ValueError for list.remove() not very helpful

2010-11-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: This has already been implemented. -- nosy: +benjamin.peterson resolution: -> out of date status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue7266] test_lib2to3 failure under Windows

2010-11-02 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue7266> ___ ___ Python-bugs-

[issue7826] support caching for 2to3

2010-11-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'm going to reject this for now. -- resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue8488] Docstrings of non-data descriptors "ignored"

2010-11-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: pydoc should probably be adapted to look at a type for descrs. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue8

[issue10300] Documentation of three PyDict_* functions

2010-11-03 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86144 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10301] Zipfile cannot be used in "with" Statement

2010-11-03 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> out of date status: open -> closed ___ Python tracker <http://bugs.python.org/issue10301> ___ ___ Pyth

[issue10300] Documentation of three PyDict_* functions

2010-11-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: This is fixed now. 2010/11/4 Hagen Fürstenau : > > Hagen Fürstenau added the comment: > > The ReST links in http://docs.python.org/py3k/c-api/dict.html#PyDict_Items > seem to be broken. > > -- > > _

[issue9508] python3.2 reversal of distutils reintrocud macos9 support

2010-11-06 Thread Benjamin Peterson
Benjamin Peterson added the comment: Fine. 2010/11/6 Éric Araujo : > > Éric Araujo added the comment: > > Fixed in r86248, thanks.  BTW, my commit removes a bit more than yours > originally did. > > In 2.7, the unused distutils.sysconfig._init_mac function is still l

[issue10378] Typo in results of help(divmod)

2010-11-09 Thread Benjamin Peterson
Changes by Benjamin Peterson : -- resolution: -> invalid status: open -> closed ___ Python tracker <http://bugs.python.org/issue10378> ___ ___ Python-bugs-

[issue10416] UnicodeDecodeError when 2to3 is run on a dir with numpy .npy files

2010-11-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: r86464 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue10416> ___ ___

[issue11302] Add more tests to test_ast.py

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: Please upload to Rietveld. I have a few comments to make. -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue11

[issue11276] 2to3: imports fixer doesn't update references to modules specified without attributes

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: I'm trying to remember if this was intentional or not... -- ___ Python tracker <http://bugs.python.org/issue11276> ___ ___

[issue11305] TextIOWrapper.readline and str.splitlines have different behavior

2011-02-23 Thread Benjamin Peterson
New submission from Benjamin Peterson : For example: >>> 'print 1\n\x0cprint 2\n\n'.splitlines() ['print 1\n', '\x0cprint 2\n', '\n'] >>> list(io.StringIO('print 1\n\x0cprint 2\n\n')) I'm not sure which is prefe

[issue11305] TextIOWrapper.readline and str.splitlines have different behavior

2011-02-23 Thread Benjamin Peterson
Benjamin Peterson added the comment: I don't see that, but the chances of changing either of these is quite low, so I suppose we should just document. -- ___ Python tracker <http://bugs.python.org/is

[issue11335] Memory leak after key function failure in sort

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: LGTM -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue11335> ___ ___ Python-bugs-list mailin

[issue11339] annotation for class being defined

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: This has been true forever. I suggest you try python-ideas. -- nosy: +benjamin.peterson resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue11250] 2to3 truncates files at formfeed character

2011-02-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: r88661 -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue11250> ___ ___

[issue11345] Fix a link in library/json docs

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: r88668 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue4600] __class__ assignment: new-style? heap? == confusing

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: This is not really accurate: >>> class x(int): pass ... >>> class y(object): pass ... >>> x().__class__ = y Traceback (most recent call last): File "", line 1, in TypeError: __class__ assignment: 'x' objec

[issue11349] _pickle should implement the module finalisation protocol

2011-02-27 Thread Benjamin Peterson
Benjamin Peterson added the comment: Unfortunately "proper" module finalization is an invitation to more segfaults because modules can be finalized before objects in them are, resulting in segfaults when its attempted to access modules. -- nosy: +benjami

[issue11349] _pickle should implement the module finalisation protocol

2011-02-28 Thread Benjamin Peterson
Benjamin Peterson added the comment: It's a chicken and egg problem because proper module finalization techniques like #812369 are bogged down by static globals in extension modules, and proper state storage in modules is prevented by proper module finaliz

[issue11349] _pickle should implement the module finalisation protocol

2011-03-01 Thread Benjamin Peterson
Benjamin Peterson added the comment: http://mail.python.org/pipermail/python-dev/2009-October/093057.html 2011/3/1 Antoine Pitrou : > > Antoine Pitrou added the comment: > > Not sure why #812369 is bogged down. The patch simply needs updating for 3.x. > >

[issue9373] pulldom has low code coverage

2011-03-02 Thread Benjamin Peterson
Benjamin Peterson added the comment: r88712 Thanks -- nosy: +benjamin.peterson resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue11428] with statement looks up __exit__ incorrectly

2011-03-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: Well, the pep is wrong, too. -- ___ Python tracker <http://bugs.python.org/issue11428> ___ ___ Python-bugs-list mailin

[issue11438] 2to3 does not fix izip_longest

2011-03-07 Thread Benjamin Peterson
Benjamin Peterson added the comment: 770d45d22a40, 88bbc574cfb0, 8947c47a9fef, a7e0cff05597 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue11441] compile() raises SystemError if called from except clause

2011-03-08 Thread Benjamin Peterson
Benjamin Peterson added the comment: You can put the test in test_compile. -- ___ Python tracker <http://bugs.python.org/issue11441> ___ ___ Python-bugs-list m

[issue11440] fix_callable should be dropped from lib2to3 / changed

2011-03-08 Thread Benjamin Peterson
Benjamin Peterson added the comment: Someone should probably ask python-dev. callable, of course, doesn't work in 3.1. -- ___ Python tracker <http://bugs.python.org/is

[issue11475] trunc in documentation of numbers.Real should math.trunc

2011-03-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: 7fd06773c3c2 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue11312] Confusing sentence in file.readline() doc

2011-03-12 Thread Benjamin Peterson
Benjamin Peterson added the comment: c017695acf19 -- nosy: +benjamin.peterson resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue11499] 2to3: reassignment to bool is left in the file

2011-03-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: That seems awfully obscure. -- ___ Python tracker <http://bugs.python.org/issue11499> ___ ___ Python-bugs-list mailin

[issue11499] 2to3: reassignment to bool is left in the file

2011-03-14 Thread Benjamin Peterson
Benjamin Peterson added the comment: Okay. This is certainly the first request I've seen, so I'm going to close. -- resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.py

[issue11477] Bug in code dispatching based on internal slots

2011-03-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: Is that a patch you can put on Rietveld then? (/me wanting to review) -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/issue11

[issue11559] Increase test coverage in dis module

2011-03-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: 1. Use splitlines() instead of split('\n') 2. Use try finally when replacing sys.stdout. 3. Why is dist(None) a RuntimeError and anything else invalid TypeError? -- nosy: +benjamin.peterson ___ Pyth

[issue11572] bring Lib/copy.py to 100% coverage

2011-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: 1. I prefer that we don't have pragma statements sprinkled over the stdlib. 2. You can use assertIs() instead of assertTrue(x is y) (Feel free to change the lot) 3. Along the way you could also change those "raise support.TestFailed" over

[issue11572] bring Lib/copy.py to 100% coverage

2011-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: 2011/3/16 Nick Coghlan : > > Nick Coghlan added the comment: > > Alexander: the coverage problem in this case has to do with it incorrectly > handling an "else:" clause on a loop (it doesn't adjust the expected target >

[issue11570] Lib/test/test_distutils.py tries to mix 32 and 64 bits object files, doesn't obey LDFLAGS

2011-03-16 Thread Benjamin Peterson
Benjamin Peterson added the comment: That should be okay. 3.1 is still open for normal bugfixes. 2011/3/16 Jesús Cea Avión : > > Jesús Cea Avión added the comment: > > Benjamin, could you possibly accept this for 3.1?. It solves a buildbot issue > that cold mask othe pro

<    1   2   3   4   5   6   7   8   9   10   >