[issue42030] Drop support for dynload_aix

2020-10-16 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya, pablogsal ___ Python tracker <https://bugs.python.org/issue42030> ___ ___ Python-bugs-list mailing list Unsub

[issue40680] thread_cputime isn't supported by AIX5

2020-10-19 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Also, I can submit changes to remove pre-AIX 6 dead code paths. Should I open > a separate issue for that or reference this one? Yes, please do so. -- ___ Python tracker <https://bugs.python.org/i

[issue42086] AST: Document / re-design? the simple constructor nodes from sums

2020-10-19 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : Simple constructors (basically constructors with no fields) are currently 'cached' / pre-created and dispatched. What I mean by that is, when a user parses some code with `ast.parse()` and gets a tree object, all simple constructors with the

[issue42087] Remove pre-AIX 6.1 dead code paths

2020-10-19 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue42087> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42086] AST: Document / re-design? the simple constructor nodes from sums

2020-10-22 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: After doing experiments with annotating the operator nodes with position information, it is concluded that it doesn't worth the efforts of changing all occurrences of operators from enum to a struct. Other than that, it was designated that we'll

[issue42086] AST: Document / re-design? the simple constructor nodes from sums

2020-10-22 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +21828 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22896 ___ Python tracker <https://bugs.python.org/issu

[issue38870] Expose ast.unparse in the ast module

2020-10-23 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: Well, I'm happy to say that 3.9.0 is finally released with the ast.unparse interface. After tens of PRs, I think it is time for us to move on. For all future bugs, please create a new issue and nosy me. Thanks everyone who has participated this jo

[issue38870] Expose ast.unparse in the ast module

2020-10-23 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42173] Drop Solaris support

2020-10-27 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue42173> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42187] Deprecating / removing token.ISTERMINAL/ISNONTERMINAL

2020-10-28 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : Since the parser & symbol modules are removed, there is no real use case for ISTERMINAL/ISNONTERMINAL since the only input that contains grammar symbols is the input of the tokenize, which all its outputs are terminals. Which restricts the practica

[issue42187] Deprecating / removing token.ISTERMINAL/ISNONTERMINAL

2020-10-28 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: -3.4regression ___ Python tracker <https://bugs.python.org/issue42187> ___ ___ Python-bugs-list mailing list Unsub

[issue42187] Deprecating / removing token.ISTERMINAL/ISNONTERMINAL

2020-10-28 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Since there are so few projects, maybe you can just contact them? For NT_OFFSET? -- ___ Python tracker <https://bugs.python.org/issu

[issue42206] Pegen: Raise errors occurred by the AST validator

2020-10-30 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : When working on the AST validator, it is unclear that which of the changes caused parser to fail on valid input. I propose to propagate the error and raise it. Current: $ ./python t.py python: Parser/pegen.c:1146: _PyPegen_run_parser: Assertion

[issue42206] Pegen: Raise errors occurred by the AST validator

2020-10-30 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +21954 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23035 ___ Python tracker <https://bugs.python.org/issu

[issue39715] Implement __repr__ methods for AST classes

2020-10-30 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > I suggest to reject this feature request +1 -- ___ Python tracker <https://bugs.python.org/issue39715> ___ ___ Python-

[issue42206] Pegen: Raise errors occurred by the AST validator

2020-10-30 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue42218> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42218] SystemError in compile builtin function

2020-10-31 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +21977 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23058 ___ Python tracker <https://bugs.python.org/issu

[issue41796] _ast module state should be made per interpreter

2020-11-03 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue41796> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26584] pyclbr module needs to be more flexible on loader support

2020-11-04 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya, terry.reedy ___ Python tracker <https://bugs.python.org/issue26584> ___ ___ Python-bugs-list mailing list Unsub

[issue42295] Error should be flagged if Walrus operator is used for multiple assigment

2020-11-09 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: Due to the precedence of the walrus operator, it is not actually a multiple assignment but rather a tuple of 3 elements with one being the value of the assignment expression. $ python -m ast (a, b := 3, 4) Module( body=[ Expr( value

[issue42295] Error should be flagged if Walrus operator is used for multiple assigment

2020-11-09 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue36310] pygettext3.7 Does Not Recognize gettext Calls Within fstrings

2020-11-09 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: New changeset bfc6b63102d37ccb58a71711e2342143cd9f4d86 by jack1142 in branch 'master': bpo-36310: Allow pygettext.py to detect calls to gettext in f-strings. (GH-19875) https://github.com/python/cpython/commit/bfc6b63102d37ccb58a71711e23421

[issue36310] pygettext3.7 Does Not Recognize gettext Calls Within fstrings

2020-11-09 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.10 -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue42313] rstrip removes the trailing `e`s.

2020-11-10 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: For 3.9+, you could do exactly what you want with .removesuffix (/.removeprefix) methods; >>> test = "external_e_object" >>> test.removesuffix("_object") 'external_e' -- nosy: +BTaskaya

[issue39411] pyclbr rewrite using AST

2020-11-10 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: New changeset fa476fe13255d0360f18528e864540d927560f66 by Batuhan Taskaya in branch 'master': bpo-39411: pyclbr rewrite on AST (#18103) https://github.com/python/cpython/commit/fa476fe13255d0360f18528e864540

[issue42086] AST: Document / re-design? the simple constructor nodes from sums

2020-11-13 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue42348] Language Reference: Set items

2020-11-13 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- assignee: -> docs@python components: +Documentation nosy: +docs@python, rhettinger ___ Python tracker <https://bugs.python.org/issu

[issue42348] Language Reference: Set items

2020-11-13 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : The data types section of the language reference (https://docs.python.org/3.10/reference/datamodel.html#the-standard-type-hierarchy) has this description directly under the Set type (which has 2 childs, set and frozenset). > These represent unorde

[issue42355] symtable: get_namespace doesn't check whether if there are multiple namespaces or no namespaces at all

2020-11-14 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : >>> table = symtable.symtable("A = 1", "", "exec") >>> table.lookup("A") >>> table.lookup("A").get_namespace() Traceback (most recent call last): File "", line 1, i

[issue42355] symtable: get_namespace doesn't check whether if there are multiple namespaces or no namespaces at all

2020-11-14 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +22172 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23278 ___ Python tracker <https://bugs.python.org/issu

[issue42354] Tuple unpacking with * causes SyntaxError in with ... as ...

2020-11-14 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: Already fixed with GH-22612 -- nosy: +BTaskaya resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39411] pyclbr rewrite using AST

2020-11-14 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue27119] `compile` doesn't compile into an AST object as specified

2020-11-15 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: We've added a reference to the compiler flags into the compile(), see issue 40484 for details. -- resolution: -> duplicate stage: -> resolved status: open -> closed versions: +Python 3.10 -Python 2.7, Python 3.5, Python 3.6, Pyth

[issue16801] Preserve original representation for integers / floats in docstrings

2020-11-15 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: I'm very late to join this thread, but since the Constant() node has now a kind field, we can possibly add this (though I'm not saying we should, depending on whether still this would be a nice addition to clinic docstrings.) 2 options that I can

[issue16801] Preserve original representation for integers / floats in docstrings

2020-11-15 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +pablogsal ___ Python tracker <https://bugs.python.org/issue16801> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42115] Caching infrastructure for the evaluation loop: specialised opcodes

2020-11-15 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +BTaskaya ___ Python tracker <https://bugs.python.org/issue42115> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42102] Make builtins.callable "generic"

2020-11-16 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > Sorry, but making builtins.callable generic looks wrong to me. It is a > predicate, not a constructor. If it would be called "iscallable" instead of > "callable" nobody would propose to make it generic, right? It's just

[issue39463] ast.Constant, bytes, and ast.unparse

2020-11-16 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: We added the warnings, and I believe we can close this safely (since there is no intend to change the behavior of ast.unparse) -- resolution: -> not a bug stage: -> resolved status: open -> closed _

[issue28002] ast.unparse can't roundtrip some f-strings

2020-11-20 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: New changeset a993e901ebe60c38d46ecb31f771d0b4a206828c by Shantanu in branch 'master': bpo-28002: Roundtrip f-strings with ast.unparse better (#19612) https://github.com/python/cpython/commit/a993e901ebe60c38d46ecb31f771d0

[issue28002] ast.unparse can't roundtrip some f-strings

2020-11-20 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: New changeset 3763cc1dbdb930f67b443ceed7c44e4feb883b42 by Miss Islington (bot) in branch '3.9': bpo-28002: Roundtrip f-strings with ast.unparse better (GH-19612) (GH-23430) https://github.com/python/cpython/commit/3763cc1dbdb930f67b443ceed7c44e

[issue28002] ast.unparse can't roundtrip some f-strings

2020-11-20 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue28002] ast.unparse can't roundtrip some f-strings

2020-11-20 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: Thanks for your efforts Shantanu! -- ___ Python tracker <https://bugs.python.org/issue28002> ___ ___ Python-bugs-list mailin

[issue42422] Py_Decref on value crash the interpreter in Python/ceval.c:1104

2020-11-22 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: I'm sorry to interrupt but what is the exact reasoning behind adding a new, (I presume) redundant crasher? There are tons of different ways to crash the interpreter with malformed bytecode, how would adding only one of them bring any good? --

[issue42422] Py_Decref on value crash the interpreter in Python/ceval.c:1104

2020-11-23 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > do you think this is too similar to bogus_code_obj.py? That's the only > crasher I can see it being similar to. As far as I assume, yes, that is the generic VM crasher via custom code object execution. I feel its existence is good enough t

[issue42454] Move slice creation to the compiler for constants

2020-11-24 Thread Batuhan Taskaya
New submission from Batuhan Taskaya : Currently, all the slices are created by the interpreter with BUILD_SLICE preceded by 2/3 LOAD_CONSTS. We can move the slice creation into the compiler and deduce the cost of these 3/4 instructions into a single LOAD_CONST operation where all values in

[issue42454] Move slice creation to the compiler for constants

2020-11-24 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- keywords: +patch pull_requests: +22386 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23496 ___ Python tracker <https://bugs.python.org/issu

[issue42454] Move slice creation to the compiler for constants

2020-11-24 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- nosy: +Mark.Shannon, serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue42454> ___ ___ Python-bugs-list mailin

[issue42454] Move slice creation to the compiler for constants

2020-11-24 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > I'm slightly concerned about hashability of slice objects. Currently the > slice constructor does not ensure that any slice parameter is a number. You > can do horrible stuff like this: The same thing can be applied to tuples, which are h

[issue42454] Move slice creation to the compiler for constants

2020-11-24 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: As a side effect, we also now fold some esoteric cases which are not very common. Like; """ test """[1:-1] We reviewed only optimizing this a while back and decided these are not that common to add a code path. Just wanted t

[issue42454] Move slice creation to the compiler for constants

2020-11-25 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > something[::-1] = something I was thinking this for a while, and this is the actual reason that I didn't propose this until I saw someone's comment under Raymond's tweet about 'slices are not hashable' (https://

[issue42454] Move slice creation to the compiler for constants

2020-11-25 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: > What are the potential benefits or drawbacks for the user? The only potential drawback that I can see is that it prevents you from distinguishing a sequence from mapping by 'accidentally' passing a slice. The major benefit for users is t

<    2   3   4   5   6   7