Batuhan Taskaya added the comment:
New changeset 35ad425866d591c33d7f2be2b9da8bce2bff9523 by Batuhan Taskaya in
branch 'main':
bpo-40528: Implement a metadata system for ASDL Generator (GH-20193)
https://github.com/python/cpython/commit/35ad425866d591c33d7f2be2b9da8b
Change by Batuhan Taskaya :
--
pull_requests: +25435
pull_request: https://github.com/python/cpython/pull/26858
___
Python tracker
<https://bugs.python.org/issue40
New submission from Batuhan Taskaya :
It is a common scenario to make calls with only constant arguments (e.g to
datetime.datetime/os.path.join/re.match.group/nox.session.run etc) and the
bytecode that we currently generate looks like this;
f(1,2,3,4,5,6)
1 0 LOAD_NAME
Batuhan Taskaya added the comment:
> I already experimented with this in issue33325. It does not worth an effort.
Yea, that is what the results for the CFG optimization shows to me (1.13x at
best, ~1.03x in real cases).
> For optimizing calls with constant arguments, it look
Batuhan Taskaya added the comment:
Here is my branch for the reference (I didn't worked on about it much, so still
lacks some error handling etc);
https://github.com/isidentical/cpython/blob/b556d1172b08c65b88093f7ff1dadc985ce72f62/Python/ast_opt.c#L634
Batuhan Taskaya added the comment:
New changeset 6c76df2b86d742cc294beae7f9b6bafabb946ad5 by Batuhan Taskaya in
branch 'main':
bpo-40528: move asdl identifier collection to the new metadata system (GH-26858)
https://github.com/python/cpython/commit/6c76df2b86d742cc294beae7f9b6ba
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +25477
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/26901
___
Python tracker
<https://bugs.python.org/issu
Batuhan Taskaya added the comment:
I've tested this with pyperformance, and no significant (1.02 faster on some,
1.01x slower on others, nothing significant) change on those so this is a
targeted optimization.
--
___
Python tracker
&
Batuhan Taskaya added the comment:
There are multiple issues with doing 'static' loop invariant code motion in
python, but the most obvious one is how would you detect if anything in the
body is related to the loop or not? The trivial way that the compiled languages
do this optim
Change by Batuhan Taskaya :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Batuhan Taskaya :
--
pull_requests: +25491
pull_request: https://github.com/python/cpython/pull/26918
___
Python tracker
<https://bugs.python.org/issue40
Batuhan Taskaya added the comment:
New changeset 107a2c59c91b3911bdd6dfdb83271c588c506a5a by Batuhan Taskaya in
branch 'main':
bpo-40528: fix is_simple(sum)s behavior for attributes (GH-26918)
https://github.com/python/cpython/commit/107a2c59c91b3911bdd6dfdb83271c
Batuhan Taskaya added the comment:
These were all the cleanups on my checklist, so can close the issue now. I'll
probably create other issues if something additional comes up
--
resolution: -> fixed
stage: patch review -> resolved
status: ope
Change by Batuhan Taskaya :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Batuhan Taskaya :
--
pull_requests: +25545
pull_request: https://github.com/python/cpython/pull/26983
___
Python tracker
<https://bugs.python.org/issue44
Batuhan Taskaya added the comment:
New changeset 0d7f61ddb074659d8c18c8f5ac86a6a18e41f9e5 by Batuhan Taskaya in
branch 'main':
bpo-44313: bump up magic (#26983)
https://github.com/python/cpython/commit/0d7f61ddb074659d8c18c8f5ac86a6
Change by Batuhan Taskaya :
--
pull_requests: +25557
pull_request: https://github.com/python/cpython/pull/26997
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
> I am still not sure that it is worth to add 50 lines of the C code to
> optimize 0.7% of calls.
As I stated, the reason that this is 'relatively' lower is that there are just
too many calls, so it just allocates a rather small part
Batuhan Taskaya added the comment:
> BTW, why do you not fold 2-argument calls?
Seems like it is making stuff worse.
> I suspect that in most of other examples the function execution time is too
> large to make the optimization meaningful.
This is (to some extent) a constant fol
Change by Batuhan Taskaya :
--
pull_requests: +25571
pull_request: https://github.com/python/cpython/pull/27011
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25574
pull_request: https://github.com/python/cpython/pull/27015
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25597
pull_request: https://github.com/python/cpython/pull/27037
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25624
pull_request: https://github.com/python/cpython/pull/27074
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25664
pull_request: https://github.com/python/cpython/pull/27117
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25669
pull_request: https://github.com/python/cpython/pull/27126
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
New changeset 9af34c935185eca497617a216d141c72ffaeae9c by Batuhan Taskaya in
branch 'main':
bpo-20201: variadic arguments support for AC (GH-18609)
https://github.com/python/cpython/commit/9af34c935185eca497617a216d141c72ffaeae9c
-
Change by Batuhan Taskaya :
--
Removed message: https://bugs.python.org/msg397638
___
Python tracker
<https://bugs.python.org/issue20201>
___
___
Python-bug
Batuhan Taskaya added the comment:
New changeset f88e138a1aa3b9a9e013963e4fd7d5cce6a0b85c by Ken Jin in branch
'main':
bpo-20291: Fix MSVC warnings in getargs.c (GH-27211)
https://github.com/python/cpython/commit/f88e138a1aa3b9a9e013963e4fd7d5
Change by Batuhan Taskaya :
--
pull_requests: +25758
pull_request: https://github.com/python/cpython/pull/27217
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
New changeset a045991f60b51636a784623dda7ad84b5b2c6b73 by Batuhan Taskaya in
branch 'main':
bpo-42355: symtable.get_namespace() now checks whether there are multiple or
any namespaces found (GH-23278)
https://github.com/python/cpyt
Change by Batuhan Taskaya :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Batuhan Taskaya :
--
type: security -> behavior
___
Python tracker
<https://bugs.python.org/issue42355>
___
___
Python-bugs-list mailing list
Un
Change by Batuhan Taskaya :
--
pull_requests: +25858
pull_request: https://github.com/python/cpython/pull/27313
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25879
pull_request: https://github.com/python/cpython/pull/27336
___
Python tracker
<https://bugs.python.org/issue43
Change by Batuhan Taskaya :
--
pull_requests: +25880
pull_request: https://github.com/python/cpython/pull/27337
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
New changeset ef8b8535cb3cd705392af9b927d6ff336d98427d by Batuhan Taskaya in
branch 'main':
bpo-43950: check against the raw string, not the pyobject (GH-27337)
https://github.com/python/cpython/commit/ef8b8535cb3cd705392af9b927d6ff
Batuhan Taskaya added the comment:
New changeset 4f5980a4f57dab68b9137304f58bd08891d43d5a by Batuhan Taskaya in
branch 'main':
bpo-43950: support long lines in traceback.py (GH-27336)
https://github.com/python/cpython/commit/4f5980a4f57dab68b9137304f58bd0
Change by Batuhan Taskaya :
--
pull_requests: +25882
pull_request: https://github.com/python/cpython/pull/27339
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
There is a subtle difference between traceback.py and Python/traceback.c which
makes the latter (C version) output the line without trimming the trailing
whitespace. The Python version simply uses `.strip()` which strips both the
left (starting) and right
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue44825>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
@samuelmarks can you share the full reproducer / AST and what you expect it to
be unparsed? (you can use gist or other pasting services if it is too big)
--
___
Python tracker
<https://bugs.python.org/issue44
Batuhan Taskaya added the comment:
> Which for some reason has made the `annotation` a `str` rather than `Name`.
> So I think it's my bug then?
Yes, from what I can see it is a bug in your code.
> body=[AnnAssign(annotation='int',
The 'annotation
Batuhan Taskaya added the comment:
See: https://github.com/python/cpython/pull/17776
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue44
Batuhan Taskaya added the comment:
AFAIK this is already resolved on the main (https://bugs.python.org/issue42725)
--
___
Python tracker
<https://bugs.python.org/issue42
Batuhan Taskaya added the comment:
I don't think this is really an issue considering some other functionalities
that consumes AST code (e.g `compile`) will expect it to be annotated with
location metadata. This is why the `ast` module already comes bundled with a
utility function c
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +26245
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/27770
___
Python tracker
<https://bugs.python.org/issu
Change by Batuhan Taskaya :
--
pull_requests: +26581
pull_request: https://github.com/python/cpython/pull/28142
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
New changeset 85ea2d6165dec0cffa6302eb6dc40406eae1edf5 by Batuhan Taskaya in
branch 'main':
bpo-43950: support positions for dis.Instructions created through dis.Bytecode
(GH-28142)
https://github.com/python/cpyt
Change by Batuhan Taskaya :
--
pull_requests: +26588
pull_request: https://github.com/python/cpython/pull/28150
___
Python tracker
<https://bugs.python.org/issue43
Batuhan Taskaya added the comment:
Does find_imports/find_store_names have to be public? I think the relocation is
fine, but making them public without any use case from outside can be avoided
at least for now.
--
nosy: +BTaskaya
___
Python
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue45408>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
I've found 81 occurrences of this pattern among 52 projects on a dataset of top
PyPI packages (~3.5K). So I'd say +1 on including this.
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.o
Batuhan Taskaya added the comment:
> Result of `255581293 > 12938373 and 113314 < 2`:
Is there a similar pattern that happens a lot on the client code? The AST
optimizer currently only optimizes common cases.
--
nosy: +BTaskaya, pablogsal, serhiy.
Batuhan Taskaya added the comment:
We just rejected the same issue 2 days ago. If you feel very strong about this;
instead of creating new ticket in the same place, you might want to try
python-dev instead.
Re: the todo comment, feel free to send a patch that removes it. I don't
Batuhan Taskaya added the comment:
See: https://bugs.python.org/issue42282
and the reason for not backporting this:
https://bugs.python.org/issue42282#msg380506
--
components: +Interpreter Core -Parser
nosy: +BTaskaya
resolution: -> duplicate
stage: -> resolved
status
Batuhan Taskaya added the comment:
After PR 17302 is accepted, I'll work on refactorings including a precedence
algorithm to find when to parentheses.
--
nosy: +Batuhan Taskaya
___
Python tracker
<https://bugs.python.org/is
New submission from Batuhan Taskaya :
pyclbr currently uses token streams to analyze but it can be alot simpler with
usage of AST. There are already many flaws, including some comments about
limitations of this token stream processing.
I have a draft about this. Initial PR wont change any
Change by Batuhan Taskaya :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue39411>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue39576>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
> Are you going to work on a patch then, Batuhan?
Serhiy already submitted a PR, which looks great.
--
___
Python tracker
<https://bugs.python.org/issu
Batuhan Taskaya added the comment:
> Isn't children annotated as List in typeshed?
Yes, lib2to3.pytree.Base.children is annotated as a list of (Node or Leafs)
https://github.com/python/typeshed/blob/ea0a9c2bd6f6a69c3e49b47870e0109d98316fc6/stdlib/2and3/lib2to3/pytree.pyi#L23
---
Batuhan Taskaya added the comment:
> 1) We should document possible exceptions that need to be caught. So far,
> I've found TypeError, MemoryError, SyntaxError, ValueError.
Maybe we should wrap all of these into something like LiteralEvalError to
easily catch all of them, Liter
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue28308>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
Serhiy, any plans to bump this patch to 3.9 and continue / merge? In general
the benefits looks great, but on the other hand this might cause some breakage
which I guess as @nascheme is OK in AST.
--
nosy: +BTaskaya, pablogsal
Change by Batuhan Taskaya :
--
nosy: +benjamin.peterson, pablogsal
___
Python tracker
<https://bugs.python.org/issue38131>
___
___
Python-bugs-list mailin
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue39562>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
> 1) We should document possible exceptions that need to be caught. So far,
> I've found TypeError, MemoryError, SyntaxError, ValueError.
Also, an addition to these errors is RecursionError
>>> t = ast.Tuple(elts=[], ctx=ast.Load())
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue39537>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Batuhan Taskaya :
It would be super convenient to keep ASDL declarations in AST nodes. There are
multiple benefits of it;
1 -> When debugging or playing with the AST, time to time you may require to
know what kind of things a field gets or is that field an optional
New submission from Batuhan Taskaya :
AST is containing a node from past that is explained as "not really an actual
node but useful in Jython's typesystem.". There is no usage of it anywhere in
the CPython repo, just some code in ast_optimizer, symbol table and compiler to
Change by Batuhan Taskaya :
--
priority: normal -> low
title: Remote Suite node from AST -> Remove Suite node from AST
___
Python tracker
<https://bugs.python.org/i
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +17890
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18513
___
Python tracker
<https://bugs.python.org/issu
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +17892
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18515
___
Python tracker
<https://bugs.python.org/issu
New submission from Batuhan Taskaya :
This is something revealed during issue 39411. As @terry.reedy commented
pyclbr's scope is extended to functions and classes instead of just classes.
--
nosy: +BTaskaya, terry.reedy
___
Python tracker
&
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
___
Python tracker
<https://bugs.python.org/issue39686>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
> The proposed enhancement would provide a complementary function, `dump_json`
> as in a json representation of the ast.
IMHO this is not a feature that has a general usage. If you want, as far as I
can see, there are some packages for doing that i
Batuhan Taskaya added the comment:
What kind of repr do you have in your mind? If the repr you are thinking
contains field information, it would be no-go. Fields of AST objects can
contain other objects and fields of that objects can contain more objects (this
goes up to the recursion limit
Change by Batuhan Taskaya :
--
keywords: +patch
nosy: +BTaskaya
nosy_count: 9.0 -> 10.0
pull_requests: +18009
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/18609
___
Python tracker
<https://bugs.p
New submission from Batuhan Taskaya :
Argument clinic uses some extra variables (like args, or noptargs, nargs etc.)
for parsing. But there is a catch about these names, the generated code becomes
wrong if there are any usages of them inside the signature. Encountered with
this problem while
Batuhan Taskaya added the comment:
After preparing the patch and transforming all arguments with a __clinic_
prefix, I saw there are some actions that are taken by relying on the parser
code. An example;
https://github.com/python/cpython/blob/8af4712a16e4b7d1b60f1faec13cd7a88da95f6a/Objects
Batuhan Taskaya added the comment:
This change needs to be discussed first on Python-ideas, and ideally needs a
PEP (and a sponsor). So you should post it on Python-ideas mailing list or
discuss.python.org Ideas section.
--
nosy: +Batuhan Taskaya
Batuhan Taskaya added the comment:
This change needs to be discussed first on Python-ideas, and ideally needs a
PEP (and a sponsor). So you should post it on Python-ideas mailing list or
discuss.python.org Ideas section.
--
nosy: +BTaskaya
Change by Batuhan Taskaya :
--
Removed message: https://bugs.python.org/msg362898
___
Python tracker
<https://bugs.python.org/issue39784>
___
___
Python-bug
New submission from Batuhan Taskaya :
$ ./python -m test test_email
0:00:00 load avg: 0.25 Run tests sequentially
0:00:00 load avg: 0.25 [1/1] test_email
test test_email failed -- Traceback (most recent call last):
File "/usr/home/isidentical/cpython/Lib/test/test_email/test_email.py&q
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +18059
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18698
___
Python tracker
<https://bugs.python.org/issu
New submission from Batuhan Taskaya :
I was building python on AIX but the old README.AIX file didn't help much. It
would be super cool to someone who is familiar with AIX update and improve that
file with all new additions and current issues about AIX.
--
components: Build
mes
Change by Batuhan Taskaya :
--
nosy: +BTaskaya, jcea
___
Python tracker
<https://bugs.python.org/issue38527>
___
___
Python-bugs-list mailing list
Unsubscribe:
Batuhan Taskaya added the comment:
> but that sure looks like a broken system.
These are all aliases to the same name.
--
___
Python tracker
<https://bugs.python.org/issu
Change by Batuhan Taskaya :
--
nosy: +BTaskaya, jcea
___
Python tracker
<https://bugs.python.org/issue39740>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Batuhan Taskaya :
Python can't build curses on Solaris because of extensions aren't activated
/export/home/isidentical/cpython/Modules/_cursesmodule.c: In function
‘_curses_get_escdelay_impl’:
/export/home/isidentical/cpython/Modules/_cursesmodule.c:3272
Change by Batuhan Taskaya :
--
keywords: +patch
pull_requests: +18065
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18705
___
Python tracker
<https://bugs.python.org/issu
Change by Batuhan Taskaya :
--
nosy: +jcea
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue39802>
___
___
Python-bugs-list mailin
Change by Batuhan Taskaya :
--
pull_requests: +18126
pull_request: https://github.com/python/cpython/pull/18768
___
Python tracker
<https://bugs.python.org/issue38
Batuhan Taskaya added the comment:
I just removed Suite node in GH-18513, so I guess this can be closed.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Batuhan Taskaya added the comment:
This looks like a duplicate of issue 35212
--
nosy: +BTaskaya, pablogsal
___
Python tracker
<https://bugs.python.org/issue39
Change by Batuhan Taskaya :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Batuhan Taskaya :
--
nosy: +BTaskaya
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue39760>
___
___
Python-bug
Batuhan Taskaya added the comment:
Yes, there is an already PR about that the bug.
Related PR: https://github.com/python/cpython/pull/17892
--
___
Python tracker
<https://bugs.python.org/issue34
Batuhan Taskaya added the comment:
Related issue: issue 39638
--
___
Python tracker
<https://bugs.python.org/issue36287>
___
___
Python-bugs-list mailin
Batuhan Taskaya added the comment:
> It is not so easy for fields like "type_ignores". They are mutable lists, so
> this approach cannot be applied to them.
What about keeping ASDL signatures in the nodes (). If we know the type of a
field (can be parsed in runtime) we can i
101 - 200 of 652 matches
Mail list logo